2017-03-17 20:46 GMT+01:00 Aleksandr Mashchenko :
>> That would be awesome but it's hard if there are just few who test the
>> latest test build ;-) That being said, I'm going to extend a test
>> build period and instead of a week give a month for everyone to test
>> it, hope this allow reduce such
> That would be awesome but it's hard if there are just few who test the
> latest test build ;-) That being said, I'm going to extend a test
> build period and instead of a week give a month for everyone to test
> it, hope this allow reduce such problems.
Month seems like a long leap from the wee
2017-03-16 20:23 GMT+01:00 Aaron Johnson :
> Keeping breaking changes in major releases is important. I recently took a
> project from 2.5.8 to 2.5.10.1 and had several compilation errors. Not a
> good surprise when attempting to get a security fix in quickly.
That would be awesome but it's hard i
I agree with respecting major/minor versions concerning breaking changes.
I also encountered an unexpected problem with updating one of our projects
at work to 2.5.10.1 (from 2.5.1), which didn’t even cause a compilation
error.
In my case it was because of the introduction of a parameter object.
Keeping breaking changes in major releases is important. I recently took a
project from 2.5.8 to 2.5.10.1 and had several compilation errors. Not a
good surprise when attempting to get a security fix in quickly.
On Thu, Mar 16, 2017 at 8:35 AM, Lukasz Lenart
wrote:
> 2017-03-16 13:21 GMT+01:00 C
2017-03-16 13:21 GMT+01:00 Christoph Nenning :
> I'd say it is too big for a minor version update -> let's put it in 2.6
https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%202.6%20AND%20project%20%3D%20WW%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC
Regards
--
Ł
> > I like those ideas!
> >
> > Currently it is a bit messy to figure out what can be customized or
used
> > by apps and what are struts internals. Having an explicit API would
clear
> > things up.
>
> Yeah, it should be a bit easier. The question is: do it now or wait
> till Struts 2.6?
>
I'
2017-03-16 10:52 GMT+01:00 Christoph Nenning :
> I like those ideas!
>
> Currently it is a bit messy to figure out what can be customized or used
> by apps and what are struts internals. Having an explicit API would clear
> things up.
Yeah, it should be a bit easier. The question is: do it now or
> Subject: Injectable LocaleProvider replaces with LocaleProviderFactory
>
> Hi,
>
> Another PR cleaning up a mess with injecting things ;)
> https://github.com/apache/struts/pull/122
>
> and what do you think about adding a dedicated artefact to keep all
> those interfaces
2017-03-16 10:26 GMT+01:00 Greg Huber :
> Would that be in the comment?
Comment or you can mark the PR's description (on the right there is
"Add your reaction" smiley face )
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---
Would that be in the comment?
On 16 March 2017 at 09:23, Lukasz Lenart wrote:
> 2017-03-16 10:21 GMT+01:00 Greg Huber :
> > +1, works for me.
>
> Cool, thanks :) Can you mark the PR with :+1: as well?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> --
2017-03-16 10:21 GMT+01:00 Greg Huber :
> +1, works for me.
Cool, thanks :) Can you mark the PR with :+1: as well?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
-
To unsubscribe, e-mail: [email protected]
+1, works for me.
Cheers Greg
On 15 March 2017 at 17:54, Lukasz Lenart wrote:
> If no objections I will merge this PR [1] tomorrow
>
> [1] https://github.com/apache/struts/pull/122
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> -
2017-03-15 20:01 GMT+01:00 Stefaan Dutry :
> I have a question about the pull request.
>
> In the interface LocaleProviderFactory, there's only a method called
> createLocaleProvider.
>
> Does this mean that there's supposed to be a seperate instance of
> LocaleProv
I have a question about the pull request.
In the interface LocaleProviderFactory, there's only a method called
createLocaleProvider.
Does this mean that there's supposed to be a seperate instance of
LocaleProvider on every single place this is used?
(I know you could technicaly imp
If no objections I will merge this PR [1] tomorrow
[1] https://github.com/apache/struts/pull/122
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
-
To unsubscribe, e-mail: [email protected]
For addi
Hi,
Another PR cleaning up a mess with injecting things ;)
https://github.com/apache/struts/pull/122
and what do you think about adding a dedicated artefact to keep all
those interfaces? strust2-api? And move all the APIs there maybe with
default implementations.
Another thing I would like to st
17 matches
Mail list logo
