Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-11 Thread Musachy Barroso
I have attached a patch and a gif file to WW-1554. Because the patch to WW-1555 has not been applied, there might be some small conflicts on struts-tld.xml. If you guys find anything still missing (hope not :) ), let me know. regards musachy Don Brown wrote: Musachy Barroso wrote: That said,

Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Musachy Barroso
Don Brown wrote: I think the core issue is a misperception that Struts 2.0 is a clean slate, and therefore, we can remove/change any tags and attributes we wish. While this seems to be the case at first glance, Struts 2.0 is really a continuation of WebWork 2.2 and therefore, This hit me a

Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Don Brown
I think the core issue is a misperception that Struts 2.0 is a clean slate, and therefore, we can remove/change any tags and attributes we wish. While this seems to be the case at first glance, Struts 2.0 is really a continuation of WebWork 2.2 and therefore, we do have to worry about backward

Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Musachy Barroso
Good that you mentioned 'cause I hadn't seen it. First thing, "notifyTopics" ,my bad, I forgot to fix it, easy to fix. The attributes that are a little bit problematic cause they were not consistent between the different tags are: preInvokeJS (in anchor, not in div), shouldn't this one be "bef

Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Martin Cooper
Oops! Forgot [1]: https://issues.apache.org/struts/browse/WW-1554 On 12/9/06, Martin Cooper <[EMAIL PROTECTED]> wrote: As Don has noted [1], there are some tag attributes (e.g. notifyTopics) that have disappeared recently. It seems that, included in the patch to upgrade Dojo to version 0.4, the