Re: LocaleProviderFactory

2017-03-16 Thread Lukasz Lenart
2017-03-16 10:26 GMT+01:00 Greg Huber : > Would that be in the comment? Comment or you can mark the PR's description (on the right there is "Add your reaction" smiley face ) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ ---

Re: LocaleProviderFactory

2017-03-16 Thread Greg Huber
Would that be in the comment? On 16 March 2017 at 09:23, Lukasz Lenart wrote: > 2017-03-16 10:21 GMT+01:00 Greg Huber : > > +1, works for me. > > Cool, thanks :) Can you mark the PR with :+1: as well? > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > --

Re: LocaleProviderFactory

2017-03-16 Thread Lukasz Lenart
2017-03-16 10:21 GMT+01:00 Greg Huber : > +1, works for me. Cool, thanks :) Can you mark the PR with :+1: as well? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: [email protected]

Re: LocaleProviderFactory

2017-03-16 Thread Greg Huber
+1, works for me. Cheers Greg On 15 March 2017 at 17:54, Lukasz Lenart wrote: > If no objections I will merge this PR [1] tomorrow > > [1] https://github.com/apache/struts/pull/122 > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > -

Re: LocaleProviderFactory

2017-03-16 Thread Lukasz Lenart
2017-03-15 20:01 GMT+01:00 Stefaan Dutry : > I have a question about the pull request. > > In the interface LocaleProviderFactory, there's only a method called > createLocaleProvider. > > Does this mean that there's supposed to be a seperate instance of > LocaleProvider on every single place this i

Re: LocaleProviderFactory

2017-03-15 Thread Stefaan Dutry
I have a question about the pull request. In the interface LocaleProviderFactory, there's only a method called createLocaleProvider. Does this mean that there's supposed to be a seperate instance of LocaleProvider on every single place this is used? (I know you could technicaly implement the inte