Re: Nested-tag support

2008-12-12 Thread Musachy Barroso
> I suggest to leave the default behaviour as-is for now, but give the > guys who want it a switch somewhere. > That is a given. musachy -- "Hey you! Would you help me to carry the stone?" Pink Floyd - To unsubscribe, e-mail:

Re: Nested-tag support

2008-12-12 Thread Ralf Fischer
Hi, On Thu, Dec 11, 2008 at 11:40 PM, Andreas Joseph Krogh wrote: > On Thursday 11 December 2008 23:31:46 Ronny Løvtangen wrote: >> On Dec 11, 2008, at 11:26 PM, Musachy Barroso wrote: >> >> > The problem with your suggestion is that it works for simple, and >> > specific cases, but given OGNL "p

Re: Nested-tag support

2008-12-12 Thread Andreas Joseph Krogh
On Friday 12 December 2008 01:30:13 Musachy Barroso wrote: > I second Dave's opinion. Patches are always welcomed. Great! Just wanted to make sure that our effort has a chance of being included in "main-struts" before we get on with the task. You'll hear from us, but it won't be tomorrow:-) --

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
I second Dave's opinion. Patches are always welcomed. musachy On Thu, Dec 11, 2008 at 6:13 PM, Dave Newton wrote: > --- On Thu, 12/11/08, Andreas Joseph Krogh wrote: >> Will patches implementing this get accepted? > > How can we answer that before getting the patches? I, for one, would probably

Re: Nested-tag support

2008-12-11 Thread Dave Newton
--- On Thu, 12/11/08, Andreas Joseph Krogh wrote: > Will patches implementing this get accepted? How can we answer that before getting the patches? I, for one, would probably evaluate such a patch: as long as it doesn't break anything else, and particularly if it solves indexed properties correc

Re: Nested-tag support

2008-12-11 Thread Nils-Helge Garli Hegvik
Didn't get that far... Couldn't get past requirement a) of part one ;) Nils-H On Thu, Dec 11, 2008 at 11:46 PM, Andreas Joseph Krogh wrote: > On Thursday 11 December 2008 23:40:51 Ronny Løvtangen wrote: >> >> On Dec 11, 2008, at 11:21 PM, Nils-Helge Garli Hegvik wrote: >> >> > As mentioned, I r

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:46:14 Andreas Joseph Krogh wrote: > On Thursday 11 December 2008 23:40:51 Ronny Løvtangen wrote: > > > > On Dec 11, 2008, at 11:21 PM, Nils-Helge Garli Hegvik wrote: > > > > > As mentioned, I realized that just _after_ pressing the send button, > > > so please igno

Re: Nested-tag support

2008-12-11 Thread Dave Newton
--- On Thu, 12/11/08, Ronny Løvtangen wrote: > On Dec 11, 2008, at 11:26 PM, Musachy Barroso wrote: > > > > > > > > > > > > > > what would the name be in that case? > > How would you handle the request parameters from this form? Indexed properties are built by hand; a shortcoming:

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:40:51 Ronny Løvtangen wrote: > > On Dec 11, 2008, at 11:21 PM, Nils-Helge Garli Hegvik wrote: > > > As mentioned, I realized that just _after_ pressing the send button, > > so please ignore my ignorance ;) > > Alright, you're on! > For those that aren't, take a lo

Re: Nested-tag support

2008-12-11 Thread Ronny Løvtangen
On Dec 11, 2008, at 11:21 PM, Nils-Helge Garli Hegvik wrote: As mentioned, I realized that just _after_ pressing the send button, so please ignore my ignorance ;) Alright, you're on! For those that aren't, take a look at the original explanation of nested tags in Struts 1 from Aaron Bates:

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:31:46 Ronny Løvtangen wrote: > > On Dec 11, 2008, at 11:26 PM, Musachy Barroso wrote: > > > The problem with your suggestion is that it works for simple, and > > specific cases, but given OGNL "power", there is a large way of cases > > when it would break. Like > >

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
> How would you handle the request parameters from this form? > Most of the time you don't do such power OGNL expressions in a form, you're > just interested in updating some objects in a collection. > My point is that the problem with this approach, is the assumption that the name is similar to t

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:31:59 Andreas Joseph Krogh wrote: > On Thursday 11 December 2008 23:26:02 Musachy Barroso wrote: > > The problem with your suggestion is that it works for simple, and > > specific cases, but given OGNL "power", there is a large way of cases > > when it would break. L

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:26:02 Musachy Barroso wrote: > The problem with your suggestion is that it works for simple, and > specific cases, but given OGNL "power", there is a large way of cases > when it would break. Like > > > > > > > > what would the nam

Re: Nested-tag support

2008-12-11 Thread Ronny Løvtangen
On Dec 11, 2008, at 11:26 PM, Musachy Barroso wrote: The problem with your suggestion is that it works for simple, and specific cases, but given OGNL "power", there is a large way of cases when it would break. Like what would the name be in that case? How woul

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
lmao, we cant be too serious here. musachy On Thu, Dec 11, 2008 at 5:21 PM, Dave Newton wrote: > What is this, some sort of Norwegian revolt? > > > --- On Thu, 12/11/08, Ronny Løvtangen wrote: > >> From: Ronny Løvtangen >> Subject: Re: Nested-tag support >

Re: Nested-tag support

2008-12-11 Thread Nils-Helge Garli Hegvik
As mentioned, I realized that just _after_ pressing the send button, so please ignore my ignorance ;) Nils-H On Thu, Dec 11, 2008 at 11:18 PM, Ronny Løvtangen wrote: > > On Dec 11, 2008, at 10:42 PM, Nils-Helge Garli Hegvik wrote: > >>> >>> The s:form equivalent of the nested-example above shoul

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:21:23 Dave Newton wrote: > What is this, some sort of Norwegian revolt? You're on! -- Andreas Joseph Krogh Senior Software Developer / CEO +-+ OfficeNet AS| The most difficult thing i

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
The problem with your suggestion is that it works for simple, and specific cases, but given OGNL "power", there is a large way of cases when it would break. Like what would the name be in that case? musachy On Thu, Dec 11, 2008 at 5:23 PM, Andreas Joseph Krogh

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:15:35 Musachy Barroso wrote: > Now I see what you mean. What 'push' does is to put a value on top of > the stack. The name attribute is a string, not an expression, and > doesn't use the stack for anything. That is why it wouldn't work. > There is a simple workaround

Re: Nested-tag support

2008-12-11 Thread Dave Newton
What is this, some sort of Norwegian revolt? --- On Thu, 12/11/08, Ronny Løvtangen wrote: > From: Ronny Løvtangen > Subject: Re: Nested-tag support > To: "Struts Developers List" > Date: Thursday, December 11, 2008, 5:18 PM > On Dec 11, 2008, at 10:42 PM, Nils

Re: Nested-tag support

2008-12-11 Thread Ronny Løvtangen
On Dec 11, 2008, at 10:42 PM, Nils-Helge Garli Hegvik wrote: The s:form equivalent of the nested-example above should be something like: Wouldn't to the trick? Yes, but what if you want to reuse code for the form fields for an address and

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 23:07:53 Musachy Barroso wrote: > Now I see what you mean. What 'push' does is to put a value on top of > the stack. The name attribute is a string, not an expression, and > doesn't use the stack for anything. That is why it wouldn't work. Yes, that's why it doesn't wo

Re: Nested-tag support

2008-12-11 Thread Nils-Helge Garli Hegvik
Yeah, I just didn't understand the question until after I sent the email :) Nils-H On Thu, Dec 11, 2008 at 10:56 PM, Musachy Barroso wrote: > it does, but the point it to make it less redundant, when you have > many fields in one block, like the "with" keyword in some languages > (Pascal? VB?) >

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
Now I see what you mean. What 'push' does is to put a value on top of the stack. The name attribute is a string, not an expression, and doesn't use the stack for anything. That is why it wouldn't work. There is a simple workaround tho, you can set a variable for it like: . or even I

Re: Nested-tag support

2008-12-11 Thread Dave Newton
--- On Thu, 12/11/08, Andreas Joseph Krogh wrote: > On Thursday 11 December 2008 22:36:37 Musachy Barroso wrote: > > I am sort if confused here, what are the advantages of this? > > >   >   > [...] The issue is the generation of the form element name, the input element value stuff would a

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 22:52:06 Musachy Barroso wrote: > > Have you ever used the nested-tags in Struts-1.1? > > Just for a few months to add it to my resume :) I've been depending on the nested-tags for years:-) > > This example is rather simple, but in much more complicated forms, inside

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 22:42:48 Nils-Helge Garli Hegvik wrote: > > > > The s:form equivalent of the nested-example above should be something like: > > > > > > > > > > > > > > > > Wouldn't to the trick? Yes, ofcourse, but that's exactly wh

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
it does, but the point it to make it less redundant, when you have many fields in one block, like the "with" keyword in some languages (Pascal? VB?) musachy On Thu, Dec 11, 2008 at 4:42 PM, Nils-Helge Garli Hegvik wrote: >> >> The s:form equivalent of the nested-example above should be something

Re: Nested-tag support

2008-12-11 Thread Nils-Helge Garli Hegvik
> > The s:form equivalent of the nested-example above should be something like: > > > > > > > Wouldn't to the trick? Nils-H - To unsubscribe, e-mail: dev-unsubscr...@struts.ap

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
> Have you ever used the nested-tags in Struts-1.1? Just for a few months to add it to my resume :) > This example is rather simple, but in much more complicated forms, inside > iterators for example, where you want to reuse JSPs it is >*extremely* useful > to avoid code-douplication. Much easi

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
On Thursday 11 December 2008 22:36:37 Musachy Barroso wrote: > I am sort if confused here, what are the advantages of this? Have you ever used the nested-tags in Struts-1.1? The advantage is that the value of the "name"-attribute is calculated for you. That way you can write:                

Re: Nested-tag support

2008-12-11 Thread Musachy Barroso
I am sort if confused here, what are the advantages of this? musachy On Thu, Dec 11, 2008 at 4:32 PM, Andreas Joseph Krogh wrote: > Anyone? > I really would like to see this included sooner than later and would > appreciate any feedback. > > On Thursday 11 December 2008 13:18:20 Andreas Joseph

Re: Nested-tag support

2008-12-11 Thread Andreas Joseph Krogh
Anyone? I really would like to see this included sooner than later and would appreciate any feedback. On Thursday 11 December 2008 13:18:20 Andreas Joseph Krogh wrote: > Hi all! > One of the most usefull things about (2.0 < Struts >= 1.1) is the > nested-tag-library. It allows you to do: > > >