Re: Rename @Inject to @StrutsInject

2011-07-27 Thread Łukasz Lenart
Let's close this discussion now, we can come back to it when users will start to complain ;-) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Warszawa JUG conference - Confitura http://confitura.pl/ - To unsubscrib

Re: Rename @Inject to @StrutsInject

2011-07-11 Thread Łukasz Lenart
This change can simple lower users' confusion and I suggested it base on my experience. Sometime ago I was developing application with CDI and RESTeasy - both have @Produces annotation and it was very annoying to discover such a mistake during unit tests or even UI tests. It's silly, but it happene

Re: Rename @Inject to @StrutsInject

2011-07-08 Thread Rene Gielen
See inline Am 08.07.11 19:53, schrieb Wes Wannemacher: > On Fri, Jul 8, 2011 at 1:35 PM, Paul Benedict wrote: >> I would leave it alone. Hibernate has many custom annotations with the >> same name as JPA annotations... if you need both, one needs to be >> fully qualified. >> > > I agree with Pau

Re: Rename @Inject to @StrutsInject

2011-07-08 Thread Dave Newton
On Fri, Jul 8, 2011 at 12:53 PM, Wes Wannemacher wrote: > A while back, I remember Don Brown mentioning that it is a good idea > to keep the IoC/DI of the framework separate from the IoC/DI available > for users. I agree with this sentiment. I'm not sure about that, although I see the point... I'

Re: Rename @Inject to @StrutsInject

2011-07-08 Thread Wes Wannemacher
On Fri, Jul 8, 2011 at 1:35 PM, Paul Benedict wrote: > I would leave it alone. Hibernate has many custom annotations with the > same name as JPA annotations... if you need both, one needs to be > fully qualified. > I agree with Paul, one of the benefits of having packages is the ability to have c

Re: Rename @Inject to @StrutsInject

2011-07-08 Thread Paul Benedict
I would leave it alone. Hibernate has many custom annotations with the same name as JPA annotations... if you need both, one needs to be fully qualified. As developers prefer CDI over XWork annotations, then Struts' @Inject will fall out of use. On Fri, Jul 8, 2011 at 12:28 PM, Jeff Black wrote:

Re: Rename @Inject to @StrutsInject

2011-07-08 Thread Jeff Black
Since it is part of XWork would @XInject be more appropriate? Just asking. From: Łukasz Lenart To: Struts Developers List Sent: Fri, July 8, 2011 6:11:23 AM Subject: Rename @Inject to @StrutsInject Hi, I was going to call for a Vote over bringing CDI plugin