RE: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-25 Thread 戸田 栞太(HARP)
I am planning to upgrade to Struts 7, but since the Java version will also be upgraded, I am still preparing. Has the EOL for Struts 6 been decided? -Original Message- From: Lukasz Lenart Sent: Friday, February 21, 2025 11:33 PM To: Struts Developers List Cc: sds-devs Subject: Re

Re: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-24 Thread Lukasz Lenart
sob., 22 lut 2025 o 10:56 i...@flyingfischer.ch.INVALID napisał(a): > There may very well be reasons to stay for some time on Tomcat 9, which > will be supported for a long time as far as I know. While it is > advisable to do so, we should not try to force users to migrate to > JakartaEE. I do no

Re: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-24 Thread Lukasz Lenart
wt., 25 lut 2025 o 02:51 戸田 栞太(HARP) napisał(a): > > I am planning to upgrade to Struts 7, but since the Java version will also be > upgraded, I am still preparing. > Has the EOL for Struts 6 been decided? No decision yet and I don't see an immediate requirement to do it. Cheers Łukasz --

Re: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-22 Thread i...@flyingfischer.ch.INVALID
I may be mistaken, but this is a question about * jakarta versus javax * Tomcat 9 versus Tomcat >= 10.1 * Java >=17 There may very well be reasons to stay for some time on Tomcat 9, which will be supported for a long time as far as I know. While it is advisable to do so, we should not try

Re: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-22 Thread Lukasz Lenart
sob., 22 lut 2025 o 10:46 Greg Huber napisał(a): > > What is the plan on v6? Continue development or maintenance only? I would prefer to switch into maintenance mode only, yet it depends on users Cheers Łukasz - To unsubscrib

Re: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-22 Thread Greg Huber
What is the plan on v6?  Continue development or maintenance only? More might jump to 7 if the latter. On 21/02/2025 14:33, Lukasz Lenart wrote: Thanks a lot for testing & confirming! Any plans to migrate to Struts 7? pt., 21 lut 2025 o 12:06 戸田 栞太(HARP) napisał(a): I've confirmed that it wor

Re: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-21 Thread Lukasz Lenart
Thanks a lot for testing & confirming! Any plans to migrate to Struts 7? pt., 21 lut 2025 o 12:06 戸田 栞太(HARP) napisał(a): > > I've confirmed that it works with Struts 6.7.4. > > Thank you for the fix! > > On 2025/02/20 14:01:53 Lukasz Lenart wrote: > > Hello, > > > > This is a patch release of St

RE: [TEST] Apache Struts 6.7.4 test build is ready

2025-02-21 Thread 戸田 栞太(HARP)
I've confirmed that it works with Struts 6.7.4. Thank you for the fix! On 2025/02/20 14:01:53 Lukasz Lenart wrote: > Hello, > > This is a patch release of Struts 6.x.x which contains only > non-breaking changes. Please take the time and test the bits - any > help is appreciated. Please report

RE: [TEST] Apache Struts 6.7.3 is ready

2025-02-20 Thread 戸田 栞太(HARP)
Thank you for researching this issue and creating a pull request. -Original Message- From: Kusal Kithul-Godage Sent: Thursday, February 20, 2025 2:28 PM To: 戸田 栞太(HARP) Cc: Struts Developers List ; sds-devs Subject: Re: [TEST] Apache Struts 6.7.3 is ready Thanks for sharing the full

Re: [TEST] Apache Struts 6.7.3 is ready

2025-02-19 Thread Łukasz Lenart
.3] > > > > at > > > > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:257) > > > > [struts2-core-6.7.3.jar:6.7.3] > > > > at > > > > jp.e_harp.common.interceptor.UserAgentCheckInt

Re: [TEST] Apache Struts 6.7.3 is ready

2025-02-19 Thread Kusal Kithul-Godage
m.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:257) > > > [struts2-core-6.7.3.jar:6.7.3] > > > at > > > org.apache.struts2.factory.StrutsActionProxy.execute(StrutsActionProxy.java:48) > > > [struts2-core-6.7.3.

Re: [TEST] Apache Struts 6.7.3 is ready

2025-02-19 Thread Łukasz Lenart
gt; [catalina.jar:9.0.71] > > at > > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:177) > > [catalina.jar:9.0.71] > > at > > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97) > &

Re: [TEST] Apache Struts 6.7.3 is ready

2025-02-19 Thread Kusal Kithul-Godage
at.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191) > [tomcat-util.jar:9.0.71] > at > org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) > [tomcat-util.jar:9.0.71] > at > org.apache.tomcat.util.threads.Ta

Re: [TEST] Apache Struts 6.7.3 is ready

2025-02-19 Thread 戸田 栞太(HARP)
___________ 差出人: Kusal Kithul-Godage 送信日時: 2025年2月19日 19:29 宛先: Struts Developers List CC: sds-devs 件名: Re: [TEST] Apache Struts 6.7.3 is ready Could you share the full stacktrace, including the exception thrown and caused by hierarchy? On Wed, Feb 19, 2025 at 9:14?PM 戸田 栞太(HARP)

Re: [TEST] Apache Struts 6.7.3 is ready

2025-02-19 Thread Kusal Kithul-Godage
Could you share the full stacktrace, including the exception thrown and caused by hierarchy? On Wed, Feb 19, 2025 at 9:14 PM 戸田 栞太(HARP) wrote: > > Hello, > > When using the tag in a JSP with the Struts tags > library, > the included page does not appear. The following error is displayed: > > S

Re: [TEST] Apache Struts 6.7.3 is ready

2025-02-19 Thread 戸田 栞太(HARP)
Hello, When using the tag in a JSP with the Struts tags library, the included page does not appear. The following error is displayed: Stacktrace: at org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:610) ~[jasper.jar:9.0.71] at org.apache.jasper.servlet.Jsp

Re: [TEST] Apache Struts 7.0.3 test build is ready

2025-02-17 Thread Lukasz Lenart
pon., 17 lut 2025 o 17:27 Burton Rhodes napisał(a): > > Thanks Lukasz! > > Quick question: With v7.0.3, what is the current status of the Multipart > upload logic? > > These 2 release comments are somewhat conflicting: > 6.7: WW-5528 Ensure multipart upload illegal characters reported as > error b

Re: [TEST] Apache Struts 7.0.3 test build is ready

2025-02-17 Thread Burton Rhodes
Thanks Lukasz! Quick question: With v7.0.3, what is the current status of the Multipart upload logic? These 2 release comments are somewhat conflicting: 6.7: WW-5528 Ensure multipart upload illegal characters reported as error by @kusalk in #1215 WW-5501 Reverts all changes related to WW-550

Re: [TEST] Apache Struts 6.7.2 test build is ready

2025-02-17 Thread Lukasz Lenart
This test build has been dropped in favour of the new Struts 6.7.3 test build (I will announce it shortly) and the problem should be addressed, thanks for your time & report! pon., 10 lut 2025 o 06:53 戸田 栞太(HARP) napisał(a): > > I am unable to obtain a token during the form upload process. Specif

RE: [TEST] Apache Struts 6.7.2 test build is ready

2025-02-09 Thread 戸田 栞太(HARP)
I am unable to obtain a token during the form upload process. Specifically, I have tried the following. ・I submitted a form from the browser with "enctype" set to "multipart/form-data" and used "struts.token.name" as the token name in the request. ・When executing "getTokenName()" from "TokenHel

Re: [TEST] Apache Struts 6.7.2 test build is ready

2025-02-04 Thread Lukasz Lenart
śr., 5 lut 2025 o 05:20 Kusal Kithul-Godage napisał(a): > > I've just tested this with the Confluence Data Center application. > > The file name filtering is actually causing a user experience regression for > us. > > Previously, we were able to validate the filename manually and display > the us

Re: [TEST] Apache Struts 6.7.2 test build is ready

2025-02-04 Thread Kusal Kithul-Godage
I've just tested this with the Confluence Data Center application. The file name filtering is actually causing a user experience regression for us. Previously, we were able to validate the filename manually and display the user an error - "Unsupported characters in file name". Now that the file i

Re: [TEST] Apache Struts 7.0.1 test build is ready

2025-02-03 Thread Lukasz Lenart
This test is closed as some issues have been discovered, a new test build is underway :) niedz., 2 lut 2025 o 08:38 Lukasz Lenart napisał(a): > > Hello, > > This is a patch release of Struts 7.x which contains only non-breaking > changes. > Please take the time and test the bits - any help is ap

Re: [TEST] Apache Struts 6.7.1 test build is ready

2025-02-03 Thread Kusal Kithul-Godage
Thanks for reporting - I believe this should fix the issue https://github.com/apache/struts/pull/1209 On Mon, Feb 3, 2025 at 10:19 PM wrote: > > Hello, > > it will happen, if you have an include tag before a closing tag - because the > release method of the PageContext will set the members like

Re: [TEST] Apache Struts 6.7.0 test build is ready

2025-01-06 Thread Lukasz Lenart
Done pon., 6 sty 2025 o 11:38 Sebastian Peters napisał(a): > > Hello Lukasz, > > Could you remove the "Pre-release" label from the release page? > https://github.com/apache/struts/releases/tag/STRUTS_6_7_0 > > Thank you! > Sebastian > >

Re: [TEST] Apache Struts 6.7.0 test build is ready

2025-01-06 Thread Sebastian Peters
Hello Lukasz, Could you remove the "Pre-release" label from the release page? https://github.com/apache/struts/releases/tag/STRUTS_6_7_0 Thank you! Sebastian - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additi

Re: [TEST] Apache Struts 7.0.0 test build is ready

2024-12-16 Thread Lukasz Lenart
pon., 16 gru 2024 o 07:27 Kusal Kithul-Godage napisał(a): > Tested with Atlassian's Confluence Data Center along with the > struts2-velocity-plugin. > > Observed one minor peculiarity with > struts.messages.upload.error.FileUploadByteCountLimitException where > the reported 'actual size' isn't con

Re: [TEST] Apache Struts 7.0.0 test build is ready

2024-12-15 Thread Kusal Kithul-Godage
Tested with Atlassian's Confluence Data Center along with the struts2-velocity-plugin. Observed one minor peculiarity with struts.messages.upload.error.FileUploadByteCountLimitException where the reported 'actual size' isn't consistent with Struts 6.x, however this may be an underlying change in c

Re: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-25 Thread Lukasz Lenart
Great! So we are good to go with call for vote then :) (mobile) W dniu pon., 25.11.2024 o 18:35 Luis Limas napisał(a): > Thank you for noticing it! it turned out that the issue was caused by > the JRebel Plugin, I turned it off and the issue is gone. Once the > struts release is out, I'll foll

Re: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-25 Thread Luis Limas
Thank you for noticing it! it turned out that the issue was caused by the JRebel Plugin, I turned it off and the issue is gone. Once the struts release is out, I'll follow up the issue with them. https://www.jrebel.com/products/jrebel/release-notes/202441-5th-november-2024 On 2024-11-25 10:59 a.

Re: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-25 Thread Lukasz Lenart
sob., 23 lis 2024 o 02:23 Luis Limas napisał(a): > Caused by: java.lang.IllegalAccessError: class > com.opensymphony.xwork2.config.ConfigurationManager tried to access protected > method 'void org.apache.struts2.ActionContext.(java.util.Map)' > (com.opensymphony.xwork2.config.ConfigurationManag

RE: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-25 Thread Luis Limas
@struts.apache.org Asunto: Re: [TEST] Apache Struts 6.7.0 test build is ready Hello Łukasz, thank you so much for your reply, I've cleaned the `temp` folder, an the issue was fixed. btw, I'm using OpenJDK Runtime Environment Temurin-17.0.8+7 (build 17.0.8+7). On 2024-11-23 07:18 a. m., Łukasz Le

Re: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-25 Thread Luis Limas
Hello Łukasz, thank you so much for your reply, I've cleaned the `temp` folder, an the issue was fixed. btw, I'm using OpenJDK Runtime Environment Temurin-17.0.8+7 (build 17.0.8+7). On 2024-11-23 07:18 a. m., Łukasz Lenart wrote: > [No suele recibir correo electrónico de lukasz.len...@gmail.com. D

Re: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-23 Thread Łukasz Lenart
What Java version do you use? Did you clean up the /tmp folder as this looks like a jar duplication issue? sob., 23 lis 2024 o 02:23 Luis Limas napisał(a): > > I had an issue with this release, I'm not sure what is causing it nor how to > replicate it, but this is the stacktrace: > > The error i

RE: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-22 Thread Luis Limas
I had an issue with this release, I'm not sure what is causing it nor how to replicate it, but this is the stacktrace: The error is thrown every time I visit that path WITHOUT a valid session when I login the error stops happening. My use-case is that I save the application logo at DB and show

Re: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-18 Thread Sebastian Peters
Hello Lukasz, it works for me in a larger web application. I migrated the following packages: import org.apache.struts2.ActionContext; import org.apache.struts2.ActionSupport; import org.apache.struts2.ModelDriven; import org.apache.struts2.Preparable; import org.apache.struts2.action.Action; ---

Re: [TEST] Apache Struts 6.7.0 test build is ready

2024-11-17 Thread Kusal Kithul-Godage
No issues here! On Mon, Nov 18, 2024 at 3:06 AM Lukasz Lenart wrote: > > Hello, > > This is a minor release of Struts 6.x series mostly because of > depreciating a lot of classes. > Please take the time and test the bits - any help is appreciated. > Please report any problems you will spot. > > H

Re: [TEST] Apache Struts 7.0.0-M10 test build is ready

2024-11-09 Thread Lukasz Lenart
And follow up https://github.com/apache/struts-site/pull/254 sob., 9 lis 2024 o 09:45 Lukasz Lenart napisał(a): > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=293046977#Struts6.x.xto7.x.xmigration-Fileupload > > sob., 9 lis 2024 o 09:21 Lukasz Lenart napisał(a): > > > > sob

Re: [TEST] Apache Struts 7.0.0-M10 test build is ready

2024-11-09 Thread Lukasz Lenart
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=293046977#Struts6.x.xto7.x.xmigration-Fileupload sob., 9 lis 2024 o 09:21 Lukasz Lenart napisał(a): > > sob., 9 lis 2024 o 08:06 Greg Huber napisał(a): > > I noticed also that needs to be > > removed now. Can this be 6.7 also as

Re: [TEST] Apache Struts 7.0.0-M10 test build is ready

2024-11-09 Thread Lukasz Lenart
sob., 9 lis 2024 o 08:06 Greg Huber napisał(a): > I noticed also that needs to be > removed now. Can this be 6.7 also as its not related to jarkata? Makes > sure the new upload works before the migration. Good point, this interceptor has been removed in Struts 7, I will point this out in the m

Re: [TEST] Apache Struts 7.0.0-M10 test build is ready

2024-11-08 Thread Greg Huber
I noticed also that needs to be removed now.  Can this be 6.7 also as its not related to jarkata?  Makes sure the new upload works before the migration. Cheers Greg On 05/11/2024 06:44, Lukasz Lenart wrote: Thanks Greg & Burton for testing the changes, nice to hear migration went smoothly :)

Re: [TEST] Apache Struts 7.0.0-M10 test build is ready

2024-11-04 Thread Lukasz Lenart
Thanks Greg & Burton for testing the changes, nice to hear migration went smoothly :) And thanks Burton pointing out missing info in the migration guide, already updated some sections and also added your suggestions with refactored names. https://cwiki.apache.org/confluence/display/WW/Struts+6.x.x

Re: [TEST] Apache Struts 7.0.0-M10 test build is ready

2024-11-04 Thread Burton Rhodes
Thanks Lukasz, M10 seems to be working well in our environment. Thanks for all your hard work on this. FYI, I didn't see any mention of the package name refactoring in the migration guide. Although it will become immediately obvious when building, it might be good to include for completeness.

Re: [TEST] Apache Struts 7.0.0-M10 test build is ready

2024-11-03 Thread Greg Huber
Works great for me. Quite alot of changes in this one.  Don't forget to update all your .ftl template mods. On 03/11/2024 14:48, Lukasz Lenart wrote: Hello, This is another milestone of Struts 7.x series, which is based on JakartaEE 6. Please take the time and test the bits - any help is app

Re: [TEST] Apache Struts 6.6.1 test build is ready

2024-10-08 Thread Kusal Kithul-Godage
No issues here! On Sun, Oct 6, 2024 at 12:21 AM Lukasz Lenart wrote: > > Hello, > > This is a patch release of Struts 6.x series. Please take the time and > test the bits - any help is appreciated. Please report any problems > you will spot. > > Here are the changes from the previous version: > h

Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-22 Thread Kusal Kithul-Godage
No issues integrating with Confluence On Sat, Jul 20, 2024 at 4:52 PM Lukasz Lenart wrote: > > Hello, > > This is another minor version of Struts 6.x series. Please take the > time and test the bits - any help is appreciated. Please report any > problems you will spot. > > Here are the changes fr

Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-21 Thread Lukasz Lenart
sob., 20 lip 2024 o 11:51 Greg Huber napisał(a): > > Sorry, please ignore previous emails, I went back in my logs and found > the same errors. Fixed it by updating my crusty code.😳 > > <%@ include file="/WEB-INF/jsps/taglibs-struts2.jsp" %> > <% > pageContext.setAttribute("version",my.model.MyFac

Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-20 Thread Greg Huber
Sorry, please ignore previous emails, I went back in my logs and found the same errors.  Fixed it by updating my crusty code.😳 <%@ include file="/WEB-INF/jsps/taglibs-struts2.jsp" %> <% pageContext.setAttribute("version",my.model.MyFactory.getMe().getVersion()); pageContext.setAttribute("revisio

Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-20 Thread Greg Huber
May have been some formatting on previous mail, here it is again 2024-07-20 09:39:59,406 WARN org.apache.struts2.interceptor.TokenSessionStoreInterceptor TokenSessionStoreInterceptor:handleInvalidToken - testHandleInvalidToken 2024-07-20 09:39:59,535 WARN com.opensymphony.xwork2.ognl.OgnlValueS

Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-20 Thread Greg Huber
I am looking into duplicate session postings (circular nulls in TokenSessionStoreInterceptor by refresh post) in my app, and noticed this now in the tomcat log 2024-07-20 09:39:59,406 WARN org.apache.struts2.interceptor.TokenSessionStoreInterceptor TokenSessionStoreInterceptor:handleInvalidT

Re: [TEST] Apache Struts 6.5.0 test build is ready

2024-07-19 Thread Lukasz Lenart
I'm going to drop this build and prepare a new one labeled 6.6.0 - a few issues have been discovered in this build. pt., 12 lip 2024 o 09:14 i...@flyingfischer.ch napisał(a): > > Works fine here. > > I can also confirm that https://issues.apache.org/jira/browse/WW-5419 is > resolved. > > Thanks f

Re: [TEST] Apache Struts 7.0.0-M8 test build is ready

2024-07-13 Thread Lukasz Lenart
sob., 13 lip 2024 o 08:10 Kusal Kithul-Godage napisał(a): > > It's prototype scope which means a new instance is constructed > wherever it's injected/retrieved. I'll take a look - shouldn't be too > hard to fix Thanks a lot! Cheers Lukasz

Re: [TEST] Apache Struts 7.0.0-M8 test build is ready

2024-07-12 Thread Kusal Kithul-Godage
It's prototype scope which means a new instance is constructed wherever it's injected/retrieved. I'll take a look - shouldn't be too hard to fix On Sat, Jul 13, 2024 at 1:59 AM Lukasz Lenart wrote: > > Shouldn't this just happen once as this is a managed bean? > > pt., 12 lip 2024 o 15:25 Kusal K

Re: [TEST] Apache Struts 7.0.0-M8 test build is ready

2024-07-12 Thread Lukasz Lenart
Shouldn't this just happen once as this is a managed bean? pt., 12 lip 2024 o 15:25 Kusal Kithul-Godage napisał(a): > > Ah that'll be my last change - I'll check this, thanks! The 6.5.0 test > build will have the same issue > > On Fri, Jul 12, 2024 at 10:17 PM Burton Rhodes wrote: > > > > I'm no

Re: [TEST] Apache Struts 7.0.0-M8 test build is ready

2024-07-12 Thread Kusal Kithul-Godage
Ah that'll be my last change - I'll check this, thanks! The 6.5.0 test build will have the same issue On Fri, Jul 12, 2024 at 10:17 PM Burton Rhodes wrote: > > I'm not sure if this is unique to M8, but I just turned on devMode and > loading a single page in my app floods the console with these en

Re: [TEST] Apache Struts 7.0.0-M8 test build is ready

2024-07-12 Thread Burton Rhodes
I'm not sure if this is unique to M8, but I just turned on devMode and loading a single page in my app floods the console with these entries. I'm sure the log entries are correct, but they aren't helpful. For example, shouldn't it tell me which classes or packages or what JSP call/variable is

Re: [TEST] Apache Struts 6.5.0 test build is ready

2024-07-12 Thread i...@flyingfischer.ch
Works fine here. I can also confirm that https://issues.apache.org/jira/browse/WW-5419 is resolved. Thanks for your steady good work! Best regards Markus Am 12.07.24 um 07:47 schrieb Lukasz Lenart: Hello, This is another minor version of Struts 6.x series. Please take the time and test th

Re: [TEST] Apache Struts 7.0.0-M8 test build is ready

2024-07-11 Thread Kusal Kithul-Godage
Thanks Lukasz Confirming that this milestone includes an enhancement which allows the OGNL allowlist capability to continue functioning in the presence of Hibernate entities. Simply set `struts.disallowProxyObjectAccess=false` and the OGNL allowlist will automatically exempt Hibernate entities. As

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-23 Thread Kusal Kithul-Godage
This capability is indeed similar to strict method invocation but for request parameters. I'm not against an XML based alternative for those who prefer it. It might lose some additional benefit that comes with co-location of configuration with code though. With annotations, anyone reading the Act

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-23 Thread Greg Huber
Going through my parameters, as I share alot of screens in various parts with different requirements, a struts.xml version on the action, similar to save,publish,expire would work well here ie path,filter public String getPath() {    return path; } public String getFilter() {    re

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-18 Thread Kusal Kithul-Godage
Yeah good call I'll look into it On Tue, Jun 18, 2024 at 5:54 PM Greg Huber wrote: > > OK thanks. > > Can the logging be the same others - Developer Notification rather than > changing the debug level? > > ie for a bad date I get > > 024-06-18 08:24:53,696 WARN org.apache.struts2.components.Date

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-18 Thread Greg Huber
OK thanks. Can the logging be the same others - Developer Notification rather than changing the debug level? ie for a bad date I get 024-06-18 08:24:53,696 WARN org.apache.struts2.components.Date Date:end - Developer Notification (set struts.devMode to false to disable this message): Expr

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-18 Thread Kusal Kithul-Godage
Good questions The log messages for these are at the debug level so you will need to enable logging at the debug level to see these. This was a deliberate decision as otherwise bad actors would be able to flood your application logs. The annotations should only target Action class methods. If you

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-18 Thread Greg Huber
For the |struts.parameters.requireAnnotations=||true| If I test my action, there are no log messages for these.  ie missing @StrutsParameter. It also says Action class, what if I have a bean in the action class, do I need to do these also? If I add them to every field/bean is this the same

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-17 Thread Kusal Kithul-Godage
I've fleshed out the Security section of the migration guide. Open to any feedback on anything that is still unclear. https://cwiki.apache.org/confluence/x/wYp3EQ On Mon, Jun 17, 2024 at 8:14 PM Kusal Kithul-Godage wrote: > > Ah right - yep no objections here > > Based on the feedback in this thr

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-17 Thread Kusal Kithul-Godage
Ah right - yep no objections here Based on the feedback in this thread, I'm working on a minor enhancement for the allowlisting capability which will allow it to continue working at a lesser strictness in environments where Hibernate entities are used. I'll target M8 for this as well as the update

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-17 Thread Lukasz Lenart
pon., 17 cze 2024 o 11:00 Kusal Kithul-Godage napisał(a): > > When you say release officially do you mean as the final Struts 7.0.0? I meant release -> publish as M7 in the Maven Central - in such a case we can spread testing to other users as they can use official artifacts. Regards Lukasz ---

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-17 Thread Kusal Kithul-Godage
When you say release officially do you mean as the final Struts 7.0.0? On Mon, Jun 17, 2024 at 6:57 PM Lukasz Lenart wrote: > > Should I call for a vote to release M7 officially? > > Cheers > Lukasz > > - > To unsubscribe, e-mail

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-17 Thread Lukasz Lenart
Should I call for a vote to release M7 officially? Cheers Lukasz - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
Folder$HibernateProxy$OVniT9Ol] struts.xml -- Original Message -- From "Kusal Kithul-Godage" To "Struts Developers List" Date 6/16/2024 9:51:36 AM Subject Re: [TEST] Apache Struts 7.0.0-M7 test build is ready So the allowlist configuration is u

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Kusal Kithul-Godage
Folder$HibernateProxy$OVniT9Ol] > > struts.xml > > value="false"/> > > > > -- Original Message ------ > From "Kusal Kithul-Godage" > To "Struts Developers List" > Date 6/16/2024 9:51:36 AM > Subject Re: [TEST] Apache Struts 7.0.0-M7

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Burton Rhodes
here--], proxy class [com.afs.core.entity.Folder$HibernateProxy$OVniT9Ol] struts.xml value="false"/> -- Original Message -- From "Kusal Kithul-Godage" To "Struts Developers List" Date 6/16/2024 9:51:36 AM Subject Re: [TEST] Apache Struts 7.0.0-M7

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Lukasz Lenart
niedz., 16 cze 2024 o 16:52 Kusal Kithul-Godage napisał(a): > Lukasz if you could give me edit permission for the Struts 7.x > migration guide, I'll add a quick note there too. You should have access, please login with Apache ID and password Regards Łukasz -

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Kusal Kithul-Godage
So the allowlist configuration is usually just informed by the warnings logged during runtime. For most applications this will either be nothing or some Pojo packages. So for the example log warning you've provided that would be: struts.allowlist.packageNames=my.pojo However, the main issue you're

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
2024-06-16 11:06:39,002 WARN com.opensymphony.xwork2.ognl.SecurityMemberAccess SecurityMemberAccess:isAccessible - Access to proxy is blocked! Target The docs don't give any hints on what the list should be. my.pojo.Pojo$HibernateProxy$tEzkTVrG] This is an inquiry screen. On 16/06/2024 1

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Kusal Kithul-Godage
So you've got 2 separate issues here: * Pojos that are not allowlisted * OGNL executions against Spring/Hibernate proxied objects If you have genuine Pojos that need allowlisting, you can do so by following the documentation: https://struts.apache.org/security/#ognl-member-access Allowlisting Pojo

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
I use both spring and hibernate v6 testing, I would not want to make any drastic changes to these as they are painful. Here is one (of many) 2024-06-16 09:26:21,419 WARN com.opensymphony.xwork2.ognl.SecurityMemberAccess SecurityMemberAccess:checkAllowlist - Declaring class [class my.pojo.Poj

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Kusal Kithul-Godage
That suggests the target is proxied by Spring or Hibernate, which Pojos should not be by definition. You'll need to attach a debugger to investigate why this is the case On Sun, Jun 16, 2024 at 7:19 PM Greg Huber wrote: > > The text looks ok, but I get this in the log also: > > 2024-06-16 10:15:1

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
The text looks ok, but I get this in the log also: 2024-06-16 10:15:12,587 WARN com.opensymphony.xwork2.ognl.SecurityMemberAccess SecurityMemberAccess:isAccessible - Access to proxy is blocked! Target [][ Where the target is my pojo, which I have alot of. On 16/06/2024 10:15, Kusal Kithul-Go

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Kusal Kithul-Godage
I didn't do much testing with the Struts JSP integration beyond the examples in the showcase app so it's possible I've missed some packages/classes that should be allowed by default. Could you share the warnings you are receiving? Perhaps deduplicate the warnings first if there are many repetitive

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
Sorry checked the wrong log file, it was this one, needed to be false. Is there any docs on this?  ie and example of what would go in the list, as its excluding struts default stuff. On 16/06/2024 10:01, Kusal Kithul-Godage wrote: All of the mentioned options should log issues at warn level

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Kusal Kithul-Godage
All of the mentioned options should log issues at warn level or greater, except for 'struts.parameters.requireAnnotations' which will log at debug level. Using the following PR as a reference, you can revert settings to their previous value one by one, to isolate which option may be causing your a

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
I tried this and there is alot of text missing on my jsp pages it mentions these: |struts.ognl.allowStaticFieldAccess=||false| |struts.ognl.expressionMaxLength=||150| |struts.disallowDefaultPackageAccess=||true| |struts.disallowProxyMemberAccess=||true| |struts.parameters.requireAnnotations=||tr

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-22 Thread Lukasz Lenart
pon., 22 kwi 2024 o 10:35 Greg Huber napisał(a): > File upload also works OK, but Without the in UploadedFile now I must > do the cast manually: > > for (UploadedFile uploadedFile : uploads) { > ... >new FileInputStream((File) uploadedFile.getContent()) > ... > } I need to think this throug

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-22 Thread Greg Huber
7.0.0-M7-SNAPSHOT Thanks it worked, maybe it was a timing thing as they are in snapshots now. M7 works ok. File upload also works OK, but Without the in UploadedFile now I must do the cast manually: for (UploadedFile uploadedFile : uploads) { ... new FileInputStream((File) uploadedFile.get

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-21 Thread Lukasz Lenart
niedz., 21 kwi 2024 o 20:11 Greg Huber napisał(a): > > I run my ide directly from git, and it is the struts project that won't > build. I was following the previous modification changing the struts pom > 3x -jakarta entries which was previously 7.0.0-M3-SNAPSHOT and it worked > then ok. So you c

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-21 Thread Greg Huber
I run my ide directly from git, and it is the struts project that won't build. I was following the previous modification changing the struts pom 3x -jakarta entries which was previously 7.0.0-M3-SNAPSHOT and it worked then ok. On Sun, 21 Apr 2024 at 12:10, Lukasz Lenart wrote: > niedz., 21 k

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-04-21 Thread Lukasz Lenart
Here is a list of all Milestones https://cwiki.apache.org/confluence/display/WW/Migration+Guide#MigrationGuide-VersionNotes7.x śr., 28 lut 2024 o 09:15 Greg Huber napisał(a): > > selecting "Maven > Disable Workspace Resolution" > > I need eclipse to build the target/classes folder otherwise I can

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-21 Thread Lukasz Lenart
niedz., 21 kwi 2024 o 11:12 Greg Huber napisał(a): > > Using 7.0.0-M6 I still get > > The POM for org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M6 is > missing, no dependency information available Do you specify "struts2-freemarker-jakarta" as a seperated dependency? Or is it just "strut

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-21 Thread Greg Huber
Using 7.0.0-M6 I still get The POM for org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M6 is missing, no dependency information available #Sun Apr 21 10:00:20 BST 2024 apache.snapshots|https\://repository.apache.org/snapshots|javadoc=1713690020922 central|https\://repo.maven.apache.o

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-20 Thread Lukasz Lenart
sob., 20 kwi 2024 o 13:20 Burton Rhodes napisał(a): > > It should be > > 7.0.0-M6 I released M4 & M5 but there was a problem with standalone ZIP packages, so I had to prepare another release. I think it would be good to push this into Maven Central to allow others to test it as well. Regards Lu

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-20 Thread Burton Rhodes
It should be 7.0.0-M6 -- Original Message -- From "Greg Huber" To "Struts Developers List" Date 4/20/2024 5:11:19 AM Subject Re: [TEST] Apache Struts 7.0.0-M6 test build is read What would be the pom fix value we need to use? 7.0.0-M6-SNAPSHOT org.ap

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-20 Thread Greg Huber
What would be the pom fix value we need to use? 7.0.0-M6-SNAPSHOT org.apache.struts struts2-velocity-tools-view-jakarta 7.0.0-M6-SNAPSHOT On 20/04/2024 08:45, Lukasz Lenart wrote: Hello, This is a third milestone of Struts 7.x series, which is based on JakartaEE 6. Please take the time

Re: [TEST] Apache Struts 6.4.0 test build is ready

2024-04-17 Thread Łukasz Lenart
pt., 12 kwi 2024 o 10:31 Kusal Kithul-Godage napisał(a): > > Following up on this - I've run the Struts 6.4 staging build through > our test suite and I've no issues or regressions to report! Great, thanks a lot for testing the new version! I already started the voting process on releasing 6.4.0

Re: [TEST] Apache Struts 6.4.0 test build is ready

2024-04-12 Thread Kusal Kithul-Godage
Following up on this - I've run the Struts 6.4 staging build through our test suite and I've no issues or regressions to report! On Mon, Apr 8, 2024 at 9:34 PM Kusal Kithul-Godage wrote: > > Thanks Lukasz > > I will run this build through the Confluence test suite before the end > of the week and

Re: [TEST] Apache Struts 6.4.0 test build is ready

2024-04-08 Thread Kusal Kithul-Godage
I will probably be one of those people :) Unfortunately my team is not in a position to upgrade to Struts 7.0 (Jakarta namespace) for at least another 12 months so we will be relying on the 6.x releases for quite some time. I suspect there will be many others in the same boat. Also relatedly, I wi

Re: [TEST] Apache Struts 6.4.0 test build is ready

2024-04-08 Thread Kusal Kithul-Godage
Thanks Lukasz I will run this build through the Confluence test suite before the end of the week and report back. Also, I wanted to check whether this is the final Struts 6.x release or if there is a 6.5 planned? On Sun, 7 Apr 2024 at 19:50, Lukasz Lenart wrote: > > Hello, > > This is another m

Re: [TEST] Apache Struts 6.4.0 test build is ready

2024-04-08 Thread Lukasz Lenart
pon., 8 kwi 2024 o 13:34 Kusal Kithul-Godage napisał(a): > > Thanks Lukasz > > I will run this build through the Confluence test suite before the end > of the week and report back. Great, thanks in advance! > Also, I wanted to check whether this is the final Struts 6.x release > or if there is a

Re: [TEST] Apache Struts 6.4.0 test build is ready

2024-04-08 Thread Kusal Kithul-Godage
Thanks Lukasz I will run this build through the Confluence test suite before the end of the week and report back. Also, I wanted to check whether this is the final Struts 6.x release or if there is a 6.5 planned? On Sun, Apr 7, 2024 at 7:50 PM Lukasz Lenart wrote: > > Hello, > > This is another

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-02-28 Thread Greg Huber
selecting "Maven > Disable Workspace Resolution" I need eclipse to build the target/classes folder otherwise I cannot run tomcat. Hopefully this will be fixed once the *-jakarta.jars are released as they are not snapshot? On 28/02/2024 00:01, James Dyer wrote: I agree the best l

  1   2   3   4   >