Re: Thoughts on Checkstyle stuff

2005-08-26 Thread Ted Husted
On 8/24/05, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: > Perhaps I can make an offer here... > > At some point, I imagine, you guys (the committers) are all going to agree > that the code is stable and ready for release. How about if at that > point, whenever it is, someone drops me a line and

Re: Thoughts on Checkstyle stuff

2005-08-24 Thread Frank W. Zammetti
Done. I also obsoleted the attachments and made a note that I will tackle all the Checkstyle complaints when the 1.3 code base is deemed stable and otherwise ready for release. By the way, I don't mind looking at PMD stuff as well, and Jlint and FindBugs too, at the same time... I think only PMD

Re: Thoughts on Checkstyle stuff

2005-08-24 Thread Don Brown
Works for me. If you could, mark the ticket LATER until then. Thanks, Don Frank W. Zammetti wrote: Perhaps I can make an offer here... At some point, I imagine, you guys (the committers) are all going to agree that the code is stable and ready for release. How about if at that point, whenev

Re: Thoughts on Checkstyle stuff

2005-08-24 Thread Frank W. Zammetti
Perhaps I can make an offer here... At some point, I imagine, you guys (the committers) are all going to agree that the code is stable and ready for release. How about if at that point, whenever it is, someone drops me a line and says "ok, have at it with the Checkstyle stuff", and give me maybe

Re: Thoughts on Checkstyle stuff

2005-08-24 Thread James Mitchell
Struts Developers List" Sent: Wednesday, August 24, 2005 1:02 PM Subject: Re: Thoughts on Checkstyle stuff Sorry James, I missed this email as apparently Thunderbird thought it was junk :) I'm willing to take the time to apply this patch if you have no objection. While I'd l

Re: Thoughts on Checkstyle stuff

2005-08-24 Thread Don Brown
Sorry James, I missed this email as apparently Thunderbird thought it was junk :) I'm willing to take the time to apply this patch if you have no objection. While I'd like to think 1.3.0 is days away, past experience has shown "don't hold your breath". My first concern looking at the patch was

RE: Thoughts on Checkstyle stuff

2005-08-24 Thread George.Dinwiddie
Sent: Wednesday, August 24, 2005 10:58 AM > To: Struts Developers List > Cc: Struts Developers List > Subject: Re: Thoughts on Checkstyle stuff > > > Hi James, > > I see this as an ongoing task... the types of things that > Checkstyle raises are the types of things that

Re: Thoughts on Checkstyle stuff

2005-08-24 Thread Frank W. Zammetti
Hi James, I see this as an ongoing task... the types of things that Checkstyle raises are the types of things that tend to creep in continually, for various reasons, even moreso with a community-driven project like Struts. That being said, I think there is value in getting what is there now taken

Re: Thoughts on Checkstyle stuff

2005-08-24 Thread James Mitchell
I saw the tread, but I haven't followed that discussion. I would rather wait till after 1.3.0 is out there. If you can wait till things settle down, I'd be happy to apply your fixes then. After all, the activity may make your patches out of date and we would need to do it ourselves or as

Re: Thoughts on Checkstyle stuff

2005-08-23 Thread Frank W. Zammetti
Anyone have a chance to look or think about this? I'd like to continue the work but I'd also like to know if folks are receptive to it or not. Maybe you were all just busier today than I was... I Unfortunately have a car that's getting ready to die any day now, so most of my time was spent l