Re: Upgrading Tiles plugin

2015-11-27 Thread Lukasz Lenart
Now I have started thinking about upgrading/redoing the Tiles 3 plugin and the problem is with conflicting dependencies. Also, it looks like Tiles 3 can handle Tiles 2 definitions, so I'm wondering if it makes sense to drop the Tiles plugin and replace it with the Tiles 3 plugin. My work on upgradi

Re: Upgrading Tiles plugin

2015-11-25 Thread Lukasz Lenart
2015-11-19 10:46 GMT+01:00 Lukasz Lenart : > 2015-11-17 12:53 GMT+01:00 Lukasz Lenart : >> I'm working on upgrading Tiles plugin to use the latest Tiles 2.x >> version - 2.2.2 - and it looks like the only thing is to drop all the >> custom code from the plugin, just leave TilesResult. >> >> Tiles 2

Re: Upgrading Tiles plugin

2015-11-22 Thread Lukasz Lenart
2015-11-21 1:20 GMT+01:00 Ken McWilliams : > Everything sounds great. I do recommend keeping the regex matching. I it's > hard to know which types of view support should be dropped, I think it is > better to err on the side of inclusion. Yes, support for RegEx will follow > On another front, don'

Re: Upgrading Tiles plugin

2015-11-20 Thread Ken McWilliams
Everything sounds great. I do recommend keeping the regex matching. I it's hard to know which types of view support should be dropped, I think it is better to err on the side of inclusion. On another front, don't you like how they select the type of matcher by using a prefix in the string? "OGNL:"

Re: Upgrading Tiles plugin

2015-11-19 Thread Lukasz Lenart
2015-11-20 7:43 GMT+01:00 Christoph Nenning : > I'm not so deep into tiles to have a strong opinion. But that makes a lot > of sense to me. Can this be shared between tiles2 and tiles3 plugins? Yes, I think after gathering all the knowledge about Tiles I'm gonna update the Tiles 3 Plugin as well :

Re: Upgrading Tiles plugin

2015-11-19 Thread Christoph Nenning
> > I'm working on upgrading Tiles plugin to use the latest Tiles 2.x > > version - 2.2.2 - and it looks like the only thing is to drop all the > > custom code from the plugin, just leave TilesResult. > > > > Tiles 2.2.2 contains support for FreeMarker (the Struts custom is > > doing that) plus few

Re: Upgrading Tiles plugin

2015-11-19 Thread Lukasz Lenart
2015-11-17 12:53 GMT+01:00 Lukasz Lenart : > I'm working on upgrading Tiles plugin to use the latest Tiles 2.x > version - 2.2.2 - and it looks like the only thing is to drop all the > custom code from the plugin, just leave TilesResult. > > Tiles 2.2.2 contains support for FreeMarker (the Struts c

Re: Upgrading Tiles plugin

2015-11-17 Thread Lukasz Lenart
Thanks Ken for all your insights :) 2015-11-17 18:59 GMT+01:00 Ken McWilliams : > I could be mistaken but I think 2.2.2 added direct support for OGNL (MVEL, > freemarker, and many others), which is pretty interesting. This was the > last step before what looks like a cleanup and some refactoring t

Re: Upgrading Tiles plugin

2015-11-17 Thread Ken McWilliams
I could be mistaken but I think 2.2.2 added direct support for OGNL (MVEL, freemarker, and many others), which is pretty interesting. This was the last step before what looks like a cleanup and some refactoring that resulted in Tiles 3 (It also has the same EL/Template support). If you're putting i