Re: [s2] Distribution contents?

2006-07-11 Thread Ted Husted
On 7/10/06, Patrick Lightbody <[EMAIL PROTECTED]> wrote: This is a good question. I've wrestled with this a lot with WebWork. A few thoughts: - Does documentation have to be included in the release, or is connectivity good enough these days to let us get away with just pointing users to the w

Re: [s2] Distribution contents?

2006-07-11 Thread Jason Carreira
> > Yes, we do seem to have a JAR bloat issue with Struts > 2. On disk, the > S2 applications run *twice* the size of comparable > S1 applications. > (Though, that does not mean the memory footprint is > different!) > > Why is that? Are we sucking in any runtime > dependencies that we don't > ne

Re: svn commit: r420868 - in /struts/site/src/site: fml/roadmap.fml xdoc/download.xml xdoc/downloads.xml xdoc/index.xml

2006-07-11 Thread Wendy Smoak
On 7/11/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: husted Date: Tue Jul 11 07:25:52 2006 New Revision: 420868 URL: http://svn.apache.org/viewvc?rev=420868&view=rev Log: SITE-8 : Update nighly build reference; delete obsolete 'downloads.xml' page; yet another tweak to index and roa

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Wendy Smoak
On 7/10/06, Ted Husted <[EMAIL PROTECTED]> wrote: Once the docs are squared-away, I can review the bundled applications, tag it all STRUTS_1_3_5, and roll the distribution. We can then review the distribution and vote on a quality grade. If for any reason, 1.3.5 doesn't make GA, we'll can try ag

[struts1] 1.3.5 - "Embedded" Tiles

2006-07-11 Thread Ted Husted
For the 1.3.5 version, do we want to remove any references to using Tiles outside of Struts, except to refer to the separate Tiles 2 subproject? As mentioned on the user list, there are references to a TilesServlet and installation notes that seem to be obsolete. For this version, I'd like to cu

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread James Mitchell
You might as well go ahead and commit those. I can't seem patch my local checkout without seeing a bunch of partial chunk failures, so I'm sure I'm just doing it wrong. Thanks -- James Mitchell On Jul 11, 2006, at 1:37 PM, Wendy Smoak wrote: On 7/10/06, Ted Husted <[EMAIL PROTECTED]>

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Ted Husted
First, I want to say that the Struts 1.3.5 assembly is a marvel of Maven engineering. * http://people.apache.org/builds/struts/1.3.x/assembly/ It's all there, simple as pie. /docs /lib /src /webapps NOTICE.txt LICENSE.txt My only question is: Does size matter? Zipped, the 1.3.5 snapshot is 40

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Frank W. Zammetti
I can do some more Checkstyle work over the next few days... when do you (or whoever is going to do it) plan to role the release? I absolutely doubt I can get them all taken care of by then, whenever then actually is, but I should be able to cut through another sizable chunk of them. Wendy, your

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread James Mitchell
I'm not sure what the issue with the patches was (for me), but I tried applying them on both of the following: Windows XP/Cygwin Mac OS X/standard console I tried it both individually and with Wendy's patch. Thanks -- James Mitchell On Jul 11, 2006, at 4:59 PM, Frank W. Zammetti wrote:

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Frank W. Zammetti
Weird. Almost certainly some silly setting when generating them that I'm not aware of... Wendy can fill us both in on what the magic she worked was :) Frank James Mitchell wrote: I'm not sure what the issue with the patches was (for me), but I tried applying them on both of the following:

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Ted Husted
On 7/11/06, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: I can do some more Checkstyle work over the next few days... when do you (or whoever is going to do it) plan to role the release? If Wendy checks in those checkstyle patches, we just need to sort out the Tiles documentation, which would b

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Frank W. Zammetti
Ok, in that case I'll hold off until later... a month or so after release maybe? I know you said patches after releases are generally frowned upon, does a month sound like a reasonable waiting period? Frank Ted Husted wrote: On 7/11/06, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: I can do

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Wendy Smoak
On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: Zipped, the 1.3.5 snapshot is 40.8mb. Zipped, the individual components come to docs.zip - 11.5mb lib.zip - 2.8mb src.zip - 5.8mb webapps - 20.5mb Do we want to offer these archives separately, in addition to the combined snapshot? I'd like

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Wendy Smoak
On 7/11/06, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: Weird. Almost certainly some silly setting when generating them that I'm not aware of... Wendy can fill us both in on what the magic she worked was :) None, apparently, if James can't apply my version either. :) FWIW, I'm applying patc

Re: [struts1] 1.3.5 - "Embedded" Tiles

2006-07-11 Thread Wendy Smoak
On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: For this version, I'd like to cut to the chase and treat Tiles as bundled component, like the Validator. I don't know if we have the code in there to use it standalone or not, but even if we do, we should refer people to Tiles 2 for that sort of

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Frank W. Zammetti
Ah, sorry, for some reason I thought your changes had worked for him. Wendy Smoak wrote: On 7/11/06, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: Weird. Almost certainly some silly setting when generating them that I'm not aware of... Wendy can fill us both in on what the magic she worked was

Re: [struts1] 1.3.5 - "Embedded" Tiles

2006-07-11 Thread Ted Husted
Do you want to copy over the Tiles docs that we have now, before I have at them? They would at least be a starting point/ -Ted. On 7/11/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: > For this version, I'd like to cut to the chase and treat Tiles

Re: [struts1] 1.3.5 - "Embedded" Tiles

2006-07-11 Thread Wendy Smoak
On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: Do you want to copy over the Tiles docs that we have now, before I have at them? I don't think so. We can always copy them by revision number later if we need them, so go ahead with your changes. -- Wendy

Re: [struts1] 1.3.5 - "Embedded" Tiles

2006-07-11 Thread Greg Reddin
On Jul 11, 2006, at 5:51 PM, Wendy Smoak wrote: On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: For this version, I'd like to cut to the chase and treat Tiles as bundled component, like the Validator. I don't know if we have the code in there to use it standalone or not, but even if we do,

[maven] URIs on sub-sites

2006-07-11 Thread Ted Husted
I don't know what I'm doing wrong, but the menu URIs on the subsites are not rendering correctly for me. For some reason, they seem to be stripping "http://struts.apache.org/"; out of all the URIs, so that a reference to "http://struts.apache.org/1.x"; becomes "1.x", and a reference to just "http

Re: [struts1] 1.3.5 - "Embedded" Tiles

2006-07-11 Thread Wendy Smoak
On 7/11/06, Greg Reddin <[EMAIL PROTECTED]> wrote: I had intended to finish out the 1.x documentation in such a way that it could be ported to 2.x but I ran out of time. The existing doc is high-level enough that it still applies to both - except the reference to TilesServlet, which only applie

Test failures...

2006-07-11 Thread Bob Lee
Anyone know what's causing this? I grepped for "com.opensymphony.xwork." and "ConfigurationProvider" but the culprit wasn't immediately clear. --- T E S T S --- java.lang.NoClassDefFoundError:

Re: Test failures...

2006-07-11 Thread Don Brown
You need to clear your local copy of xwork, most likely. Don Bob Lee wrote: Anyone know what's causing this? I grepped for "com.opensymphony.xwork." and "ConfigurationProvider" but the culprit wasn't immediately clear. --- T E S T S

Re: [maven] URIs on sub-sites

2006-07-11 Thread Wendy Smoak
On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: I don't know what I'm doing wrong, but the menu URIs on the subsites are not rendering correctly for me. For some reason, they seem to be stripping "http://struts.apache.org/"; out of all the URIs, so that a reference to "http://struts.apache.or

Re: [maven] URIs on sub-sites

2006-07-11 Thread Wendy Smoak
On 7/11/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: If the directory name on the site matches the artifactId in the pom, it works as designed. s/designed/desired. I assume it's working as designed, even if I'm not quite sure what the design is... -- Wendy -

Re: [maven] URIs on sub-sites

2006-07-11 Thread Ted Husted
On 7/11/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: It's (somehow) related to the // in the pom. It took me a few tries to get the links on the Tiles 2 site to work. If the directory name on the site matches the artifactId in the pom, it works as designed. If not, you have to add elements to f

Re: [maven] URIs on sub-sites

2006-07-11 Thread Don Brown
The web site directory already matches the artifact id, IIRC. I thought your original complaint was about how Maven dealt with the /1.x prefix. Don On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: On 7/11/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: > It's (somehow) related to the // in > the p

Re: [maven] URIs on sub-sites

2006-07-11 Thread Wendy Smoak
On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: Do we want to go with the flow and change the directory names then? If we are using "struts-scripting" on the website, it makes more sense to me to use "struts-scripting" in the repository. Changing the directory names in the svn repo isn't go

Re: [maven] URIs on sub-sites

2006-07-11 Thread Don Brown
Oh, you are talking about svn. Ignore me :) Don Don Brown wrote: The web site directory already matches the artifact id, IIRC. I thought your original complaint was about how Maven dealt with the /1.x prefix. Don On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: On 7/11/06, Wendy Smoak <[E

Re: [maven] URIs on sub-sites

2006-07-11 Thread Don Brown
I dunno: /repos/asf/struts/struts1/struts-core ... that's a lot of Struts and too much typing, IMO. The only reason the artifact id's have "struts-" in them is for the jar names. Otherwise, I'd say the group id having Struts in it would be fine. Don Wendy Smoak wrote: On 7/11/06, Ted Hust

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Michael Jouravlev
On 7/11/06, Ted Husted <[EMAIL PROTECTED]> wrote: Zipped, the 1.3.5 snapshot is 40.8mb. Zipped, the individual components come to docs.zip - 11.5mb lib.zip - 2.8mb src.zip - 5.8mb webapps - 20.5mb Do we want to offer these archives separately, in addition to the combined snapshot? In some pl

Re: [maven] URIs on sub-sites

2006-07-11 Thread Ted Husted
On 7/11/06, Don Brown <[EMAIL PROTECTED]> wrote: I dunno: /repos/asf/struts/struts1/struts-core ... that's a lot of Struts and too much typing, IMO. The only reason the artifact id's have "struts-" in them is for the jar names. Otherwise, I'd say the group id having Struts in it would be fine.

Re: [maven] URIs on sub-sites

2006-07-11 Thread Ted Husted
On 7/11/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: It's (somehow) related to the // in the pom. It took me a few tries to get the links on the Tiles 2 site to work. If the directory name on the site matches the artifactId in the pom, it works as designed. If not, you have to add elements to f

Re: [maven] URIs on sub-sites

2006-07-11 Thread Don Brown
Ted Husted wrote: I'd really prefer that we use one set of naming conventions. If it's more typing, then so be it. I've already typed a year's worth of URIs in this email message :) My suggestion is that we make it a straight-line correlation Website /s/1.x/struts1 /s/2.0/struts2 Repository /s

Re: [struts1] STATUS - Version 1.3.5

2006-07-11 Thread Paul Benedict
With the official names being? struts-docs-1.3.5.zip - 11.5mb struts-lib-1.3.5.zip - 2.8mb struts-src-1.3.5.zip - 5.8mb struts-webapps-1.3.5.zip - 20.5mb ? Michael Jouravlev <[EMAIL PROTECTED]> wrote: On 7/11/06, Ted Husted wrote: > Zipped, the 1.3.5 snapshot is 40.8mb. > > Zipped, the individu

Re: svn commit: r421117 - in /struts/struts1/trunk/core/src: main/java/org/apache/struts/action/ main/java/org/apache/struts/chain/commands/ main/java/org/apache/struts/chain/commands/generic/ main/ja

2006-07-11 Thread Wendy Smoak
On 7/11/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: wsmoak Date: Tue Jul 11 21:35:47 2006 New Revision: 421117 URL: http://svn.apache.org/viewvc?rev=421117&view=rev Log: STR-2900 Fix Checkstyle errors in struts-core. Submitted by: Frank Zammetti The large change in ActionRedirect

[s2] Getting rid of statics

2006-07-11 Thread Don Brown
The ticket is WW-1369 [1] and its goal is to make it possible do deploy two Struts 2 filter dispatchers with completely different configurations side-by-side in the same web application. As I dig down into this, it is becoming quite apparent this would be a huge change, and before I do anythin

Re: svn commit: r421151 [1/2] - in /struts/struts1/trunk/tiles/src: main/java/org/apache/struts/tiles/ main/java/org/apache/struts/tiles/actions/ main/java/org/apache/struts/tiles/beans/ main/java/org

2006-07-11 Thread Wendy Smoak
On 7/11/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: wsmoak Date: Tue Jul 11 23:07:14 2006 New Revision: 421151 URL: http://svn.apache.org/viewvc?rev=421151&view=rev Log: STR-2900 Fix Checkstyle errors in struts-tiles. Submitted by: Frank Zammetti TilesRequestProcessor, InsertTag,