[GitHub] struts pull request: WW-4540: Strict DMI

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] struts pull request: WW-4540: Strict DMI

If there be no objections I would like to merge this PR and push a new BETA today 2015-09-26 9:57 GMT+02:00 Lukasz Lenart : > 2015-09-25 16:04 GMT+02:00 Christoph Nenning : >> Well, I don't think it is necessary to check parent packages at

Re: [GitHub] struts pull request: WW-4540: Strict DMI

> > Well, I don't think it is necessary to check parent packages at all. > > Because strictDMI is a primitive boolean and cannot be null. So each > > package has it explicitly configured, inheriting it is not required. > > PackageConfig.isStrictMethodInvocation() should just return that value. >

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-28 13:11 GMT+02:00 Christoph Nenning : >> > What does the current implementation do? >> > if strictDMI is set to false it returns false. >> > if it is set to true parent packages are checked. if it is true in one >> > parent true is returned. >> > otherwise

Re: [GitHub] struts pull request: WW-4540: Strict DMI

+1 Johannes # web: http://www.jgeppert.com twitter: http://twitter.com/jogep 2015-09-28 9:50 GMT+02:00 Lukasz Lenart : > If there be no objections I would like to merge this PR and push a new > BETA today > > 2015-09-26