[GitHub] struts issue #156: WW-4834 Improve RegEx used to validate URLs

2017-08-02 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/156 Ach... you did merge it :\ But this isn't a valid RegEx :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] struts issue #157: WW-4834 fixed faulty regex

2017-08-02 Thread sdutry
Github user sdutry commented on the issue: https://github.com/apache/struts/pull/157 Ok, I will wait. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

2017-08-02 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 > With the new code in #155 the custom type converter isn't initialized at all. :( w00t! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

2017-08-02 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 Would it be possible to share an application that replicates this behaviour? Sorry for bothering you but I want to understand what's going on :) --- If your project is set up for it, you can

[GitHub] struts pull request #156: WW-4834 Improve RegEx used to validate URLs

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] struts issue #157: WW-4834 fixed faulty regex

2017-08-02 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/157 Could you wait a bit with merging this PR? I have asked somebody to take a look on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] struts pull request #157: WW-4834 fixed faulty regex

2017-08-02 Thread sdutry
GitHub user sdutry opened a pull request: https://github.com/apache/struts/pull/157 WW-4834 fixed faulty regex You can merge this pull request into a Git repository by running: $ git pull https://github.com/sdutry/struts WW-4834 Alternatively you can review and apply these

Re: Would we need to achieve better place in trends ranking?

2017-08-02 Thread Christoph Nenning
> > Are we, volunteers, allowed to help/contribute with such structural > > changes? I hope yes. If so, I have passion in `support for > > actors/asynchronous request handling`. Could you please register an > > issue with a few directive details? then we can pick and start work on > > that :) same

[GitHub] struts issue #44: WW-4520 - Add prefix for CSS classes.

2017-08-02 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/44 > I wonder how hard it will be to make this configurable Making this configurable would be cool. But when looking at changed files, and all those different file types, i fear it would be

[GitHub] struts pull request #158: WW-4835: Configurable handlers

2017-08-02 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/158 WW-4835: Configurable handlers This PR changes API a bit to allow pass current `ActionInvocation` to the REST content type handlers to allow implement different behaviour based on a current

Re: [GitHub] struts pull request #158: WW-4835: Configurable handlers

2017-08-02 Thread Lukasz Lenart
Hi, Can you take a look on this? Thanks in advance -- Ɓukasz + 48 606 323 122 http://www.lenart.org.pl/ 2017-08-02 15:02 GMT+02:00 lukaszlenart : > GitHub user lukaszlenart opened a pull request: > > https://github.com/apache/struts/pull/158 > > WW-4835:

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

2017-08-02 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 I don't see any other options now to merge this. @aleksandr-m could you prepare that example app? I will be able to investigate what's wrong with my solution ;-) --- If your project is set up

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

2017-08-02 Thread aleksandr-m
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 Sure. No problem. Test project - https://github.com/aleksandr-m/struts2-objectfactory-container/ This commit adds custom date converter -