Modification to speed up s:text from StrutsLocalizedTextProvider

2020-09-14 Thread Greg Huber
I have a local modification that I do to speed up my app on how I get screen text ie via com.opensymphony.xwork2.util.StrutsLocalizedTextProvider. By default StrutsLocalizedTextProvider will scan the class packages first for the message and then if it cannot find it try ApplicationResources.

[GitHub] [struts] yasserzamani opened a new pull request #438: WW-5087 handle Parameter.Empty properly

2020-09-14 Thread GitBox
yasserzamani opened a new pull request #438: URL: https://github.com/apache/struts/pull/438 There was a bug with AliasInterceptor not handling the Parameter.Empty that is returned from HttpParameters.get(). Since HttpParameters.get() always returns a non-null value, the Evaluated object is

Re: Modification to speed up s:text from StrutsLocalizedTextProvider

2020-09-14 Thread Lukasz Lenart
pon., 14 wrz 2020 o 10:43 Greg Huber napisał(a): > > I have a local modification that I do to speed up my app on how I get > screen text ie via > com.opensymphony.xwork2.util.StrutsLocalizedTextProvider. > > By default StrutsLocalizedTextProvider will scan the class packages > first for the messa

[GitHub] [struts] lukaszlenart merged pull request #438: WW-5087 handle Parameter.Empty properly

2020-09-14 Thread GitBox
lukaszlenart merged pull request #438: URL: https://github.com/apache/struts/pull/438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: Modification to speed up s:text from StrutsLocalizedTextProvider

2020-09-14 Thread Yasser Zamani
Maybe this functionality was needed to allow user to override higher layers defined values (?) Or maybe another user for any reason claim that current behavior is wanted. So generally I think we can have a Map as a cache, if not found in cache then searching and if found after search, saving in ca

Re: Modification to speed up s:text from StrutsLocalizedTextProvider

2020-09-14 Thread Lukasz Lenart
wt., 15 wrz 2020 o 07:49 Yasser Zamani napisał(a): > So generally I think we can have a Map as a cache, if not found in cache > then searching and if found after search, saving in cache. I've seen > this mechanism in Struts in other places as well. This is already done, results of the scan are al

Re: Modification to speed up s:text from StrutsLocalizedTextProvider

2020-09-14 Thread Yasser Zamani
Hi Lukasz :) Excuse me... do you remember the place where caching occurs please? I found some references of StrutsLocalizedTextProvider.getText and followed up their parents. Also saw TextProviderSupport.java. I couldn't find any cache for founded text :( Maybe because it's dependent to current va