[GitHub] [struts] yasserzamani merged pull request #573: [WW-5173] - Attempt to fix DI behaviour for custom cache factories

2022-08-21 Thread GitBox
yasserzamani merged PR #573: URL: https://github.com/apache/struts/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@struts.apach

[GitHub] [struts-examples] lukaszlenart commented on pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
lukaszlenart commented on PR #164: URL: https://github.com/apache/struts-examples/pull/164#issuecomment-1221513702 Nice :) LGTM 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [struts-examples] lukaszlenart merged pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
lukaszlenart merged PR #164: URL: https://github.com/apache/struts-examples/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@str

[GitHub] [struts-examples] yasserzamani commented on a diff in pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
yasserzamani commented on code in PR #164: URL: https://github.com/apache/struts-examples/pull/164#discussion_r950819926 ## jasperreports/pom.xml: ## @@ -0,0 +1,87 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [struts-examples] lukaszlenart commented on a diff in pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
lukaszlenart commented on code in PR #164: URL: https://github.com/apache/struts-examples/pull/164#discussion_r950820154 ## jasperreports/pom.xml: ## @@ -0,0 +1,87 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [struts-examples] fp024 commented on a diff in pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
fp024 commented on code in PR #164: URL: https://github.com/apache/struts-examples/pull/164#discussion_r950825337 ## jasperreports/pom.xml: ## @@ -0,0 +1,87 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:s

[GitHub] [struts-examples] yasserzamani commented on a diff in pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
yasserzamani commented on code in PR #164: URL: https://github.com/apache/struts-examples/pull/164#discussion_r950833728 ## jasperreports/pom.xml: ## @@ -0,0 +1,87 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [struts-examples] fp024 commented on a diff in pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
fp024 commented on code in PR #164: URL: https://github.com/apache/struts-examples/pull/164#discussion_r950865890 ## jasperreports/pom.xml: ## @@ -0,0 +1,87 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:s

[GitHub] [struts-examples] fp024 commented on a diff in pull request #164: Add JasperReports tutorial example

2022-08-21 Thread GitBox
fp024 commented on code in PR #164: URL: https://github.com/apache/struts-examples/pull/164#discussion_r950865890 ## jasperreports/pom.xml: ## @@ -0,0 +1,87 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:s

[GitHub] [struts-examples] fp024 opened a new pull request, #165: Remove spring-framework-bom dependency from jasperreports example

2022-08-21 Thread GitBox
fp024 opened a new pull request, #165: URL: https://github.com/apache/struts-examples/pull/165 Hello I removed the bom declaration as it was unnecessary. It seems better to use the version set by the Struts 2 Spring plugin. Please review. thank you -- This is an

[GitHub] [struts-examples] dependabot[bot] opened a new pull request, #166: Bump spring-framework-bom from 5.3.20 to 5.3.22

2022-08-21 Thread GitBox
dependabot[bot] opened a new pull request, #166: URL: https://github.com/apache/struts-examples/pull/166 Bumps [spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.20 to 5.3.22. Release notes Sourced from https://github.com/spring-projects/spring-fr

[GitHub] [struts-examples] dependabot[bot] opened a new pull request, #167: Bump dependency-check-maven from 7.1.1 to 7.1.2

2022-08-21 Thread GitBox
dependabot[bot] opened a new pull request, #167: URL: https://github.com/apache/struts-examples/pull/167 Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 7.1.1 to 7.1.2. Release notes Sourced from https://github.com/jeremylong/DependencyCheck/rele

[GitHub] [struts-examples] dependabot[bot] opened a new pull request, #168: Bump slf4j-simple from 1.7.36 to 2.0.0

2022-08-21 Thread GitBox
dependabot[bot] opened a new pull request, #168: URL: https://github.com/apache/struts-examples/pull/168 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.0. Commits https://github.com/qos-ch/slf4j/commit/0614d467d7bca81724f45e228f4f871161222b51";>0614d46

[GitHub] [struts-examples] lukaszlenart merged pull request #166: Bump spring-framework-bom from 5.3.20 to 5.3.22

2022-08-21 Thread GitBox
lukaszlenart merged PR #166: URL: https://github.com/apache/struts-examples/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@str

[GitHub] [struts-examples] lukaszlenart merged pull request #167: Bump dependency-check-maven from 7.1.1 to 7.1.2

2022-08-21 Thread GitBox
lukaszlenart merged PR #167: URL: https://github.com/apache/struts-examples/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@str

[GitHub] [struts-examples] lukaszlenart merged pull request #168: Bump slf4j-simple from 1.7.36 to 2.0.0

2022-08-21 Thread GitBox
lukaszlenart merged PR #168: URL: https://github.com/apache/struts-examples/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@str

[GitHub] [struts-site] lukaszlenart merged pull request #168: Linkifies FAQ refs from struts tags page

2022-08-21 Thread GitBox
lukaszlenart merged PR #168: URL: https://github.com/apache/struts-site/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@struts.

[GitHub] [struts-examples] lukaszlenart merged pull request #165: Remove spring-framework-bom dependency from jasperreports example

2022-08-21 Thread GitBox
lukaszlenart merged PR #165: URL: https://github.com/apache/struts-examples/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@str