[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-02-16 Thread wolpi
Github user wolpi commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-74502592 could you add a unit test, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] struts pull request: Improve LocalizedTextUtil.getMessage() defend...

2015-09-22 Thread wolpi
Github user wolpi commented on the pull request: https://github.com/apache/struts/pull/50#issuecomment-142278975 Usually it is not supported to use struts2 utility classes outside of struts context. I would rather not merge this as it increases maintanance burden. That it

[GitHub] struts pull request: Improve LocalizedTextUtil.getMessage() defend...

2015-09-22 Thread wolpi
Github user wolpi commented on the pull request: https://github.com/apache/struts/pull/50#issuecomment-142507218 > It make struts more robust. When LocalizedTextUtil is used as intended and supported it is already robust :wink: > It doesn'

[GitHub] struts pull request: Make it easier to extend to use own ActionInv...

2015-10-09 Thread wolpi
Github user wolpi commented on the pull request: https://github.com/apache/struts/pull/54#issuecomment-146840650 Please create a JIRA issue. That makes it easier to track changes and contributions. https://issues.apache.org/jira/browse/WW --- If your project is set up for

[GitHub] struts issue #128: WW-4578: Multidimensional validation

2017-04-18 Thread wolpi
Github user wolpi commented on the issue: https://github.com/apache/struts/pull/128 +1 for merging 😆 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so