Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/158
sounds great ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/158
and what is your idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/158
Do you want to further develop this PR or merge it first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/158
Using `AbstractContentTypeHandler` to implement deprecated methods to log
on WARN seems like a good idea.
I don't see where new parameter `ActionInvocation` is actually used. Is
that yet
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/44
> I wonder how hard it will be to make this configurable
Making this configurable would be cool. But when looking at changed files,
and all those different file types, i fear it wo
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/142
IMO this can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/138
ð for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/138
> can you elaborate a bit more about parsing dates? I thought this is
already supported.
Now that you mention it, I see there is a locale aware `DateConverter`.
Cannot remember why
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/138
In our apps we have often demand for locale aware values. But more often we
need dates, not doubles. Mostly we do this by calling java methods in JSPs. But
having converts which do this out
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/130
If patterns change users have another reason to upgrade to latest struts
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/130
How often do credit card companies change their number-patterns in a way
that the regex needs to be updated? 'guess it is rare enough.
---
If your project is set up for it, you can reply
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/131
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/130
I hope the regex is stable ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/128
IMO these 4 could be considered, too:
- `DoubleRangeFieldValidator`
- `URLValidator`
- `RequiredStringValidator`
- `StringLengthFieldValidator`
---
If your project is set up
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/125
Sounds like a very good idea! A short check showed that my apps are not
affected ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/124
> Should I ask legal [1] about that? What do you think?
That's the class that has been copied from spring. Yes, I think it's better
to ask how to handle this.
---
If your project is
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/120
Besides the failing test this looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/114
Looks good to me ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/113
:+1:
That means #97 can be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/108
> How would this be fixed now?
I fixed it already just by running `git cherry-pick`. (there is a jira
comment about it)
I feared that monstrous issue
([WW-4628](ht
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/98
> I think we should move portlet-app away from Struts into Struts Examples
Oh, yes! We really should!
---
If your project is set up for it, you can reply to this email and have your
re
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/99
Please create a jira ticket, too. We usually document all changes in jira
to generate change logs.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/99
> Ideally, line 224 would use the globalAllowedMethods set from the
PackageConfig instead of a hard coded list but there is currently no associated
getter method and I figured it would be bet
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221490265
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/85#issuecomment-179082240
Alright, thanks for reviewing. I agree with your findings and pushed
updates.
I'm going to merge it later.
---
If your project is set up for it, you can reply
Github user cnenning commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r50693282
--- Diff:
plugins/tiles/src/test/java/org/apache/struts2/tiles/TestStrutsTilesAnnotationProcessor.java
---
@@ -0,0 +1,148 @@
+package org.apache.struts2
GitHub user cnenning opened a pull request:
https://github.com/apache/struts/pull/85
WW-4594: Configure TilesDefs by annotating Actions
Adds annotations for each element from `tiles.xml` to annotate actions.
Those annotations are processed by a new class in tiles-plugin which
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/72#issuecomment-172772942
> Merged #72.
Yay, I got it landed :)
This Email was scanned by Sophos Anti Virus
---
If your project is set up for it, you can re
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-172460318
> Simplifies logging
Still not final :wink: ?
Let's merge it!
---
If your project is set up for it, you can reply to this email and have your
re
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171968504
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cnenning commented on a diff in the pull request:
https://github.com/apache/struts/pull/72#discussion_r49698088
--- Diff:
plugins/json/src/main/java/org/apache/struts2/json/JSONValidationInterceptor.java
---
@@ -72,8 +74,8 @@
private static final Logger
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171662399
> I have resolved the problem with missing definitions but I'm a bit
confused how Tiles resolves
> resources - 66d29d4 - basically all the definitions are
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/72#issuecomment-170908683
> Why static?
There was no reason. In the app where that result was originaly implemented
there was some other class calling that methods. I chan
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-170932000
:+1:
Looks great!
There is one thing: when I try to run showcase app I get exceptions when
trying to access tiles examples
GitHub user cnenning opened a pull request:
https://github.com/apache/struts/pull/72
New result 'JSONActionRedirectResult' in json-plugin
Adds new result 'JSONActionRedirectResult' to json-plugin. Contains tests
and example in showcase app. The new result type is intended
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/60#issuecomment-169613075
I would say we merge this and may fix the "EL not working in
freemarker-insert with freemarker-template" issue in master.
---
If your project is set up for i
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/60#issuecomment-168964296
> https://github.com/lukaszlenart/struts2-tiles-demo
I created a PR for that demo app which demonstrates the issue.
See https://github.com/lukaszlen
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/60#issuecomment-166308691
The new version looks awesome!
Just a small addon to constructor of
`StrutsWildcardServletTilesApplicationContext`, that re-enables loading of
`tiles*.xml
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/60#issuecomment-160655820
For struts 2.3 I still got an old app with tiles2 which does some custom
stuff and which has issues with these changes.
* `tiles-servlet-wildcard` depends
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/59#issuecomment-160149460
I hope that code can be shared between both tiles plugins. What do you
think of creating a strust-tiles-commons.jar or somthing the like?
---
If your project is set up
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/59#issuecomment-160158437
yay, it runs ! :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
41 matches
Mail list logo
