[GitHub] struts issue #158: WW-4835: Configurable handlers
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/158 sounds great ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #158: WW-4835: Configurable handlers
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/158 and what is your idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #158: WW-4835: Configurable handlers
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/158 Do you want to further develop this PR or merge it first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #158: WW-4835: Configurable handlers
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/158 Using `AbstractContentTypeHandler` to implement deprecated methods to log on WARN seems like a good idea. I don't see where new parameter `ActionInvocation` is actually used. Is that yet to come? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #44: WW-4520 - Add prefix for CSS classes.
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/44 > I wonder how hard it will be to make this configurable Making this configurable would be cool. But when looking at changed files, and all those different file types, i fear it would be hard. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #142: WW-4805 Blocks ognl access to class members of Spring pro...
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/142 IMO this can be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #138: WW-3171 WW-3650 WW-4581: Locale aware converters
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/138 ð for merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #138: WW-3171 WW-3650 WW-4581: Locale aware converters
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/138 > can you elaborate a bit more about parsing dates? I thought this is already supported. Now that you mention it, I see there is a locale aware `DateConverter`. Cannot remember why we rolled our own. Might be it was not using the format (`SHORT, MEDIUM, LONG`) we wanted. wdyt about making that configurable? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #138: WW-3171 WW-3650 WW-4581: Locale aware converters
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/138 In our apps we have often demand for locale aware values. But more often we need dates, not doubles. Mostly we do this by calling java methods in JSPs. But having converts which do this out of the box would be great. > Will this break apps with locales which are using different decimal separator? Yes, for some apps that would be a breaking change. But IMHO most apps use number formats which their users expect (-> locale aware number format). So for most it would be an improvement and they could remove custom code. But still, some apps might be broken. I always find it hard to get java `NumberFormat` and `ParsePositon` right. Not sure if there are subtle bugs in this PR. But there are lots of tests so hopefully all corner cases are covered ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #130: WW-3952: Credit card validator
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 If patterns change users have another reason to upgrade to latest struts ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #130: WW-3952: Credit card validator
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 How often do credit card companies change their number-patterns in a way that the regex needs to be updated? 'guess it is rare enough. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #131: WW-4210: Type conversion class
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/131 ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #130: WW-3952: Credit card validator
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 I hope the regex is stable ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #128: WW-4578: Multidimensional validation
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/128 IMO these 4 could be considered, too: - `DoubleRangeFieldValidator` - `URLValidator` - `RequiredStringValidator` - `StringLengthFieldValidator` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #125: Immutable context
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/125 Sounds like a very good idea! A short check showed that my apps are not affected ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/124 > Should I ask legal [1] about that? What do you think? That's the class that has been copied from spring. Yes, I think it's better to ask how to handle this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #120: WW-4753: Injectable context
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/120 Besides the failing test this looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #114: Virtual file representation
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/114 Looks good to me ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #113: WW-4636 - File upload error message always in default lan...
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/113 :+1: That means #97 can be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/108 > How would this be fixed now? I fixed it already just by running `git cherry-pick`. (there is a jira comment about it) I feared that monstrous issue ([WW-4628](https://issues.apache.org/jira/browse/WW-4628)) would get another round of discussion and was relieved that it was just an accident :wink: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/98 > I think we should move portlet-app away from Struts into Struts Examples Oh, yes! We really should! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #99: add allowed methods to handleUnknownAction
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/99 Please create a jira ticket, too. We usually document all changes in jira to generate change logs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #99: add allowed methods to handleUnknownAction
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/99 > Ideally, line 224 would use the globalAllowedMethods set from the PackageConfig instead of a hard coded list but there is currently no associated getter method and I figured it would be better to discuss adding that functionality via the PR. IMHO a getter `getGlobalAllowedMethods()` can just be added to `PackageConfig`. @lukaszlenart Do you see reasons not to add the getter? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221490265 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/85#issuecomment-179082240 Alright, thanks for reviewing. I agree with your findings and pushed updates. I'm going to merge it later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...
Github user cnenning commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r50693282
--- Diff:
plugins/tiles/src/test/java/org/apache/struts2/tiles/TestStrutsTilesAnnotationProcessor.java
---
@@ -0,0 +1,148 @@
+package org.apache.struts2.tiles;
+
+import java.util.List;
+import java.util.Set;
+
+import org.apache.struts2.tiles.annotation.TilesDefinition;
+import org.apache.tiles.Attribute;
+import org.apache.tiles.Definition;
+import org.apache.tiles.Expression;
+import org.junit.Test;
+
+import org.junit.Assert;
+
+public class TestStrutsTilesAnnotationProcessor {
--- End diff --
oh, of course :sweat_smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...
GitHub user cnenning opened a pull request: https://github.com/apache/struts/pull/85 WW-4594: Configure TilesDefs by annotating Actions Adds annotations for each element from `tiles.xml` to annotate actions. Those annotations are processed by a new class in tiles-plugin which is used by TilesResult. With those annotations it is possible to keep `tiles.xml` very short (e.g. just put layout in there) and configure concrete tiles-definitions just by annotating actions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cnenning/struts master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit d9f4054b1367cd7ab6e3f22b9cc677f62def4e83 Author: cnenning <cnenn...@apache.org> Date: 2016-01-22T13:59:48Z fixed tiles showcase by setting dtd to 3.0 commit 9ac326aa2458fe43140c1b13b61c87752d282e3d Author: cnenning <cnenn...@apache.org> Date: 2016-01-22T14:27:09Z Added tiles annotations, see WW-4594. Added tiles annotations, created StrutsTilesAnnotationProcessor to create Definitons from them and using it in TilesResult. commit e50c37c5ba5781900edf53f9ec71b8649471d448 Author: cnenning <cnenn...@apache.org> Date: 2016-01-22T14:27:50Z added sample for tiles annotations commit d76357fd829a3ea8ddca21d625c49b606cca88d5 Author: cnenning <cnenn...@apache.org> Date: 2016-01-25T10:23:10Z added tests for StrutsTilesAnnotationProcessor commit a53deac7ce8732053edd43dddac329448055aef0 Author: cnenning <cnenn...@apache.org> Date: 2016-01-25T12:39:47Z updated javadoc commit b1588ddc84d876a676bab66ad80ec34637e98536 Author: cnenning <cnenn...@apache.org> Date: 2016-01-25T12:50:45Z fixed line endings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: New result 'JSONActionRedirectResult' in json...
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/72#issuecomment-172772942 > Merged #72. Yay, I got it landed :) This Email was scanned by Sophos Anti Virus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4584: Upgrade tiles plugin
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-172460318 > Simplifies logging Still not final :wink: ? Let's merge it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4584: Upgrade tiles plugin
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171968504 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: New result 'JSONActionRedirectResult' in json...
Github user cnenning commented on a diff in the pull request: https://github.com/apache/struts/pull/72#discussion_r49698088 --- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONValidationInterceptor.java --- @@ -72,8 +74,8 @@ private static final Logger LOG = LogManager.getLogger(JSONValidationInterceptor.class); -private static final String VALIDATE_ONLY_PARAM = "struts.validateOnly"; -private static final String VALIDATE_JSON_PARAM = "struts.enableJSONValidation"; +static final String VALIDATE_ONLY_PARAM = "struts.validateOnly"; +static final String VALIDATE_JSON_PARAM = "struts.enableJSONValidation"; --- End diff -- oh yes, that they are private was a pain as I started this new result in an app project :laughing: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4584: Upgrade tiles plugin
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171662399 > I have resolved the problem with missing definitions but I'm a bit confused how Tiles resolves > resources - 66d29d4 - basically all the definitions are loaded on startup but then are loaded again. In my experiments the tiles.xml was only loaded one time, at first request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: New result 'JSONActionRedirectResult' in json...
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/72#issuecomment-170908683 > Why static? There was no reason. In the app where that result was originaly implemented there was some other class calling that methods. I changed it. > Problem with indent? I re-formatted javadoc. Or were you refering to something else? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4584: Upgrade tiles plugin
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-170932000 :+1: Looks great! There is one thing: when I try to run showcase app I get exceptions when trying to access tiles examples: `org.apache.tiles.definition.NoSuchDefinitionException: Cannot find definition named 'showcase.index'` The definition is defined in `showcase/src/main/webapp/WEB-INF/tiles.xml`. When I try to copy that file to different locations (like `webapp/` or `src/main/resources/`) the error remains. IMO that can be solved in `master`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: New result 'JSONActionRedirectResult' in json...
GitHub user cnenning opened a pull request: https://github.com/apache/struts/pull/72 New result 'JSONActionRedirectResult' in json-plugin Adds new result 'JSONActionRedirectResult' to json-plugin. Contains tests and example in showcase app. The new result type is intended to be used along with existing JSONValidationInterceptor. It makes it possible to do form validation via ajax and handle form submitting, action execution and redirect evaluation all in one request inside JS context. The sample Action is called `AjaxFormSubmitAction`. That example is by far longer that the change to json-plugin itself (not just that action class but other files that it requires). Here is an excerpt of it's javadoc, that shows what can be done with the new result: * Depends on `json-plugin`. * Requires `jsonValidationInterceptor` to be on stack. * Uses a special json redirect result type. * Uses http parameters `struts.enableJSONValidation=true` and `struts.validateOnly=false`. * Uses a customized theme to make sure html elements required as error containers are always present and easily selectable in JS. * Uses some custom JS code depending on jQuery to issue AJAX request and to render errors in html. * Shows visual feedback while waiting for AJAX response. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cnenning/struts ajax-form Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit cb11898416949c4028d99651e9697671797f1b99 Author: cnenning <cnenn...@apache.org> Date: 2016-01-11T13:36:32Z Adds new result 'JSONActionRedirectResult' to json-plugin. Contains tests and example in showcase app. The new result type is intended to be used along with existing JSONValidationInterceptor. It makes it possible to do form validation via ajax and handle form submitting, action execution and redirect evaluation all in one request inside JS context. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Struts 2.3.x: Tiles plugin upgrade
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/60#issuecomment-169613075 I would say we merge this and may fix the "EL not working in freemarker-insert with freemarker-template" issue in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Struts 2.3.x: Tiles plugin upgrade
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/60#issuecomment-168964296 > https://github.com/lukaszlenart/struts2-tiles-demo I created a PR for that demo app which demonstrates the issue. See https://github.com/lukaszlenart/struts2-tiles-demo/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Struts 2.3.x: Tiles plugin upgrade
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/60#issuecomment-166308691
The new version looks awesome!
Just a small addon to constructor of
`StrutsWildcardServletTilesApplicationContext`, that re-enables loading of
`tiles*.xml` from classpath and works in IBM stuff, too:
```
Enumeration cpResources =
getClass().getClassLoader().getResources("/");
while (cpResources.hasMoreElements()) {
URL cpResource = cpResources.nextElement();
urls.add(cpResource);
}
```
Regarding the other issues:
* css looks alright again in FF, seems like it was a FF bug
* About EL stuff: I'm pretty helpless and pretty confused. That log message
is created in `freemarker.ext.jsp.TaglibFactory`. It looks for a `BeansWrapper`
which struts creates in `FreemarkerManager.createObjectWrapper()`. When
tiles-layout is created with a JSP, and just tiles-attributes are done with
FTLs everything seems OK. But when tiles-layout is done with FTL that message
is logged and EL support seems broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Struts 2.3.x: Tiles plugin upgrade
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/60#issuecomment-160655820
For struts 2.3 I still got an old app with tiles2 which does some custom
stuff and which has issues with these changes.
* `tiles-servlet-wildcard` depends on `spring-web`. That causes spring to
be pulled in to all apps that use `struts-tiles-pluign`. Due to this I would
prefer wildcard support could be optional
* in `TilesContainerFactory.createContainerFactory()` it is necessary for
me to register `tilesContainer` in `servletContext`. Can be done like this,
would you mind adding this to `StrutsTilesContainerFactory`?
```
@Override
protected BasicTilesContainer instantiateContainer(TilesApplicationContext
applicationContext) {
CachingTilesContainer tilesContainer = new CachingTilesContainer();
ServletContext servletContext = (ServletContext)
applicationContext.getContext();
ServletUtil.setContainer(servletContext, tilesContainer);
return tilesContainer;
}
```
* in `StrutsTilesContainerFactory.getSourceURLs()` these two resource
patterns are used: `/WEB-INF/**/tiles*.xml` and
`classpath*:META-INF/**/tiles*.xml`. The 2nd one causes an exception in
WebSphere with IBM JDK. Would be nice if we could make this configurable. The
exception is `Caused by: java.net.MalformedURLException: SRVE0238E: Resource
paths should have a leading slash`
Currently I have created my own `TilesListener`, `TilesInitializer` and
`TilesContainerFactory`. With the above changes I could avoid that and just
stick to `StrutsTilesListener`.
Two minor things I noticed in showcase app:
* It logs this message: `WARN (freemarker.jsp:75) - Custom EL functions
won't be loaded because no ObjectWarpper was specified .` So it may be that
`tiles-el` along with `tiles-freemarker` are not working?
* css layout seems to be broken in firefox (surely not related to this PR,
looks good in chrome and ie11, is fixed in master branch)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Upgrade tiles plugin
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160149460 I hope that code can be shared between both tiles plugins. What do you think of creating a strust-tiles-commons.jar or somthing the like? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Upgrade tiles plugin
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160158437 yay, it runs ! :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
