[GitHub] [submarine] tangzhankun commented on a change in pull request #130: SUBMARINE-321. Add JobManager and SubmitterManager components

2019-12-17 Thread GitBox
tangzhankun commented on a change in pull request #130: SUBMARINE-321. Add JobManager and SubmitterManager components URL: https://github.com/apache/submarine/pull/130#discussion_r359117029 ## File path:

[GitHub] [submarine] tangzhankun commented on issue #130: SUBMARINE-321. Add JobManager and SubmitterManager components

2019-12-17 Thread GitBox
tangzhankun commented on issue #130: SUBMARINE-321. Add JobManager and SubmitterManager components URL: https://github.com/apache/submarine/pull/130#issuecomment-566830915 Thanks a lot! Wanqiang! The patch looks good to me. Do we need to add simple test cases? Or we can add in

[jira] [Commented] (SUBMARINE-302) Split the submitter-yarnservice from travis into job

2019-12-17 Thread Wanqiang Ji (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998278#comment-16998278 ] Wanqiang Ji commented on SUBMARINE-302: --- I had update the new PR, if no more comments, I think

[GitHub] [submarine] jiwq commented on a change in pull request #108: SUBMARINE-302. Split the submitter-yarnservice from travis into job

2019-12-17 Thread GitBox
jiwq commented on a change in pull request #108: SUBMARINE-302. Split the submitter-yarnservice from travis into job URL: https://github.com/apache/submarine/pull/108#discussion_r358795057 ## File path: .travis.yml ## @@ -167,6 +154,18 @@ matrix: dist: xenial