Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread Ben Reser
On Mon, Apr 1, 2013 at 10:34 AM, Ben Reser wrote: > On Mon, Apr 1, 2013 at 9:27 AM, Julian Foad > wrote: >> First we need to clarify what "@a path (a file,)" means. From the >> discussion below I gather "a file" means an absolute local filesystem path, >> so let's say so. > > Yes absolute OS

Re: [svnbench] Revision: 1463069 compiled Apr 1 2013, 00:22:00 on x86_64-unknown-linux-gnu

2013-04-01 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Apr 02, 2013 at 02:42:52 +0300: > Neels Hofmeyr wrote on Tue, Apr 02, 2013 at 01:29:09 +0200: > > Somewhere between r1454789 and r1457253 on trunk, that's three to > > four weeks ago, 'commit', 'copy' and 'merge' got dramatically faster: as > > much as 80%, and more! Ama

Re: [svnbench] Revision: 1463069 compiled Apr 1 2013, 00:22:00 on x86_64-unknown-linux-gnu

2013-04-01 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Apr 02, 2013 at 02:42:52 +0300: > Neels Hofmeyr wrote on Tue, Apr 02, 2013 at 01:29:09 +0200: > > Somewhere between r1454789 and r1457253 on trunk, that's three to > > four weeks ago, 'commit', 'copy' and 'merge' got dramatically faster: as > > much as 80%, and more! Ama

Re: [svnbench] Revision: 1463069 compiled Apr 1 2013, 00:22:00 on x86_64-unknown-linux-gnu

2013-04-01 Thread Daniel Shahaf
Neels Hofmeyr wrote on Tue, Apr 02, 2013 at 01:29:09 +0200: > Somewhere between r1454789 and r1457253 on trunk, that's three to > four weeks ago, 'commit', 'copy' and 'merge' got dramatically faster: as > much as 80%, and more! Amazing. Ahem, you should probably correlate that with whenever our VM

Re: [PATCH] run_test.py appearance changes

2013-04-01 Thread Daniel Shahaf
Gabriela Gibson wrote on Mon, Apr 01, 2013 at 22:36:57 +0100: > [[[ > > Disable ANSI color for dumb terminals, fix logic bug where > dimensions of (0,0) was treated as a positive result, > re-factored _run_tests to remove repeated calculation of > line_length. > > * build/run_tests.py > (_get_ter

Re: [svnbench] Revision: 1463069 compiled Apr 1 2013, 00:22:00 on x86_64-unknown-linux-gnu

2013-04-01 Thread Neels Hofmeyr
On Mon, 01 Apr 2013 00:44:12 + ne...@apache.org wrote: > 1.7.0@1181106 vs. trunk@1462907 > Started at Mon Apr 1 00:26:11 UTC 2013 > > *DISCLAIMER* - This tests only file://-URL access on a GNU/Linux VM. > This is intended to measure changes in performance of the local > working copy layer, *o

[PATCH] Adding tests for some functions in svn_checksum.h in SWIG bindings for python

2013-04-01 Thread Shivani Poddar
Log: [[[ Followup to r1420334: Adding new tests. * subversiom/bindings/swig/python/tests/checksum.py Writing new tests to ensure robustness of svn_checksum_match(), svn_checksum_dup() and svn_checksum_empty_checksum(). Patch by: Shivani Poddar ]]] Regards, Shivani Poddar, irc-nick - Pods

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread Blair Zajac
On 4/1/13 10:25 AM, C. Michael Pilato wrote: On 03/31/2013 12:31 AM, Blair Zajac wrote: Question on svn_repos_load_fs4() and svn_repos_get_fs_build_parser4() (maybe other functions have a similar text): * @note If @a start_rev and @a end_rev are valid revisions, this * function presumes the

Re: [PATCH] run_test.py appearance changes

2013-04-01 Thread Gabriela Gibson
On 01/04/13 01:31, Daniel Shahaf wrote: I reworked hunk 2 because I found a bug. The actual problem I saw was caused because the script didn't handle the case where the terminal dimension returns as (0,0). I've fixed this in the new patch, and cleaned up inefficient code. > I did note, though

Re: 1.6.21 up for testing/signing

2013-04-01 Thread C. Michael Pilato
On 03/28/2013 11:27 PM, Ben Reser wrote: > The 1.6.21 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion Summary: +1 to release. Platform: Linux 3.2.0-39-generic-pae Ubuntu 12.04.2 (precise) Linu

Re: Fold the merge_automatic API into the existing merge_peg API

2013-04-01 Thread Julian Foad
Branko Čibej wrote: > On 28.03.2013 22:07, Julian Foad wrote: >> Branko Čibej wrote: >>> On 28.03.2013 21:38, Julian Foad wrote: I like the focused API, but I also see how the automatic merge can be considered to fill in a bit of missing functionality that merge_peg ought to p

Re: svn commit: r1462828 - in /subversion/trunk/subversion/include: svn_fs.h svn_ra_svn.h

2013-04-01 Thread Stefan Fuhrmann
On Mon, Apr 1, 2013 at 7:22 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: zaterdag 30 maart 2013 19:07 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1462828 - in /subversion/trunk/subversion/include:

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread Ben Reser
On Mon, Apr 1, 2013 at 9:27 AM, Julian Foad wrote: > First we need to clarify what "@a path (a file,)" means. From the discussion > below I gather "a file" means an absolute local filesystem path, so let's say > so. Yes absolute OS filesystem path. I prefer saying OS filesystem path because it

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread C. Michael Pilato
On 03/31/2013 12:31 AM, Blair Zajac wrote: > Question on svn_repos_load_fs4() and svn_repos_get_fs_build_parser4() (maybe > other functions have a similar text): > > * @note If @a start_rev and @a end_rev are valid revisions, this > * function presumes the revisions as numbered in @a dumpstream

RE: svn commit: r1462828 - in /subversion/trunk/subversion/include: svn_fs.h svn_ra_svn.h

2013-04-01 Thread Bert Huijben
> -Original Message- > From: stef...@apache.org [mailto:stef...@apache.org] > Sent: zaterdag 30 maart 2013 19:07 > To: comm...@subversion.apache.org > Subject: svn commit: r1462828 - in /subversion/trunk/subversion/include: > svn_fs.h svn_ra_svn.h > > Author: stefan2 > Date: Sat Mar 30 1

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread Julian Foad
Here's the current doc string of svn_repos_authz_read2(): /**  * Read authz configuration data from @a path (a file, repos relative  * url, an absolute file url, or a registry path) into @a *authz_p,  * allocated in @a pool.  *  * If @a groups_path (a file, repos relative url, an absolute file ur

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread Ben Reser
On Sun, Mar 31, 2013 at 5:58 AM, Daniel Shahaf wrote: > How about forbidding PATH to be a repos-relative URL, but permitting it > to be a relpath, that is then interpreted relative to the repos root. > The conversion is trivial, just +2 on the argument, but it avoids > "non-canonical" and "^/ URLs

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread C. Michael Pilato
On 04/01/2013 11:25 AM, C. Michael Pilato wrote: > On 03/31/2013 12:31 AM, Blair Zajac wrote: >> Question on svn_repos_load_fs4() and svn_repos_get_fs_build_parser4() (maybe >> other functions have a similar text): >> >> * @note If @a start_rev and @a end_rev are valid revisions, this >> * functi

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread C. Michael Pilato
On 03/31/2013 12:31 AM, Blair Zajac wrote: > On 03/29/2013 01:17 PM, C. Michael Pilato wrote: >> Devs, >> >> I've just completed my review of the new-in-1.8 public APIs, minus the bits >> that Philip reviewed (thanks!) and the new merge-related stuff which, if I >> understand from recent threads co

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread C. Michael Pilato
On 03/30/2013 02:26 PM, Stefan Fuhrmann wrote: > r1462828 addresses the issues listed for svn_fs.h and svn_ra_svn.h. > Please review. The zero-copy-limit stuff looks good. I don't quite understand the bit about svn_fs_verify() possibly ignoring the 'start' and 'end' parameters altogether. From c

Re: 1.6.21 up for testing/signing

2013-04-01 Thread Johan Corveleyn
On Fri, Mar 29, 2013 at 4:27 AM, Ben Reser wrote: > The 1.6.21 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on April > 4th so please try and g

Re: [PATCH] Make conflict message translatable

2013-04-01 Thread Mattias Engdegård
29 mar 2013 kl. 03.03 skrev Julian Foad: Mattias Engdegård wrote: The patch assumes that svn_node_none, svn_node_unknown or svn_wc_operation_none cannot occur here. Please confirm or refute. I haven't checked whether these can occur in this message. svn_node_unknown can certainly occur