Re: svn+ssh long-lived daemon

2015-11-20 Thread Philip Martin
Ivan Zhakov writes: > 5. HTTPS authentication using client certificates Client certificates are a possibility. There are some drawbacks: the signing authority has to be maintained, revoking a certificate is more complicated than removing a key from the authorized_keys file. -- Philip Mar

Re: svn+ssh long-lived daemon

2015-11-20 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Thu, Nov 19, 2015 at 18:22:29 +: >> Are there alternative ways to get a long-lived daemon to do >> authentication with public/private key pairs? > > 1. Plain old ssh port forwarding: > > server# svnserve -d >

svn+ssh long-lived daemon

2015-11-19 Thread Philip Martin
ation with public/private key pairs? Can svn:// with SASL do it? It might be possible to extend SASL, but I think this would involve client and server changes. -- Philip Martin WANdisco

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-17 Thread Philip Martin
em: allowing incompatible components. I originally installed ruby-minitest for your first patch. I'm happy to commit this, it's r1714790. -- Philip Martin WANdisco

Re: [PATCH] Fix modification of nil value in Ruby test suite

2015-11-17 Thread Philip Martin
at works when I try it but I'm not familar with Ruby. I know Ruby has GC but what controls the lifetime of the io object and how long does it need to persist? -- Philip Martin WANdisco

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-17 Thread Philip Martin
Philip Martin writes: > James McCoy writes: > >> On Mon, Nov 09, 2015 at 12:15:51AM -0500, James McCoy wrote: >>> On Sat, Nov 07, 2015 at 10:09:37PM -0500, James McCoy wrote: >>> > The attached patch, however, at least gets the test suite working with >&g

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-17 Thread Philip Martin
/usr/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' from /home/pm/sw/subversion/obj/../src/subversion/bindings/swig/ruby/test/run-test.rb:22:in `' Makefile:922: recipe for target 'check-swig-rb' failed make: *** [check-swig-rb] Error 1 -- Philip Martin WANdisco

Re: Merge 'svnmover' demo tool to trunk

2015-11-13 Thread Philip Martin
7;fake' are the branching state and branching transaction stuff as well as the merging and conflict stuff. These are the bits that show how moves can be described, transferred and combined in a way that allows the repository to store them and the client to use them. -- Philip Martin WANdisco

Re: Merge 'svnmover' demo tool to trunk

2015-11-13 Thread Philip Martin
7;fake' are the branching state and branching transaction stuff as well as the merging and conflict stuff. These are the bits that show how moves can be described, transferred and combined in a way that allows the repository to store them and the client to use them. -- Philip Martin WANdisco

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-05 Thread Philip Martin
James McCoy writes: > As an independent package or as part of the Ruby package? The minitest available via yum is rubygem-minitest 4.3.2. I suppose I could install a separate gem. -- Philip Martin WANdisco

Re: [PATCH] Convert Ruby tests from test-unit to minitest

2015-11-05 Thread Philip Martin
) is bundled. These > changes broke check-swig-rb, since the test framework APIs behave > differently. This patch works on my Debian/stable system but not on CentOS 7 which only has minitest 4.3.2. -- Philip Martin WANdisco

Re: svn commit: r1710215 - in /subversion/trunk/subversion:bindings/javahl/native/SVNClient.cpp include/svn_client.hlibsvn_client/cleanup.c

2015-10-23 Thread Philip Martin
ent part, leaving the JNI part. See r1710290. -- Philip Martin WANdisco

Re: NFS performance regression in 1.9

2015-10-23 Thread Philip Martin
Branko Čibej writes: > On 16.10.2015 13:14, Philip Martin wrote: >> Philip Martin writes: >> >>> "Bert Huijben" writes: >>> >>>> I'm not able to answer all that, but I do know that your change will >>>> slow Subversion do

Re: Binary incompatibility in JavaHL runtime version check

2015-10-22 Thread Philip Martin
r development) -- Philip Martin WANdisco

Binary incompatibility in JavaHL runtime version check

2015-10-22 Thread Philip Martin
es.Version.isAtLeast(III)Z+1 j org.apache.subversion.javahl.NativeResources.init()V+17 j org.apache.subversion.javahl.NativeResources.loadNativeLibrary()V+71 j org.apache.subversion.javahl.types.Version.()V+0 -- Philip Martin WANdisco

Re: [PATCH] improved behaviour of tools/backup/hot-backup.py

2015-10-22 Thread Philip Martin
For example pack on a FSFS repository could remove revision files, a commit to a BDB repository could delete a log file. Any such files will cause archive creation to fail with your patch. -- Philip Martin WANdisco

Re: NFS performance regression in 1.9

2015-10-16 Thread Philip Martin
Philip Martin writes: > "Bert Huijben" writes: > >> I'm not able to answer all that, but I do know that your change will >> slow Subversion down on Samba shares as used from Windows systems with >> that flag. And once one user used it in that way it will s

Re: NFS performance regression in 1.9

2015-10-15 Thread Philip Martin
ange r1659426 stated: The TRUNCATE and DELETE journal modes are compatible, so different Subversion clients with different journal mode should just work with same working copy without problems. -- Philip Martin WANdisco

Re: NFS performance regression in 1.9

2015-10-15 Thread Philip Martin
at uses LVM+mdadm+ZFS/BtrFS? Is NFS less reliable than the firmware in a h/w RAID card? -- Philip Martin WANdisco

NFS performance regression in 1.9

2015-10-15 Thread Philip Martin
e brings the 1.9 checkout time down to 69s, so only 5% slower than 1.8 rather than 36%. -- Philip Martin WANdisco

Re: Running SVN 1.9.x on ASF servers?

2015-10-09 Thread Philip Martin
, but that obviously means we better be *damned* sure it won't lose or corrupt the repo :-) -- Philip Martin WANdisco

[PATCH] mod_auth_kerb/mod_auth_ntlm and mod_authz_svn

2015-10-09 Thread Philip Martin
) -{ - ap_note_auth_failure(r); - return HTTP_UNAUTHORIZED; -} +return DECLINED; } #else if (!authn_required) -- Philip Martin WANdisco

Re: Bulk copying locks

2015-09-24 Thread Philip Martin
7;ve just discovered that it is even possible to lock directories! http://subversion.tigris.org/issues/show_bug.cgi?id=2507#desc28 -- Philip Martin WANdisco

Bulk copying locks

2015-09-24 Thread Philip Martin
add_locks) def rm_locks(dst_lock, pool): src_lock = fs.get_lock(src_fs, dst_lock.path) if not src_lock: fs.unlock(dst_fs, dst_lock.path, dst_lock.token, True) print "rm: " + dst_lock.path access = fs.create_access("dummy") fs.set_access(dst_fs, access) fs.get_locks(dst_fs, "", rm_locks) -- Philip Martin WANdisco

Re: 1.9.2 up for signing/testing

2015-09-21 Thread Philip Martin
+OIkBVB50oV6eOZJ7JHhy9rJ5D3W9MaH+tiV3gBe u5cFj6T4KUnj8gyNgpvzyBXWbCDhSHOkLdwvsg1PNjtLDkGiHkflpRKiMEJL6Umv x8QNJGbmzC8hKhRtINK3mmUEBDTV3q9jUOcLmuqn7fHJ31RKl+Z73+H0tPNq5vM= =irhF -END PGP SIGNATURE- -- Philip Martin WANdisco

Re: Merge ra-reuse-session branch to trunk or not?

2015-09-17 Thread Philip Martin
t the error from a broken RA session and create another? Track the time when the session was last used? Something else? -- Philip Martin WANdisco

svnfsfs stats division by zero on empty repository

2015-09-08 Thread Philip Martin
nt - sum, ',', pool), 249 (int)((stats->file_histogram.total.count - sum) * 100 / 250stats->file_histogram.total.count)); 251 } 252 253 /* Print the (up to) 16 extensions in STATS with the largest total size of (gdb) p stats->file_histogram.total.count $1 = 0 -- Philip Martin WANdisco

Re: detach.py script isn't updated for 1.8/1.9

2015-08-17 Thread Philip Martin
unfinished and not ready to be used on live data. Trust us. I don't really see how we could make it clearer. -- Philip Martin WANdisco

Re: detach.py script isn't updated for 1.8/1.9

2015-08-17 Thread Philip Martin
Stefan Sperling writes: > On Mon, Aug 17, 2015 at 11:03:12AM +0100, Philip Martin wrote: >> The script was an experiment that was never finished. I was wrong, the script does handle SQLite indices as it copies the entire schema. The main problem is we don't really know how we

Re: bash_completion - subversion add: svn ls/merge ^/

2015-08-17 Thread Philip Martin
CH[3]}" > +remote_files="$(svn ls "$url")" What about error messages from the command? Should they be dropped or displayed? What about authentication prompts? Is --non-interactive needed? -- Philip Martin WANdisco

Re: detach.py script isn't updated for 1.8/1.9

2015-08-17 Thread Philip Martin
s script is unfinished" message and it is true that support for 1.7 is not complete, e.g. no support for SQLite indices. The script was an experiment that was never finished. -- Philip Martin WANdisco

Re: JavaHL, 1.9: "Bad file descriptor", "Stream doesn't support this capability" errors

2015-08-14 Thread Philip Martin
Philip Martin writes: > That's the apr_poll() call in data_available_handler_apr() failing, and > E09 could be EBADF. Perhaps E09 is not EBADF on Windows? Looking on Google I find Error Code 9: The storage control block address is invalid. [ERROR_INVALID_BLOCK (0x9)] I

Re: JavaHL, 1.9: "Bad file descriptor", "Stream doesn't support this capability" errors

2015-08-14 Thread Philip Martin
&n, 0); (gdb) p pfd.desc.f[0].filedes $6 = 6 On Linux I can check that 6 a valid file descriptor for this process: $ ls -l /proc/28574/fd/6 lr-x-- 1 pm pm 64 Aug 14 10:18 /proc/28574/fd/6 -> pipe:[612259] -- Philip Martin WANdisco

Re: Review of sizeof usage

2015-08-13 Thread Philip Martin
ind all the locations that a given type is allocated then using grep is hard on code like this: type_t *p; ... p = apr_palloc(result_pool, *p); and this: void foo(type_t **p, apr_pool_t *pool) { *p = apr_palloc(pool, **p); } Finding sizeof(type_t) is easier. -- Philip Martin WANdisco

Re: Linux distributions and the Apache MMN

2015-08-12 Thread Philip Martin
Philip Martin writes: > I suppose I have to put back the MMN checks in mod_authz_svn.c, retain > the new configure checks, and have configure set some #define that > overides the checks in mod_authz_svn.c for httpd patched without MMN > bump. If I arrange it so that configure only s

Re: Linux distributions and the Apache MMN

2015-08-12 Thread Philip Martin
Philip Martin writes: > Stefan Fuhrmann writes: > >> What does the version check look like on Windows? > > Good point, I don't know how to handle that. I suppose I have to put back the MMN checks in mod_authz_svn.c, retain the new configure checks, and have configur

Re: Linux distributions and the Apache MMN

2015-08-12 Thread Philip Martin
Stefan Fuhrmann writes: > What does the version check look like on Windows? Good point, I don't know how to handle that. -- Philip Martin WANdisco

Re: Linux distributions and the Apache MMN

2015-08-12 Thread Philip Martin
Philip Martin writes: > Writing autoconf code to run grep on the httpd header file might be an > option. I worked up a patch. This has the added advantage the the detection now happens earlier so broken httpd causes a configure error rather than a compile error. It has the disadvantag

Re: Review of sizeof usage

2015-08-11 Thread Philip Martin
e explicit type as it is easier to grep. -- Philip Martin WANdisco

Linux distributions and the Apache MMN

2015-08-11 Thread Philip Martin
is not portable. Writing autoconf code to run grep on the httpd header file might be an option. We could add a configure option to use of the new API even when the MMN has not been updated, the opposite of --enable-broken-httpd-auth. Or we could leave users to edit the Subversion source code. -- Philip Martin WANdisco

Re: Subversion 1.8.14 up for testing/signing

2015-07-31 Thread Philip Martin
/mO2J6mvjlgFE1xci7iycgkgUcBEUxEuVJVhrGGydDnJ35J0ORMM= =JcMI -END PGP SIGNATURE- -- Philip Martin WANdisco

Re: Subversion 1.9.0 up for testing/signing

2015-07-30 Thread Philip Martin
-END PGP SIGNATURE- -- Philip Martin WANdisco

Re: Bulk copying revprops

2015-07-25 Thread Philip Martin
Philip Martin writes: > svnsync has a simple algorithm that writes every revprop for each > revision. If we put the write optimisation into svnsync, not writing unchanged revprops, this would probably give most of the efficiency gain for the case where the bulk of the revprops are unchang

Re: Bulk copying revprops

2015-07-24 Thread Philip Martin
Philip Martin writes: > svnadmin dump-revprops repo | svnadmin load-revprops repo Oops! Load into a different repository: svnadmin dump-revprops repo | svnadmin load-revprops repo2 -- Philip Martin WANdisco

Bulk copying revprops

2015-07-24 Thread Philip Martin
iteritems(): try: src_value = src_props[dst_name] except: fs.change_rev_prop(dst_fs, r, dst_name, None) # delete -- Philip Martin WANdisco

Re: 1.9.0 minimal Python version

2015-07-24 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >> RHEL 6 is on Python 2.6 and is unlikely to change. Python 2.7 is >> available as a Red Hat Software Collection component. > > The Software Collection python27 is sufficient to build Subversion and > run the regre

Re: 1.9.0 minimal Python version

2015-07-24 Thread Philip Martin
Philip Martin writes: > RHEL 6 is on Python 2.6 and is unlikely to change. Python 2.7 is > available as a Red Hat Software Collection component. The Software Collection python27 is sufficient to build Subversion and run the regression tests but some of the tests FAIL. The tests that fa

Re: 1.9.0 minimal Python version

2015-07-24 Thread Philip Martin
Debian 7.0/8.0/9.0 (wheezy/jessie/stretch - currently >> oldstable/stable/testing): py2.7 > > The "very old enterprise versions" are probably RHEL 6 and SuSE 10; both > are still in wide use. RHEL 6 is on Python 2.6 and is unlikely to change. Python 2.7 is available as a

Re: svn commit: r1687152 - in /subversion/branches/1.7.x: ./ STATUS subversion/libsvn_wc/upgrade.c subversion/libsvn_wc/wc-metadata.sql subversion/libsvn_wc/wc_db.c subversion/libsvn_wc/wc_db.h

2015-07-22 Thread Philip Martin
ETE_LIST to be ordered. All that is necessary is that the same rows are selected (so that the correct notifications are generated). -- Philip Martin WANdisco

Re: svn commit: r1687152 - in /subversion/branches/1.7.x: ./ STATUS subversion/libsvn_wc/upgrade.c subversion/libsvn_wc/wc-metadata.sql subversion/libsvn_wc/wc_db.c subversion/libsvn_wc/wc_db.h

2015-07-22 Thread Philip Martin
S during compilation of libsvn_subr; but > I don't think that support was already available in 1.7) I backported SVN_SQLITE_REVERSE_UNORDERED_SELECTS to 1.7 and the above fix to STMT_INSERT_DELETE_FROM_NODE_RECURSIVE is sufficient to PASS the regression tests when reverse is enabled. Reverting r1687152 is the most reliable way to avoid a regression but fixing STMT_INSERT_DELETE_FROM_NODE_RECURSIVE is probably sufficient. -- Philip Martin WANdisco

Re: svn commit: r1687152 - in /subversion/branches/1.7.x: ./ STATUS subversion/libsvn_wc/upgrade.c subversion/libsvn_wc/wc-metadata.sql subversion/libsvn_wc/wc_db.c subversion/libsvn_wc/wc_db.h

2015-07-21 Thread Philip Martin
rsion/libsvn_wc/wc-queries.sql === --- subversion/libsvn_wc/wc-queries.sql (revision 1692140) +++ subversion/libsvn_wc/wc-queries.sql (working copy) @@ -818,6 +818,7 @@ WHERE wc_id = ?1 OR IS_STRICT_DESCENDANT_OF(local_relpath, ?2)) AND op_depth = ?3 AND presence NOT IN ('base-deleted', 'not-present', 'excluded', 'absent') +ORDER BY local_relpath -- STMT_INSERT_WORKING_NODE_FROM_BASE_COPY INSERT INTO nodes ( -- Philip Martin WANdisco

move-tracking-2 pool management

2015-07-09 Thread Philip Martin
t() is also changed to not destroy the svnmover_wc_t pool. -- Philip Martin WANdisco

Re: [PATCH] Improve the regex of sed command of SVN_SERF_INCLUDES macro

2015-07-08 Thread Philip Martin
FIG $serf_pc_arg --libs | $SED -e > 's/-l[^ ]*//g'`"] I changed [:space:] to a literal space for consistency with the rest of the regex. I suppose we could switch [:space:] everwhere but I don't think that is necessary. Comitted as r1689824. Thanks! -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: 1.9.0-rc3 up for testing/signing

2015-07-06 Thread Philip Martin
= =Faco -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1686181 - in /subversion/trunk/subversion/mod_dav_svn:./ reports/

2015-06-18 Thread Philip Martin
tatus returned to the client - 'error_id' is an additional DAV error, i.e. some violation of the DAV rules. There are some definitions in mod_dav.h but callers can pass other values. - 'aprerr' is any underlying APR error, i.e. some sort of runtime system error. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-17 Thread Philip Martin
s.org/issues/show_bug.cgi?id=3750 It can lead to inconsistent locks: - a lock that shows up on a file /A/f but doesn't show up when one asks for all the locks in /A. - a lock for a file that does not exist in HEAD -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-16 Thread Philip Martin
se succeeding. I suppose we could change svn_repos_notify_t.err to some other type, but svn_error_t is a convenient way to package the information. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Blame behaviour change in 1.9

2015-06-12 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >> 1.9 has a more accurate svn_fs_contents_changed() that doesn't report as >> many false positives. This means that some (or all?) of the -g revisions >> reported by svn_repos_get_file_revs2() do not include a text

Re: Blame behaviour change in 1.9

2015-06-12 Thread Philip Martin
Philip Martin writes: > 1.9 has a more accurate svn_fs_contents_changed() that doesn't report as > many false positives. This means that some (or all?) of the -g revisions > reported by svn_repos_get_file_revs2() do not include a textdelta that > was included by 1.8. It appe

Re: [patch] Support modern network utilities for finding free ports for tests

2015-06-10 Thread Philip Martin
Philip Martin writes: >>> > HTTPD_PORT=3691 >>> > -while netstat -an | grep $HTTPD_PORT | grep 'LISTEN' >/dev/null; do >>> > +while \ >>> > + (ss -ltn sport = :$HTTP_PORT 2>&1 | grep :$HTTP_PORT > /dev/null ) \ >>&g

Re: [patch] Support modern network utilities for finding free ports for tests

2015-06-10 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: Philip Martin [mailto:philip.mar...@wandisco.com] >> Sent: woensdag 10 juni 2015 14:05 >> To: Andreas Stieger >> Cc: dev@subversion.apache.org >> Subject: Re: [patch] Support modern

Re: [patch] Support modern network utilities for finding free ports for tests

2015-06-10 Thread Philip Martin
ORT | grep 'LISTEN' > /dev/null ) \ > + do You have HTTP_PORT where it should be HTTPD_PORT. I fixed that and committed r1684649. Thanks! -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Blame behaviour change in 1.9

2015-06-09 Thread Philip Martin
2015-06-09T20:11:55.821288Z U1ZOAACBdgIBAoI1Cg== 2015-06-09T20:11:55.932638Z m pm The significant difference is the missing txdeltas (ignore the hash ordering of revprops). -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Blame behaviour change in 1.9

2015-06-09 Thread Philip Martin
Philip Martin writes: > The 1.9 server is sending the same revisions as the 1.8 server but some > of the revisions from the 1.9 server do not have a textdelta. Both the > 1.8 and 1.9 servers call svn_repos_get_file_revs2() which calls > send_path_revision(). Inside send_path_revisi

Re: Blame behaviour change in 1.9

2015-06-09 Thread Philip Martin
Philip Martin writes: > $ ../../svn/svn blame -g > svn-test-work/working_copies/blame_tests-10/trunk/iota >2jrandom This is the file 'iota'. >2jrandom 'A' has changed a bit, with 'upsilon', and 'xi'. > > while t

Blame behaviour change in 1.9

2015-06-09 Thread Philip Martin
Build 1.8 and 1.9 (I'm building 1684452). Run a 1.9 server pointing at the 1.8 build directory; the server can be httpd or svnserve, but svnserve is probably easiest: ../obj-1.9/subversion/svnserve/svnserve -Tdr ../obj-1.8/subversion/tests/cmdline then run blame_tests.py 10: cd ../obj-1.8/

Re: 1.9.0-rc2 up for testing/signing

2015-06-04 Thread Philip Martin
7sYgyVuR3W6aJThFLPdToHT0D11OLezOPHTvahZJubM0EXPNnh7WK9WU9pE4wa80 pj1nOXSItmyoBYKzcNEfQQJE0bOCEOnKgK9Rl0aA7GEJx4f+TC6HWPo1wURiAVEn 3D1hqp35nayJa+/RQ2AXCnyVw1AoHVLlLOPEOY9wAxB6TWhdUMs0flp2HRn3I54= =lFPC -END PGP SIGNATURE- -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Philip Martin
Ivan Zhakov writes: > FWIW libsvn_fsfs uses dirent->name as key since it's already copied to > result_pool: That was a FSFS change in r1572049; I think it is a better solution so I have applied it to FSX. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Philip Martin
+apr_hash_set(hash, > + apr_pstrmemdup(scratch_pool, entry.key, entry.keylen), > + entry.keylen, dirent); >else > APR_ARRAY_PUSH(entries, svn_fs_x__dirent_t *) = dirent; > } -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Efficient and effective fsync during commit

2015-05-29 Thread Philip Martin
Stefan Fuhrmann writes: > On Thu, May 28, 2015 at 9:54 PM, Philip Martin > wrote: >> >> fsync() works on file descriptors rather than files, do we need to keep >> the original file descriptors open in order to fsync()? > > We could b/c there are at most 7 (4 f

Re: Efficient and effective fsync during commit

2015-05-28 Thread Philip Martin
ure of the transfer is implementation-defined. It probably is feasible to keep the file descriptors open, provided we don't accumulate too many. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1682265 - /subversion/trunk/subversion/libsvn_fs_fs/util.c

2015-05-28 Thread Philip Martin
d imo. If we fix svn_io_file_rename() that also make svn_io_file_move() work properly on Windows. Then if we can get svn_fs_fs__move_into_place() to call svn_fs_file_move() we move all the EXDEV stuff to io.c. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1682265 - /subversion/trunk/subversion/libsvn_fs_fs/util.c

2015-05-28 Thread Philip Martin
uested Windows behaviour that does not match Unix. Perhaps it was unintentional? > It could be nice > to fix in APR, but they seem to ignore our patches :( Do they have a record of doing that? I've sent patches that have been applied. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1682265 - /subversion/trunk/subversion/libsvn_fs_fs/util.c

2015-05-28 Thread Philip Martin
es the file to a temporary in the destination directory and then calls apr_file_rename(). -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-28 Thread Philip Martin
Ivan Zhakov writes: > I hope you're aware the original code has unbounded memory usage? No, could you explain? Is it a problem with the underlying stream code, or with the way it was used? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-28 Thread Philip Martin
27;, file, pool)); We have svn_stream_printf() and it makes the stream code neater. We could fix that by introducing svn_io_file_printf(). Either we add all the neat stream features to the file code or we attempt to move to the stream code. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-28 Thread Philip Martin
y the opposite, the code that opens the file/stream knows that the file/stream should be flushed. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-28 Thread Philip Martin
be able to do things that we can do. I think the fact that third parties are limited is OK. I've just applied the FSFS file flush changes to FSX. I think I got it right but it would have been easier with the stream approach. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-28 Thread Philip Martin
ary positions. I don't insist on this solution, if people think the file code is better that is OK. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Populating the rep-cache

2015-05-27 Thread Philip Martin
revision range that is just HEAD. - We could avoid a public API and call some FSFS function from svnfsfs. I'll probably go with the last option initially. Any comments? I should note that WANdisco has an interest in this code being developed. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-27 Thread Philip Martin
prop pack file and the revprop manifest file. That means replacing more, if not all, of the stream code in revprops.c. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-26 Thread Philip Martin
Evgeny Kotkov writes: > I sketched this option in the attached patch. With this patch applied, we > could rework the r1680819 fix like below. What do you think? Yes, that looks good. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Segfault in Perl bindings when commit touches a large number of files

2015-05-22 Thread Philip Martin
Philip Martin writes: > So, following the approach of r876245, would something like this do the > trick? It would help if I built the correct tree. No, that is not enough, the regression tests fail. -- Philip

Re: Segfault in Perl bindings when commit touches a large number of files

2015-05-22 Thread Philip Martin
(svn_swig_pl_from_md5($1)); -} +/* + * Skip the md5sum + * FIXME: Wrap the md5sum + */ +%typemap(in, numinputs=0) unsigned char *result_digest + "$1 = NULL;"; #endif /* Category 3 */ -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-22 Thread Philip Martin
Evgeny Kotkov writes: > Or is it just a gut feeling that we should be using streams here? We have been gradually moving our file-based code to stream-based code for years. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-22 Thread Philip Martin
= 0 write(5, "\202\0373\n3\n91\n91\n91\n\nK 10\nsvn:author\n"..., 289) = 289 fsync(5)= 0 close(5) = 0 write(4, "3.0\n3.0\n3.0\n", 12) = 12 fsync(4)= 0 close(4)= 0 -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-22 Thread Philip Martin
Ivan Zhakov writes: > On 22 May 2015 at 11:50, Philip Martin wrote: >> >> Another approach would be to have a function to enable flushing directly >> on the stream created by svn_stream_from_aprfile2() without creating a >> new stream. This is probably the smal

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-22 Thread Philip Martin
LL, +_("No closing file to flush")); + + svn_stream_set_close(stream, close_handler_flush); + + return SVN_NO_ERROR; +} + + +static svn_error_t * mark_handler_apr(void *baton, svn_stream_mark_t **mark, apr_pool_t *pool) { struct baton_apr *btn = baton; -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-22 Thread Philip Martin
Branko Čibej writes: > On 22.05.2015 10:50, Philip Martin wrote: >> >> Another approach would be to have a function to enable flushing directly >> on the stream created by svn_stream_from_aprfile2() without creating a >> new stream. This is probably the smal

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-22 Thread Philip Martin
andler_flush); + + return SVN_NO_ERROR; +} + + +static svn_error_t * mark_handler_apr(void *baton, svn_stream_mark_t **mark, apr_pool_t *pool) { struct baton_apr *btn = baton; -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-21 Thread Philip Martin
scratch_pool)); SVN_ERR(svn_stream_write(stream, compressed->data, &compressed->len)); SVN_ERR(svn_stream_close(stream)); A patch like that is possibly easier to review than r1680819. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-21 Thread Philip Martin
now work with files. Flush the data to disk when >done writing to a temporary manifest file. Is that the best approach? In the past we have been moving away from file code to stream code. Can we make the flush part of the stream code? Perhaps we could create a "flushing strea

Re: reversible fingerprint comment in membuffer code

2015-05-19 Thread Philip Martin
Philip Martin writes: > Is this comment in cache-membuffer.c:combine_key correct? > > /* scramble key DATA. All of this must be reversible to prevent key >* collisions. So, we limit ourselves to xor and permutations. */ > data[1] = (data[1] <<

reversible fingerprint comment in membuffer code

2015-05-19 Thread Philip Martin
[0] & 0x; data[0] ^= data[1] & APR_UINT64_C(0x); I don't see why this needs to be reversible, and it's not clear it is reversible. The comment was added in r1458643 on the cache-server branch http://svn.apache.org/viewvc?view=revision&revision=r14586

Re: getting desperate because of assumed regression after 1.8.11

2015-05-18 Thread Philip Martin
1660023: At revision 2. 22 pm wc 21 pm wc/e X2 ? ? wc/em 22 pm wc/s X2 ? ? wc/s/es -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
Philip Martin writes: > Prompted by the warnings I think there are some issues to fix. For > APR_HASH_KEY_STRING keys there is no protection against abnormally long > keys. combined_long_key() will allocate strlen() memory even if it is > many GB. The item will not get cached

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >> Prompted by the warnings I think there are some issues to fix. For >> APR_HASH_KEY_STRING keys there is no protection against abnormally long >> keys. combined_long_key() will allocate strlen() memory even if it is &g

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
Philip Martin writes: > Prompted by the warnings I think there are some issues to fix. For > APR_HASH_KEY_STRING keys there is no protection against abnormally long > keys. combined_long_key() will allocate strlen() memory even if it is > many GB. The item will not get cached

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
, which could be more than 4GB, will be permanently allocated in the cache. There is also a problem with overflow in membuffer_cache_set_internal() when calculating key+data length, although in practice a key large enough to trigger this will probably fail memory allocation first. In practice keys

svnsync --trust-server-cert-failure

2015-05-12 Thread Philip Martin
on or in addition. Or perhaps trust should be applied to servers via some sort of naming scheme like the options in the servers file? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

<    1   2   3   4   5   6   7   8   9   10   >