Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-29 Thread Stefan Fuhrmann
On Mon, Sep 28, 2015 at 10:55 AM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > On Wed, Sep 23, 2015 at 12:55 PM, Julian Foad > wrote: > >> > Johan Corveleyn wrote: >> >> [...] stefan2 told me in person that that part of the >> >> ch

Re: ASF JIRA: IRC Notifications

2015-09-29 Thread Stefan Fuhrmann
On Tue, Sep 29, 2015 at 11:07 AM, Ivan Zhakov wrote: > The ASFBot supports posting JIRA updates to IRC channel. Currently it > configured to post notifications on all issue changes. But it seems to > generate a lot traffic to IRC channel and may distract from > discussions. See yesterday conversi

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-28 Thread Stefan Fuhrmann
On Wed, Sep 23, 2015 at 12:55 PM, Julian Foad wrote: > > Johan Corveleyn wrote: > >> [...] stefan2 told me in person that that part of the > >> change in r1572363 was unintentional :-). IIUC, he didn't realize that > >> it would have this effect on the output of dump. > [...] > I think the d

Re: svn_fs_fs__prop_rep_equal: non-strict mode, consistency, and MD5

2015-09-28 Thread Stefan Fuhrmann
On Fri, Sep 25, 2015 at 8:01 PM, Julian Foad wrote: > (New thread, taken from an observation in the "No-op changes no longer > dumped..." thread. In that thread, I hadn't spotted that it is only > the props comparison.) > > Starting from 1.9.0, the FS API content comparison methods > > svn_fs

Re: [PATCH] simplify link to hackathon 2012

2015-09-20 Thread Stefan Fuhrmann
On Sun, Sep 20, 2015 at 5:38 PM, Stefan wrote: > Hi, > > attached patch would remove an unnecessary part of the link to the 2012 > hackathon news. > +1 on commit. -- Stefan^2.

Re: [PATCH] add hackathon 2014 news link to community page

2015-09-20 Thread Stefan Fuhrmann
On Sun, Sep 20, 2015 at 5:37 PM, Stefan wrote: > Hi, > > following suggested patch would add a link to the hackathon in 2014 to the > community page. > +1 on commit. -- Stefan^2.

Re: 1.9.2 up for signing/testing

2015-09-20 Thread Stefan Fuhrmann
On Fri, Sep 18, 2015 at 5:43 PM, Evgeny Kotkov wrote: > The 1.9.2 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on September 30th > so please

Re: Merge ra-reuse-session branch to trunk or not?

2015-09-17 Thread Stefan Fuhrmann
On Fri, Sep 18, 2015 at 12:08 AM, Ivan Zhakov wrote: > On 17 September 2015 at 21:53, Philip Martin > wrote: > > Ivan Zhakov writes: > > > >> I think now is good moment to discuss whether we should merge > >> ra-reuse-session [1] branch to trunk or not: it's better to merge such > >> branch in

Re: Migrating Subversion issues to ...

2015-09-15 Thread Stefan Fuhrmann
On Tue, Sep 15, 2015 at 11:59 AM, Bert Huijben wrote: > Hi All, > > > > Here at the hackathon in Berlin we are discussing issue trackers, and more > particular how we should eventually move our issues to ASF infrastructure. > An old TODO. > As much as I'm hesitant about changing

Re: svn commit: r1700799 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c svnadmin/svnadmin.c svnfsfs/load-index-cmd.c tests/libsvn_subr/stream-test.c

2015-09-14 Thread Stefan Fuhrmann
On Sat, Sep 12, 2015 at 1:46 AM, Evgeny Kotkov wrote: > Julian Foad writes: > > > Also for: > >svnrdump load > >svnmucc put - > > > > ? (These just came to mind when I thought about it.) > > I think, yes. Thank you for pointing this out, Julian. > After discussion at the Berlin hackat

Re: svn commit: r1702305 - /subversion/trunk/subversion/libsvn_subr/stream.c

2015-09-11 Thread Stefan Fuhrmann
On Fri, Sep 11, 2015 at 11:05 AM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > On Fri, Sep 11, 2015 at 11:01 AM, Branko Čibej wrote: > >> On 10.09.2015 23:50, Evgeny Kotkov wrote: >> > Stefan Fuhrmann writes: >> > >> > + * Special files

Re: svn commit: r1702305 - /subversion/trunk/subversion/libsvn_subr/stream.c

2015-09-11 Thread Stefan Fuhrmann
On Fri, Sep 11, 2015 at 11:01 AM, Branko Čibej wrote: > On 10.09.2015 23:50, Evgeny Kotkov wrote: > > Stefan Fuhrmann writes: > > > > + * Special files like STDIN will have no flags set at all. In that > case, > > + * we can't filter and must allow any o

Re: svn commit: r1702305 - /subversion/trunk/subversion/libsvn_subr/stream.c

2015-09-10 Thread Stefan Fuhrmann
On Thu, Sep 10, 2015 at 9:00 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: donderdag 10 september 2015 20:14 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1702305 - > > /subversion/trunk/subversion/l

Re: svnfsfs stats division by zero on empty repository

2015-09-10 Thread Stefan Fuhrmann
On Tue, Sep 8, 2015 at 12:56 PM, Philip Martin wrote: > $ svnadmin create repo > $ svnfsfs stats repo > ... > Extensions by number of representations: > Floating point exception > > Program received signal SIGFPE, Arithmetic exception. > 0x0040311c in print_extensions_by_changes (stats=0x

Re: svn commit: r1700799 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c svnadmin/svnadmin.c svnfsfs/load-index-cmd.c tests/libsvn_subr/stream-test.c

2015-09-10 Thread Stefan Fuhrmann
On Wed, Sep 9, 2015 at 12:31 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > >> The original commit begins using svn_stream_wrap_buffered_read() during > >> svnadmin load-revprops and svnfsfs load-index. This patch, however, > does > >> something enti

Re: svn commit: r1701633 - /subversion/trunk/subversion/libsvn_subr/stream.c

2015-09-08 Thread Stefan Fuhrmann
On Tue, Sep 8, 2015 at 11:21 AM, Ivan Zhakov wrote: > On 7 September 2015 at 18:06, wrote: > > Author: kotkov > > Date: Mon Sep 7 15:06:57 2015 > > New Revision: 1701633 > > > > URL: http://svn.apache.org/r1701633 > > Log: > > Fix svn_stream_for_stdin() and related functions for STDOUT and STD

Re: svn commit: r1700799 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c svnadmin/svnadmin.c svnfsfs/load-index-cmd.c tests/libsvn_subr/stream-test.c

2015-09-08 Thread Stefan Fuhrmann
On Mon, Sep 7, 2015 at 6:38 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > That is indeed a good idea, so I tried it in various ways: > > > > Index: subversion/libsvn_subr/stream.c > > ===

Re: svn commit: r1701317 - in /subversion/trunk/subversion: include/private/svn_ra_svn_private.h libsvn_ra_svn/marshal.c

2015-09-06 Thread Stefan Fuhrmann
On Sat, Sep 5, 2015 at 11:19 PM, Branko Čibej wrote: > On 05.09.2015 18:53, Ivan Zhakov wrote: > > On 5 September 2015 at 19:23, Branko Čibej wrote: > >> On 05.09.2015 02:53, Branko Čibej wrote: > >>> On 04.09.2015 21:17, stef...@apache.org wrote: > Author: stefan2 > Date: Fri Sep 4 1

Re: svn commit: r1698359 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c svnadmin/svnadmin.c svnfsfs/load-index-cmd.c tests/libsvn_subr/stream-test.c

2015-09-04 Thread Stefan Fuhrmann
On Wed, Sep 2, 2015 at 5:11 PM, Evgeny Kotkov wrote: > Branko Čibej writes: > > > Uh, sorry, you don't get to dictate how the veto gets resolved. Reworking > > what's on trunk is as valid as reverting. If you don't intend to work on > the > > solution, you may as well just let Stefan do that whi

Re: svn commit: r1700799 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c svnadmin/svnadmin.c svnfsfs/load-index-cmd.c tests/libsvn_subr/stream-test.c

2015-09-04 Thread Stefan Fuhrmann
On Wed, Sep 2, 2015 at 3:33 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Author: stefan2 > > Date: Wed Sep 2 13:04:51 2015 > > New Revision: 1700799 > > > > URL: http://svn.apache.org/r1700799 > > Log: > > [Combines r1698359 an

Re: svn commit: r1698359 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c svnadmin/svnadmin.c svnfsfs/load-index-cmd.c tests/libsvn_subr/stream-test.c

2015-09-02 Thread Stefan Fuhrmann
On Tue, Sep 1, 2015 at 7:26 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Yes. This is exactly why we can only use it when we have reasonable > control > > over the stream's usage, i.e. we can use it in our CL tools because all > the > > code th

Re: svn commit: r1698359 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c svnadmin/svnadmin.c svnfsfs/load-index-cmd.c tests/libsvn_subr/stream-test.c

2015-08-31 Thread Stefan Fuhrmann
On Sat, Aug 29, 2015 at 3:57 PM, Evgeny Kotkov wrote: > Hi Stefan, > > Stefan Fuhrmann writes: > > > Introduce a stream wrapper object that adds mark/seek support to any > > readable stream. Use it on the stdin streams in our CL tools. > > [...] >

Re: Bulk copying revprops

2015-08-31 Thread Stefan Fuhrmann
On Sat, Aug 29, 2015 at 3:18 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Because most of the infrastructure for dump-revprops and load-revprops is > > already in place, I'll give it a go and commit a straightforward > > implementation. > > As of r

Re: Subversion 1.9.1 up for testing/signing

2015-08-27 Thread Stefan Fuhrmann
On Thu, Aug 27, 2015 at 3:52 PM, Branko Čibej wrote: > The 1.9.1 release artefacts are now available for testing/signing. > The planned release date is Wednesday, 2nd September. > > Please get the tarballs from > > https://dist.apache.org/repos/dist/dev/subversion/ > > and add your signatures

Re: svn commit: r1697390 - /subversion/branches/1.9.x/STATUS

2015-08-26 Thread Stefan Fuhrmann
On Tue, Aug 25, 2015 at 3:41 PM, Branko Čibej wrote: > On 24.08.2015 15:32, stef...@apache.org wrote: > > Author: stefan2 > > Date: Mon Aug 24 13:32:41 2015 > > New Revision: 1697390 > > > > URL: http://svn.apache.org/r1697390 > > Log: > > * STATUS: Add svnfsfs load-index fixes (r1697381, r169738

Re: svn commit: r1697828 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

2015-08-26 Thread Stefan Fuhrmann
On Wed, Aug 26, 2015 at 8:17 AM, Branko Čibej wrote: > On 26.08.2015 09:14, br...@apache.org wrote: > > Author: brane > > Date: Wed Aug 26 07:14:59 2015 > > New Revision: 1697828 > > > > URL: http://svn.apache.org/r1697828 > > Log: > > Fix a 64-bit to 32-bit conversion warning on 64-bit platforms

Re: svn commit: r1697654 - /subversion/branches/1.9.x/STATUS

2015-08-26 Thread Stefan Fuhrmann
On Wed, Aug 26, 2015 at 8:26 AM, Branko Čibej wrote: > On 26.08.2015 07:34, Daniel Shahaf wrote: > > Branko Čibej wrote on Wed, Aug 26, 2015 at 07:26:47 +0200: > >> On 25.08.2015 23:12, Stefan Fuhrmann wrote: > >>> On Tue, Aug 25, 2015 at 4:43 PM, Branko Čibej &g

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-26 Thread Stefan Fuhrmann
On Wed, Aug 26, 2015 at 1:31 PM, Ivan Zhakov wrote: > On 26 August 2015 at 11:18, Branko Čibej wrote: > > On 25.08.2015 23:08, Stefan Fuhrmann wrote: > >>> All right, so I figured that the difference is that apr_array_make does > >>> two allocations compared to

Re: svn commit: r1697654 - /subversion/branches/1.9.x/STATUS

2015-08-25 Thread Stefan Fuhrmann
On Tue, Aug 25, 2015 at 4:43 PM, Branko Čibej wrote: > On 25.08.2015 17:31, Stefan Fuhrmann wrote: > > On Tue, Aug 25, 2015 at 12:55 PM, Branko Čibej > wrote: > > > >> On 25.08.2015 13:49, br...@apache.org wrote: > >>> Author: brane > >>>

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-25 Thread Stefan Fuhrmann
On Tue, Aug 25, 2015 at 10:08 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > ./subversion/svnserve/svnserve -Tdr > /media/stefan/033c7ee9-9980-45a8-b9c6-f911dc2ac664/f7-test/ -M 1000 -c 0 > --client-speed 10 > stefan@macbook:~/develop/trunk$ time ./subve

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-25 Thread Stefan Fuhrmann
./subversion/svnserve/svnserve -Tdr /media/stefan/033c7ee9-9980-45a8-b9c6-f911dc2ac664/f7-test/ -M 1000 -c 0 --client-speed 10 stefan@macbook:~/develop/trunk$ time ./subversion/svn/svn diff --summarize svn://localhost/ruby-f6-packed -r0:HEAD > /dev/null real0m2.150s user0m1.964s sys

Re: svn commit: r1697654 - /subversion/branches/1.9.x/STATUS

2015-08-25 Thread Stefan Fuhrmann
On Tue, Aug 25, 2015 at 12:55 PM, Branko Čibej wrote: > On 25.08.2015 13:49, br...@apache.org wrote: > > Author: brane > > Date: Tue Aug 25 11:49:09 2015 > > New Revision: 1697654 > > > > URL: http://svn.apache.org/r1697654 > > Log: > > * branches/1.9.x/STATUS: > >- Approve r1693886. > >-

Re: Issue #4588, part 1: FSFS access error

2015-08-25 Thread Stefan Fuhrmann
On Tue, Aug 25, 2015 at 7:15 AM, Daniel Shahaf wrote: > Evgeny Kotkov wrote on Tue, Aug 25, 2015 at 02:47:16 +0300: > > Stefan Fuhrmann writes: > > > > > My current hypothesis is that the server did not get restarted after > > > replacing the repository. B

Re: Issue #4588, part 1: FSFS access error

2015-08-25 Thread Stefan Fuhrmann
On Tue, Aug 25, 2015 at 12:47 AM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > My current hypothesis is that the server did not get restarted after > > replacing the repository. Because we decided not to make the instance ID > > part of the cache key, we cou

Issue #4588, part 3: Build issues on CentOS

2015-08-23 Thread Stefan Fuhrmann
The latest relevant section taken from that issue: Secondly, I would like to install Subversion 1.9 to try it out, but I'm running > CentOS 6.4 and I just can't get Subversion 1.9 to build. As I mentioned > below, I > have to download the latest Serf version, which doesn't come with CentOS 6.4. >

Issue #4588, part 2: Property checking in svnadmin load

2015-08-23 Thread Stefan Fuhrmann
When loading a dump file we 1. Complain about invalid property contents, 2. Provide no simple way of fixing trivial cases in 'svnadmin load', but 3. Inconsistently provide those automatic fixes if the user jumps through a bunch of hoops: http://stackoverflow.com/a/32030939/421049 Given that th

Re: Issue #4588, part 1: FSFS access error

2015-08-23 Thread Stefan Fuhrmann
On Sun, Aug 23, 2015 at 8:38 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > My current hypothesis is that the server did not get restarted > after replacing the repository. Because we decided not to make > the instance ID part of the cache key, we could easily h

Issue #4588, part 1: FSFS access error

2015-08-23 Thread Stefan Fuhrmann
Garret Wilson had a terrible experience upgrading to SVN 1.9 (http://subversion.tigris.org/issues/show_bug.cgi?id=4588), ranging from build problems over svnadmin load inconsistency to a low-level FSFS format 7 read error. This post focuses on the FSFS issue. The good news is that confidence is h

Re: svn commit: r1696626 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2015-08-21 Thread Stefan Fuhrmann
On Wed, Aug 19, 2015 at 6:57 PM, Branko Čibej wrote: > On 19.08.2015 18:26, stef...@apache.org wrote: > > Author: stefan2 > > Date: Wed Aug 19 16:26:05 2015 > > New Revision: 1696626 > > > > URL: http://svn.apache.org/r1696626 > > Log: > > * subversion/libsvn_ra_serf/util.c > > (ssl_convert_ser

Re: Removing deleted branches from our mergeinfo

2015-08-18 Thread Stefan Fuhrmann
On Sun, Aug 16, 2015 at 12:30 AM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Sat, Aug 15, 2015 at 20:18:53 +0100: > > Although we technically could, we will neither merge from > > them (using the branch@rev notation) nor resurrect them > > in the future. Therefore, I&#x

Re: detection of moved branches for svn-normalizer tool

2015-08-16 Thread Stefan Fuhrmann
On Wed, Jul 22, 2015 at 12:07 PM, Stefan Hett wrote: > Hi, > > I came across a case where svn-normalizer did remove mergeinfo for a > branch which was still present but got renamed in one revision. > I understand why it behaves the current way, but maybe in favor of the > improvements done for ha

Re: svn-normalizer tool error E160013

2015-08-16 Thread Stefan Fuhrmann
On Mon, Jul 20, 2015 at 6:08 PM, Stefan Hett wrote: > Hi, > > (sending to dev rather than to user since it's still an unreleased tool) > > I just tried to do a test-run on another checked-out path from the same > repository I already ran svn-normalizer on, but get a weird error which I > don't un

Re: svn-mergeinfo-normalizer ideas

2015-08-16 Thread Stefan Fuhrmann
On Fri, Jul 10, 2015 at 12:40 AM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > On Thu, Jun 25, 2015 at 5:10 PM, Stefan Hett wrote: > >> Hi, >> >> I'm dealing with one remaining case svn-mergeinfo-normalizer normalize >> doesn't seem to

Removing deleted branches from our mergeinfo

2015-08-15 Thread Stefan Fuhrmann
Hi all, Our mergeinfo on /trunk as grown to almost 100 branch entries now. Most of those branches don't exist anymore. Although we technically could, we will neither merge from them (using the branch@rev notation) nor resurrect them in the future. Therefore, I'd like to shave off 15k from our mer

Re: Review of sizeof usage

2015-08-13 Thread Stefan Fuhrmann
On Thu, Aug 13, 2015 at 11:17 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > > >> I prefer the explicit type as it is easier to grep. > > > > What do you grep for, specifically? The type should > > already show up for the variable / function argument >

Re: Review of sizeof usage

2015-08-13 Thread Stefan Fuhrmann
On Tue, Aug 11, 2015 at 4:02 PM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > way we use sizeof. In my opinion, we should take the > > size of the created or processed variable instead of its > > type, i.e. > > > > abc_t *v = apr_pcalloc(pool, sizeo

Review of sizeof usage

2015-08-11 Thread Stefan Fuhrmann
Hi all, The bug that lead to r1694533 prompted me to grep for all 2500+ uses of sizeof and to review them. I only found one other real problem and fixed it in r1694929. However, I noticed an inconsistency in the way we use sizeof. In my opinion, we should take the size of the created or processed

Re: New 1.7 release due to VS 2015 build issue

2015-08-11 Thread Stefan Fuhrmann
On Mon, Aug 10, 2015 at 3:40 AM, Stefan wrote: > Hi, > > I'm wondering whether it would be reasonable to release another 1.7-build. > > 1.7.21 added support to build 1.7 using Visual Studio 2015. However there > seemed to have been an oversight with neon, which misses the > platformtoolset-settin

Re: svn commit: r1694502 [1/6] - in /subversion/trunk: ./ notes/subversion/include/private/ subversion/libsvn_fs_x/ subversion/libsvn_subr/subversion/tests/cmdline/ subversion/tests/libsvn_fs/subversi

2015-08-11 Thread Stefan Fuhrmann
On Fri, Aug 7, 2015 at 7:53 PM, Branko Čibej wrote: > On 07.08.2015 15:02, Stefan Fuhrmann wrote: > > On Fri, Aug 7, 2015 at 1:25 AM, > <mailto:b...@qqmail.nl>> wrote: > > > > [And now to the proper list] > >

Re: svn commit: r1694489 [1/2] - in /subversion/trunk: ./ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subversion/libsvn_subr/ subversion/tests/libsvn_subr/

2015-08-11 Thread Stefan Fuhrmann
On Fri, Aug 7, 2015 at 2:57 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > On Thu, Aug 6, 2015 at 3:59 PM, Ivan Zhakov wrote: > >> On 6 August 2015 at 15:54, wrote: >> > Author: stefan2 >> > Date: Thu Aug 6 12:54:36 2015 >> &

Re: svn commit: r1694489 [1/2] - in /subversion/trunk: ./ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subversion/libsvn_subr/ subversion/tests/libsvn_subr/

2015-08-07 Thread Stefan Fuhrmann
On Thu, Aug 6, 2015 at 3:59 PM, Ivan Zhakov wrote: > On 6 August 2015 at 15:54, wrote: > > Author: stefan2 > > Date: Thu Aug 6 12:54:36 2015 > > New Revision: 1694489 > > > > URL: http://svn.apache.org/r1694489 > > Log: > > Merge the 1.10-cache-improvements development branch to trunk and remo

Re: svn commit: r1694502 [1/6] - in /subversion/trunk: ./ notes/subversion/include/private/ subversion/libsvn_fs_x/ subversion/libsvn_subr/subversion/tests/cmdline/ subversion/tests/libsvn_fs/subversi

2015-08-07 Thread Stefan Fuhrmann
On Fri, Aug 7, 2015 at 1:25 AM, wrote: > [And now to the proper list] > > > > On the buildbots I see > > [[[ > > ..\..\..\subversion\tests\libsvn_fs_x\fs-x-pack-test.c:873, > > ..\..\..\subversion\libsvn_fs_x\batch_fsync.c:386, > > ..\..\..\subversion\libsvn_fs_x\batch_fsync.c:343, > > ..\..\..\s

Re: 1.9.0 crash in ra_test (Solaris, Bus error, Alignment)

2015-08-06 Thread Stefan Fuhrmann
On Thu, Aug 6, 2015 at 4:54 PM, Rainer Jung wrote: > Am 06.08.2015 um 16:36 schrieb Rainer Jung: > >> Position of crash: >> >> #0 0xff29f194 in vparse_tuple (pool=pool@entry=0x35f10, >> fmt=fmt@entry=0xffbff264, ap=ap@entry=0xffbff20c, >> items=> 0xfa>, items=> 0xfa>) >> at subversion/

Merging development branches to trunk

2015-08-06 Thread Stefan Fuhrmann
Hi there, I had created a number of development branches to make sure 1.9 stabilization would be uninterrupted. Otherwise, they would have been trunk dev business as usual. Now that 1.9 has been released, I'll merge them to /trunk. The branches are: ^/subversion/branches/1.10-cache-improvements

Re: Can't build subversion 1.9 or master without gpg-agent

2015-08-06 Thread Stefan Fuhrmann
On Thu, Aug 6, 2015 at 12:03 PM, Alexander Dreweke wrote: > Hi > > when trying to build subversion without gpg-agent support the build fails. > > All code in subversion/libsvn_subr/gpg_agent.c is encapsulated in #ifdef > SVN_HAVE_GPG_AGENT, but the call to svn_auth__get_gpg_agent_simple_provider

Re: [PATCH] INSTALL documentation OpenSSL >= 1.0.0 update

2015-08-06 Thread Stefan Fuhrmann
On Tue, Aug 4, 2015 at 12:04 PM, Stefan wrote: > Hi, > > attached is a patch (suggested by danielsh) to update the information on > building OpenSSL as part of building on Windows from Source. > As of OpenSSL 1.0.0 the mentioned masm-support is no longer available. > Therefore you have to use one

Re: 1.7.22 up for testing/signing

2015-08-05 Thread Stefan Fuhrmann
On Wed, Aug 5, 2015 at 10:51 AM, Stefan Sperling wrote: > 1.7.22 is now available for testing/signing at > https://dist.apache.org/repos/dist/dev/subversion > > Please add your signatures there. > > This release fixes the test suite problem found in 1.7.21. > If you have already tested 1.7.21 + r

Re: Bulk copying revprops

2015-08-05 Thread Stefan Fuhrmann
On Wed, Aug 5, 2015 at 1:05 PM, Ivan Zhakov wrote: > On 24 July 2015 at 22:58, Philip Martin > wrote: > > [Arising from some discussion on IRC today.] > > > > I've been considering the problem of a dump/load upgrade for a > > repository with a large number of revisions. To minimise downtime the

Re: Bulk copying revprops

2015-08-05 Thread Stefan Fuhrmann
On Fri, Jul 24, 2015 at 9:10 PM, Philip Martin wrote: > Philip Martin writes: > > > svnadmin dump-revprops repo | svnadmin load-revprops repo > > Oops! Load into a different repository: > > svnadmin dump-revprops repo | svnadmin load-revprops repo2 > > I think the long-term solution would

Re: Subversion 1.7.21 up for testing/signing

2015-08-04 Thread Stefan Fuhrmann
Just verified that the HTTP tests run without exceptions in the logs. So, still +1 on 1.7.21. -- Stefan^2. On Mon, Jul 27, 2015 at 9:38 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > On Mon, Jul 27, 2015 at 6:23 AM, Branko Čibej wrote: > >> The 1.7.21 release

Re: [ANNOUNCE] Apache Subversion 1.9.0-rc3 released

2015-07-30 Thread Stefan Fuhrmann
On Wed, Jul 15, 2015 at 12:06 AM, Branko Čibej wrote: > As discussed elsewhere, this extends the soak period to 28th July. This > would be a good time to finalize the 1.9 release notes ... please? :) > Bump. There is still lots of TODOs in the 1.9 release notes. Please add / complete the bits t

Re: Subversion 1.8.14 up for testing/signing

2015-07-28 Thread Stefan Fuhrmann
On Tue, Jul 28, 2015 at 2:48 PM, Ivan Zhakov wrote: > On 28 July 2015 at 00:15, Stefan Fuhrmann > wrote: > > On Mon, Jul 27, 2015 at 8:02 AM, Branko Čibej wrote: > >> > >> The 1.8.14 release artefacts are now available for testing/signing. > >

Re: Subversion 1.8.14 up for testing/signing

2015-07-27 Thread Stefan Fuhrmann
On Mon, Jul 27, 2015 at 8:02 AM, Branko Čibej wrote: > The 1.8.14 release artefacts are now available for testing/signing. > > Please get the tarballs from > > https://dist.apache.org/repos/dist/dev/subversion/ > > and add your signatures there. > > Thanks! > Summary: +1 to release Platf

Re: Subversion 1.9.0 up for testing/signing

2015-07-27 Thread Stefan Fuhrmann
On Mon, Jul 27, 2015 at 9:43 AM, Branko Čibej wrote: > The 1.9.0 release artefacts are now available for testing/signing. > > Please get the tarballs from > > https://dist.apache.org/repos/dist/dev/subversion/ > > and add your signatures there. > > Thanks! > Summary: +1 to release Platfo

Re: Subversion 1.7.21 up for testing/signing

2015-07-27 Thread Stefan Fuhrmann
On Mon, Jul 27, 2015 at 6:23 AM, Branko Čibej wrote: > The 1.7.21 release artefacts are now available for testing/signing. > > Please get the tarballs from > > https://dist.apache.org/repos/dist/dev/subversion/ > > and add your signatures there. > > Thanks! > Summary: +1 to release Plat

Re: Bulk copying revprops

2015-07-25 Thread Stefan Fuhrmann
On Sat, Jul 25, 2015 at 8:49 AM, Philip Martin wrote: > Philip Martin writes: > > > svnsync has a simple algorithm that writes every revprop for each > > revision. > > If we put the write optimisation into svnsync, not writing unchanged > revprops, this would probably give most of the efficiency

Re: Bulk copying revprops

2015-07-25 Thread Stefan Fuhrmann
On Fri, Jul 24, 2015 at 8:58 PM, Philip Martin wrote: > I was thinking that perhaps we ought to provide a more accessible way to > do this. First, modify the FS implementations to detect when a change > is a noop that doesn't modify a value and skip all the writing. Done in r1692650. -- Stefa

Re: crash in svn-mergeinfo-normalizer

2015-07-17 Thread Stefan Fuhrmann
On Wed, Jul 15, 2015 at 12:03 PM, Stefan Hett wrote: > Hi Stefan^2, > > I've just tried to rerun the latest svn-mergeinfo-normalizer. > > Running the command "svn-mergeinfo-normalizer normalize" the application > crashes in local_lookup() in missing-branches.c in line 95 due to lookup > being nul

Re: [ANNOUNCE] Apache Subversion 1.9.0-rc3 released

2015-07-14 Thread Stefan Fuhrmann
On Wed, Jul 15, 2015 at 3:02 AM, Daniel Shahaf wrote: > Branko Čibej wrote on Wed, Jul 15, 2015 at 01:06:47 +0200: > > As discussed elsewhere, this extends the soak period to 28th July. This > > would be a good time to finalize the 1.9 release notes ... please? :) > > I've got this about FSFS f7

Re: svn-mergeinfo-normalizer ideas

2015-07-09 Thread Stefan Fuhrmann
On Thu, Jun 25, 2015 at 5:10 PM, Stefan Hett wrote: > Hi, > > I'm dealing with one remaining case svn-mergeinfo-normalizer normalize > doesn't seem to be able to handle yet. Would it be possible to add support > for this? > > Case: Eliminate incorrect mergeinfos of pre-branch-revisions. > > Looki

Re: inconsistency between mergeinfo records

2015-07-09 Thread Stefan Fuhrmann
On Thu, Jun 25, 2015 at 3:29 PM, Stefan Hett wrote: > Hi, > > as promised, answering the remaining questions now: > Hi Stefan, First of all, thank you for the detailed feedback! It is very helpful. I spent the last two weeks refactoring and reworking the tool. The main changes: * explicit --v

Re: 1.9.0-rc3 up for testing/signing

2015-07-06 Thread Stefan Fuhrmann
On Mon, Jul 6, 2015 at 9:18 AM, Branko Čibej wrote: > The 1.9.0-rc3 release artefacts are now available for testing/signing. > > Please get the tarballs from > > https://dist.apache.org/repos/dist/dev/subversion/ > > and add your signatures there. > Summary: +1 to release Platform Ubu

Re: Time to release Subversion 1.9.0-rc3?

2015-07-04 Thread Stefan Fuhrmann
On Fri, Jul 3, 2015 at 7:49 PM, Ivan Zhakov wrote: > On 3 July 2015 at 15:23, Branko Čibej wrote: > > On 03.07.2015 14:05, Ivan Zhakov wrote: > >> There are several changes merged to 1.9.x branch since 1.9.0-rc2: > [...] > >> > >> These commits contain public API changes and the community guide

Re: svn commit: r1688511 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

2015-07-01 Thread Stefan Fuhrmann
t file (should never happen, but ...) -- Stefan^2. > > > *From:* Stefan Fuhrmann > *Sent:* ‎Tuesday‎, ‎June‎ ‎30‎, ‎2015 ‎9‎:‎50‎ ‎PM > *To:* comm...@subversion.apache.org > > Author: stefan2 > Date: Tue Jun 30 19:50:46 2015 > New Revision: 1688511 > > URL: http

Re: Trunk builds are failing with FSFSv4 and -v6

2015-06-30 Thread Stefan Fuhrmann
On Tue, Jun 30, 2015 at 9:22 PM, Branko Čibej wrote: > http://ci.apache.org/builders/svn-x64-macosx-fsfs-v4/builds/1 > http://ci.apache.org/builders/svn-x64-macosx-fsfs-v6/builds/1 > > Could be related to the recent change in 'svnadmin pack' output. > Indeed. Our pre-cooked repos are always shar

Re: mergeinfo-normalizer issue with irrelevant ranges

2015-06-24 Thread Stefan Fuhrmann
On Wed, Jun 24, 2015 at 4:58 PM, Stefan Hett wrote: > Hi, > > hope it's ok to discuss this on this list rather than the users list > (since the tool is not part of a released version): > > I'm looking at the following output from mergeinfo-normalizer analyse: > > Trying to elide mergeinfo from pa

Re: inconsistency between mergeinfo records

2015-06-24 Thread Stefan Fuhrmann
On Wed, Jun 24, 2015 at 10:21 AM, Stefan Hett wrote: > Hi Stefan^2, > > Hi Stefan, >> >> If you have a working build environment for Subversion, >> you might have a look at this branch: >> >> >> https://svn.apache.org/repos/asf/subversion/branches/svn-mergeinfo-normalizer >> >> It provides a new

Re: inconsistency between mergeinfo records

2015-06-23 Thread Stefan Fuhrmann
On Tue, Jun 23, 2015 at 2:33 PM, Stefan Hett wrote: > Hi Stefan^2, > > On Thu, Mar 26, 2015 at 2:21 PM, Stefan Hett wrote: > >> Hi Stefan, >> >> thanks for taking the time to write that tool. >> I've scheduled a time-slot to check this out/test on our side. >> Unfortunately, our current proje

Re: svn commit: r1686478 - in /subversion/trunk/subversion: libsvn_repos/rev_hunt.c tests/libsvn_client/mtcc-test.c

2015-06-22 Thread Stefan Fuhrmann
On Mon, Jun 22, 2015 at 3:42 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: vrijdag 19 juni 2015 20:29 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1686478 - in /subversion/trunk/subversion: > > libs

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-22 Thread Stefan Fuhrmann
On Fri, Jun 19, 2015 at 8:37 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Well, it "works" based on SVN's concept of OS-side readonlyness. > > svnadmin_tests.py 51 passes on Windows. > > Did you try the test after doing 'svn merge -c-r168

Re: Blame behaviour change in 1.9

2015-06-19 Thread Stefan Fuhrmann
cessary. > [snip insightful commentary that I agree with] > Stefan Fuhrmann wrote: > > Branko Čibej wrote: > >> Philip Martin wrote: > >>> Philip Martin writes: > >>>> However the implementation of root_vtable_t.contents_changed() has > >&g

Re: svn commit: r1685985 - in /subversion/branches/fsx-1.10/subversion: include/private/svn_mutex.h libsvn_fs_x/batch_fsync.c libsvn_fs_x/batch_fsync.h libsvn_fs_x/fs.c libsvn_subr/mutex.c tests/libsv

2015-06-19 Thread Stefan Fuhrmann
On Fri, Jun 19, 2015 at 11:50 AM, Branko Čibej wrote: > On 18.06.2015 21:58, Stefan Fuhrmann wrote: > > One key design element is that the batch fsync > > container owns the open files and will open them > > only once. So, it can not only guarantee that we > > don

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-19 Thread Stefan Fuhrmann
On Fri, Jun 19, 2015 at 2:26 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > And the regression should be fixed. > > [...] > > > There is a trivial fix: Try to acquire the lock and fall back to the > > non-locking behavior if you get an EACCESS. The nic

Re: svn commit: r1685985 - in /subversion/branches/fsx-1.10/subversion: include/private/svn_mutex.h libsvn_fs_x/batch_fsync.c libsvn_fs_x/batch_fsync.h libsvn_fs_x/fs.c libsvn_subr/mutex.c tests/libsv

2015-06-18 Thread Stefan Fuhrmann
On Wed, Jun 17, 2015 at 3:46 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: woensdag 17 juni 2015 12:09 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1685985 - in > /subversion/branches/fsx-1.10/subve

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-18 Thread Stefan Fuhrmann
On Thu, Jun 18, 2015 at 3:24 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Sorry, my bad, I was wrong there. I only remembered that we had and still > > have the pack/hotcopy race condition in 1.8 and then I saw the recursive > > directory copy calls in the

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-17 Thread Stefan Fuhrmann
On Tue, Jun 16, 2015 at 11:55 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > That makes we wonder how we prevent packing in old format repositories. > > We know that hotcopying while packing can corrupt the destination repo. > > [...] > > > I'm

Re: Efficient and effective fsync during commit

2015-06-16 Thread Stefan Fuhrmann
On Mon, Jun 15, 2015 at 5:36 PM, Ivan Zhakov wrote: > On 12 June 2015 at 15:11, Stefan Fuhrmann > wrote: > > On Fri, May 29, 2015 at 6:23 PM, Ivan Zhakov wrote: > >> > >> On 29 May 2015 at 18:55, Stefan Fuhrmann > >> wrote: > >> > I

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-16 Thread Stefan Fuhrmann
On Tue, Jun 16, 2015 at 9:38 PM, Branko Čibej wrote: > On 16.06.2015 20:49, Stefan Fuhrmann wrote: > > Once we are at it, let's detect pack operations during > > hotcopy (compare pack status before & after the hotcopy). > > Then we can at least warn the user of old

Experiments with FlushFileBuffers on Windows

2015-06-16 Thread Stefan Fuhrmann
Hey there, One of the links recently provided by Daniel Klima pointed to a way to enable write caching even on USB devices. So, I could use my Windows installation for experiments now without the risk of brick-ing 2 grand worth of disks by pulling the plug tens of times. -- Stefan^2. TL;DR

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-16 Thread Stefan Fuhrmann
On Tue, Jun 16, 2015 at 8:12 PM, Evgeny Kotkov wrote: > FSFS7 introduced a new on-disk lockfile, db/pack-lock, that allows packing > a repository without completely blocking the commits. We also extended the > svn_fs_fs__hotcopy() logic to take this lock for the source repository, see > r1589284

Re: Blame behaviour change in 1.9

2015-06-14 Thread Stefan Fuhrmann
On Fri, Jun 12, 2015 at 8:38 PM, Branko Čibej wrote: > On 12.06.2015 16:55, Philip Martin wrote: > > Philip Martin writes: > > > >> Philip Martin writes: > >> > >>> 1.9 has a more accurate svn_fs_contents_changed() that doesn't report > as > >>> many false positives. This means that some (or al

Re: Efficient and effective fsync during commit

2015-06-12 Thread Stefan Fuhrmann
On Fri, May 29, 2015 at 6:23 PM, Ivan Zhakov wrote: > On 29 May 2015 at 18:55, Stefan Fuhrmann > wrote: > > On Fri, May 29, 2015 at 4:14 PM, Ivan Zhakov wrote: > >> On 28 May 2015 at 20:47, Stefan Fuhrmann > wrote: > >>> Hi all, > >>> > >

Re: svn commit: r1682265 - /subversion/trunk/subversion/libsvn_fs_fs/util.c

2015-06-12 Thread Stefan Fuhrmann
On Fri, May 29, 2015 at 4:54 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > However, it does not tell you anything about consistency with outside > > parties, say some svnsync'ed repository. The problem is that Windows may > > end up not persisting the

Re: 1.9.0-rc2 up for testing/signing

2015-06-04 Thread Stefan Fuhrmann
On Tue, Jun 2, 2015 at 12:45 PM, Daniel Shahaf wrote: > Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700: > > The 1.9.0-rc2 release artifacts are now available for testing/signing. > > Please get the tarballs from > > https://dist.apache.org/repos/dist/dev/subversion > > and add your sign

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-04 Thread Stefan Fuhrmann
On Wed, Jun 3, 2015 at 2:33 PM, Branko Čibej wrote: > On 21.05.2015 17:23, Evgeny Kotkov wrote: > > Subversion 1.9.0-rc1 introduced a new svnadmin verify --keep-going mode > [1]. > > In order to achieve this, we added a svn_repos_verify_fs3() API function > and > > deprecated its predecessor, svn

Re: 1.9.0-rc2 up for testing/signing

2015-06-01 Thread Stefan Fuhrmann
On Sun, May 31, 2015 at 11:28 PM, Ben Reser wrote: > The 1.9.0-rc2 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > Summary: +1 to release Platform Ubuntu 14.04.

Re: fsfs7 structure-indexes - questions

2015-06-01 Thread Stefan Fuhrmann
On Mon, May 18, 2015 at 1:20 AM, Daniel Shahaf wrote: > Good morning Stefan, > > A couple of questions on the fsfs7 indexes doc: > > [[[ > --- subversion/libsvn_fs_fs/structure-indexes > +++ subversion/libsvn_fs_fs/structure-indexes > @@ -18,6 +18,9 @@ a simple concatenation of runtime structs an

Re: Efficient and effective fsync during commit

2015-05-29 Thread Stefan Fuhrmann
On Fri, May 29, 2015 at 4:14 PM, Ivan Zhakov wrote: > On 28 May 2015 at 20:47, Stefan Fuhrmann wrote: >> Hi all, >> >> Most of us would agree that way we fsync FS changes >> in FSFS and FSX is slow (~10 commits / sec on a SSD, >> YMMV) and not even all ch

Re: Queries about rep cache: get_shared_rep()

2015-05-29 Thread Stefan Fuhrmann
On Wed, May 27, 2015 at 6:35 PM, Julian Foad wrote: > Stefan Fuhrmann wrote: >> Alright. I gave it a bit more thought now. >> >> Whenever we encounter this mismatch, something pretty >> bad likely happened to the repo - such as a failed restore >> attempt. In tur

Re: Efficient and effective fsync during commit

2015-05-29 Thread Stefan Fuhrmann
On Thu, May 28, 2015 at 9:54 PM, Philip Martin wrote: > Stefan Fuhrmann writes: > >> In the future, we should implement step 1 as simple >> non-fsync'ing file operations. Then explicitly sync every >> file, and on POSIX the folders, once. Step 2 does not >&

<    1   2   3   4   5   6   7   8   9   10   >