Re: Status of the branch diff-optimizations-bytes branch

2011-01-28 Thread Julian Foad
Hyrum K Wright wrote: > On Fri, Jan 28, 2011 at 6:49 AM, Johan Corveleyn wrote: > > And one more thing came to mind with regards to the new API > > (datasources_open function): currently it only supports up to 4 > > datasources, so not an arbitrary number of datasources (the > > implementation in

Re: Status of the branch diff-optimizations-bytes branch

2011-01-28 Thread Hyrum K Wright
On Fri, Jan 28, 2011 at 6:49 AM, Johan Corveleyn wrote: > On Fri, Jan 28, 2011 at 5:51 AM, Hyrum K Wright wrote: >> On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: >>> On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright >>> wrote: Johan (and other interested parties), I've been f

Re: Status of the branch diff-optimizations-bytes branch

2011-01-28 Thread Johan Corveleyn
On Fri, Jan 28, 2011 at 5:51 AM, Hyrum K Wright wrote: > On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: >> On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright >> wrote: >>> Johan (and other interested parties), >>> I've been following some of the commits to the >>> diff-optimizations-branc

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: > On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright wrote: >> Johan (and other interested parties), >> I've been following some of the commits to the >> diff-optimizations-branch with interest.  While I've not reviewed them >> for technical me

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Thu, Jan 27, 2011 at 3:13 PM, Hyrum K Wright wrote: > On Thu, Jan 27, 2011 at 3:08 PM, Johan Corveleyn wrote: >> On Thu, Jan 27, 2011 at 4:52 PM, Hyrum K Wright >> wrote: >>> Johan, >>> I'd appreciate review on the attached patch.  It is an attempt to rev >>> the svn_diff_fns_t struct and re

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Thu, Jan 27, 2011 at 3:08 PM, Johan Corveleyn wrote: > On Thu, Jan 27, 2011 at 4:52 PM, Hyrum K Wright wrote: >> Johan, >> I'd appreciate review on the attached patch.  It is an attempt to rev >> the svn_diff_fns_t struct and related functions.  You'll notice that I >> commented out the use of

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Johan Corveleyn
On Thu, Jan 27, 2011 at 4:52 PM, Hyrum K Wright wrote: > Johan, > I'd appreciate review on the attached patch.  It is an attempt to rev > the svn_diff_fns_t struct and related functions.  You'll notice that I > commented out the use of datasources_open in both diff_file.c and > diff_memory.c, in a

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Wed, Jan 26, 2011 at 7:15 PM, Johan Corveleyn wrote: > On Wed, Jan 26, 2011 at 10:50 PM, Hyrum K Wright > wrote: >> On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: >> ...  * revv svn_diff.h#svn_diff_fns_t             [] It looks like, for the most part, any destabilizi

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Johan Corveleyn
On Wed, Jan 26, 2011 at 10:50 PM, Hyrum K Wright wrote: > On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: > ... >>>  * revv svn_diff.h#svn_diff_fns_t             [] >>> >>> It looks like, for the most part, any destabilizing functionality is >>> completed, and what remains are simply opti

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Johan Corveleyn
On Wed, Jan 26, 2011 at 7:18 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Wed, Jan 26, 2011 at 15:18:24 +0100: >> - The only internal caller of the "old" function 'datasource_open' >> (for a single datasource) doesn't call it anymore >> (token.c#svn_diff__get_tokens) (there is no need anymo

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: ... >>  * revv svn_diff.h#svn_diff_fns_t             [] >> >> It looks like, for the most part, any destabilizing functionality is >> completed, and what remains are simply optimizations.  This >> optimization work can probably be performed o

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Stefan Fuhrmann
On 25.01.2011 16:58, Hyrum K Wright wrote: Johan (and other interested parties), I've been following some of the commits to the diff-optimizations-branch with interest. While I've not reviewed them for technical merit, it appears that others have, and that there is good work going on in the bran

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Jan 26, 2011 at 15:18:24 +0100: > - The only internal caller of the "old" function 'datasource_open' > (for a single datasource) doesn't call it anymore > (token.c#svn_diff__get_tokens) (there is no need anymore, since the > callers in diff.c, diff3.c and diff4.c alrea

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Johan Corveleyn
On Wed, Jan 26, 2011 at 2:46 PM, Hyrum K Wright wrote: > On Tue, Jan 25, 2011 at 11:41 PM, Daniel Shahaf > wrote: >> Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: >>> Revving svn_diff_fns_t: what do you mean with parallelizing it? I must >>> admit that I don't really know (yet) h

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 11:41 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: >> Revving svn_diff_fns_t: what do you mean with parallelizing it? I must >> admit that I don't really know (yet) how to go about that. Very early >> during the branch work, danie

Re: Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: > Revving svn_diff_fns_t: what do you mean with parallelizing it? I must > admit that I don't really know (yet) how to go about that. Very early > during the branch work, danielsh pointed out that I modified this > public struct (vtable

Re: Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: > On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright wrote: > > Johan (and other interested parties), > > I've been following some of the commits to the > > diff-optimizations-branch with interest.  While I've not reviewed them > > for tec

Re: Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Johan Corveleyn
On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright wrote: > Johan (and other interested parties), > I've been following some of the commits to the > diff-optimizations-branch with interest.  While I've not reviewed them > for technical merit, it appears that others have, and that there is > good work