Re: default mode of 'svn cleanup' changed

2017-07-25 Thread Stefan Sperling
On Tue, Jul 25, 2017 at 11:09:21AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Mon, 24 Jul 2017 18:34 +0200: > > Daniel, I'm thinking that reverting r1802797, which changed the default > > behaviour of 'svn cleanup', may be good enough to address your backwards > > compat concerns, while

Re: default mode of 'svn cleanup' changed

2017-07-25 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, 24 Jul 2017 18:34 +0200: > Daniel, I'm thinking that reverting r1802797, which changed the default > behaviour of 'svn cleanup', may be good enough to address your backwards > compat concerns, while still giving people a choice to remove pristines > without risking a d

Re: default mode of 'svn cleanup' changed

2017-07-25 Thread Julian Foad
Stefan Sperling wrote: > The only problem which remains is that the user is currently being given > no choice to either steal locks or vacuum pristines. [...] The other problem you uncovered is that 'vacuuming' pristines is not mentioned at all in the help string. - Julian

Re: default mode of 'svn cleanup' changed

2017-07-24 Thread Stefan Sperling
On Mon, Jul 24, 2017 at 06:22:10PM +0200, Stefan Sperling wrote: > On Mon, Jul 24, 2017 at 03:40:32PM +, Daniel Shahaf wrote: > > It seems the real fix would be figuring out a way for 'cleanup' not to > > break all locks it sees. > > Actually, I missed that cleanup_internal() grabs a WC lock,

Re: default mode of 'svn cleanup' changed

2017-07-24 Thread Stefan Sperling
On Mon, Jul 24, 2017 at 03:40:32PM +, Daniel Shahaf wrote: > It seems the real fix would be figuring out a way for 'cleanup' not to > break all locks it sees. Actually, I missed that cleanup_internal() grabs a WC lock, so the entire point of my argument is moot. The other client manipulating W

Re: default mode of 'svn cleanup' changed

2017-07-24 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, 24 Jul 2017 14:09 +0200: > I have slightly changed the default mode of 'svn cleanup' in r1802797. > It will no longer remove unreferenced pristines from the pristine store. > > Instead, the new --vacuum-pristines option must be used, added in r1802787. > This runs the

default mode of 'svn cleanup' changed

2017-07-24 Thread Stefan Sperling
I have slightly changed the default mode of 'svn cleanup' in r1802797. It will no longer remove unreferenced pristines from the pristine store. Instead, the new --vacuum-pristines option must be used, added in r1802787. This runs the same operation under a working copy write lock. Note that the d