Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Julian Foad
On Mon, 2010-08-09, danie...@apache.org wrote: +/** Return TRUE if @a err's chain contains the error code @a apr_err. + * + * @since New in 1.7. + */ +svn_boolean_t +svn_error_has_cause(svn_error_t *err, apr_status_t apr_err); This looks like it could be a useful API. I would expect to

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Daniel Shahaf
(I intended to commit that to trunk) Julian Foad wrote on Tue, Aug 10, 2010 at 12:17:24 +0100: On Mon, 2010-08-09, danie...@apache.org wrote: +/** Return TRUE if @a err's chain contains the error code @a apr_err. + * + * @since New in 1.7. + */ +svn_boolean_t

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Julian Foad
On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: (I intended to commit that to trunk) Julian Foad wrote on Tue, Aug 10, 2010 at 12:17:24 +0100: On Mon, 2010-08-09, danie...@apache.org wrote: +/** Return TRUE if @a err's chain contains the error code @a apr_err. + * + *

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Daniel Shahaf
Julian Foad wrote on Tue, Aug 10, 2010 at 13:48:20 +0100: On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: I can see several options: * forbid passing SVN_NO_ERROR * return FALSE on SVN_NO_ERROR * reture (apr_err == APR_SUCCESS ? TRUE : FALSE) on SVN_NO_ERROR Right now, the

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Julian Foad
On Tue, 2010-08-10, Daniel Shahaf wrote: Julian Foad wrote on Tue, Aug 10, 2010 at 13:48:20 +0100: On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: I can see several options: * forbid passing SVN_NO_ERROR * return FALSE on SVN_NO_ERROR * reture (apr_err == APR_SUCCESS ?

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Daniel Shahaf
Julian Foad wrote on Tue, Aug 10, 2010 at 14:33:24 +0100: On Tue, 2010-08-10, Daniel Shahaf wrote: +++ subversion/libsvn_subr/error.c (working copy) @@ -274,9 +274,8 @@ { svn_error_t *child; - if (! err ! apr_err) -/* The API doesn't specify the behaviour when ERR is