Re: svn rm $URI mangles the commit-message-template

2014-07-04 Thread Ben Reser
On 7/4/14 2:15 PM, Mark Eichin wrote: > The irony I was trying to point out is that if it's been wrong this long, the > material beneath that line gets ignored by *human readers* as well as by the > code. I would guess that rm on URLs is a rare action and when it is done it's usually done with -m

Re: svn rm $URI mangles the commit-message-template

2014-07-04 Thread Ben Reser
On 7/4/14 2:23 PM, Mark Eichin wrote: > Ah, does that imply that it's far enough along that it doesn't need a ticket? > (or does it cause http://subversion.tigris.org/issues/show_bug.cgi?id=1199 to > be reopened, since that was, I assume, what introduced it?) No need for a ticket and Issue #1199

Re: svn rm $URI mangles the commit-message-template

2014-07-04 Thread Mark Eichin
On Thu, Jul 3, 2014 at 5:50 PM, Ben Reser wrote: > On 7/3/14 2:16 PM, Stefan Sperling wrote: > > Thanks for your report. > > > > This is definitely not intentional. I can reproduce this on 1.8.x but not > > on trunk. Not sure yet when it was fixed on trunk. > > This was resolved by my commit in r

Re: svn rm $URI mangles the commit-message-template

2014-07-04 Thread Mark Eichin
On Thu, Jul 3, 2014 at 6:24 PM, Daniel Shahaf wrote: > Mark Eichin wrote on Thu, Jul 03, 2014 at 14:59:30 -0400: > > 1.6 on ubuntu precise gets this right, 1.8 on trusty gets it wrong, the > > following repro script is from trusty: > > > > $ mkdir svnrmbug > > $ cd svnrmbug > > /home/eichin/tmp/s

Re: svn rm $URI mangles the commit-message-template

2014-07-03 Thread Daniel Shahaf
Mark Eichin wrote on Thu, Jul 03, 2014 at 14:59:30 -0400: > 1.6 on ubuntu precise gets this right, 1.8 on trusty gets it wrong, the > following repro script is from trusty: > > $ mkdir svnrmbug > $ cd svnrmbug > /home/eichin/tmp/svnrmbug > $ svnadmin create repo > $ U=file://$(pwd)/repo > $ svn mk

Re: svn rm $URI mangles the commit-message-template

2014-07-03 Thread Ben Reser
On 7/3/14 2:50 PM, Ben Reser wrote: > This was resolved by my commit in r1591123. It's currently nominated for > backport in the 1.8.x STATUS file and is currently missing one vote (stsp: > hint > hint). I probably should have mentioned this is a regression that started in 1.7.9, so there's also

Re: svn rm $URI mangles the commit-message-template

2014-07-03 Thread Ben Reser
On 7/3/14 2:16 PM, Stefan Sperling wrote: > Thanks for your report. > > This is definitely not intentional. I can reproduce this on 1.8.x but not > on trunk. Not sure yet when it was fixed on trunk. This was resolved by my commit in r1591123. It's currently nominated for backport in the 1.8.x ST

Re: svn rm $URI mangles the commit-message-template

2014-07-03 Thread Stefan Sperling
On Thu, Jul 03, 2014 at 02:59:30PM -0400, Mark Eichin wrote: > $ cat svn-commit.tmp > > --This line, and those below, will be ignored-- > > Dfile:///home/eichin/tmp/svnrmbug/repo/bugbranch > > Note specifically the URI to be deleted. (Ironically, I think it really > *does* get ignored, a co

svn rm $URI mangles the commit-message-template

2014-07-03 Thread Mark Eichin
1.6 on ubuntu precise gets this right, 1.8 on trusty gets it wrong, the following repro script is from trusty: $ mkdir svnrmbug $ cd svnrmbug /home/eichin/tmp/svnrmbug $ svnadmin create repo $ U=file://$(pwd)/repo $ svn mkdir --parents -m 'base' $U/{trunk,branches,tags,branches/me,tags/me} Commit