Brane:
I just read through this thread. Your proposal makes a lot of sense.
To me, it's one of those things that should go into a new version (not a
patch).
And there should be a nit-picky script to point out "strange stuff" (like
the example
that Julian posed).
Cheers.
Doug
On Mon, Dec 3,
Daniel Shahaf wrote:
> [...] write a script that:
> 1. Queries the repository for trunk revnums that have been merged to the
stable branch since the last tag;
See attached "svn-revs-backported.sh".
> 3. Synthesizes a CHANGES-like listing [...]
That's one reasonable option.
I do also wonder if
There are some important server fixes nominated for backport:
SVN-4791, an issue with the DAG open_path() (for 1.9, 1.10, 1.11)
SVN-4793, authz rights from inverted access selectors (for 1.10, 1.11)
I'd like to cut new releases around the new year.
Could anyone review these in the next week or
Brane:
I've decided that documenting the syntax of authz files at this level
> doesn't really belong in this document. So I started this:
>
> https://cwiki.apache.org/confluence/x/oYvQBQ
>
> and will refer to that page instead, pointing out the differences.
>
The statement "Section names are
Branko Čibej wrote:
> What inconsistencies? A canonical URI has the scheme and host name in
> lowercase, but the path, query, fragment and user info parts are case-
> sensitive.>
> Similarly, I think we (or APR?) make drive letters lowercase.
In both cases I found examples where is_canonical
On Fri, 14 Dec 2018, 18:14 Julian Foad Julian Foad wrote:
> > Are you willing to add random-input testing for them?
>
> The attached patch 'dirent-uri-test-random-2.patch' tests rules like:
>
> * every result should pass an X_is_canonical() test (obvious by code
> inspection);
> * every other
On Fri, 14 Dec 2018, 16:18 Julian Foad Branko Čibej wrote:
> > r1848943, for review. [...]
>
> Woo hoo! Thanks, Brane.
>
> Are you willing to add random-input testing for them?
>
> Minor comments:
> * the 'relpath' one is not needed because, AFAIK, it's possible to
> canonicalize any relpath
Julian Foad wrote:
> Are you willing to add random-input testing for them?
The attached patch 'dirent-uri-test-random-2.patch' tests rules like:
* every result should pass an X_is_canonical() test (obvious by code
inspection);
* every other input should produce
Branko Čibej wrote:
> r1848943, for review. [...]
Woo hoo! Thanks, Brane.
Are you willing to add random-input testing for them?
Minor comments:
* the 'relpath' one is not needed because, AFAIK, it's possible to
canonicalize any relpath and we already do;
* the non-canonical 'result' and
br...@apache.org wrote on Fri, Dec 14, 2018 at 14:55:43 -:
> Add new dirent, relpath and URI canonicalization functions that
> check and report canonicalization failures.
LGTM, nits below:
> @@ -473,6 +476,30 @@ const char *
> +/**
> + * Return a new @a *cannonical_dirent like @a dirent, but
On 13.12.2018 17:00, Branko Čibej wrote:
> On 13.12.2018 16:53, Michael Pilato wrote:
>> On 12/13/18 10:45 AM, Branko Čibej wrote:
>>> Uh. I forgot about the malfunction handler. However this doesn't really
>>> help, other than putting possibly sensitive paths into the crash handler
>>> info? We
On Fri, 14 Dec 2018, 05:41 Nathan Hartman On Thu, Dec 13, 2018 at 11:59 AM Branko Čibej wrote:
>
>> I never said that it's a good idea to abort in a library. We made a
>> mistake in the early days of this project to allow such patterns.
>
>
>>
>> I am quite angry at the contrariness and
12 matches
Mail list logo
