Re: SQLite and callbacks

2011-02-15 Thread Stefan Sperling
On Tue, Feb 15, 2011 at 03:35:43PM +, Hyrum K Wright wrote: I've not reviewed the patch, but to the question about bumping the wc format, I think you're safe to do so (so long as the upgrade code is properly implemented / tested, etc). The current working copy much more gracefully

Re: contribute for subversion project

2011-02-16 Thread Stefan Sperling
On Wed, Feb 16, 2011 at 11:58:24AM +0530, Kapila Witharana wrote: Hi, I'm Kapila, a student of Post Graduate Division of University of Colombo School of Computing (UCSC), University of Colombo, Sri Lanka. I'm now looking for a research level project (1 year) for my final year project. Could

Re: Bindings use is *painful*

2011-02-16 Thread Stefan Sperling
On Wed, Feb 16, 2011 at 03:08:39PM +, Hyrum K Wright wrote: I'm writing a script in which I simply want to retrieve a set of arbitrary log message and then do stuff with them. Using the Python bindings seemed like the logical choice (whether is was or not is now debatable, but that isn't

Re: svn commit: r1071330 - in /subversion/branches/1.6.x: ./ subversion/tests/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/ subversion/tests/libsvn_fs/ subversion/tests/libsvn_fs_base/

2011-02-16 Thread Stefan Sperling
On Wed, Feb 16, 2011 at 05:58:00PM -, hwri...@apache.org wrote: Author: hwright Date: Wed Feb 16 17:58:00 2011 New Revision: 1071330 URL: http://svn.apache.org/viewvc?rev=1071330view=rev Log: Merge r1051744, r1051745, r1053185, r1053241 from trunk, using the instructions Notes:

Re: SQLite and callbacks

2011-02-16 Thread Stefan Sperling
On Wed, Feb 16, 2011 at 02:26:51PM -0500, Mark Phippard wrote: 2011/2/16 Branko Čibej br...@e-reka.si: My not very humble opinion -- we can play silly buggers trying to optimize this bit of the query, but effort would be better spent in merging NODES and ACTUAL_NODE, which in turn would

Re: svnadmin hotcopy --incremental

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 10:54:38AM +, Philip Martin wrote: Somebody responsible for backing up a large FSFS repository asked me if it were possible to do an incremental hotcopy. An incremental hotcopy would update a previous hotcopy to the current HEAD and would only need to copy the rev

Re: svnadmin hotcopy --incremental

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 01:14:40PM +0200, Daniel Shahaf wrote: Stefan Sperling wrote on Thu, Feb 17, 2011 at 12:11:06 +0100: People are using rsync instead of hotcopy for this reason (and as long 'current' is copied first this is probably the best way of making incremental backups

Re: svnadmin hotcopy --incremental

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 01:26:55PM +0200, Daniel Shahaf wrote: Stefan Sperling wrote on Thu, Feb 17, 2011 at 12:29:09 +0100: On Thu, Feb 17, 2011 at 01:14:40PM +0200, Daniel Shahaf wrote: Stefan Sperling wrote on Thu, Feb 17, 2011 at 12:11:06 +0100: People are using rsync instead

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 12:47:32PM +0100, Stefan Küng wrote: Hi, The new function svn_wc__prop_list_recursive() provides a big performance gain for listing all properties of a full working copy. Currently I have to use svn_client_proplist3() to make use of that. But I'd like to have that

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 01:52:44PM +0100, Branko Čibej wrote: On 17.02.2011 13:39, Julian Foad wrote: Let me point out the background, in case you weren't aware. There has been a general feeling (especially during the WC re-write) that the WC API wasn't well suited to being maintained as a

Re: [PATCH] svn command - blame - multiple targets

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 06:30:05PM +0530, Noorul Islam K M wrote: This patch is a followup of the following thread. All tests pass with this patch. http://svn.haxx.se/dev/archive-2011-01/0210.shtml Log [[[ Make 'svn blame' continue processing targets after printing warning if one or

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 02:17:16PM +0100, Branko Čibej wrote: With a sane, useful public WC API you can at least think about plugging different WC backends ... someday. Same goes for the repos/fs separation. I'd say doing this now is premature optimisation. Especially because wc-ng isn't done

Re: htpasswd without apache

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 05:46:24AM -0800, Rego wrote: Hi, I'm trying to make a local repository (protocol svn://, without apache) works with a password file with htpasswd entries. But my svn does not recognize the passwords added there. How can I configure svn to make it work? Hello Rego,

Re: svn commit: r1033709 - /subversion/tests/cmdline/patch_tests.py

2011-02-17 Thread Stefan Sperling
On Thu, Feb 17, 2011 at 04:37:11PM -0500, Paul Burba wrote: On Tue, Feb 15, 2011 at 12:04 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Paul Burba wrote on Mon, Feb 14, 2011 at 17:36:43 -0500: 2011/2/10 Branko Čibej br...@e-reka.si: On 10.02.2011 20:25, Paul Burba wrote: Author:

Re: Inconsistent indentation in python code across code base

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 03:26:26PM +0530, Noorul Islam K M wrote: I think we have in consistent python indentation. I can see that we use 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea to stick to common indentation? I can fix it. Fixing ctypes-python will be

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: This patch reduces checkout by around 23 times. On my system the difference is 43 seconds vs. 30 seconds. We lose the ability to easily spot which of the subtest is failing if we do this. I.e. instead of: ... PASS:

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: Modify expected error string to use only error codes and also restrict one of the lines to less than 80 characters. Log [[[ * subversion/tests/cmdline/cat_tests.py (cat_local_directory, cat_remote_directory,

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 03:58:00PM +0530, Noorul Islam K M wrote: Stefan Sperling s...@elego.de writes: But I think there is value in seeing the error message in the test code. It makes it much easier for those reading the test code to follow what kind of error the test is expecting. If all

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 11:57:50AM +, Philip Martin wrote: Stefan Sperling s...@elego.de writes: On Mon, Feb 21, 2011 at 11:21:10AM +, Philip Martin wrote: Stefan Sperling s...@elego.de writes: But I think there is value in seeing the error message in the test code

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 12:19:34PM +, Philip Martin wrote: Stefan Sperling s...@elego.de writes: Fair enough, but why not write a specific test for this instead of testing it as a side effect of making the code of other tests harder to read? The assumption is that translation only

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 02:48:49PM -0500, Keith Palmer Jr. wrote: Nothing in what you just copy-pasted indicates whether it's *the actual data stream* that's being encrypted, or just the *authentication*. I need to know if the checked-out files that are being transferred are encrypted or

Re: svn commit: r1073325 - /subversion/trunk/contrib/client-side/svn_apply_autoprops.py

2011-02-22 Thread Stefan Sperling
On Tue, Feb 22, 2011 at 12:18:36PM -0500, C. Michael Pilato wrote: On 02/22/2011 08:51 AM, s...@apache.org wrote: Author: stsp Date: Tue Feb 22 13:51:16 2011 New Revision: 1073325 [...] In some situations users might want to use a different configuration file to configure a

Why does import fail with autoprops (inconsistent eol style)?

2011-02-22 Thread Stefan Sperling
When trying to 'svn import' files that have a mixed eol style, and at the same time using autoprops to set an svn:eol-style property with value 'native' on this file, svn import aborts with an Inconsistent line ending style error. Is there any specific reason for this? Can't we just normalize the

Re: Comments on 'notes/unicode-composition-for-filenames'

2011-02-22 Thread Stefan Sperling
On Tue, Feb 22, 2011 at 07:41:12PM +0100, Branko Čibej wrote: On 22.02.2011 18:17, Julian Foad wrote: Proposed Support Library Assumptions --- The main assumption is that we'll keep using APR for character set s/character set/character

Re: [PATCH] Remove dead code - was - Re: svn commit: r1067669

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 09:05:16AM +0100, Stefan Fuhrmann wrote: On 23.02.2011 06:47, Dongsheng Song wrote: Hi Donsheng, Thanks for your review. You are right that these two functions are not being used right now, but the integration-partial-getter and integration-is-cachable branches

Re: Why does import fail with autoprops (inconsistent eol style)?

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 05:56:13AM -0500, John Szakmeister wrote: On Wed, Feb 23, 2011 at 5:47 AM, Stefan Sperling s...@elego.de wrote: On Wed, Feb 23, 2011 at 04:56:03AM -0500, John Szakmeister wrote: On Tue, Feb 22, 2011 at 1:35 PM, Stefan Sperling s...@elego.de wrote: When trying

Re: [Issue 3818] fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 07:16:24AM -0600, Hyrum K Wright wrote: On Wed, Feb 23, 2011 at 7:10 AM, s...@tigris.org wrote: http://subversion.tigris.org/issues/show_bug.cgi?id=3818 User stsp changed the following:                What    |Old value                 |New value

initial thoughts on issue #3818

2011-02-23 Thread Stefan Sperling
I filed a new issue today (issue #3818, fix handling of externals in wc-ng http://subversion.tigris.org/issues/show_bug.cgi?id=3818). I had a brief chat with sbutler at the elego office before filing this issue. Below are basic ideas we've had for approaching the problem. Feedback appreciated!

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 04:26:52PM +, Julian Foad wrote: Hyrum K Wright wrote: On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad julian.f...@wandisco.com wrote: Stefan Sperling wrote: So, ideally, we should decouple the concept of a wcroot from the path. We could tie it to a wc_id

Re: initial thoughts on issue #3818

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 05:50:57PM +, Philip Martin wrote: Stefan Sperling s...@elego.de writes: Given a local_abspath, there's an ambiguity about which wcroots are associated with it when externals are involved. E.g. given the path was foo/bar/baz, where bar has an svn:externals

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 04:13:21PM +, Julian Foad wrote: We need a handle that we can pass around that references the whole nesting of WCs (where WC is defined as the scope of a single wcroot). That could be a new thing that we can invent, but I wonder if instead it would be reasonable to

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 12:46:44PM -0600, Hyrum K Wright wrote: On Wed, Feb 23, 2011 at 12:26 PM, Stefan Sperling s...@elego.de wrote: We need to preserve 1.6 semantics of how operations affect externals. Why? People have been wanting to commit across externals and working copies

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 08:52:18PM +0100, Bert Huijben wrote: I think just seeing every node below a workingcopy as a node in the parent working copy will make things harder instead of simpler. So I would suggest moving the redefining of normal externals to 1.8. (But I still think we have to

Re: svn commit: r1074461 - in /subversion/trunk: subversion/libsvn_subr/dirent_uri.c subversion/libsvn_wc/relocate.c tools/client-side/svnmucc/svnmucc.c

2011-02-25 Thread Stefan Sperling
On Fri, Feb 25, 2011 at 02:06:59PM +0200, Daniel Shahaf wrote: It was discussed a few months ago, conclusion was that the casts are necessary because they don't happen automatically for varargs functions (like apr_pstrcat()). Yes, see these, and other messages from the same thread, for

Re: found the PDH problem

2011-02-27 Thread Stefan Sperling
On Sun, Feb 27, 2011 at 02:34:44AM -0500, Greg Stein wrote: Hyrum, On IRC, we also talked about trying to remove stat() calls from the parse function. Upon reflection, that won't be possible. If the given path is below a wcroot, then we cannot simply return that wcroot. We need to see if

Re: [PATCH] Fix a bug introduced in r1071025.

2011-02-27 Thread Stefan Sperling
On Sun, Feb 27, 2011 at 10:55:55PM +1100, Gavin Beau Baumanis wrote: Ping. This patch submission has received no comments. Thanks Gavin. This has already been committed (r1072242). On 19/02/2011, at 2:28 PM, Noorul Islam K M wrote: Without the patch I get Segmentation fault when I

Re: [PATCH] Fix a bug introduced in r1071025.

2011-02-27 Thread Stefan Sperling
On Sun, Feb 27, 2011 at 11:40:47PM +1100, Gavin Beau Baumanis wrote: Thanks Stefan, I will remove it from my list. Why does this always remind of Earl Hickey? :)

Re: functions that would help TSVN

2011-03-01 Thread Stefan Sperling
On Mon, Feb 28, 2011 at 08:35:44PM +0100, Stefan Küng wrote: One other thing I'd like to discuss: currently all svn functions use streams and provide the data in callbacks to save memory. While I fully understand that, I'd like to have at least the svn_client_proplist() function to also

Re: functions that would help TSVN

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 01:20:20PM +0100, Stefan Küng wrote: Let me illustrate this a little bit: Assume: 1M properties in 100k folders svn_proplist recursive. Callback called 100k times for every callback: - svn lib allocates memory for the data - calls callback function, passes data -

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 11:59:28AM +0530, vijay wrote: [[[ Update log_access_verdict to make it work with httpd trunk as well as older versions. The function is being called with APLOG_MACRO in few places. The macro APLOG_MARK expands to 2 arguments till httpd-2.2.x but 3 arguments in

Re: [PATCH] Fix issue #3686 - executable bit not set during merge

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 07:24:56PM +1100, Gavin Beau Baumanis wrote: Ping. This submission has received no new comments. Thanks for the reminder. Committed in r1075802.

Re: [PATCH] issue #3719 fix slow large checkouts on Windows

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 02:01:34PM +, Neil Bird wrote: Around about 08/02/11 10:01, Neil Bird typed ... Just to re-iterate, what I've done is change svn_io_open_unique_file3() so that instead of just calling svn_io_open_uniquely_named() it is in fact a verbatim copy of

Re: [PATCH] issue #3719 fix slow large checkouts on Windows

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 04:42:28PM +0100, Stefan Sperling wrote: I will try backporting the trunk code to 1.6.x myself. If that gets anywhere then we can use it. Neil, can you try the attached patch, please? Thanks! Index: subversion/libsvn_subr/io.c

Re: [PATCH] issue #3719 fix slow large checkouts on Windows

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 04:43:47PM +, Neil Bird wrote: Around about 01/03/11 16:34, Stefan Sperling typed ... It's not perfect yet. There are regression test failures around setting file permissions for svn:needs-lock and svn:executable. Yes, I saw those. But the most interesting

Re: [PATCH] - Fix for issue #3792

2011-03-01 Thread Stefan Sperling
On Sat, Feb 05, 2011 at 12:55:55PM +0530, Noorul Islam K M wrote: Daniel Shahaf d...@daniel.shahaf.name writes: @@ -363,6 +364,9 @@ SVN_ERR(svn_cmdline_printf(pool, _(Copied From Rev: %ld\n), info-copyfrom_rev)); } + + if

Re: svn commit: r1075942 - in /subversion/trunk: notes/wc-ng/pristine-store subversion/libsvn_wc/wc_db.h subversion/libsvn_wc/wc_db_pristine.c subversion/tests/libsvn_wc/pristine-store-test.c

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 10:07:58PM +0300, Ivan Zhakov wrote: On Tue, Mar 1, 2011 at 20:47, julianf...@apache.org wrote: Author: julianfoad Date: Tue Mar  1 17:47:04 2011 New Revision: 1075942 URL: http://svn.apache.org/viewvc?rev=1075942view=rev Log: Make the pristine text store

Re: [PATCH] issue #3719 fix slow large checkouts on Windows

2011-03-02 Thread Stefan Sperling
On Wed, Mar 02, 2011 at 08:31:01AM +, Neil Bird wrote: Around about 01/03/11 17:13, Stefan Sperling typed ... Great! Here's a new version that includes a fix for the lock_tests failures. I'll propose this for backport now. Thanks for providing the initial patch submission

Re: [PATCH] Add --dry-run flag to svn update client command

2011-03-02 Thread Stefan Sperling
On Wed, Mar 02, 2011 at 04:17:33PM +0200, Daniel Shahaf wrote: Bert Huijben wrote on Wed, Mar 02, 2011 at 11:14:24 +0100: -Original Message- From: Arwin Arni [mailto:ar...@collab.net] Please review this and share your thoughts. I don't think this is the way we should

Re: [PATCH] - Fix for issue #3792

2011-03-03 Thread Stefan Sperling
On Thu, Mar 03, 2011 at 10:39:11PM +0530, Noorul Islam K M wrote: @@ -164,9 +171,18 @@ if (tmpinfo-depth == svn_depth_unknown) tmpinfo-depth = svn_depth_infinity; - SVN_ERR(svn_wc__node_get_schedule(tmpinfo-schedule, NULL, -wc_ctx,

Re: svn commit: r1076712 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc-queries.sql wc_db.c wc_db.h

2011-03-03 Thread Stefan Sperling
On Thu, Mar 03, 2011 at 07:48:22PM +0100, Stefan Sperling wrote: On Thu, Mar 03, 2011 at 01:40:55PM -0500, C. Michael Pilato wrote: On 03/03/2011 01:15 PM, s...@apache.org wrote: Author: stsp Date: Thu Mar 3 18:15:46 2011 New Revision: 1076712 URL: http://svn.apache.org/viewvc

Re: svn commit: r1076741 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc_db.c wc_db.h

2011-03-04 Thread Stefan Sperling
On Fri, Mar 04, 2011 at 11:10:17AM +, Philip Martin wrote: s...@apache.org writes: Author: stsp Date: Thu Mar 3 19:23:12 2011 New Revision: 1076741 URL: http://svn.apache.org/viewvc?rev=1076741view=rev Log: Another step towards eliminating use of the node walker in

Re: possible improvement to svn log with forward revision range

2011-03-07 Thread Stefan Sperling
On Mon, Mar 07, 2011 at 01:29:29PM +0100, Avalon wrote: For the svn log command the direction -r N:1 works fine - even if the resource does NOT exist in revision one. So in this case the resource is NOT checked to exist in both start and end revision. Ah, I think I see where your problem

Re: possible improvement to svn log with forward revision range

2011-03-08 Thread Stefan Sperling
On Tue, Mar 08, 2011 at 09:38:02AM +0200, Alan Barrett wrote: On Mon, 07 Mar 2011, Stefan Sperling wrote: I believe that users expect svn log -rREV1:REV2 path@PEG to mean report everything that happened to path@REV between revision REV1 and REV2, inclusive, with both creation

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

2011-03-08 Thread Stefan Sperling
On Tue, Mar 08, 2011 at 09:21:58AM +, John Beranek wrote: I guess from now on I'll just keep my investigations to myself. Please don't keep them to yourself. Any information you have might help. Just keep in mind that we're already looking at this in detail. E.g. detailed profiler output to

Re: svn commit: r1079008 - /subversion/trunk/subversion/svnadmin/main.c

2011-03-08 Thread Stefan Sperling
On Tue, Mar 08, 2011 at 01:46:23PM +, Philip Martin wrote: stef...@apache.org writes: Author: stefan2 Date: Mon Mar 7 22:57:04 2011 New Revision: 1079008 URL: http://svn.apache.org/viewvc?rev=1079008view=rev Log: Set FSFS cache default size to 16 MB. This is the same default

Re: svn commit: r1079008 - /subversion/trunk/subversion/svnadmin/main.c

2011-03-08 Thread Stefan Sperling
On Tue, Mar 08, 2011 at 02:15:06PM +, Philip Martin wrote: Stefan Sperling s...@elego.de writes: So I think it would be better if the cache was off by default, and must be enabled in a configuration file. I suppose svnserve and mod_dav_svn configuration files would be the best

Re: possible improvement to svn log with forward revision range

2011-03-08 Thread Stefan Sperling
On Tue, Mar 08, 2011 at 05:05:10PM +0100, Avalon wrote: There are now two different issues brought up in these thread: 1. For 'svn log -rX:Y PATH@PEG, where Y PEG, don't croak when PATH@Y doesn't exist. Instead, automatically substitute for Y the last revision in which PATH@THAT-REV *did*

Re: [PATCH] - Fix for issue #3792

2011-03-09 Thread Stefan Sperling
On Wed, Mar 09, 2011 at 10:51:19AM +0530, Noorul Islam K M wrote: I fixed the warning issue. Is there anything else do be done with this patch? Nothing, thank you. I've committed it in r1079758, but accidentally used the old version. r1079759 adds the braces again (sorry about that).

Re: [PATCH] Remove entry of test for issue #3792.

2011-03-09 Thread Stefan Sperling
On Wed, Mar 09, 2011 at 07:25:41PM +0530, Noorul Islam K M wrote: Log [[[ * notes/xfail-status: Remove entry of test for issue #3792. Test passes now. ]]] Thanks, committed in r1079803.

Re: svn commit: r1080253 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc_db.c wc_db.h

2011-03-10 Thread Stefan Sperling
On Thu, Mar 10, 2011 at 04:50:13PM +0100, Bert Huijben wrote: -Original Message- From: s...@apache.org [mailto:s...@apache.org] Sent: donderdag 10 maart 2011 16:43 To: comm...@subversion.apache.org Subject: svn commit: r1080253 - in /subversion/trunk/subversion/libsvn_wc:

Re: svn commit: r1080489 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2011-03-11 Thread Stefan Sperling
On Fri, Mar 11, 2011 at 12:17:38PM +0100, Branko Čibej wrote: On 11.03.2011 12:05, Greg Stein wrote: This is a great simplification, but it makes me wonder... how did that original version even get conceived? Looks like someone took a hint my NODES_CURRENT view but didn't understand why

Re: wc_db performance (was: wc_db API discussion)

2011-03-12 Thread Stefan Sperling
On Fri, Mar 11, 2011 at 10:43:46PM -0500, Greg Stein wrote: 2011/3/11 Branko Čibej br...@e-reka.si: ... For the second task, I think the first order of business is to change the wc-db tree crawler to do one query instead of zillions, or at least, where several queries are required, to do

Re: svn commit: r1081390 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

2011-03-14 Thread Stefan Sperling
On Mon, Mar 14, 2011 at 02:24:58PM -, kame...@apache.org wrote: Author: kameshj Date: Mon Mar 14 14:24:58 2011 New Revision: 1081390 URL: http://svn.apache.org/viewvc?rev=1081390view=rev Log: Adds an XFail test to catch regression created by r1075802 *

Re: [PATCH] Fix for issue 3787

2011-03-14 Thread Stefan Sperling
On Thu, Mar 10, 2011 at 04:49:32PM +0530, Noorul Islam K M wrote: From issue tracker (http://subversion.tigris.org/issues/show_bug.cgi?id=3787) It would be ever-so-helpful to folks looking to capture and replicate a working copy sparse checkouts configuration if 'svn info -R' would show

Re: wc_db performance

2011-03-14 Thread Stefan Sperling
On Mon, Mar 14, 2011 at 10:53:48AM -0400, C. Michael Pilato wrote: On 12.03.2011 13:47, Stefan Sperling wrote: For others who want to jump in and help, here is a list of places where the node walker is still being used. I'm not sure if we can eliminate it everywhere before release

Re: wc_db performance

2011-03-14 Thread Stefan Sperling
On Mon, Mar 14, 2011 at 05:05:39PM +0100, Stefan Sperling wrote: The concern seems to be that invoking a notification callback could attempt to modify DB state, correct? Which would deadlock if you invoke the callback after starting a transaction to tweak changelist information but before

Re: [PATCH] Add --dry-run flag to svn update client command

2011-03-14 Thread Stefan Sperling
On Mon, Mar 14, 2011 at 06:34:15PM +0200, Daniel Shahaf wrote: Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530: Unless there are no objection I will commit this patch post I receive a r1075802 regression fix(and testcase) from either Daniel Becroft or Arwin. Hold on, are

Re: svn commit: r1081390 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

2011-03-14 Thread Stefan Sperling
On Mon, Mar 14, 2011 at 02:24:58PM -, kame...@apache.org wrote: Author: kameshj Date: Mon Mar 14 14:24:58 2011 New Revision: 1081390 URL: http://svn.apache.org/viewvc?rev=1081390view=rev Log: Adds an XFail test to catch regression created by r1075802 *

Re: [PATCH] Add --dry-run flag to svn update client command

2011-03-14 Thread Stefan Sperling
On Mon, Mar 14, 2011 at 06:22:11PM +0100, Bert Huijben wrote: It adds an insane amount of conditionals. How are you going to test this and maintain it? The complexity of sourcecode increases by every conditional. The testing approach taken by Arwin seems solid enough in my book. I don't

Re: [PATCH] Add --dry-run flag to svn update client command

2011-03-14 Thread Stefan Sperling
On Mon, Mar 14, 2011 at 07:49:21PM +0200, 'Daniel Shahaf' wrote: I'd have expected this discussion to take place prior to anyone writing a patch. Whether or not the order of patch submission and discussion is a problem depends on the attitude of the person putting in the work. Arwin already

Re: [PATCH] Fix regression introduced in r1075802

2011-03-14 Thread Stefan Sperling
On Tue, Mar 15, 2011 at 07:33:06AM +1000, Daniel Becroft wrote: Hi, Below is a patch that fixes the regression introduced in r1075802. THe thread related to this regress can be found here: http://svn.haxx.se/dev/archive-2011-03/0145.shtml. Cheers, Daniel B. [[[ Fix regression

Re: wc_db performance

2011-03-15 Thread Stefan Sperling
On Tue, Mar 15, 2011 at 10:26:15AM +, Philip Martin wrote: Branko Čibej br...@e-reka.si writes: The restriction that you may not invoke a callback from within a sqlite transaction remains. That's what the temporary results tables are for -- they live outside transactions on the main

Re: applying hunks in svn patch

2009-11-18 Thread Stefan Sperling
On Wed, Nov 18, 2009 at 10:03:05AM +, Julian Foad wrote: Alan Barrett wrote: By the way, patch(1) is described in http://www.opengroup.org/onlinepubs/009695399/utilities/patch.html. The algorithm described under Patch Application there is the minimal requirement, and is really simple

Re: applying hunks in svn patch

2009-11-18 Thread Stefan Sperling
On Wed, Nov 18, 2009 at 03:24:10PM +0200, Daniel Shahaf wrote: In this case, how about losing the GROUP BY hunk from the sort? i.e., BIG_LIST = [] for each hunk: for each candidate in hunk: compute a score for candidate BIG_LIST.append(candidate)

Re: applying hunks in svn patch

2009-11-18 Thread Stefan Sperling
On Wed, Nov 18, 2009 at 08:47:51AM +0200, Alan Barrett wrote: On Mon, 16 Nov 2009, Stefan Sperling wrote: 5) Hunks are only applied if they do not overlap with any other hunk. Other patch implementations are able to deal with overlapping hunks. For example, consider this pair of hunks

Re: [RFC] checkout --view name URL

2009-11-20 Thread Stefan Sperling
On Fri, Nov 20, 2009 at 05:36:13AM +0100, Martin Furter wrote: So multiple views can be active at the same time within the same WC? Would this not complicate things a bit too much? No, they are not 'active in a working' copy, they're not registered there. The view just describes what

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-23 Thread Stefan Sperling
On Mon, Nov 23, 2009 at 07:16:49AM -0600, Hyrum K. Wright wrote: On Nov 23, 2009, at 3:03 AM, Stefan Sperling wrote: Speaking of which, rm -f $(CLEAN_FILES) could also end up being too long on certain types of UNIX. So maybe put .pycs into a different list. Or if we can find out the minimum

Re: r40202 broke commit over ra_neon (Re: svn commit: r40202 - trunk/subversion/libsvn_ra_neon)

2009-11-26 Thread Stefan Sperling
On Mon, Nov 23, 2009 at 11:32:51AM +0530, Kannan wrote: [[[ Log: Make a proper fix to resolve some deprecation warnings using `svn_path_url_add_component2()' by canonicalizing the base before passing to the above method; and a minor indentation fix. [in subversion/libsvn_ra_neon] *

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 01:53:31PM -, Jon Foster wrote: But it only works if the synsync processes run on the host where the target repository is located (i.e. you have to run synsync pulls from a cronjob on the mirror, rather than triggering svnsync pushes from a post-commit hook).

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 01:42:58PM +, Philip Martin wrote: Stefan Sperling s...@elego.de writes: Would it be reasonable to add a --local-lock-file FILENAME option to svnsync, which would turn off the current locking and use file locking instead? If so, I can work on a patch to do

Re: An analysis of possible tree conflicts during update

2009-12-02 Thread Stefan Sperling
On Wed, Dec 02, 2009 at 08:53:00AM +0100, Daniel Näslund wrote: [[[ * When svn update or svn switch raises a tree conflict, it shall update the victim's base version from OLD to THEIRS, and leave the working version in a state that would be committable (but for the explicit check that

Re: An analysis of possible tree conflicts during update

2009-12-02 Thread Stefan Sperling
On Wed, Dec 02, 2009 at 12:57:31PM +, Julian Foad wrote: 1. Locale add, incoming add [...] - I was doing roughly the same thing but the item is a bit different. - merge the two items - manual 2-way merge (or 3-way if both are w/hist and it's the same copy-from source) -

Re: Email archives

2009-12-09 Thread Stefan Sperling
On Wed, Dec 09, 2009 at 01:10:54PM +, Julian Foad wrote: MARC ARCHIVE MARC http://marc.info/?l=subversion-dev looks OK. Completeness: It has Subversion archives up to a year ago, and could probably be updated. Worthy of further investigation. I like marc.info a lot. The UI is simple and

Re: svn commit: r888979 - in /subversion/trunk/subversion: libsvn_repos/load.c tests/cmdline/svnadmin_tests.py

2009-12-09 Thread Stefan Sperling
On Wed, Dec 09, 2009 at 09:24:20PM -, cmpil...@apache.org wrote: Author: cmpilato Date: Wed Dec 9 21:24:19 2009 New Revision: 888979 URL: http://svn.apache.org/viewvc?rev=888979view=rev Log: Fix issue #3547 - 'svnadmin load --parent-dir PATH' can destroy mergeinfo + /* The

Re: [PATCH] Replace two deprecated wc functions

2009-12-17 Thread Stefan Sperling
On Thu, Dec 17, 2009 at 08:40:15PM +0100, Daniel Näslund wrote: Hi! NOTE: This patch depends on my patch for #3390 that has not been commited yet [1]. The external_func uses abspaths and that is fixed in the referred patch. I have two more patches that depend on [1]. make check passes

Re: svn commit: r884250 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2009-12-21 Thread Stefan Sperling
On Wed, Nov 25, 2009 at 09:15:03PM +, Philip Martin wrote: Stefan Sperling s...@elego.de writes: On Wed, Nov 25, 2009 at 03:51:43PM -0500, Mark Phippard wrote: On Wed, Nov 25, 2009 at 3:27 PM, s...@apache.org wrote: Author: stsp Date: Wed Nov 25 20:27:38 2009 New Revision

Re: svn commit: r884250 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2009-12-21 Thread Stefan Sperling
On Mon, Dec 21, 2009 at 05:38:28PM +0100, Bert Huijben wrote: -Original Message- From: Julian Foad [mailto:julianf...@btopenworld.com] Sent: maandag 21 december 2009 16:51 To: Bert Huijben Cc: 'Stefan Sperling'; 'Philip Martin'; 'Mark Phippard'; dev@subversion.apache.org

Re: 1.6.7 up for signing/testing

2009-12-24 Thread Stefan Sperling
On Thu, Dec 24, 2009 at 10:40:51AM +0100, Bert Huijben wrote: -Original Message- From: Bhuvaneswaran A [mailto:bhu...@collab.net] Sent: donderdag 24 december 2009 5:15 To: Hyrum K. Wright Cc: Subversion Development Subject: Re: 1.6.7 up for signing/testing On Wed,

Re: new substitution keyword for global repository revision

2009-12-24 Thread Stefan Sperling
On Thu, Dec 24, 2009 at 04:44:24PM +0100, Christian Schoenebeck wrote: On Thursday 24 December 2009 15:59:38 Stefan Sperling wrote: What if I do an update which should not update the working copy root, such as svn update somefile? Then you have a mixed revision working copy. To address

Re: new substitution keyword for global repository revision

2009-12-26 Thread Stefan Sperling
On Thu, Dec 24, 2009 at 06:39:17PM +0100, Christian Schoenebeck wrote: On Thursday 24 December 2009 17:00:00 Stefan Sperling wrote: What problem do you really want to solve with this? Why is svnversion not good enough for your problem? Since svnversion is a separate application, it has

Re: 1.6.7 up for signing/testing

2009-12-26 Thread Stefan Sperling
On Wed, Dec 23, 2009 at 09:35:23AM -0600, Hyrum K. Wright wrote: A little late, but never never, here's the promised tarballs for Subversion 1.6.7. The magic revision is r893529, and you can find the tarballs here: http://orac.ece.utexas.edu/pub/svn/1.6.7/ Not sure if we care, but

Re: 1.6.7 up for signing/testing

2009-12-26 Thread Stefan Sperling
On Wed, Dec 23, 2009 at 09:35:23AM -0600, Hyrum K. Wright wrote: A little late, but never never, here's the promised tarballs for Subversion 1.6.7. The magic revision is r893529, and you can find the tarballs here: http://orac.ece.utexas.edu/pub/svn/1.6.7/ Please be sure to test the

client-side hooks (was: Re: new substitution keyword for global repository revision)

2009-12-27 Thread Stefan Sperling
On Sat, Dec 26, 2009 at 06:08:15PM +0100, Branko Čibej wrote: Every couple of years someone comes up with a proposal like this, and it usually ends with a client-side hooks idea. Beh. Subversion is a version control system, not a build systam. If you want current global revision to label your

Re: client-side hooks

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 06:38:32AM +0100, Branko Čibej wrote: Stefan Sperling wrote: Client-side hooks can do very interesting things. I've seen people pick TortoiseSVN as their only client because it has this feature. Just like server-side hooks, it allows for a higher degree

Re: [PATCH] v5 Fix #3390 Relative externals not updated during switch

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 03:36:46PM +0100, Daniel Näslund wrote: + /* If we're doing an 'svn export' the current dir will not be a + working copy. We can't get the parent_dir. */ + if (err err-apr_err == SVN_ERR_WC_NOT_WORKING_COPY) +{ + if (err-apr_err ==

Re: svn trunk r894053: FAIL (x64-ubuntu gcc)

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 11:25:29AM -0800, Joe Swatosh wrote: This buildbot is still failing the build before the tests are even run. Something to do with libtool? /usr/share/apr-1.0/build/libtool: line 970: none: command not found make: *** [subversion/bindings/swig/ruby/svn_client.lo] Error

Re: Subversion in 2010

2010-01-04 Thread Stefan Sperling
On Mon, Jan 04, 2010 at 01:01:14PM -0500, Mark Mielke wrote: Again, I appreciate the unique difficulties that the Subversion architecture introduces, and I appreciate the efforts done so far - merge tracking in 1.5, tree conflict resolution in 1.6 - but this area still needs work. I'd be

Re: Subversion in 2010

2010-01-04 Thread Stefan Sperling
On Mon, Jan 04, 2010 at 01:17:51PM -0500, Mark Phippard wrote: On Mon, Jan 4, 2010 at 1:01 PM, Mark Mielke m...@mark.mielke.cc wrote: Another related area of limitation here is the reintegrate. This seems fundamentally broken to me. That the branch needs to be removed and re-created in

Re: Subversion in 2010

2010-01-04 Thread Stefan Sperling
On Mon, Jan 04, 2010 at 01:45:07PM -0500, Mark Mielke wrote: On 01/04/2010 01:25 PM, Stefan Sperling wrote: On Mon, Jan 04, 2010 at 01:01:14PM -0500, Mark Mielke wrote: Again, I appreciate the unique difficulties that the Subversion architecture introduces, and I appreciate the efforts done so

Re: Roadmap for 1.7 end game?

2010-01-04 Thread Stefan Sperling
On Thu, Dec 17, 2009 at 06:18:28PM +0100, Stefan Sperling wrote: On Thu, Dec 17, 2009 at 06:12:43PM +0100, Stefan Sperling wrote: I still have some work to do for svn patch. The current hunk-application code ends up ignoring valid hunks in certain situations. I already know how I want

<    1   2   3   4   5   6   7   8   9   10   >