[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-08 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371659614 @williaster @john-bodley I've pushed the change to make coloring turned on as default. Thanks for reviewing the

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-08 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371598370 @williaster I've made red channel = 150 and it does look better. Here's aligning to the left. Actually I remember

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-08 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371549279 @john-bodley @williaster Since I think the best viz type depends on context, I've simply added options: `Right

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-08 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371425925 Maybe I'm just used to [domain coloring ](https://en.wikipedia.org/wiki/Domain_coloring) since I think negative

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-07 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371391243 @john-bodley @williaster Comparison with multiple columns. After playing around for a while I feel they both have

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-07 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371391243 @john-bodley @williaster Comparison with multiple columns. After playing around with it for a while I feel they

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-07 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371374038 @john-bodley @williaster Thanks for the suggestion. I experimented with this idea but turns out the major issue is

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-07 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371374038 @john-bodley @williaster Thanks for the suggestion. I experimented with this idea but turns out the major issue is

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-07 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371374038 @john-bodley @williaster Thanks for the suggestion. I experimented with this idea but turns out the major issue is

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

2018-03-07 Thread GitBox
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371374038 @john-bodley @williaster Thanks for the suggestion. I experimented with this idea but turns out the major issue is