date:20180312

[GitHub] geekSnails opened a new issue #4600: the size of slices in dashboard is too small

2018-03-12 Thread GitBox

geekSnails opened a new issue #4600: the size of slices in dashboard is too 
small 
URL: https://github.com/apache/incubator-superset/issues/4600
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version 
of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.23.2
   
   when superset upgraded to 0.23.2, the dashboard shows not normally.
   for the example, the World's Bank Date Dashboard:
   ### Expected results
   
![image](https://user-images.githubusercontent.com/26055737/37281567-77659ff6-262c-11e8-9bbc-190da9a83d4b.png)
   
   ### Actual results
   
![image](https://user-images.githubusercontent.com/26055737/37281522-46c10f3e-262c-11e8-8f3d-16464448437a.png)
   
   ### Steps to reproduce
   upgraded to 0.23.2,the older version shows ok, and the new version shows not 
normally
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[DRAFT] Incubator PMC Board Report - March 2018

2018-03-12 Thread John D. Ament

All,

Below is the current draft of the Incubator board report.  We are still
missing reports from many podlings, and several missing sign off.  I have
CC'd the podlings missing sign off, and separately notified the ones
missing reports.

John

Incubator PMC report for March 2018

The Apache Incubator is the entry path into the ASF for projects and
codebases wishing to become part of the Foundation's efforts.

There are currently 54 podlings under incubation.  We added 1 new IPMC
member, 3 new podlings and executed on 4 releases.  The HTrace report
indicates retirement in flight.

* Community

  New IPMC members:

  - Timothy Chen

  People who left the IPMC:



* New Podlings

  - Druid
  - Dubbo
  - Nemo

* Podlings that failed to report, expected next month

  - Gearpump
  - Milagro
  - OpenWhisk
  - Pony Mail
  - Quickstep

* Podling Reports Missing Sign off
  - Hivemall
  - Myriad
  - Samoa
  - Service Comb
  - SINGA
  - Slider
  - Spot
  - Superset

* Graduations

  The board has motions for the following:

  - Your podling here?
  - Your podling here?

* Releases

  The following releases entered distribution during the month of
  February:

  - 2018-02-05 Apache Livy 0.5.0
  - 2018-02-15 Apache Netbeans 9.0 beta
  - 2018-02-19 Apache PonyMail 0.10.0
  - 2018-02-19 Apache MXNet 1.1.0

* IP Clearance



* Legal / Trademarks

  - See Daffodil's report related to open legal questions.
  - See SkyWalking's report for open questions around optional modules
under discussion on legal lists.

* Infrastructure



* Miscellaneous



* Credits

--
   Table of Contents
AriaTosca
Crail
Druid
Dubbo
ECharts
Gearpump
Griffin
Hivemall
HTrace
Milagro
Myriad
Nemo
Omid
OpenWhisk
PLC4X
Pony Mail
Pulsar
Quickstep
SAMOA
ServiceComb
SINGA
SkyWalking
Slider
Spot
Superset
Taverna
Tephra

--


AriaTosca

ARIA TOSCA project offers an easily consumable Software Development Kit(SDK)
and a Command Line Interface(CLI) to implement TOSCA(Topology and
Orchestration Specification of Cloud Applications) based solutions.

AriaTosca has been incubating since 2016-08-27.

Three most important issues to address in the move towards graduation:

  1. Grow the community and enroll new committers.
  2. Have (more) frequent Release cycles to be compliant with the Apache
Way.
  3. Grow the project’s contributions from existing community of
contributors

Any issues that the Incubator PMC (IPMC) or ASF Board wish/need to be
aware of?

1. The project issued its third release (0.2.0) as far as the code is
concerned.  Some considerable functionality has been added since the last
release in addition to a growth in diversity of contributions.

How has the community developed since the last report?

* All project communication now takes place on either the mailing list or
ASF's Slack, and is open for everybody.  We have worked hard to make this
the normal operating mode of the community. There have been some hiccups,
but in general the majority of discourse has taken place on the list.

 * Increased chatter on the mailing list including new subscribers who ask
questions, make suggestions and are likely to become contributors
themselves in the near future.

* Weekly grooming meetings are now attended by the majority of the
community. This is not only a forum to review the weekly work items list,
but also as a place for open discussion about issues, questions as well as
for the community to get to better know each other.


How has the community developed since the last report?

Over the last 3 months we have seen a significant increase in contributions
as well as a few new contributors, particularly from the Ericsson
contingent.


How has the project developed since the last report?

ARIA now has two new patches considerably extend the parser's
plugin/extensions

Website and documentation improvements for usability and to enhance new
user Usability in terms of “getting started” instructions

9 JIRA issues have been resolved since the last report.  Note that the
repository was locked for several weeks during this period due to release
process issues and learning curve.

We will be doing another release during this quarter.

The community has begun to undertake updating AriaTosca to support the
Tosca 1.1 Simple YAML profile.


How would you assess the podling's maturity?
Please feel free to add your own commentary.

  [ ] Initial setup
  [ ] Working towards first release
  [X] Community building
  [ ] Nearing graduation
  [ ] Other:

Date of last release:

  The 0.2.0 release was issued on January 16, 2018.  The .3 release is
planned for this quarter.

When were the last committers or PPMC members elected?

Tom Nadeau was added to the PMC/committers on 11/28/2017

Signed-off-by:

  [X](ariatosca) Suneel Marthi
 Comments: Podling needs to focus on growing the community and a more

Re: Apache Superset Committer Meeting Notes

2018-03-12 Thread Stephanie Rivera

Hi Jeff et al,

I am interested in joining. We have begun to use Superset here at SpotX and
my data engineering team is beginning to build out features for Superset.
We do not have anything complete enough to commit yet. Mostly the team has
been learning the framework and models as to determine the best way to
implement features instep with the current codebase.

Cheers,

Stephanie


*Stephanie Rivera* |* Sr. Director of Data Intelligence*

8181 Arista Place | Suite 300 | Broomfield, CO 80021 | Westminster, CO 80020
ph: 303.345.6650 | cell: 970.690.6904 | spotx.tv 






On Mon, Mar 12, 2018 at 12:43 AM, Nishant Bangarwa <
nbanga...@hortonworks.com> wrote:

> He Jeff,
> I work in IST timezone and would love to be part of these meetings.
> Please add me.
>
> Also, is it possible to have the meeting little early as it will be too
> late for me.
>
> --
> Nishant Bangarwa
> Hortonworks
> (M): +91-9729200044
>
>
>
>
>
>
> On 3/12/18, 10:31 AM, "Jeff Feng"  wrote:
>
> >Apache Superset Community,
> >
> >The bulk of the committers on the Superset project from Airbnb & Lyft, as
> >well as a few active contributors from Twitter have been meeting every 2
> >weeks on Friday from 12-1:30 pm PDT at Airbnb to discuss and advance the
> >project.
> >
> >In an effort to provide transparency, we are sharing the notes from the
> >meeting:
> >
> >https://docs.google.com/document/d/1R8zKt8KCcOmKEdSHQshuj2DCChSyF
> 41ehlqkRWOUDUA/edit?usp=sharing
> >
> >Additionally, if you would like to join the meetings via WebEx, please let
> >me know and I will add you to the invite.  The next meeting will be Friday
> >3/23 from 12-1:30 pm PDT.
> >
> >Cheers,
> >Jeff
>

[GitHub] brylie commented on issue #4193: Init docker for local development environment.

2018-03-12 Thread GitBox

brylie commented on issue #4193: Init docker for local development environment.
URL: 
https://github.com/apache/incubator-superset/pull/4193#issuecomment-372336673
 
 
   @xiaohanyu, any status update here?
   
   Perhaps we can compromise and put these files in a `docker` folder, so it is 
explicit what they are for?
   
   Having a Docker container would really make this project more viable for 
several reasons, notably development and deployment. By way of example, we have 
deployed Metabase and Redash recently on AWS using their Docker images.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xiaohanyu commented on issue #4193: Init docker for local development environment.

2018-03-12 Thread GitBox

xiaohanyu commented on issue #4193: Init docker for local development 
environment.
URL: 
https://github.com/apache/incubator-superset/pull/4193#issuecomment-372337404
 
 
   @brylie I'll update the status this week. Just come back to work from this 
week. Sorry for the delay.
   
   Think can put it to a `contrib/docker` folder.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Apache Superset Committer Meeting Notes

2018-03-12 Thread Jim Jagielski

Is it possible to have rotating meetings? Although such
meetings can be useful, they also have the disadvantage to
disenfranchise large segments of the current and potential
community, especially as the meetings become more popular
and seen as "the" way of communicating and development.

It is great that the notes from the meetings are posted in public,
but we also want to ensure that anyone and everyone that wants
to participate, and achieve merit, have equal opportunities to
do so.

> On Mar 12, 2018, at 9:54 AM, Stephanie Rivera  wrote:
> 
> Hi Jeff et al,
> 
> I am interested in joining. We have begun to use Superset here at SpotX and
> my data engineering team is beginning to build out features for Superset.
> We do not have anything complete enough to commit yet. Mostly the team has
> been learning the framework and models as to determine the best way to
> implement features instep with the current codebase.
> 
> Cheers,
> 
> Stephanie
> 
> 
> *Stephanie Rivera* |* Sr. Director of Data Intelligence*
> 
> 8181 Arista Place | Suite 300 | Broomfield, CO 80021 | Westminster, CO 80020
> ph: 303.345.6650 | cell: 970.690.6904 | spotx.tv 
> 
> 
> 
> 
> 
> 
> On Mon, Mar 12, 2018 at 12:43 AM, Nishant Bangarwa <
> nbanga...@hortonworks.com> wrote:
> 
>> He Jeff,
>> I work in IST timezone and would love to be part of these meetings.
>> Please add me.
>> 
>> Also, is it possible to have the meeting little early as it will be too
>> late for me.
>> 
>> --
>> Nishant Bangarwa
>> Hortonworks
>> (M): +91-9729200044
>> 
>> 
>> 
>> 
>> 
>> 
>> On 3/12/18, 10:31 AM, "Jeff Feng"  wrote:
>> 
>>> Apache Superset Community,
>>> 
>>> The bulk of the committers on the Superset project from Airbnb & Lyft, as
>>> well as a few active contributors from Twitter have been meeting every 2
>>> weeks on Friday from 12-1:30 pm PDT at Airbnb to discuss and advance the
>>> project.
>>> 
>>> In an effort to provide transparency, we are sharing the notes from the
>>> meeting:
>>> 
>>> https://docs.google.com/document/d/1R8zKt8KCcOmKEdSHQshuj2DCChSyF
>> 41ehlqkRWOUDUA/edit?usp=sharing
>>> 
>>> Additionally, if you would like to join the meetings via WebEx, please let
>>> me know and I will add you to the invite.  The next meeting will be Friday
>>> 3/23 from 12-1:30 pm PDT.
>>> 
>>> Cheers,
>>> Jeff
>>

[GitHub] fabianmenges commented on a change in pull request #4593: [sql lab] reduce the number of metadata calls when loading a table

2018-03-12 Thread GitBox

fabianmenges commented on a change in pull request #4593: [sql lab] reduce the 
number of metadata calls when loading a table
URL: 
https://github.com/apache/incubator-superset/pull/4593#discussion_r173848660
 
 

 ##
 File path: superset/db_engine_specs.py
 ##
 @@ -235,14 +235,15 @@ def where_latest_partition(
 
 @classmethod
 def select_star(cls, my_db, table_name, schema=None, limit=100,
-show_cols=False, indent=True, latest_partition=True):
+show_cols=False, indent=True, latest_partition=True,
+cols=None):
 fields = '*'
-cols = []
-if show_cols or latest_partition:
+cols = cols or []
+if (show_cols or latest_partition) and not cols:
 cols = my_db.get_table(table_name, schema=schema).columns
 
 if show_cols:
-fields = [my_db.get_quoter()(c.name) for c in cols]
+fields = [my_db.get_quoter()(c.get('name')) for c in cols]
 
 Review comment:
   Why did this line change? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jeffreythewang commented on issue #4520: Allow users to view dashboards they own

2018-03-12 Thread GitBox

jeffreythewang commented on issue #4520: Allow users to view dashboards they own
URL: 
https://github.com/apache/incubator-superset/pull/4520#issuecomment-372383192
 
 
   Any updates on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID is defined

2018-03-12 Thread GitBox

codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID 
is defined
URL: 
https://github.com/apache/incubator-superset/pull/4573#issuecomment-371409484
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=h1)
 Report
   > Merging 
[#4573](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/2bc089ef8dcec5d98a43cb2ec80aacf1cdc706cf?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4573/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4573  +/-   ##
   ==
   + Coverage   71.18%   71.18%   +<.01% 
   ==
 Files 189  189  
 Lines   1484514846   +1 
 Branches 1086 1086  
   ==
   + Hits1056710568   +1 
 Misses   4275 4275  
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4573/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.46%  (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=footer).
 Last update 
[2bc089e...26257d9](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID is defined

2018-03-12 Thread GitBox

codecov-io commented on issue #4573: [cache] Ensuring that the datasource UID 
is defined
URL: 
https://github.com/apache/incubator-superset/pull/4573#issuecomment-371409484
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=h1)
 Report
   > Merging 
[#4573](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/2bc089ef8dcec5d98a43cb2ec80aacf1cdc706cf?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4573/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4573  +/-   ##
   ==
   + Coverage   71.18%   71.18%   +<.01% 
   ==
 Files 189  189  
 Lines   1484514846   +1 
 Branches 1086 1086  
   ==
   + Hits1056710568   +1 
 Misses   4275 4275  
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4573/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.46%  (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=footer).
 Last update 
[2bc089e...26257d9](https://codecov.io/gh/apache/incubator-superset/pull/4573?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4593: [sql lab] reduce the number of metadata calls when loading a table

2018-03-12 Thread GitBox

mistercrunch commented on a change in pull request #4593: [sql lab] reduce the 
number of metadata calls when loading a table
URL: 
https://github.com/apache/incubator-superset/pull/4593#discussion_r173887476
 
 

 ##
 File path: superset/db_engine_specs.py
 ##
 @@ -235,14 +235,15 @@ def where_latest_partition(
 
 @classmethod
 def select_star(cls, my_db, table_name, schema=None, limit=100,
-show_cols=False, indent=True, latest_partition=True):
+show_cols=False, indent=True, latest_partition=True,
+cols=None):
 fields = '*'
-cols = []
-if show_cols or latest_partition:
+cols = cols or []
+if (show_cols or latest_partition) and not cols:
 cols = my_db.get_table(table_name, schema=schema).columns
 
 if show_cols:
-fields = [my_db.get_quoter()(c.name) for c in cols]
+fields = [my_db.get_quoter()(c.get('name')) for c in cols]
 
 Review comment:
   Good catch, turns out I had inconsistent ways to get the column information 
here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4593: [sql lab] reduce the number of metadata calls when loading a table

2018-03-12 Thread GitBox

mistercrunch commented on issue #4593: [sql lab] reduce the number of metadata 
calls when loading a table
URL: 
https://github.com/apache/incubator-superset/pull/4593#issuecomment-372406484
 
 
   Let me add a unit test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4595: sqllab: preview should quote table name

2018-03-12 Thread GitBox

xrmx commented on issue #4595: sqllab: preview should quote table name
URL: 
https://github.com/apache/incubator-superset/issues/4595#issuecomment-372406885
 
 
   If someone can give me an hint at where the query is sent to the frontend i 
can give take a look at fixing it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4593: [sql lab] reduce the number of metadata calls when loading a table

2018-03-12 Thread GitBox

codecov-io commented on issue #4593: [sql lab] reduce the number of metadata 
calls when loading a table
URL: 
https://github.com/apache/incubator-superset/pull/4593#issuecomment-372095936
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=h1)
 Report
   > Merging 
[#4593](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/f9881101ee9cd447f7ccb2d38bc7563f31f686c5?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `91.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4593/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4593  +/-   ##
   ==
   - Coverage   71.17%   71.15%   -0.02% 
   ==
 Files 188  189   +1 
 Lines   1483414846  +12 
 Branches 1086 1086  
   ==
   + Hits1055810564   +6 
   - Misses   4273 4279   +6 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.7% <0%> (?)` | :arrow_up: |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `51.61% <100%> (-0.64%)` | :arrow_down: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.16% <100%> (-0.05%)` | :arrow_down: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `87.83% <0%> (-0.29%)` | :arrow_down: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.45% <0%> (?)` | :arrow_up: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `100% <0%> (?)` | |
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `76.28% <0%> (+0.03%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=footer).
 Last update 
[f988110...99dc019](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida opened a new pull request #4601: Instantiate ChartContainer with width

2018-03-12 Thread GitBox

betodealmeida opened a new pull request #4601: Instantiate ChartContainer with 
width
URL: https://github.com/apache/incubator-superset/pull/4601
 
 
   Property `width` is not being passed properly when instantiating a 
`ChartContainer`. This results in an error when switching the viz type from 
scatterplot to line chart (and others). This PR fixes it:
   
   
![switch](https://user-images.githubusercontent.com/1534870/37305804-f14e6cc4-25f2-11e8-920a-91deeec0979f.gif)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida closed pull request #4601: Instantiate ChartContainer with width

2018-03-12 Thread GitBox

betodealmeida closed pull request #4601: Instantiate ChartContainer with width
URL: https://github.com/apache/incubator-superset/pull/4601
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx 
b/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx
index bfb24fff7f..1ccab1afa3 100644
--- a/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx
+++ b/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx
@@ -44,6 +44,7 @@ class ExploreChartPanel extends React.PureComponent {
 datasource={this.props.datasource}
 formData={this.props.form_data}
 height={this.getHeight()}
+width={parseInt(this.props.width, 10)}
 slice={this.props.slice}
 chartKey={this.props.chart.chartKey}
 setControlValue={this.props.actions.setControlValue}


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on issue #4601: Instantiate ChartContainer with width

2018-03-12 Thread GitBox

betodealmeida commented on issue #4601: Instantiate ChartContainer with width
URL: 
https://github.com/apache/incubator-superset/pull/4601#issuecomment-372439650
 
 
   This is broken, the width is too big. Will fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4601: Instantiate ChartContainer with width

2018-03-12 Thread GitBox

codecov-io commented on issue #4601: Instantiate ChartContainer with width
URL: 
https://github.com/apache/incubator-superset/pull/4601#issuecomment-372443272
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=h1)
 Report
   > Merging 
[#4601](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/2bc089ef8dcec5d98a43cb2ec80aacf1cdc706cf?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4601/graphs/tree.svg?src=pr&width=650&token=KsB0fHcx6l&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4601   +/-   ##
   ===
 Coverage   71.18%   71.18%   
   ===
 Files 189  189   
 Lines   1484514845   
 Branches 1086 1086   
   ===
 Hits1056710567   
 Misses   4275 4275   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...vascripts/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=)
 | `0%  (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=footer).
 Last update 
[2bc089e...93e7f28](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida opened a new pull request #4601: Only show overlay if container is set

2018-03-12 Thread GitBox

betodealmeida opened a new pull request #4601: Only show overlay if container 
is set
URL: https://github.com/apache/incubator-superset/pull/4601
 
 
   Property `width` is not being passed properly when instantiating a 
`ChartContainer`. This results in an error when switching the viz type from 
scatterplot to line chart (and others). This PR fixes it:
   
   
![switch](https://user-images.githubusercontent.com/1534870/37305804-f14e6cc4-25f2-11e8-920a-91deeec0979f.gif)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4520: Allow users to view dashboards they own

2018-03-12 Thread GitBox

timifasubaa commented on issue #4520: Allow users to view dashboards they own
URL: 
https://github.com/apache/incubator-superset/pull/4520#issuecomment-372455213
 
 
   I don't have merge privileges but this LGTM. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4601: Only show overlay if container is set

2018-03-12 Thread GitBox

codecov-io commented on issue #4601: Only show overlay if container is set
URL: 
https://github.com/apache/incubator-superset/pull/4601#issuecomment-372443272
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=h1)
 Report
   > Merging 
[#4601](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/2bc089ef8dcec5d98a43cb2ec80aacf1cdc706cf?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4601/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4601  +/-   ##
   ==
   - Coverage   71.18%   71.17%   -0.01% 
   ==
 Files 189  189  
 Lines   1484514846   +1 
 Branches 1086 1087   +1 
   ==
 Hits1056710567  
   - Misses   4275 4276   +1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==)
 | `64.95% <0%> (-0.56%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=footer).
 Last update 
[2bc089e...25ecd09](https://codecov.io/gh/apache/incubator-superset/pull/4601?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat commented on issue #4597: [BugFix] Resizing widgets problem #4596

2018-03-12 Thread GitBox

graceguo-supercat commented on issue #4597: [BugFix] Resizing widgets problem 
#4596
URL: 
https://github.com/apache/incubator-superset/pull/4597#issuecomment-372468330
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat closed pull request #4597: [BugFix] Resizing widgets problem #4596

2018-03-12 Thread GitBox

graceguo-supercat closed pull request #4597: [BugFix] Resizing widgets problem 
#4596
URL: https://github.com/apache/incubator-superset/pull/4597
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/package.json b/superset/assets/package.json
index 03a6f652b0..300f79288d 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -89,7 +89,7 @@
 "react-datetime": "2.9.0",
 "react-dom": "^15.6.2",
 "react-gravatar": "^2.6.1",
-"react-grid-layout": "^0.16.0",
+"react-grid-layout": "0.16.5",
 "react-map-gl": "^3.0.4",
 "react-redux": "^5.0.2",
 "react-resizable": "^1.3.3",


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on issue #4572: Legend for deck.gl scatterplot

2018-03-12 Thread GitBox

betodealmeida commented on issue #4572: Legend for deck.gl scatterplot
URL: 
https://github.com/apache/incubator-superset/pull/4572#issuecomment-372479523
 
 
   Once this is merged I'll add support in the other deck.gl viz types.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4581: Making timeseries_limit not required for phase 2

2018-03-12 Thread GitBox

john-bodley commented on issue #4581: Making timeseries_limit not required for 
phase 2
URL: 
https://github.com/apache/incubator-superset/pull/4581#issuecomment-372485931
 
 
   @mistercrunch would you mind reviewing this PR? It seems like you have the 
most context here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4194: [bug fixes] annotations <> x domains, zeros in text

2018-03-12 Thread GitBox

williaster commented on issue #4194: [bug fixes] annotations <> x domains, 
zeros in text
URL: 
https://github.com/apache/incubator-superset/pull/4194#issuecomment-372494337
 
 
   @mistercrunch will try to get this done today 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley opened a new pull request #4602: [druid] Adding cluster filter for refresh

2018-03-12 Thread GitBox

john-bodley opened a new pull request #4602: [druid] Adding cluster filter for 
refresh
URL: https://github.com/apache/incubator-superset/pull/4602
 
 
   This PR fixes an issue with syncing of Druid datasources where the 
datasource name is not globally unique. Previously the filter didn't include 
the cluster name (unique) which is required as the cluster/datasource tuple 
ensures global uniqueness.
   
   Note I also replace the OR filter with the more efficient IN. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4602: [druid] Adding cluster filter for refresh

2018-03-12 Thread GitBox

codecov-io commented on issue #4602: [druid] Adding cluster filter for refresh
URL: 
https://github.com/apache/incubator-superset/pull/4602#issuecomment-372498819
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4602?src=pr&el=h1)
 Report
   > Merging 
[#4602](https://codecov.io/gh/apache/incubator-superset/pull/4602?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/8951990d6e282618e040a4060eb3e9344981baad?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4602/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4602?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4602   +/-   ##
   ===
 Coverage   71.18%   71.18%   
   ===
 Files 189  189   
 Lines   1484514845   
 Branches 1086 1086   
   ===
 Hits1056710567   
 Misses   4275 4275   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4602?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `76.28%  (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4602?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4602?src=pr&el=footer).
 Last update 
[8951990...9604e1d](https://codecov.io/gh/apache/incubator-superset/pull/4602?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4587: [logs] Dropping dt column

2018-03-12 Thread GitBox

john-bodley commented on issue #4587: [logs] Dropping dt column
URL: 
https://github.com/apache/incubator-superset/pull/4587#issuecomment-372499774
 
 
   @mistercrunch I added an `UPDATING.md` file. Let me know if you want me to 
add more refinement beyond a simple list of breaking PRs. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to show name

2018-03-12 Thread GitBox

codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to 
show name
URL: 
https://github.com/apache/incubator-superset/pull/4579#issuecomment-371642722
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr&el=h1)
 Report
   > Merging 
[#4579](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/8951990d6e282618e040a4060eb3e9344981baad?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4579/graphs/tree.svg?src=pr&token=KsB0fHcx6l&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4579   +/-   ##
   ===
 Coverage   71.18%   71.18%   
   ===
 Files 189  189   
 Lines   1484514845   
 Branches 1086 1086   
   ===
 Hits1056710567   
 Misses   4275 4275   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.13% <100%> (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr&el=footer).
 Last update 
[8951990...8829218](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] MeenaJain commented on issue #738: Dual Axis Line chart

2018-03-12 Thread GitBox

MeenaJain commented on issue #738: Dual Axis Line chart
URL: 
https://github.com/apache/incubator-superset/issues/738#issuecomment-372519464
 
 
   How can i make line graph as an area chart?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley opened a new pull request #4603: [flask-appbuilder] Bumping version to 1.10.0

2018-03-12 Thread GitBox

john-bodley opened a new pull request #4603: [flask-appbuilder] Bumping version 
to 1.10.0
URL: https://github.com/apache/incubator-superset/pull/4603
 
 
   This PR bumps the `Flask-AppBuilder` package to version 
[1.10.0](https://github.com/dpgaspar/Flask-AppBuilder/blob/master/docs/versions.rst#improvements-and-bug-fixes-on-1100)
 which includes a fix to ensure that associations are unique. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley closed issue #3541: Druid datasource names should only be unique for a given cluster

2018-03-12 Thread GitBox

john-bodley closed issue #3541: Druid datasource names should only be unique 
for a given cluster
URL: https://github.com/apache/incubator-superset/issues/3541
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida opened a new pull request #4604: Show "Range Filter" by default

2018-03-12 Thread GitBox

betodealmeida opened a new pull request #4604: Show "Range Filter" by default
URL: https://github.com/apache/incubator-superset/pull/4604
 
 
   cc: @vylc


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4603: [flask-appbuilder] Bumping version to 1.10.0

2018-03-12 Thread GitBox

codecov-io commented on issue #4603: [flask-appbuilder] Bumping version to 
1.10.0
URL: 
https://github.com/apache/incubator-superset/pull/4603#issuecomment-372525117
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=h1)
 Report
   > Merging 
[#4603](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/8951990d6e282618e040a4060eb3e9344981baad?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4603/graphs/tree.svg?token=KsB0fHcx6l&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4603   +/-   ##
   ===
 Coverage   71.18%   71.18%   
   ===
 Files 189  189   
 Lines   1484514845   
 Branches 1086 1086   
   ===
 Hits1056710567   
 Misses   4275 4275   
 Partials33
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=footer).
 Last update 
[8951990...552f869](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4603: [flask-appbuilder] Bumping version to 1.10.0

2018-03-12 Thread GitBox

codecov-io commented on issue #4603: [flask-appbuilder] Bumping version to 
1.10.0
URL: 
https://github.com/apache/incubator-superset/pull/4603#issuecomment-372525117
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=h1)
 Report
   > Merging 
[#4603](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/8951990d6e282618e040a4060eb3e9344981baad?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4603/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4603   +/-   ##
   ===
 Coverage   71.18%   71.18%   
   ===
 Files 189  189   
 Lines   1484514845   
 Branches 1086 1086   
   ===
 Hits1056710567   
 Misses   4275 4275   
 Partials33
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=footer).
 Last update 
[8951990...552f869](https://codecov.io/gh/apache/incubator-superset/pull/4603?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4604: Show "Range Filter" by default

2018-03-12 Thread GitBox

codecov-io commented on issue #4604: Show "Range Filter" by default
URL: 
https://github.com/apache/incubator-superset/pull/4604#issuecomment-372526668
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=h1)
 Report
   > Merging 
[#4604](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/8951990d6e282618e040a4060eb3e9344981baad?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4604/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4604   +/-   ##
   ===
 Coverage   71.18%   71.18%   
   ===
 Files 189  189   
 Lines   1484514845   
 Branches 1086 1086   
   ===
 Hits1056710567   
 Misses   4275 4275   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4604/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `38.16%  (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=footer).
 Last update 
[8951990...4ff0db9](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4604: Show "Range Filter" by default

2018-03-12 Thread GitBox

codecov-io commented on issue #4604: Show "Range Filter" by default
URL: 
https://github.com/apache/incubator-superset/pull/4604#issuecomment-372526668
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=h1)
 Report
   > Merging 
[#4604](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/8951990d6e282618e040a4060eb3e9344981baad?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4604/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4604   +/-   ##
   ===
 Coverage   71.18%   71.18%   
   ===
 Files 189  189   
 Lines   1484514845   
 Branches 1086 1086   
   ===
 Hits1056710567   
 Misses   4275 4275   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4604/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `38.16%  (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=footer).
 Last update 
[8951990...4ff0db9](https://codecov.io/gh/apache/incubator-superset/pull/4604?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4572: Legend for deck.gl scatterplot

2018-03-12 Thread GitBox

mistercrunch commented on a change in pull request #4572: Legend for deck.gl 
scatterplot
URL: 
https://github.com/apache/incubator-superset/pull/4572#discussion_r173973450
 
 

 ##
 File path: superset/assets/visualizations/Legend.jsx
 ##
 @@ -0,0 +1,52 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+import './Legend.css';
+
+const propTypes = {
+  categories: PropTypes.object,
+  toggleCategory: PropTypes.func,
+  position: PropTypes.oneOf(['tl', 'tr', 'bl', 'br']),
+};
+
+const defaultProps = {
+  categories: {},
+  toggleCategory: () => {},
+  position: 'tr',
+};
+
+export default class Legend extends React.PureComponent {
+  render() {
+if (Object.keys(this.props.categories).length === 0) {
+  return null;
+}
+
+const categories = Object.entries(this.props.categories).map(([k, v]) => {
 
 Review comment:
   This may require a polyfill we may or may not have. Let's dbl-check whether 
it needs to be added.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4572: Legend for deck.gl scatterplot

2018-03-12 Thread GitBox

mistercrunch commented on a change in pull request #4572: Legend for deck.gl 
scatterplot
URL: 
https://github.com/apache/incubator-superset/pull/4572#discussion_r174012429
 
 

 ##
 File path: superset/assets/visualizations/deckgl/layers/scatter.jsx
 ##
 @@ -68,8 +89,10 @@ function getLayer(formData, payload, slice, inFrame) {
 data = jsFnMutator(data);
   }
 
-  if (inFrame != null) {
-data = data.filter(inFrame);
+  if (filters != null) {
+filters.forEach((f) => {
+  data = data.filter(f);
 
 Review comment:
   interesting pattern here :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4572: Legend for deck.gl scatterplot

2018-03-12 Thread GitBox

mistercrunch commented on a change in pull request #4572: Legend for deck.gl 
scatterplot
URL: 
https://github.com/apache/incubator-superset/pull/4572#discussion_r174012269
 
 

 ##
 File path: superset/assets/visualizations/Legend.jsx
 ##
 @@ -0,0 +1,52 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+import './Legend.css';
+
+const propTypes = {
+  categories: PropTypes.object,
+  toggleCategory: PropTypes.func,
+  position: PropTypes.oneOf(['tl', 'tr', 'bl', 'br']),
+};
+
+const defaultProps = {
+  categories: {},
+  toggleCategory: () => {},
+  position: 'tr',
+};
+
+export default class Legend extends React.PureComponent {
+  render() {
+if (Object.keys(this.props.categories).length === 0) {
+  return null;
+}
+
+const categories = Object.entries(this.props.categories).map(([k, v]) => {
+  const style = { color: 'rgba(' + v.color.join(', ') + ')' };
+  const icon = v.enabled ? '\u25CF' : '\u25CB';
+  return (
+
+   this.props.toggleCategory(k)}>
 
 Review comment:
   It's not needed, but it could be nice to select only current on dblclick, 
and would match the nvd3 behavior.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4194: [bug fixes] annotations <> x domains, zeros in text

2018-03-12 Thread GitBox

williaster commented on issue #4194: [bug fixes] annotations <> x domains, 
zeros in text
URL: 
https://github.com/apache/incubator-superset/pull/4194#issuecomment-372541646
 
 
   I think annotations are broken in production, so will debug that as part of 
this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4604: Show "Range Filter" by default

2018-03-12 Thread GitBox

mistercrunch commented on issue #4604: Show "Range Filter" by default
URL: 
https://github.com/apache/incubator-superset/pull/4604#issuecomment-372542188
 
 
   Personally I'm not a huge fan of this, I've seen users get confused by it 
and it looks pretty bad at reduced height (when added to a dashboard and 
shrunk). I don't want to spark a debate though, so I won't oppose strongly to 
this, just saying my preference.
   
   Maybe an option would be to have yes|no|auto, where auto is default and 
shows when height > a certain number of pixels. We should probably do a bit of 
CSS to make it more obvious that it can be brushed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kkalyan commented on issue #4169: Dashboard Filtering Issue across different data sources

2018-03-12 Thread GitBox

kkalyan commented on issue #4169: Dashboard Filtering Issue across different 
data sources
URL: 
https://github.com/apache/incubator-superset/issues/4169#issuecomment-372553335
 
 
   @john-bodley @oxydash will be able to take a look at this issue? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

44 matches

Mail list logo