[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu Thanks for the response . So will this feature be applicable even for the plain table other than pivot .And can you provide the tentative timeline regarding when it will be merged . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu Thanks for the response . So will this feature be applicable even for the plain table other than pivot . Any tentative timeline regarding when it will be merged . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu Thanks for the response . So will this feature be applicable even for the plain table other than pivot . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu okay . So will this feature be applicable even for the plain table other than pivot . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365841957 @shyam2794 Hi, this PR is not merged yet, and if you would like to have a try, you have to cherry pick this PR manually by yourself, then you have to recompile the frontend assets. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] XavierDeLapeyre commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )
XavierDeLapeyre commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format ) URL: https://github.com/apache/incubator-superset/issues/4424#issuecomment-365839470 @raffas Thanks for the link and indepth background review. Basically, all I need to do then is run the command line that compiles the production / optimized js & css either $ npm run prod or $ npm run dev or do I have to run yarn first? # from the root of the repository, move to where our JS package.json lives $ cd superset/assets/ # install yarn, a replacement for `npm install` that is faster and more deterministic $ npm install -g yarn # run yarn to fetch all the dependencies $ yarn # Start a web server that manages and updates your assets as you modify them $ npm run dev This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] XavierDeLapeyre commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod
XavierDeLapeyre commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod URL: https://github.com/apache/incubator-superset/issues/4425#issuecomment-365834219 Hi @xrmx , I'm not reporting a bug, I'm asking for some hints on how to debug this gibberish. What is wrong here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365831198 @xiaohanyu I reinstalled superset to use this feature in my machine . But i could not find any row or column configuration in the Pivot table This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat closed issue #305: Debug exception message not visible
graceguo-supercat closed issue #305: Debug exception message not visible URL: https://github.com/apache/incubator-superset/issues/305 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat closed issue #2012: SQL LAb. Fetch results checks the perms
graceguo-supercat closed issue #2012: SQL LAb. Fetch results checks the perms URL: https://github.com/apache/incubator-superset/issues/2012 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on a change in pull request #4432: Added check cache key util
hug commented on a change in pull request #4432: Added check cache key util
URL:
https://github.com/apache/incubator-superset/pull/4432#discussion_r168362658
##
File path: superset/views/core.py
##
@@ -2208,6 +2208,15 @@ def cached_key(self, key):
return resp
return 'nope'
+@expose('/cache_key_exist//')
Review comment:
whoops...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] timifasubaa commented on issue #4179: Summary line in table view visualization
timifasubaa commented on issue #4179: Summary line in table view visualization URL: https://github.com/apache/incubator-superset/pull/4179#issuecomment-365799013 @hgeorg They failed due to your code modifications. You should click on the `Details` link beside Required, below "All checks have failed" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util
timifasubaa commented on a change in pull request #4432: Added check cache key
util
URL:
https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613
##
File path: superset/views/core.py
##
@@ -2208,6 +2208,15 @@ def cached_key(self, key):
return resp
return 'nope'
+@expose('/cache_key_exist//')
Review comment:
missing `@has_access_api`. Intentional?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hughhhh opened a new pull request #4434: Added Example snippet for setting up Redis cache
hug opened a new pull request #4434: Added Example snippet for setting up Redis cache URL: https://github.com/apache/incubator-superset/pull/4434 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util
timifasubaa commented on a change in pull request #4432: Added check cache key
util
URL:
https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613
##
File path: superset/views/core.py
##
@@ -2208,6 +2208,15 @@ def cached_key(self, key):
return resp
return 'nope'
+@expose('/cache_key_exist//')
Review comment:
missing `@has_access_api`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util
timifasubaa commented on a change in pull request #4432: Added check cache key
util
URL:
https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613
##
File path: superset/views/core.py
##
@@ -2208,6 +2208,15 @@ def cached_key(self, key):
return resp
return 'nope'
+@expose('/cache_key_exist//')
Review comment:
Was `@has_access_api` intentionally omitted
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined
timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined URL: https://github.com/apache/incubator-superset/issues/4433#issuecomment-365797082 Can you share a picture of the error or the stack trace and how to reproduce? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined
timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined URL: https://github.com/apache/incubator-superset/issues/4433#issuecomment-365797082 Can you share a picture of the error or the stack trace? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vylc opened a new issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined
vylc opened a new issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined URL: https://github.com/apache/incubator-superset/issues/4433 Postgres table with varchar(256) type throws this error when placed in the filter by box Make sure these boxes are checked before submitting your issue - thank you! - [ x] I have checked the superset logs for python stacktraces and included it here as text if any - [ x] I have reproduced the issue with at least the latest released version of superset - [ x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4416: [dashboard] more granular grid layout
timifasubaa commented on issue #4416: [dashboard] more granular grid layout URL: https://github.com/apache/incubator-superset/pull/4416#issuecomment-365795046 https://github.com/apache/incubator-superset/issues/4014 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #2012: SQL LAb. Fetch results checks the perms
timifasubaa commented on issue #2012: SQL LAb. Fetch results checks the perms URL: https://github.com/apache/incubator-superset/issues/2012#issuecomment-365794404 This is no longer an issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh opened a new pull request #4432: Added check cache key util
hug opened a new pull request #4432: Added check cache key util URL: https://github.com/apache/incubator-superset/pull/4432 Added cache_key_exist endpoint for debugging purpose and making sure cache keys are being registered properly. @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #1389: [BUG] JSON and CSV download does not download the druid response
timifasubaa commented on issue #1389: [BUG] JSON and CSV download does not download the druid response URL: https://github.com/apache/incubator-superset/issues/1389#issuecomment-365793971 @vera-liu If you still remember, can you flesh out what you meant here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #2798: [permissions] when a user creates a table from sql-lab, make them an owner
timifasubaa commented on issue #2798: [permissions] when a user creates a table from sql-lab, make them an owner URL: https://github.com/apache/incubator-superset/issues/2798#issuecomment-365792652 Related https://github.com/apache/incubator-superset/issues/911 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4352: Newly created datasource should be accessible be creator
timifasubaa commented on issue #4352: Newly created datasource should be accessible be creator URL: https://github.com/apache/incubator-superset/issues/4352#issuecomment-365789913 see https://github.com/apache/incubator-superset/issues/2798 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4418: Updated Italian Translation
mistercrunch closed pull request #4418: Updated Italian Translation
URL: https://github.com/apache/incubator-superset/pull/4418
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/translations/it/LC_MESSAGES/messages.json
b/superset/translations/it/LC_MESSAGES/messages.json
index 93e1d837db..03177dedc6 100644
--- a/superset/translations/it/LC_MESSAGES/messages.json
+++ b/superset/translations/it/LC_MESSAGES/messages.json
@@ -1 +1 @@
-{"domain":"superset","locale_data":{"superset":{"":{"domain":"superset","plural_forms":"nplurals=1;
plural=0","lang":"it"},"Time Column":["Colonna del
Tempo"],"second":["secondo"],"minute":["minuto"],"hour":["ora"],"day":["giorno"],"week":["settimana"],"month":["mese"],"quarter":["quartile"],"year":["anno"],"week_start_monday":["settimana_inizio_luned?"],"week_ending_saturday":["settimana_fine_domenica"],"week_start_sunday":["settimana_inizio_domenica"],"5
minute":["5 minuti"],"half hour":["mezz'ora"],"10 minute":["10
minuti"],"[Superset] Access to the datasource %(name)s was granted":[""],"Viz
is missing a datasource":[""],"From date cannot be larger than to
date":[""],"Table View":["Vista Tabella"],"Pick a granularity in the Time
section or uncheck 'Include Time'":[""],"Choose either fields to [Group By] and
[Metrics] or [Columns], not both":[""],"Pivot Table":["Vista Pivot"],"Please
choose at least one \"Group by\" field ":[""],"Please choose at least one
metric":[""],"'Group By' and 'Columns' can't
overlap":[""],"Markup":["Marcatore"],"Separator":["Separatore"],"Word
Cloud":["Cloud di Parole"],"Treemap":["Treemap"],"Calendar
Heatmap":["Calendario di Intensit?"],"Box Plot":["Box Plot"],"Bubble
Chart":["Grafico a Bolle"],"Pick a metric for x, y and size":[""],"Bullet
Chart":["Grafico a Proiettile"],"Pick a metric to display":[""],"Big Number
with Trendline":["Numero Grande con Linea del Trend"],"Pick a
metric!":[""],"Big Number":["Numero Grande"],"Time Series - Line Chart":["Serie
Temporali - Grafico Lineare"],"Pick a time granularity for your time
series":[""],"Time Series - Dual Axis Line Chart":["Serie Temporali - Grafico
Lineare ad Assi Duali"],"Pick a metric for left axis!":[""],"Pick a metric for
right axis!":[""],"Please choose different metrics on left and right
axis":[""],"Time Series - Bar Chart":["Serie Temporali - Grafico Barre"],"Time
Series - Percent Change":["Serie Temporali - Cambiamento Percentuale"],"Time
Series - Stacked":["Serie Temporali - Stacked"],"Distribution - NVD3 - Pie
Chart":["Distribuzione - NVD3 - Grafico
Torta"],"Histogram":["Istogramma"],"Must have one numeric column
specified":[""],"Distribution - Bar Chart":["Distribuzione - Grafico
Barre"],"Can't have overlap between Series and Breakdowns":[""],"Pick at least
one metric":[""],"Pick at least one field for
[Series]":[""],"Sunburst":["Sunburst"],"Sankey":["Sankey"],"Pick exactly 2
columns as [Source / Target]":[""],"There's a loop in your Sankey, please
provide a tree. Here's a faulty link: {}":[""],"Directed Force
Layout":["Disposizione a Forza Diretta"],"Pick exactly 2 columns to 'Group
By'":[""],"Country Map":["Mappa della Nazione"],"World Map":["Mappa del
Mondo"],"Filters":["Filtri"],"Pick at least one filter
field":[""],"iFrame":["iFrame"],"Parallel Coordinates":["Coordinate
Parallele"],"Heatmap":["Mappa di Intensit?"],"Horizon Charts":["Grafici
d'orizzonte"],"Mapbox":["Mapbox"],"Must have a [Group By] column to have
'count' as the [Label]":[""],"Choice of [Label] must be present in [Group
By]":[""],"Choice of [Point Radius] must be present in [Group
By]":[""],"[Longitude] and [Latitude] columns must be present in [Group
By]":[""],"Event flow":[""],"Time Series - Paired t-test":[""],"No data was
returned.":["Nessun dato restituito."],"List Druid Column":[""],"Show Druid
Column":[""],"Add Druid Column":[""],"Edit Druid
Column":[""],"Column":["Colonna"],"Type":["Tipo"],"Datasource":["Sorgente
Dati"],"Groupable":["Raggruppabile"],"Filterable":["Filtrabile"],"Count
Distinct":["Count Distinct"],"Sum":["Sum"],"Min":["Min"],"Max":["Max"],"Whether
this column is exposed in the `Filters` section of the explore view.":["Se
questa colonna ? esposta nella sezione `Filtri` della vista
esplorazione."],"List Druid Metric":[""],"Show Druid Metric":[""],"Add Druid
Metric":[""],"Edit Druid Metric":[""],"Whether the access to this metric is
restricted to certain roles. Only roles with the permission 'metric access on
XXX (the name of this metric)' are allowed to access this metric":["Se
l'accesso a questa metrica ? limitato a determinati ruoli. Solo i ruoli con
l'autorizzazione 'accesso metrico su XXX (il nome di questa metrica)' possono
accedervi"],"Metric":["Metrica"],"Description":["Descrizione"],"Verbose
[GitHub] mistercrunch closed pull request #4431: Add .1s option to D3 Format dropdown
mistercrunch closed pull request #4431: Add .1s option to D3 Format dropdown URL: https://github.com/apache/incubator-superset/pull/4431 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/superset/assets/javascripts/explore/stores/controls.jsx b/superset/assets/javascripts/explore/stores/controls.jsx index 007523c4d1..ea0feaa378 100644 --- a/superset/assets/javascripts/explore/stores/controls.jsx +++ b/superset/assets/javascripts/explore/stores/controls.jsx @@ -12,6 +12,7 @@ const D3_FORMAT_DOCS = 'D3 format syntax: https://github.com/d3/d3-format'; // input choices & options const D3_FORMAT_OPTIONS = [ + ['.1s', '.1s | 12k'], ['.3s', '.3s | 12.3k'], ['.3%', '.3% | 1234543.210%'], ['.4r', '.4r | 12350'], This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] raffas commented on issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined
raffas commented on issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/issues/4391#issuecomment-365788847 Resolved in latest version: GIT_SHA fa0aa337673459315a7ae8a7813ee015e654e901 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] raffas closed issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined
raffas closed issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/issues/4391 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] raffas closed pull request #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined
raffas closed pull request #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/pull/4395 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/superset/viz.py b/superset/viz.py index d66884a3b6..adb2b8c9de 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -1620,7 +1620,7 @@ class FilterBoxViz(BaseViz): cache_type = 'get_data' def query_obj(self): -return None +return self.filter_query_obj() def run_extra_queries(self): qry = self.filter_query_obj() This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] raffas commented on issue #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined
raffas commented on issue #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/pull/4395#issuecomment-365788362 Problem solved with latest release GIT_SHA: fa0aa337673459315a7ae8a7813ee015e654e901. Closing pull request This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4408: Add link on how to get permission to permission error
timifasubaa commented on issue #4408: Add link on how to get permission to permission error URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365787814 Language abbreviated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] raffas opened a new pull request #4431: Add .1s option to D3 Format dropdown
raffas opened a new pull request #4431: Add .1s option to D3 Format dropdown URL: https://github.com/apache/incubator-superset/pull/4431 Add option .1s to D3_FORMAT_OPTIONS. This patch add the ability to display numbers like 12.0 as 12 where the dropdown is active. This is not the solution for #4424, but we can think to add dropdown to let the user specify the format of the tooltip ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4405: Disable user access request
mistercrunch closed pull request #4405: Disable user access request
URL: https://github.com/apache/incubator-superset/pull/4405
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/config.py b/superset/config.py
index c2da1db8b5..d367d36638 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -326,6 +326,9 @@ class CeleryConfig(object):
# example: FLASK_APP_MUTATOR = lambda x: x.before_request = f
FLASK_APP_MUTATOR = None
+# Set this to false if you don't want users to be able to request/grant
+# datasource access requests from/to other users.
+ENABLE_ACCESS_REQUEST = False
# smtp server configuration
EMAIL_NOTIFICATIONS = False # all the emails are sent using dryrun
diff --git a/superset/views/core.py b/superset/views/core.py
index 03636db826..a864e6296a 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -362,30 +362,30 @@ class DatabaseTablesAsync(DatabaseView):
appbuilder.add_view_no_menu(DatabaseTablesAsync)
-class AccessRequestsModelView(SupersetModelView, DeleteMixin):
-datamodel = SQLAInterface(DAR)
-list_columns = [
-'username', 'user_roles', 'datasource_link',
-'roles_with_datasource', 'created_on']
-order_columns = ['created_on']
-base_order = ('changed_on', 'desc')
-label_columns = {
-'username': _('User'),
-'user_roles': _('User Roles'),
-'database': _('Database URL'),
-'datasource_link': _('Datasource'),
-'roles_with_datasource': _('Roles to grant'),
-'created_on': _('Created On'),
-}
-
+if config.get('ENABLE_ACCESS_REQUEST'):
+class AccessRequestsModelView(SupersetModelView, DeleteMixin):
+datamodel = SQLAInterface(DAR)
+list_columns = [
+'username', 'user_roles', 'datasource_link',
+'roles_with_datasource', 'created_on']
+order_columns = ['created_on']
+base_order = ('changed_on', 'desc')
+label_columns = {
+'username': _('User'),
+'user_roles': _('User Roles'),
+'database': _('Database URL'),
+'datasource_link': _('Datasource'),
+'roles_with_datasource': _('Roles to grant'),
+'created_on': _('Created On'),
+}
-appbuilder.add_view(
-AccessRequestsModelView,
-'Access requests',
-label=__('Access requests'),
-category='Security',
-category_label=__('Security'),
-icon='fa-table')
+appbuilder.add_view(
+AccessRequestsModelView,
+'Access requests',
+label=__('Access requests'),
+category='Security',
+category_label=__('Security'),
+icon='fa-table')
class SliceModelView(SupersetModelView, DeleteMixin): # noqa
@@ -1918,14 +1918,15 @@ def dashboard(self, dashboard_id):
if datasource:
datasources.add(datasource)
-for datasource in datasources:
-if datasource and not self.datasource_access(datasource):
-flash(
-__(get_datasource_access_error_msg(datasource.name)),
-'danger')
-return redirect(
-'superset/request_access/?'
-'dashboard_id={dash.id}&'.format(**locals()))
+if config.get('ENABLE_ACCESS_REQUEST'):
+for datasource in datasources:
+if datasource and not self.datasource_access(datasource):
+flash(
+__(get_datasource_access_error_msg(datasource.name)),
+'danger')
+return redirect(
+'superset/request_access/?'
+'dashboard_id={dash.id}&'.format(**locals()))
# Hack to log the dashboard_id properly, even when getting a slug
@log_this
diff --git a/tests/access_tests.py b/tests/access_tests.py
index d33cbc6c06..22231518b6 100644
--- a/tests/access_tests.py
+++ b/tests/access_tests.py
@@ -9,7 +9,7 @@
import mock
-from superset import db, security, sm
+from superset import app, db, security, sm
from superset.connectors.connector_registry import ConnectorRegistry
from superset.connectors.druid.models import DruidDatasource
from superset.connectors.sqla.models import SqlaTable
@@ -200,24 +200,25 @@ def test_clean_requests_after_role_extend(self):
# Check if access request for gamma at energy_usage was deleted
# gamma2 and gamma request table_role on energy usage
-access_request1 = create_access_request(
-session, 'table', 'random_time_series', TEST_ROLE_1, 'gamma2')
-ds_1_id = access_request1.datasource_id
-create_access_request(
-session, 'table', 'random_time_series', TEST_ROLE_1, 'gamma
[GitHub] mistercrunch commented on issue #4408: Add link on how to get permission to permission error
mistercrunch commented on issue #4408: Add link on how to get permission to permission error URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365770984 Unrelated to this PR: we need padding on the `Panel.body` when showing alerts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] raffas commented on issue #4418: Updated Italian Translation
raffas commented on issue #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#issuecomment-365770412 @xrmx Translation updated This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4408: Add link on how to get permission to permission error.
john-bodley commented on issue #4408: Add link on how to get permission to permission error. URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365766638 Pending https://github.com/apache/incubator-superset/pull/4405 I think this LGTM, my only comment was possibly on abbreviating the language. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4409: Add permissions decider for delegating access controls.
john-bodley commented on issue #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#issuecomment-365766348 An alternative solution would be to refactor the datasource permissions to be handled by an abstract security class. The current FAB logic could be be transferred to a derived class (which would be the default implementation), which would allows others to implement their own security model, bypassing FAB completely for datasource access if desired. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls.
timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#discussion_r168007018 ## File path: superset/config.py ## @@ -364,6 +364,24 @@ class CeleryConfig(object): # Interval between consecutive polls when using Hive Engine HIVE_POLL_INTERVAL = 5 + +# System to handle delegated data access. Implement both is_allowed_access() and +# is_eligible_datasource() to delegate access controls. +class PermsDecider: Review comment: But None is falsey and so it will be easy to mix up `access denied` with `I don't know enough to decide for this datasource (from this db)` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on a change in pull request #4408: Add link on how to get permission to permission error.
john-bodley commented on a change in pull request #4408: Add link on how to get
permission to permission error.
URL:
https://github.com/apache/incubator-superset/pull/4408#discussion_r168329983
##
File path: superset/views/core.py
##
@@ -64,7 +64,14 @@
ACCESS_REQUEST_MISSING_ERR = __(
'The access requests seem to have been deleted')
USER_MISSING_ERR = __('The user seems to have been deleted')
-DATASOURCE_ACCESS_ERR = __("You don't have access to this datasource")
+perms_instruction_link = config.get('PERMISSION_INSTRUCTIONS_LINK')
+if perms_instruction_link:
+DATASOURCE_ACCESS_ERR = __(
+"You don't have access to this datasource. How to gain
access."
Review comment:
I think this is fine. If you wanted to truncate the length of the message
maybe something like
> You don't have access to this datasource (Gain Access)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls.
timifasubaa commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r168307620
##
File path: superset/viz.py
##
@@ -307,7 +307,12 @@ def get_df_payload(self, query_obj=None):
cached_dttm = datetime.utcnow().isoformat().split('.')[0]
if cache_key and cache and not self.force:
cache_value = cache.get(cache_key)
-if cache_value:
+perms_decider = config.get('DATA_PERMS_DECIDER')
+perms_decider_disapproves = (
Review comment:
In our case, we don't want to provide info from the cache based on superset
permissions. Rather from an outside system. I moved the check from viz.py to
explore_json. and set force=true when the perms_decider denied the person
access.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365737142 @maver1ck This PR only gives different deployments the the option to remove the ability to request access from users. It doesn't change whether gamma has access to dashboards it created. Like you suggested in the issue, you could create a new rule in the permissions check that allows the creator to see their dashboards even if it is a gamma user. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365737142 @maver1ck This PR only gives different deployments the the option to remove the ability to request access from users. It doesn't change whether gamma has access to dashboards it created. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maver1ck commented on issue #4428: Proper error handling in Hive Queries
maver1ck commented on issue #4428: Proper error handling in Hive Queries URL: https://github.com/apache/incubator-superset/pull/4428#issuecomment-365727748 Can we retest this ? Failed check has nothing to do with my patch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maver1ck commented on issue #4405: Disable user access request
maver1ck commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365717791 Do you have idea how does it join with https://github.com/apache/incubator-superset/issues/4352 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4422: [geoviz] lines made from locations in time (can be animated)
mistercrunch commented on a change in pull request #4422: [geoviz] lines made
from locations in time (can be animated)
URL:
https://github.com/apache/incubator-superset/pull/4422#discussion_r168283393
##
File path: superset/assets/visualizations/deckgl/DeckGLContainer.jsx
##
@@ -11,10 +11,16 @@ const propTypes = {
mapStyle: PropTypes.string,
mapboxApiAccessToken: PropTypes.string.isRequired,
onViewportChange: PropTypes.func,
+ renderFrequency: PropTypes.number,
+ overlayContent: PropTypes.func,
Review comment:
getOverlayContent
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4382: Change current thumbnails to smaller ones.
mistercrunch commented on issue #4382: Change current thumbnails to smaller ones. URL: https://github.com/apache/incubator-superset/pull/4382#issuecomment-365705967 https://github.com/apache/incubator-superset/pull/4430 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4382: Change current thumbnails to smaller ones.
mistercrunch closed pull request #4382: Change current thumbnails to smaller ones. URL: https://github.com/apache/incubator-superset/pull/4382 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/gallery.rst b/docs/gallery.rst index f0c7dfaec5..28515277c7 100644 --- a/docs/gallery.rst +++ b/docs/gallery.rst @@ -2,88 +2,88 @@ Gallery === .. image:: _static/img/viz_thumbnails/line.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/bubble.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/table.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/pie.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/bar.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/world_map.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/sankey.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/word_cloud.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/filter_box.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/pivot_table.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/directed_force.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/compare.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/sunburst.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/area.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/big_number.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/big_number_total.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/bullet.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/dist_bar.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/heatmap.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/markup.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/para.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/iframe.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/box_plot.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/treemap.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/cal_heatmap.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/horizon.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/mapbox.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/separator.png - :scale: 25 % + :scale: 50 % .. image:: _static/img/viz_thumbnails/histogram.png - :scale: 25 % + :scale: 50 % diff --git a/superset/assets/images/viz_thumbnails/area.png b/superset/assets/images/viz_thumbnails/area.png index 86f1080cda..6b2fb75d42 100644 Binary files a/superset/assets/images/viz_thumbnails/area.png and b/superset/assets/images/viz_thumbnails/area.png differ diff --git a/superset/assets/images/viz_thumbnails/bar.png b/superset/assets/images/viz_thumbnails/bar.png index ab0e8d9915..1ef2633122 100644 Binary files a/superset/assets/images/viz_thumbnails/bar.png and b/superset/assets/images/viz_thumbnails/bar.png differ diff --git a/superset/assets/images/viz_thumbnails/big_number.png b/superset/assets/images/viz_thumbnails/big_number.png index 2420f25e9f..01d6da45ba 100644 Binary files a/superset/assets/images/viz_thumbnails/big_number.png and b/superset/assets/images/viz_thumbnails/big_number.png differ diff --git a/superset/assets/images/viz_thumbnails/big_number_total.png b/superset/assets/images/viz_thumbnails/big_number_total.png index eb4b345731..350d5a1ab1 100644 Binary files a/superset/assets/images/viz_thumbnails/big_number_total.png and b/superset/assets/images/viz_thumbnails/big_number_total.png differ diff --git a/superset/assets/images/viz_thumbnails/box_plot.png b/superset/assets/images/viz_thumbnails/box_plot.png index de8f061a68..8925e50680 100644 Binary files a/superset/assets/images/viz_thumbnails/box_plot.png and b/superset/assets/images/viz_thumbnails/box_plot.png differ diff --git a/superset/assets/images/viz_thumbnails/bubble.png b/superset/assets/images/viz_thumbnails/bubble.png index 08de51f4ff..453388104e 100644 Binary files a/superset/assets/images/viz_thumbnails/bubble.png and b/superset/assets/images/viz_thumbnails/bubble.png differ diff --git a/superset/assets/images/viz_thumbnails/bullet.png b/superset/assets/images/viz_thumbnails/bullet.png index 7a66a41c7a..f98c70f29b 100644 Binary files a/s
[GitHub] mistercrunch opened a new pull request #4430: Change current thumbnails to smaller ones.
mistercrunch opened a new pull request #4430: Change current thumbnails to smaller ones. URL: https://github.com/apache/incubator-superset/pull/4430 Smaller thumbs, but preserving old ones, keeping them out of python package, but into the repo. Superseeds https://github.com/apache/incubator-superset/pull/4382 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4408: Add link on how to get permission.
timifasubaa commented on issue #4408: Add link on how to get permission. URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365698803 PING This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view
villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365692257 @xrmx I would appreciate some guidance on what type of test case is requested, e.g. a similar case or functionality, as I was unable to find anything that I could extend easily. The code base is still very new to me, so I'm still having a hard time understanding all the details of it's inner workings. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed issue #4347: [Druid] Explore view throws error when group by is applied
mistercrunch closed issue #4347: [Druid] Explore view throws error when group by is applied URL: https://github.com/apache/incubator-superset/issues/4347 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4347: [Druid] Explore view throws error when group by is applied
mistercrunch commented on issue #4347: [Druid] Explore view throws error when group by is applied URL: https://github.com/apache/incubator-superset/issues/4347#issuecomment-365689253 Should be fixed in master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4427: Bump dependencies with security issues
mistercrunch closed pull request #4427: Bump dependencies with security issues URL: https://github.com/apache/incubator-superset/pull/4427 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/superset/assets/package.json b/superset/assets/package.json index fbfa32a27d..12c9e66882 100644 --- a/superset/assets/package.json +++ b/superset/assets/package.json @@ -68,8 +68,8 @@ "lodash.throttle": "^4.1.1", "luma.gl": "^5.0.1", "mapbox-gl": "^0.43.0", -"mathjs": "^3.16.3", -"moment": "2.18.1", +"mathjs": "^3.20.2", +"moment": "^2.20.1", "mustache": "^2.2.1", "nvd3": "1.8.6", "po2json": "^0.4.5", This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible
SpyderRivera commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429#issuecomment-365686205 Bottom margin is available in the latest ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera closed issue #4429: [TimeSeries-BarChart] x axis dates are not visible
SpyderRivera closed issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] darylerwin commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible
darylerwin commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429#issuecomment-365681354 There is a chart option "Bottom Margin" that is available to tweak this.. just an FYI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera opened a new issue #4429: [TimeSeries-BarChart] x axis dates are not visible
SpyderRivera opened a new issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 23 rc2 08b88fd4d2eb5ef065a55cb75b9f67875ad4bea1 ### Expected results TimeSeries BarChart with visible dates ### Actual results   ### Steps to reproduce Create a time series bar chart with a druid data source. Metric doesn't matter. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maver1ck opened a new pull request #4428: Proper error handling in Hive Queries
maver1ck opened a new pull request #4428: Proper error handling in Hive Queries URL: https://github.com/apache/incubator-superset/pull/4428 Resolves: #4414 Fetch_many gives strange exception when hive query is in Error state. So we're reading status to get proper error message before calling fetch_many This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx opened a new pull request #4427: Bump dependencies with security issues
xrmx opened a new pull request #4427: Bump dependencies with security issues URL: https://github.com/apache/incubator-superset/pull/4427 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx opened a new issue #4426: yarn run prod fails on master
xrmx opened a new issue #4426: yarn run prod fails on master URL: https://github.com/apache/incubator-superset/issues/4426 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 342180b263079db2fac5434fc929805d4b441e19 ### Expected results no errors ### Actual results ``` ERROR in ./node_modules/css-loader!./visualizations/chord.css Module build failed: Error: ENOENT: no such file or directory, open '/home/rm/work/stats/superset/superset/assets/node_modules/svgo/lib/svgo/../../.svgo.yml' at Object.fs.openSync (fs.js:646:18) at Object.fs.readFileSync (fs.js:551:33) at module.exports (/home/rm/work/stats/superset/superset/assets/node_modules/svgo/lib/svgo/config.js:31:48) at new module.exports (/home/rm/work/stats/superset/superset/assets/node_modules/svgo/lib/svgo.js:21:19) at /home/rm/work//stats/superset/superset/assets/node_modules/postcss-svgo/dist/index.js:95:16 at Object.creator [as postcssSvgo] (/home/rm/work//stats/superset/superset/assets/node_modules/postcss/lib/postcss.js:150:35) at /home/rm/work/stats/superset/superset/assets/node_modules/cssnano/dist/index.js:295:40 at Array.forEach () at /home/rm/work/stats/superset/superset/assets/node_modules/cssnano/dist/index.js:282:29 at creator (/home/rm/work/stats/superset/superset/assets/node_modules/postcss/lib/postcss.js:150:35) at processCss (/home/rm/work/maieuticallabs/stats/superset/superset/assets/node_modules/css-loader/lib/processCss.js:199:16) at Object.module.exports (/home/rm/work/maieuticallabs/stats/superset/superset/assets/node_modules/css-loader/lib/loader.js:40:2) @ ./visualizations/chord.css 4:14-74 @ ./visualizations/chord.jsx @ ./visualizations/main.js @ ./javascripts/modules/AnnotationTypes.js @ ./javascripts/chart/chartAction.js @ ./javascripts/dashboard/components/DashboardContainer.jsx @ ./javascripts/dashboard/index.jsx @ multi babel-polyfill ./javascripts/dashboard/index.jsx ``` ### Steps to reproduce yarn run prod postcss-svgo is 2.1.6 svgo is 0.7.2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod
xrmx commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod URL: https://github.com/apache/incubator-superset/issues/4425#issuecomment-365554280 Please report bugs against latest release and not old ones. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] XavierDeLapeyre opened a new issue #4425: Error on compiles the production / optimized js & css with npm run prod
XavierDeLapeyre opened a new issue #4425: Error on compiles the production /
optimized js & css with npm run prod
URL: https://github.com/apache/incubator-superset/issues/4425
### Superset version
{"GIT_SHA": "", "version": "0.21.1"}
Background info :
SuperSet v0.21.1
Setup in a VirtEnv
I modified
VirtEnv/lib/python2.7/site-packages/superset/static/assets/visualizations/nvd3_vis.js
But the modifications did not show up on the browser.
After researching a bit, found that I needed to recompile the ../assets/build
Found the command line in
https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#npm-packages
# Compiles the production / optimized js & css
npm run prod
after running that commande I got this error :
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'run', 'prod' ]
2 info using npm@3.8.6
3 info using node@v5.12.0
4 verbose run-script [ 'preprod', 'prod', 'postprod' ]
5 info lifecycle superset@0.21.1~preprod: superset@0.21.1
6 silly lifecycle superset@0.21.1~preprod: no script for preprod, continuing
7 info lifecycle superset@0.21.1~prod: superset@0.21.1
8 verbose lifecycle superset@0.21.1~prod: unsafe-perm in lifecycle true
9 verbose lifecycle superset@0.21.1~prod: PATH:
/usr/lib/node_modules/npm/bin/node-gyp-bin:/var/www/bi_mma_aquilarisk_pro/bimmavenv/bimmavenv/lib/python2.7/site-packages/superset/static/assets/node_modules/.bin:/usr/bin:/var/www/bi_mma_aquilarisk_pro/bimmavenv/bimmavenv/bin:/usr/local/bin:/usr/bin:/bin:/usr/games
10 verbose lifecycle superset@0.21.1~prod: CWD:
/var/www/bi_mma_aquilarisk_pro/bimmavenv/bimmavenv/lib/python2.7/site-packages/superset/static/assets
11 silly lifecycle superset@0.21.1~prod: Args: [ '-c',
11 silly lifecycle 'NODE_ENV=production node --max_old_space_size=4096
./node_modules/webpack/bin/webpack.js -p --colors --progress' ]
12 silly lifecycle superset@0.21.1~prod: Returned: code: 1 signal: null
13 info lifecycle superset@0.21.1~prod: Failed to exec prod script
14 verbose stack Error: superset@0.21.1 prod: `NODE_ENV=production node
--max_old_space_size=4096 ./node_modules/webpack/bin/webpack.js -p --colors
--progress`
14 verbose stack Exit status 1
14 verbose stack at EventEmitter.
(/usr/lib/node_modules/npm/lib/utils/lifecycle.js:239:16)
14 verbose stack at emitTwo (events.js:100:13)
14 verbose stack at EventEmitter.emit (events.js:185:7)
14 verbose stack at ChildProcess.
(/usr/lib/node_modules/npm/lib/utils/spawn.js:24:14)
14 verbose stack at emitTwo (events.js:100:13)
14 verbose stack at ChildProcess.emit (events.js:185:7)
14 verbose stack at maybeClose (internal/child_process.js:850:16)
14 verbose stack at Process.ChildProcess._handle.onexit
(internal/child_process.js:215:5)
15 verbose pkgid superset@0.21.1
16 verbose cwd
/var/www/bi_mma_aquilarisk_pro/bimmavenv/bimmavenv/lib/python2.7/site-packages/superset/static/assets
17 error Linux 3.2.0-4-amd64
18 error argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "prod"
19 error node v5.12.0
20 error npm v3.8.6
21 error code ELIFECYCLE
22 error superset@0.21.1 prod: `NODE_ENV=production node
--max_old_space_size=4096 ./node_modules/webpack/bin/webpack.js -p --colors
--progress`
22 error Exit status 1
23 error Failed at the superset@0.21.1 prod script 'NODE_ENV=production node
--max_old_space_size=4096 ./node_modules/webpack/bin/webpack.js -p --colors
--progress'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the superset package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error NODE_ENV=production node --max_old_space_size=4096
./node_modules/webpack/bin/webpack.js -p --colors --progress
23 error You can get information on how to open an issue for this project
with:
23 error npm bugs superset
23 error Or if that isn't available, you can get their info via:
23 error npm owner ls superset
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]
The cmd : npm bugs superset
gave me this info
npm ERR! Linux 3.2.0-4-amd64
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "bugs" "superset"
npm ERR! node v5.12.0
npm ERR! npm v3.8.6
npm ERR! path xdg-open
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm ERR! syscall spawn xdg-open
npm ERR! enoent spawn xdg-open ENOENT
npm ERR! enoent spawn xdg-open ENOENT
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
This is an automated message from the Apache Git Servi
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168111611
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
Review comment:
```
if datasource.cache_timeout:
cache_timeout = ...
else:
cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT')
try:
if datasource.database.cache_timeout:
cache_timeout = ...
except AttributeError:
pass
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168117455
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
Review comment:
Updated the code above
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168111611
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
Review comment:
```
cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT')
if datasource.cache_timeout:
cache_timeout = ...
try:
if datasource.database.cache_timeout:
cache_timeout = ...
except AttributeError:
pass
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vnnw commented on a change in pull request #4421: Update core.py
vnnw commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168116469
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
Review comment:
I don't think using try-except is proper here. There are three possible
places to get cache_timeout value. I wanted to make it cascading fallback.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] raffas commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )
raffas commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format ) URL: https://github.com/apache/incubator-superset/issues/4424#issuecomment-365545144 You need to use the development version. Files in the assets folder are managed by webpack. You cannot modify using the production server (or debug server). They are minified and Superset loads it from the dist/ subdir, not from the assets directory See https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md on how to setup. Maybe an options to .1s can be added in the control defined in assets/javascripts/explore/stores/controls.jsx so it its available for anyone This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )
xrmx commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format ) URL: https://github.com/apache/incubator-superset/issues/4424#issuecomment-365544974 You have to read the documentation on how to do your own build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4418: Updated Italian Translation
xrmx commented on issue #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#issuecomment-365543996 I've found a few more typos! With these fixed, looks good to me, thanks a lot! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4418: Updated Italian Translation
xrmx commented on issue #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#issuecomment-365543996 Thanks a lot i've found a few more typos! With these fixed, looks good to me, thanks a lot! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168113761 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -391,83 +391,83 @@ msgstr "" #: superset/assets/javascripts/SqlLab/actions.js:57 msgid "Your query was saved" -msgstr "" +msgstr "La tua query ? stata salvata" #: superset/assets/javascripts/SqlLab/actions.js:58 msgid "Your query could not be saved" -msgstr "" +msgstr "La tua query non pu? essere salvata" #: superset/assets/javascripts/SqlLab/actions.js:111 msgid "Failed at retrieving results from the results backend" -msgstr "" +msgstr "Errore nel recupero dei dati dal backend" #: superset/assets/javascripts/SqlLab/actions.js:157 msgid "Could not connect to server" -msgstr "" +msgstr "Non posso connettermi al server" #: superset/assets/javascripts/SqlLab/actions.js:162 msgid "Your session timed out, please refresh your page and try again." -msgstr "" +msgstr "La tua sessione ? scaduta, ricarica la pagina e riprova." #: superset/assets/javascripts/SqlLab/actions.js:181 msgid "Query was stopped." -msgstr "" +msgstr "La query ? stata fermata." #: superset/assets/javascripts/SqlLab/actions.js:184 msgid "Failed at stopping query." -msgstr "" +msgstr "Errore nel fermare la query." #: superset/assets/javascripts/SqlLab/actions.js:297 #: superset/assets/javascripts/SqlLab/actions.js:310 msgid "Error occurred while fetching table metadata" -msgstr "" +msgstr "Errore nel recupero dei metadati della tabella" #: superset/assets/javascripts/SqlLab/actions.js:364 msgid "shared query" -msgstr "" +msgstr "tabella condivisa" Review comment: query is query This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168113931 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -391,83 +391,83 @@ msgstr "" #: superset/assets/javascripts/SqlLab/actions.js:57 msgid "Your query was saved" -msgstr "" +msgstr "La tua query ? stata salvata" #: superset/assets/javascripts/SqlLab/actions.js:58 msgid "Your query could not be saved" -msgstr "" +msgstr "La tua query non pu? essere salvata" #: superset/assets/javascripts/SqlLab/actions.js:111 msgid "Failed at retrieving results from the results backend" -msgstr "" +msgstr "Errore nel recupero dei dati dal backend" #: superset/assets/javascripts/SqlLab/actions.js:157 msgid "Could not connect to server" -msgstr "" +msgstr "Non posso connettermi al server" #: superset/assets/javascripts/SqlLab/actions.js:162 msgid "Your session timed out, please refresh your page and try again." -msgstr "" +msgstr "La tua sessione ? scaduta, ricarica la pagina e riprova." #: superset/assets/javascripts/SqlLab/actions.js:181 msgid "Query was stopped." -msgstr "" +msgstr "La query ? stata fermata." #: superset/assets/javascripts/SqlLab/actions.js:184 msgid "Failed at stopping query." -msgstr "" +msgstr "Errore nel fermare la query." #: superset/assets/javascripts/SqlLab/actions.js:297 #: superset/assets/javascripts/SqlLab/actions.js:310 msgid "Error occurred while fetching table metadata" -msgstr "" +msgstr "Errore nel recupero dei metadati della tabella" #: superset/assets/javascripts/SqlLab/actions.js:364 msgid "shared query" -msgstr "" +msgstr "tabella condivisa" #: superset/assets/javascripts/SqlLab/actions.js:372 #: superset/assets/javascripts/SqlLab/actions.js:392 msgid "The query couldn't be loaded" -msgstr "" +msgstr "La query non pu? essere caricata" #: superset/assets/javascripts/SqlLab/actions.js:426 msgid "An error occurred while creating the data source" -msgstr "" +msgstr "Errore nel creare il datasource" #: superset/assets/javascripts/SqlLab/constants.js:30 msgid "Pick a chart type!" -msgstr "" +msgstr "Seleziona un tipo di grafico" #: superset/assets/javascripts/SqlLab/constants.js:31 msgid "To use this chart type you need at least one column flagged as a date" -msgstr "" +msgstr "Per usare questo tipo di grafico devi avere almeno una colonna selezionata come data" #: superset/assets/javascripts/SqlLab/constants.js:32 msgid "To use this chart type you need at least one dimension" -msgstr "" +msgstr "Per usare questo tipo di grafico devi avere almeno una dimensione" #: superset/assets/javascripts/SqlLab/constants.js:33 msgid "To use this chart type you need at least one aggregation function" -msgstr "" +msgstr "Per usare questo tipo di grafico devi avere almeno uan funziona di aggregazione" #: superset/assets/javascripts/SqlLab/components/QueryTable.jsx:49 #: superset/assets/javascripts/SqlLab/reducers.js:11 msgid "Untitled Query" -msgstr "" +msgstr "Query senza nome" #: superset/assets/javascripts/SqlLab/reducers.js:44 #, python-format msgid "Copy of %s" -msgstr "" +msgstr "Copia di %s" #: superset/assets/javascripts/SqlLab/components/CopyQueryTabUrl.jsx:30 msgid "share query" -msgstr "" +msgstr "query condivisa" Review comment: condividi query This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168114174 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -391,83 +391,83 @@ msgstr "" #: superset/assets/javascripts/SqlLab/actions.js:57 msgid "Your query was saved" -msgstr "" +msgstr "La tua query ? stata salvata" #: superset/assets/javascripts/SqlLab/actions.js:58 msgid "Your query could not be saved" -msgstr "" +msgstr "La tua query non pu? essere salvata" #: superset/assets/javascripts/SqlLab/actions.js:111 msgid "Failed at retrieving results from the results backend" -msgstr "" +msgstr "Errore nel recupero dei dati dal backend" #: superset/assets/javascripts/SqlLab/actions.js:157 msgid "Could not connect to server" -msgstr "" +msgstr "Non posso connettermi al server" #: superset/assets/javascripts/SqlLab/actions.js:162 msgid "Your session timed out, please refresh your page and try again." -msgstr "" +msgstr "La tua sessione ? scaduta, ricarica la pagina e riprova." #: superset/assets/javascripts/SqlLab/actions.js:181 msgid "Query was stopped." -msgstr "" +msgstr "La query ? stata fermata." #: superset/assets/javascripts/SqlLab/actions.js:184 msgid "Failed at stopping query." -msgstr "" +msgstr "Errore nel fermare la query." #: superset/assets/javascripts/SqlLab/actions.js:297 #: superset/assets/javascripts/SqlLab/actions.js:310 msgid "Error occurred while fetching table metadata" -msgstr "" +msgstr "Errore nel recupero dei metadati della tabella" #: superset/assets/javascripts/SqlLab/actions.js:364 msgid "shared query" -msgstr "" +msgstr "tabella condivisa" #: superset/assets/javascripts/SqlLab/actions.js:372 #: superset/assets/javascripts/SqlLab/actions.js:392 msgid "The query couldn't be loaded" -msgstr "" +msgstr "La query non pu? essere caricata" #: superset/assets/javascripts/SqlLab/actions.js:426 msgid "An error occurred while creating the data source" -msgstr "" +msgstr "Errore nel creare il datasource" #: superset/assets/javascripts/SqlLab/constants.js:30 msgid "Pick a chart type!" -msgstr "" +msgstr "Seleziona un tipo di grafico" #: superset/assets/javascripts/SqlLab/constants.js:31 msgid "To use this chart type you need at least one column flagged as a date" -msgstr "" +msgstr "Per usare questo tipo di grafico devi avere almeno una colonna selezionata come data" #: superset/assets/javascripts/SqlLab/constants.js:32 msgid "To use this chart type you need at least one dimension" -msgstr "" +msgstr "Per usare questo tipo di grafico devi avere almeno una dimensione" #: superset/assets/javascripts/SqlLab/constants.js:33 msgid "To use this chart type you need at least one aggregation function" -msgstr "" +msgstr "Per usare questo tipo di grafico devi avere almeno uan funziona di aggregazione" #: superset/assets/javascripts/SqlLab/components/QueryTable.jsx:49 #: superset/assets/javascripts/SqlLab/reducers.js:11 msgid "Untitled Query" -msgstr "" +msgstr "Query senza nome" #: superset/assets/javascripts/SqlLab/reducers.js:44 #, python-format msgid "Copy of %s" -msgstr "" +msgstr "Copia di %s" #: superset/assets/javascripts/SqlLab/components/CopyQueryTabUrl.jsx:30 msgid "share query" -msgstr "" +msgstr "query condivisa" #: superset/assets/javascripts/SqlLab/components/CopyQueryTabUrl.jsx:33 msgid "copy URL to clipboard" -msgstr "" +msgstr "copia URL in clipoboard" Review comment: copia URL negli appunti This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168114607 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -2296,7 +2296,7 @@ msgstr "" #: superset/assets/javascripts/explore/stores/visTypes.js:66 msgid "Advanced Analytics" -msgstr "" +msgstr "Analitycs avanzate" Review comment: Analytics, you swap y with i :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168113031
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
+cache_timeout = datasource.database.cache_timeout
+elif (hasattr(datasource, 'database') and
datasource.cache_timeout):
+cache_timeout = datasource.database.cache_timeout
+else:
+cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT')
+cache_value = cache.get(cache_key)
+if cache_value:
+logging.info('Loading filter values from cache')
+try:
+payload = json.dumps(cache_value,
default=utils.json_int_dttm_ser)
+except Exception as e:
+logging.exception(e)
+logging.error('Error reading cache:' +
+ utils.error_msg_from_exception(e))
+logging.info('Serving filter values from cache')
+else:
+cache_value = datasource.values_for_column(
+column,
+config.get('FILTER_SELECT_ROW_LIMIT', 1),
+)
+try:
+payload = json.dumps(cache_value,
default=utils.json_int_dttm_ser)
+stats_logger.incr('set_cache_key')
+cache.set(cache_key, cache_value, cache_timeout)
+except Exception as e:
+logging.warning('Error writing cache
{}:'.format(cache_key))
+logging.exception(e)
+cache.delete(cache.key)
Review comment:
cache_key
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168113263
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
+cache_timeout = datasource.database.cache_timeout
+elif (hasattr(datasource, 'database') and
datasource.cache_timeout):
+cache_timeout = datasource.database.cache_timeout
+else:
+cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT')
+cache_value = cache.get(cache_key)
+if cache_value:
Review comment:
Looks like of duplicated code here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r16832
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
Review comment:
cache_key will always evaluate True
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168111611
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
Review comment:
```
cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT')
try:
if datasource.database.cache_timeout:
cache_timeout = ...
except AttributeError:
if datasource.cache_timeout:
cache_timeout = ...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on a change in pull request #4421: Update core.py
xrmx commented on a change in pull request #4421: Update core.py
URL:
https://github.com/apache/incubator-superset/pull/4421#discussion_r168113337
##
File path: superset/views/core.py
##
@@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id,
column):
return json_error_response(DATASOURCE_MISSING_ERR)
if not self.datasource_access(datasource):
return json_error_response(DATASOURCE_ACCESS_ERR)
-
-payload = json.dumps(
-datasource.values_for_column(
-column,
-config.get('FILTER_SELECT_ROW_LIMIT', 1),
-),
-default=utils.json_int_dttm_ser)
+# Implement: Cache endpoint by datasource and column
+cache_key = hashlib.md5((datasource_id +
column).encode('utf-8')).hexdigest()
+if cache_key and cache:
+if (hasattr(datasource, 'database') and
datasource.database.cache_timeout):
+cache_timeout = datasource.database.cache_timeout
+elif (hasattr(datasource, 'database') and
datasource.cache_timeout):
+cache_timeout = datasource.database.cache_timeout
+else:
+cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT')
+cache_value = cache.get(cache_key)
+if cache_value:
+logging.info('Loading filter values from cache')
+try:
+payload = json.dumps(cache_value,
default=utils.json_int_dttm_ser)
+except Exception as e:
+logging.exception(e)
+logging.error('Error reading cache:' +
+ utils.error_msg_from_exception(e))
+logging.info('Serving filter values from cache')
+else:
+cache_value = datasource.values_for_column(
+column,
+config.get('FILTER_SELECT_ROW_LIMIT', 1),
+)
+try:
+payload = json.dumps(cache_value,
default=utils.json_int_dttm_ser)
+stats_logger.incr('set_cache_key')
+cache.set(cache_key, cache_value, cache_timeout)
+except Exception as e:
Review comment:
You don't know if it was writing the cache that failed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] XavierDeLapeyre opened a new issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )
XavierDeLapeyre opened a new issue #4424: Pie Chart - format number display
from .3s to .1s ( or other format )
URL: https://github.com/apache/incubator-superset/issues/4424
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if any
- [x] I have reproduced the issue with at least the latest released version
of superset
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
{"GIT_SHA": "", "version": "0.21.1"}
### Expected results
My data are whole integers in my query.
Having decimals does not make sense in this case.
I made search in the source codes and found some formatting in nvd3_vis.js
and a pie chart case.
### Steps to reproduce
env/lib/python2.7/site-packages/superset/static/assets/visualizations/nvd3_vis.js
case 'pie':
...
// chart.valueFormat(f);
chart.valueFormat('.1s');
...
else if (fd.pie_label_type === 'key_value') {
//chart.labelType(d => `${d.data.x}:
${d3.format('.3s')(d.data.y)}`);
chart.labelType(d => `${d.data.x}:
${d3.format('.1s')(d.data.y)}`);
}
Do I need to change anything else?
Thanks in adv.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
