[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418057236 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418057236 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418057236 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418055736 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418053849 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418052728 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/auth/JPASAML2IdPMetadataDAO.java ## @@ -0,0 +1,61 @@ +/* + *

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417332912 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: @mmoayyed

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417332912 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: @mmoayyed

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417332912 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: @mmoayyed

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416618050 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: ATM in the

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416608586 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: I think

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416607578 ## File path: fit/core-reference/pom.xml ## @@ -222,6 +222,30 @@ under the License. bcpkix-jdk15on test + Review comment: