[GitHub] [systemds] mboehm7 commented on a change in pull request #1054: [MINOR] Remove Exceptions From FederatedResponse

2020-09-13 Thread GitBox
mboehm7 commented on a change in pull request #1054: URL: https://github.com/apache/systemds/pull/1054#discussion_r487525755 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorkerHandler.java ## @@ -155,7 +155,7 @@ private

[GitHub] [systemds] asfgit closed pull request #1053: [MINOR] Move Privacy Handling of UDFs

2020-09-13 Thread GitBox
asfgit closed pull request #1053: URL: https://github.com/apache/systemds/pull/1053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemds] mboehm7 commented on pull request #1053: [MINOR] Move Privacy Handling of UDFs

2020-09-13 Thread GitBox
mboehm7 commented on pull request #1053: URL: https://github.com/apache/systemds/pull/1053#issuecomment-691666709 LGTM - thanks @sebwrede This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [systemds] asfgit closed pull request #1051: [SYSTEMDS-2605] Fine-Grained Privacy Constraints 2 Rebased

2020-09-13 Thread GitBox
asfgit closed pull request #1051: URL: https://github.com/apache/systemds/pull/1051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemds] mboehm7 commented on pull request #1051: [SYSTEMDS-2605] Fine-Grained Privacy Constraints 2 Rebased

2020-09-13 Thread GitBox
mboehm7 commented on pull request #1051: URL: https://github.com/apache/systemds/pull/1051#issuecomment-691664020 Also thanks to @Baunsgaard for the earlier review. This is an automated message from the Apache Git Service.

[GitHub] [systemds] mboehm7 commented on pull request #1051: [SYSTEMDS-2605] Fine-Grained Privacy Constraints 2 Rebased

2020-09-13 Thread GitBox
mboehm7 commented on pull request #1051: URL: https://github.com/apache/systemds/pull/1051#issuecomment-691663906 LGTM. Thanks for the patch @sebwrede and reconciling the tests with the new federated backend. I only made some minor changes: removed warnings, fixed few formatting issues,