Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/63
@johnament Thanks for the review John. Please take another look when you
get a chance.
---
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/62
Porting LGTM ð
---
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/63#discussion_r140343798
--- Diff: tephra-distribution/NOTICE_BINARY ---
@@ -6,10 +6,19 @@ The Apache Software Foundation (http://www.apache.org/).
Apache
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/63
@johnament Please review this PR that fixes the NOTICE file for Apache
Tephra when you get a chance. Thank you!
---
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/63
TEPHRA-265 Fix NOTICE_BINARY for Guice and Guice Assisted Inject libraries
JIRA : https://issues.apache.org/jira/browse/TEPHRA-265
You can merge this pull request into a Git repository
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/60
Don't package JSR in binary distribution, move LICENSE/NOTICE files to top
level
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/58
@poornachandra Thanks for the review. Addressed your comment (moved LICENSE
and NOTICE files under tephra-distribution). Please take a look again.
---
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/58
TEPHRA-231 Fix LICENSE and NOTICE files for release distribution
JIRA : https://issues.apache.org/jira/browse/TEPHRA-231
You can merge this pull request into a Git repository
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/49
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/46
TEPHRA-239 Fix NPE by waiting for the service to startup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gokulavasan/incubator
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117838945
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/ClientIdAwareTransactionModule.java
---
@@ -0,0 +1,41
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117838903
--- Diff:
tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java
---
@@ -35,13 +34,24 @@
import
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/42
@poornachandra Injecting ClientId in TransactionServiceClient now instead
of changing the API of TransactionSystemClient. Please review when you get a
chance.
---
If your project
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/42
@poornachandra Can you please review the last commit. I have addressed your
comment about TransactionContext change (deprecated old constructors and
introduced a new one
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117557607
--- Diff:
tephra-hbase-compat-0.98/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -127,7 +126,7 @@ public
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117324833
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -763,15 +781,22 @@ private long getNextWritePointer
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117322759
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -1378,17 +1403,32 @@ public TransactionType
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117316435
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -763,15 +781,22 @@ private long getNextWritePointer
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/42
TEPHRA-228 Adding the ability to pass-in a clientId during the start â¦
â¦of a transaction which is logged when the transaction gets invalidated
during time out.
You can merge
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/41
TEPHRA-152 Using ReferenceCounting for TransactionStateCache refresh â¦
â¦thread, so that it can be stopped
You can merge this pull request into a Git repository by running
Github user gokulavasan closed the pull request at:
https://github.com/apache/incubator-tephra/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gokulavasan closed the pull request at:
https://github.com/apache/incubator-tephra/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/40
TEPHRA-227 Add a new command to get the set of regions that have not been
compacted
Also adding a CLI command.
JIRA : https://issues.apache.org/jira/browse/TEPHRA-227
You
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/39
(TEPHRA-226) Use older API to run as login user
JIRA : https://issues.apache.org/jira/browse/TEPHRA-226
You can merge this pull request into a Git repository by running:
$ git
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/37#discussion_r102122535
--- Diff:
tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/36
Release/0.11.0 incubating
Bumping up the version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tephra
release
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/35
@poornachandra The build is failing in a different compat module due to the
PruneUpperBoundWriter issue that I have fixed in compat-1.1-base module. Once
we port the changes to other
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100881247
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -81,14 +84,23
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/34#discussion_r100868455
--- Diff:
tephra-hbase-compat-0.96/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
@@ -341,6 +310,87 @@ public
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/35
(TEPHRA-219) Execute cross region calls in Coprocessor as the login user
i) Fixes a problem where the pruneThread would exit if the state of the
service is not yet set to RUNNING state
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/34#discussion_r100655264
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -322,6 +333,28
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/34#discussion_r100632563
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -322,6 +333,28
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/34#discussion_r100632110
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -322,6 +333,28
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/33
Use getRegion instead of getRegionInfo for hbase-0.98 compat module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gokulavasan
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/32
@poornachandra Addressed comments. Please take a look when you get a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r100173006
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -18,56 +18,56
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/32
@poornachandra Please review when you get a chance. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/31
@poornachandra Ported changes to other modules. Please take a look. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99964049
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
@@ -129,17 +168,19 @@ public
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/31#discussion_r99951182
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -147,6 +147,7
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/32
@poornachandra Can you please take a look again. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/32#discussion_r99903840
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriterSupplier.java
---
@@ -0,0 +1,52
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/32
(TEPHRA-215) (TEPHRA-218) Use single thread across all regions in a râ¦
â¦egion server to persist Prune Upper Bound info. Also don't refresh cache
during startup
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/30
Use getRegion instead of getRegionInfo for hbase-0.98 compat module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gokulavasan
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/29
@poornachandra Addressed comments. Please take a look again. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98801214
--- Diff:
tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
@@ -135,6 +138,15 @@ private
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/26
@poornachandra Do you have any thoughts on
https://github.com/apache/incubator-tephra/pull/26#issuecomment-276127210 ?
---
If your project is set up for it, you can reply to this email
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/29
@poornachandra Addressed comments. Please take a look when you get a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98137572
--- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java ---
@@ -369,6 +369,12 @@
* Interval in seconds to schedule prune
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/29
TEPHRA-212 Perform writes to prune state asynchronously
JIRA : https://issues.apache.org/jira/browse/TEPHRA-212
You can merge this pull request into a Git repository by running
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/28
@poornachandra Addressed your comment by making getConfiguration method
return a Configuration which could be nullable. Please look at
``ensureValidTxLifetime`` method since we now
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97699482
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -303,10 +305,22
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97660499
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +141,25
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97421801
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +141,25
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97421770
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +141,25
Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97421547
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +141,25
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/28
TEPHRA-210 Get table specific properties from tableDescriptor
And other properties from getConfiguration method, construct
compactionState lazily
JIRA : https
Github user gokulavasan closed the pull request at:
https://github.com/apache/incubator-tephra/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/27
@poornachandra @chtyim Please take a look. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user gokulavasan opened a pull request:
https://github.com/apache/incubator-tephra/pull/27
TEPHRA-210 Get table specific properties from tableDescriptor and othâ¦
â¦er properties from getConfiguration method allowing users to override it
to supply it
JIRA : https
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/25
@poornachandra Ported changes from PR#22 to all compat modules. Please
review PR when you get a chance. Thanks!
---
If your project is set up for it, you can reply to this email
Github user gokulavasan commented on the issue:
https://github.com/apache/incubator-tephra/pull/25
@poornachandra Can you review the commit
(https://github.com/apache/incubator-tephra/pull/25/commits/3db422bc73fd3aeb75e36b050b710bf1af15f22e)
where I have ported the changes from PR#22
62 matches
Mail list logo
