[GitHub] thrift pull request: THRIFT-3520 Dart TSocket onError type as Obje...

GitHub user markerickson-wf opened a pull request: https://github.com/apache/thrift/pull/770 THRIFT-3520 Dart TSocket onError type as Object Dart TSocket exposes `onError` as a `Stream`. However, the payload may be either a String or an Error, and should be typed as `Stream`.

[jira] [Updated] (THRIFT-3520) Dart TSocket onError stream should be typed as Object

[ https://issues.apache.org/jira/browse/THRIFT-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3520: -- Summary: Dart TSocket onError stream should be typed as Object (was: Dart TSocket onError

[jira] [Updated] (THRIFT-3520) Dart TSocket onError handler is too restrictive

[ https://issues.apache.org/jira/browse/THRIFT-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3520: -- Description: PROBLEM Dart TSocket exposes an onError Stream. However, the payload may be

[jira] [Commented] (THRIFT-3520) Dart TSocket onError stream should be typed as Object

[ https://issues.apache.org/jira/browse/THRIFT-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081817#comment-15081817 ] ASF GitHub Bot commented on THRIFT-3520: GitHub user markerickson-wf opened a pull request:

[jira] [Updated] (THRIFT-3520) Dart TSocket onError stream should be typed as Object

[ https://issues.apache.org/jira/browse/THRIFT-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3520: -- Description: PROBLEM Dart TSocket exposes an onError Stream. However, the payload may be

[jira] [Commented] (THRIFT-1653) TThreadedSelectorServer leaks CLOSE_WAIT sockets

[ https://issues.apache.org/jira/browse/THRIFT-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081759#comment-15081759 ] Jens Geyer commented on THRIFT-1653: [~xiaokang], would you mind to create a test case and a patch

[jira] [Created] (THRIFT-3520) Dart TSocket onError handler is too restrictive

Mark Erickson created THRIFT-3520: - Summary: Dart TSocket onError handler is too restrictive Key: THRIFT-3520 URL: https://issues.apache.org/jira/browse/THRIFT-3520 Project: Thrift Issue

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

Github user becrux closed the pull request at: https://github.com/apache/thrift/pull/628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081815#comment-15081815 ] ASF GitHub Bot commented on THRIFT-3437: Github user becrux closed the pull request at:

[jira] [Created] (THRIFT-3517) Default value of enum is starting at zero in Java

Andrew Zhang created THRIFT-3517: Summary: Default value of enum is starting at zero in Java Key: THRIFT-3517 URL: https://issues.apache.org/jira/browse/THRIFT-3517 Project: Thrift Issue

[jira] [Commented] (THRIFT-1653) TThreadedSelectorServer leaks CLOSE_WAIT sockets

[ https://issues.apache.org/jira/browse/THRIFT-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080848#comment-15080848 ] xiaokang commented on THRIFT-1653: -- the reason about creating this bug maybe is in

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build

Github user becrux commented on the pull request: https://github.com/apache/thrift/pull/771#issuecomment-168839987 @nsuke I've just committed changes using a new pull request. Hope that they'll be fine. Thanks, A. --- If your project is set up for it, you can reply to

[GitHub] thrift pull request: THRIFT-3520 Dart TSocket onError type as Obje...

Github user evanweible-wf commented on the pull request: https://github.com/apache/thrift/pull/770#issuecomment-168816225 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (THRIFT-3520) Dart TSocket onError stream should be typed as Object

[ https://issues.apache.org/jira/browse/THRIFT-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081841#comment-15081841 ] ASF GitHub Bot commented on THRIFT-3520: Github user evanweible-wf commented on the pull request:

[jira] [Commented] (THRIFT-3520) Dart TSocket onError stream should be typed as Object

[ https://issues.apache.org/jira/browse/THRIFT-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081835#comment-15081835 ] Jens Geyer commented on THRIFT-3520: I'm going to take care of them in the next days. Thanks for all

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081961#comment-15081961 ] ASF GitHub Bot commented on THRIFT-3437: Github user becrux commented on the pull request:

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081899#comment-15081899 ] ASF GitHub Bot commented on THRIFT-3437: GitHub user becrux opened a pull request:

[jira] [Commented] (THRIFT-3513) lib/cpp/src/thrift/TToString.h : the function "to_string" is not compatible for int8_t(byte)

[ https://issues.apache.org/jira/browse/THRIFT-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082251#comment-15082251 ] phoneli commented on THRIFT-3513: - Yeah , i had read this boost's document before asking questions. You

[jira] [Commented] (THRIFT-3513) lib/cpp/src/thrift/TToString.h : the function "to_string" is not compatible for int8_t(byte)

[ https://issues.apache.org/jira/browse/THRIFT-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082260#comment-15082260 ] phoneli commented on THRIFT-3513: - when a byte is equal to ten ( just like this : int8_t a = 10) , the

[jira] [Updated] (THRIFT-3518) TConcurrentClientSyncInfo files were missing for Visual Studio

[ https://issues.apache.org/jira/browse/THRIFT-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoshuang LU updated THRIFT-3518: -- Description: $. add TestService.thrift {code} namespace cpp test service TestService {

[jira] [Updated] (THRIFT-3518) TConcurrentClientSyncInfo files were missing for Visual Studio

[ https://issues.apache.org/jira/browse/THRIFT-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoshuang LU updated THRIFT-3518: -- Description: $. thrift file {code} namespace cpp test service TestService { i32

[jira] [Updated] (THRIFT-3518) TConcurrentClientSyncInfo files were missing for Visual Studio

[ https://issues.apache.org/jira/browse/THRIFT-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoshuang LU updated THRIFT-3518: -- Attachment: THRIFT-3518.patch > TConcurrentClientSyncInfo files were missing for Visual Studio

[jira] [Created] (THRIFT-3518) TConcurrentClientSyncInfo files were missing for Visual Studio

Xiaoshuang LU created THRIFT-3518: - Summary: TConcurrentClientSyncInfo files were missing for Visual Studio Key: THRIFT-3518 URL: https://issues.apache.org/jira/browse/THRIFT-3518 Project: Thrift

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

Github user becrux commented on the pull request: https://github.com/apache/thrift/pull/628#issuecomment-168705173 Hi @nsuke, really sorry for the delay, I was very busy during last month. I've prepared a new patch, according to your suggestions. How can I clean this

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081270#comment-15081270 ] ASF GitHub Bot commented on THRIFT-3437: Github user becrux commented on the pull request:

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build

GitHub user becrux opened a pull request: https://github.com/apache/thrift/pull/771 THRIFT-3437 - Fixed MinGW-w64 build You can merge this pull request into a Git repository by running: $ git pull https://github.com/becrux/thrift master Alternatively you can review and apply

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081470#comment-15081470 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on the pull request:

[jira] [Commented] (THRIFT-3513) lib/cpp/src/thrift/TToString.h : the function "to_string" is not compatible for int8_t(byte)

[ https://issues.apache.org/jira/browse/THRIFT-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081476#comment-15081476 ] James E. King, III commented on THRIFT-3513: I assume this is the result of looking at:

[jira] [Updated] (THRIFT-3513) lib/cpp/src/thrift/TToString.h : the function "to_string" is not compatible for int8_t(byte)

[ https://issues.apache.org/jira/browse/THRIFT-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3513: --- Labels: (was: bug) > lib/cpp/src/thrift/TToString.h : the function "to_string" is

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

Github user becrux commented on the pull request: https://github.com/apache/thrift/pull/628#issuecomment-168751457 Well, maybe it's better to start from the actual master revision ... do you agree? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/628#issuecomment-168750912 @becrux Thanks for that ! You can push your changes to the original branch of this pull request (in your case it seems master branch of your fork) and the changes will

[jira] [Updated] (THRIFT-3513) lib/cpp/src/thrift/TToString.h : the function "to_string" is not compatible for int8_t(byte)

[ https://issues.apache.org/jira/browse/THRIFT-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3513: --- Priority: Trivial (was: Major) > lib/cpp/src/thrift/TToString.h : the function

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081477#comment-15081477 ] ASF GitHub Bot commented on THRIFT-3437: Github user becrux commented on the pull request:

[jira] [Comment Edited] (THRIFT-3513) lib/cpp/src/thrift/TToString.h : the function "to_string" is not compatible for int8_t(byte)

[ https://issues.apache.org/jira/browse/THRIFT-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081476#comment-15081476 ] James E. King, III edited comment on THRIFT-3513 at 1/4/16 5:56 PM: I

[jira] [Comment Edited] (THRIFT-3513) lib/cpp/src/thrift/TToString.h : the function "to_string" is not compatible for int8_t(byte)

[ https://issues.apache.org/jira/browse/THRIFT-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081476#comment-15081476 ] James E. King, III edited comment on THRIFT-3513 at 1/4/16 5:56 PM: I

[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/768#issuecomment-168752457 Thanks for incorporating these :) Just tested this and it works fine including `-gen go`. The size is 151 MB which is even smaller than plain ubuntu or centos image

[jira] [Commented] (THRIFT-3474) Docker: thrift-compiler

[ https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081482#comment-15081482 ] ASF GitHub Bot commented on THRIFT-3474: Github user nsuke commented on the pull request:

[jira] [Created] (THRIFT-3519) fastbinary does not work with -gen py:utf8strings

Aki Sukegawa created THRIFT-3519: Summary: fastbinary does not work with -gen py:utf8strings Key: THRIFT-3519 URL: https://issues.apache.org/jira/browse/THRIFT-3519 Project: Thrift Issue

[jira] [Resolved] (THRIFT-3516) Add feature test for THeader TBinaryProtocol interop

[ https://issues.apache.org/jira/browse/THRIFT-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3516. -- Resolution: Fixed Fix Version/s: 1.0 > Add feature test for THeader TBinaryProtocol

[jira] [Resolved] (THRIFT-3515) Python 2.6 compatibility and test on CI

[ https://issues.apache.org/jira/browse/THRIFT-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3515. -- Resolution: Fixed Fix Version/s: 1.0 > Python 2.6 compatibility and test on CI >

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/628#issuecomment-168758978 yes, that would indeed be better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081533#comment-15081533 ] ASF GitHub Bot commented on THRIFT-3437: Github user becrux commented on the pull request:

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

Github user becrux commented on the pull request: https://github.com/apache/thrift/pull/628#issuecomment-168759296 Great. So, I could clean this pull request? Should I create a new one? --- If your project is set up for it, you can reply to this email and have your reply appear on

Build failed in Jenkins: thrift #576

See Changes: [nsuke] Update IDL spec [nsuke] THRIFT-3515 Python 2.6 compatibility and test on CI [nsuke] THRIFT-3516 Add feature test for THeader TBinaryProtocol -- [...truncated 1650

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/628#issuecomment-168761555 It may not be necessary because it will be updated automatically as you update your branch. But it's also totally fine to close this one and create new one. --- If

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081540#comment-15081540 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on the pull request: