[jira] [Commented] (THRIFT-2561) Enumerated types expressed as int, not "typedef"-ed, in objective-c compilation

[ https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831160#comment-15831160 ] ASF GitHub Bot commented on THRIFT-2561: Github user jfarrell closed the pull request at:

[GitHub] thrift pull request #325: THRIFT-2561: Typedef enums using NS_ENUM.

Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831159#comment-15831159 ] Jake Farrell commented on THRIFT-2504: -- mockito is MIT licensed so no issues, just needs to be given

[jira] [Commented] (THRIFT-2898) Generate -copyWithZone: method (NSCopying protocol)

[ https://issues.apache.org/jira/browse/THRIFT-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831156#comment-15831156 ] ASF GitHub Bot commented on THRIFT-2898: Github user jfarrell closed the pull request at:

[jira] [Commented] (THRIFT-2882) Lua Generator: using string.len funtion to get struct(map,list,set) size

[ https://issues.apache.org/jira/browse/THRIFT-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831155#comment-15831155 ] ASF GitHub Bot commented on THRIFT-2882: Github user jfarrell closed the pull request at:

[GitHub] thrift pull request #327: THRIFT-2898: Generated classes implement the NSCop...

Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #311: THRIFT-2882 Lua Generator: using string.len funtio...

Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-2899) Enum values should be prefixed with the Cocoa namespace

[ https://issues.apache.org/jira/browse/THRIFT-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2899. Resolution: Duplicate Assignee: James E. King, III Fix Version/s:

[jira] [Resolved] (THRIFT-2898) Generate -copyWithZone: method (NSCopying protocol)

[ https://issues.apache.org/jira/browse/THRIFT-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2898. Resolution: Duplicate Assignee: James E. King, III Fix Version/s:

[jira] [Commented] (THRIFT-2898) Generate -copyWithZone: method (NSCopying protocol)

[ https://issues.apache.org/jira/browse/THRIFT-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830613#comment-15830613 ] James E. King, III commented on THRIFT-2898: I believe this was implemented as part of

[jira] [Commented] (THRIFT-2896) Support specifying a custom base class for generated classes

[ https://issues.apache.org/jira/browse/THRIFT-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830607#comment-15830607 ] ASF GitHub Bot commented on THRIFT-2896: Github user jeking3 commented on the issue:

[GitHub] thrift issue #326: THRIFT-2896: Added support for a custom base class.

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/326 This needs to be rebased against the current master and squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (THRIFT-2561) Enumerated types expressed as int, not "typedef"-ed, in objective-c compilation

[ https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830601#comment-15830601 ] ASF GitHub Bot commented on THRIFT-2561: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-2561) Enumerated types expressed as int, not "typedef"-ed, in objective-c compilation

[ https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830602#comment-15830602 ] Phil Eaton commented on THRIFT-2561: Hello, Unfortunately you have reached me while I am at leave

[GitHub] thrift issue #325: THRIFT-2561: Typedef enums using NS_ENUM.

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/325 @jfarrell this pull request is not necessary as the work was done in a duplicate item. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Resolved] (THRIFT-2561) Enumerated types expressed as int, not "typedef"-ed, in objective-c compilation

[ https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2561. Resolution: Duplicate Assignee: James E. King, III Fix Version/s:

[jira] [Commented] (THRIFT-2882) Lua Generator: using string.len funtion to get struct(map,list,set) size

[ https://issues.apache.org/jira/browse/THRIFT-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830597#comment-15830597 ] ASF GitHub Bot commented on THRIFT-2882: Github user jeking3 commented on the issue:

[GitHub] thrift issue #311: THRIFT-2882 Lua Generator: using string.len funtion to ge...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/311 @jfarrell this pull request can be closed - I verified the code was merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (THRIFT-2721) generate more idiomatic erlang code

[ https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830587#comment-15830587 ] ASF GitHub Bot commented on THRIFT-2721: Github user jeking3 commented on the issue:

[GitHub] thrift issue #226: THRIFT-2721: reduce complexity of generated erlang code a...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/226 This would need to be rebased and corrected, pass CI builds and code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (THRIFT-2721) generate more idiomatic erlang code

[ https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830584#comment-15830584 ] James E. King, III commented on THRIFT-2721: You mentioned you felt like it could use a but

[jira] [Commented] (THRIFT-2668) TestSuite: detailed result on passed tests by feature

[ https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830581#comment-15830581 ] James E. King, III commented on THRIFT-2668: Based on a look through wwhat code exists today,

[jira] [Updated] (THRIFT-2721) generate more idiomatic erlang code

[ https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2721: --- Fix Version/s: (was: 1.0) > generate more idiomatic erlang code >

[jira] [Commented] (THRIFT-2668) TestSuite: detailed result on passed tests by feature

[ https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830567#comment-15830567 ] James E. King, III commented on THRIFT-2668: This issue has a pull request that is a couple

[jira] [Commented] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830564#comment-15830564 ] James E. King, III commented on THRIFT-2504: [~jfarrell] please command on whether having

[jira] [Updated] (THRIFT-4033) Default build WITH_PLUGIN=ON for all builds has resulting in too many packaging errors

[ https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4033: --- Assignee: James E. King, III Environment: Ubuntu 14.04.4 LTS is where I

[jira] [Commented] (THRIFT-4033) After building thrift-0.10.0 debian packages and installing them on Ubuntu 14.04, the thrift compiler does not work (packaged incorrectly)

[ https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830442#comment-15830442 ] ASF GitHub Bot commented on THRIFT-4033: Github user jfarrell commented on the issue:

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 sure, or modify the ticket description to 'disable compiler plug-ins by default for all builds' --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (THRIFT-4033) After building thrift-0.10.0 debian packages and installing them on Ubuntu 14.04, the thrift compiler does not work (packaged incorrectly)

[ https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830343#comment-15830343 ] ASF GitHub Bot commented on THRIFT-4033: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1157 I'm okay making the default for plug-in support "OFF", and you have to enable it specifically. Would it be okay to merge this as it fixes the ticket as described, and open a new one to change the

[jira] [Commented] (THRIFT-4033) After building thrift-0.10.0 debian packages and installing them on Ubuntu 14.04, the thrift compiler does not work (packaged incorrectly)

[ https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830337#comment-15830337 ] ASF GitHub Bot commented on THRIFT-4033: Github user jfarrell commented on the issue:

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 We have had issues with plugin support being on by default in a couple build instances now, and this does not fix when we pull out autoconf that it wont reappear with cmake. I'd like to see us

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1157 @jfarrell I'd like one review of this before I merge it. It did fix the issue I had with the stock 0.10.0 debian package for the compiler not working. --- If your project is set up for it, you

[jira] [Commented] (THRIFT-4033) After building thrift-0.10.0 debian packages and installing them on Ubuntu 14.04, the thrift compiler does not work (packaged incorrectly)

[ https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830227#comment-15830227 ] ASF GitHub Bot commented on THRIFT-4033: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3242) OSGi Import-Package directive is missing the Apache HTTP packages

[ https://issues.apache.org/jira/browse/THRIFT-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830203#comment-15830203 ] James E. King, III commented on THRIFT-3242: Could someone take a look at SM-3224 and make

[jira] [Commented] (THRIFT-184) Add OSGi Manifest headers to the libthrift java library to be able to use Thrift in the OSGi runtime

[ https://issues.apache.org/jira/browse/THRIFT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830197#comment-15830197 ] James E. King, III commented on THRIFT-184: --- Please see SM-3224 and see if our 0.10.0 jar has

[jira] [Commented] (THRIFT-184) Add OSGi Manifest headers to the libthrift java library to be able to use Thrift in the OSGi runtime

[ https://issues.apache.org/jira/browse/THRIFT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830193#comment-15830193 ] James E. King, III commented on THRIFT-184: --- Does this mean we do not need an Apache ServiceMix

[jira] [Commented] (THRIFT-3926) There should be an error emitted when http status code is not 200

[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830073#comment-15830073 ] ASF GitHub Bot commented on THRIFT-3926: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1086 As-is the patch would require string parsing to get the statusCode which is brittle. I like the overall direction of handling unexpected status code with an exception; consider using a derived

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830069#comment-15830069 ] ASF GitHub Bot commented on THRIFT-4034: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1161#discussion_r96876704 --- Diff: compiler/cpp/CMakeLists.txt --- @@ -101,9 +102,6 @@ THRIFT_ADD_COMPILER(xml "Enable compiler for XML" ON) # we also add the current

[GitHub] thrift pull request #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1161#discussion_r96876857 --- Diff: compiler/cpp/CMakeLists.txt --- @@ -16,30 +16,30 @@ # specific language governing permissions and limitations # under the License. #

[GitHub] thrift pull request #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1161#discussion_r96876685 --- Diff: compiler/cpp/CMakeLists.txt --- @@ -53,6 +53,7 @@ set(compiler_core set(thrift-compiler_SOURCES src/thrift/main.cc

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830068#comment-15830068 ] ASF GitHub Bot commented on THRIFT-4034: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830067#comment-15830067 ] ASF GitHub Bot commented on THRIFT-4034: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-3926) There should be an error emitted when http status code is not 200

[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829786#comment-15829786 ] ASF GitHub Bot commented on THRIFT-3926: Github user lifei commented on the issue:

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user lifei commented on the issue: https://github.com/apache/thrift/pull/1086 > I think that putting the statusCode into the text description would be useful here added --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (THRIFT-3926) There should be an error emitted when http status code is not 200

[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829576#comment-15829576 ] ASF GitHub Bot commented on THRIFT-3926: Github user RobberPhex commented on the issue:

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1086 status code not equal 200 doesn't means it's a `TApplicationException`. * When status code is 301/3xx, should thrift client follow the redirect? * In some server implements, server

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829562#comment-15829562 ] ASF GitHub Bot commented on THRIFT-4034: Github user RobberPhex commented on the issue:

[jira] [Updated] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Lu updated THRIFT-4034: -- External issue URL: https://github.com/apache/thrift/pull/1161 > CMake doesn't work to build compiler

[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 https://issues.apache.org/jira/browse/THRIFT-4034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request #1161: Thrift-4034 CMake doesn't work to build compiler

GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1161 Thrift-4034 CMake doesn't work to build compiler You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-4034

[jira] [Created] (THRIFT-4034) CMake doesn't work to build compiler

Robert Lu created THRIFT-4034: - Summary: CMake doesn't work to build compiler Key: THRIFT-4034 URL: https://issues.apache.org/jira/browse/THRIFT-4034 Project: Thrift Issue Type: Bug