[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404221#comment-16404221 ] ASF GitHub Bot commented on THRIFT-4489: Github user danielhtshih commented on the issue:

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

2018-03-18 Thread danielhtshih
Github user danielhtshih commented on the issue: https://github.com/apache/thrift/pull/1491 I believe the unexpected failures from the latest run is not related to my changes for nodejs. Maybe it needs another merge from master branch? ```

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

2018-03-18 Thread Jens Geyer
Hi, occasionally the "make clean" rules seem to run out of sync (probably because nobody tests that). I run into similar things a few times myself. If it happens that find the guilty, please fix it. Thanks + have fun, JensG -Ursprüngliche Nachricht- From: Allen George Sent:

[jira] [Created] (THRIFT-4522) d-cpp_binary_buffered-ip-ssl cross test shows a dlang binary protocol issue

2018-03-18 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4522: -- Summary: d-cpp_binary_buffered-ip-ssl cross test shows a dlang binary protocol issue Key: THRIFT-4522 URL: https://issues.apache.org/jira/browse/THRIFT-4522

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404002#comment-16404002 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-18 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 All green! :) ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403958#comment-16403958 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on a diff in the pull

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-03-18 Thread ozymaxx
Github user ozymaxx commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r175284941 --- Diff: build/appveyor/MSVC-appveyor-build.bat --- @@ -39,7 +39,7 @@ CD "%BUILDDIR%" || EXIT /B

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403957#comment-16403957 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on a diff in the pull

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-03-18 Thread ozymaxx
Github user ozymaxx commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r175284886 --- Diff: compiler/cpp/src/thrift/generate/t_generator.h --- @@ -268,6 +271,30 @@ class t_generator { return out.str(); } + const