[jira] [Commented] (THRIFT-5233) I/O timeout handling in go library

[ https://issues.apache.org/jira/browse/THRIFT-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134564#comment-17134564 ] Duru Can Celasun commented on THRIFT-5233: -- > I started to look into the rabbit hole of I/O

[jira] [Created] (THRIFT-5233) I/O timeout handling in go library

Yuxuan Wang created THRIFT-5233: --- Summary: I/O timeout handling in go library Key: THRIFT-5233 URL: https://issues.apache.org/jira/browse/THRIFT-5233 Project: Thrift Issue Type: Improvement

[jira] [Comment Edited] (THRIFT-5230) Fix connection leak and CancelledKeyException when handling Epoll bug

[ https://issues.apache.org/jira/browse/THRIFT-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134504#comment-17134504 ] Jens Geyer edited comment on THRIFT-5230 at 6/12/20, 8:08 PM: -- > This issue

[jira] [Commented] (THRIFT-5230) Fix connection leak and CancelledKeyException when handling Epoll bug

[ https://issues.apache.org/jira/browse/THRIFT-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134504#comment-17134504 ] Jens Geyer commented on THRIFT-5230: > This issue has been reported before: So this is a duplicate? 

[GitHub] [thrift] Jens-G closed pull request #2177: THRIFT-4926: Adding LOGGER.isDebugEnabled() conditions into TSaslTransport

Jens-G closed pull request #2177: URL: https://github.com/apache/thrift/pull/2177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (THRIFT-4928) Sensitive information about expected and actual reading lengths (len, got) is leaked from TIOStreamTransport to TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4928. -- Assignee: Jens Geyer Resolution: Invalid > Sensitive information about expected and actual

[jira] [Commented] (THRIFT-4928) Sensitive information about expected and actual reading lengths (len, got) is leaked from TIOStreamTransport to TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134503#comment-17134503 ] Jens Geyer commented on THRIFT-4928: TTransportExceptions never leave the machine where they are

[jira] [Closed] (THRIFT-4929) Sensitive information about socket input stream or output stream is leaked from TIOStreamTransport

[ https://issues.apache.org/jira/browse/THRIFT-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4929. -- Assignee: Jens Geyer Resolution: Invalid Logging such messages is perfectly legit. >

[jira] [Closed] (THRIFT-4926) An information leakage from TSaslTransport

[ https://issues.apache.org/jira/browse/THRIFT-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4926. -- Assignee: Jens Geyer Resolution: Invalid Logging such messages is perfectly legit. Furthermore,

[jira] [Commented] (THRIFT-5232) .net Thrift nuget package TSocket(host,port) fails for all non local host connections

[ https://issues.apache.org/jira/browse/THRIFT-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134497#comment-17134497 ] Andrew Denner commented on THRIFT-5232: --- The code with the TSocket(host,port) worked in version

[jira] [Closed] (THRIFT-4925) An information leakage from TSaslClientTransport

[ https://issues.apache.org/jira/browse/THRIFT-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4925. -- Assignee: Jens Geyer Resolution: Invalid Logging such messages is perfectly legit. Furthermore,

[jira] [Closed] (THRIFT-4924) An information leakage from TSocket

[ https://issues.apache.org/jira/browse/THRIFT-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4924. -- Assignee: Jens Geyer Resolution: Invalid Logging such messages is perfectly legit. Furthermore,

[GitHub] [thrift] Jens-G closed pull request #2178: THRIFT-4928: Adding LOGGER.isInfoEnabled() condition into TTransport

Jens-G closed pull request #2178: URL: https://github.com/apache/thrift/pull/2178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (THRIFT-4923) An information leakage from TIOStreamTransport

[ https://issues.apache.org/jira/browse/THRIFT-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4923. -- Assignee: Jens Geyer Resolution: Invalid Logging such messages is perfectly legit. Furthermore,

[jira] [Closed] (THRIFT-4922) Sensitive information is leaked from TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4922. -- Resolution: Invalid TTransportExceptions never leave the machine where they are raised/thrown.

[jira] [Reopened] (THRIFT-4922) Sensitive information is leaked from TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reopened THRIFT-4922: Assignee: Jens Geyer > Sensitive information is leaked from TTransport through a

[jira] [Closed] (THRIFT-4922) Sensitive information is leaked from TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4922. -- Resolution: Fixed > Sensitive information is leaked from TTransport through a TTransportException >

[jira] [Created] (THRIFT-5232) .net Thrift nuget package TSocket(host,port) fails for all non local host connections

Andrew Denner created THRIFT-5232: - Summary: .net Thrift nuget package TSocket(host,port) fails for all non local host connections Key: THRIFT-5232 URL: https://issues.apache.org/jira/browse/THRIFT-5232

[jira] [Closed] (THRIFT-4930) An information leakage about socket input stream or output stream from TIOStreamTransport to TSocket

[ https://issues.apache.org/jira/browse/THRIFT-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4930. -- Assignee: Jens Geyer Resolution: Invalid Printing information via LOGGER is not a security

[GitHub] [thrift] Jens-G closed pull request #2179: THRIFT-4930: Remove LOGGER.warn in org.apache.thrift.transport.TSocket

Jens-G closed pull request #2179: URL: https://github.com/apache/thrift/pull/2179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Comment Edited] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134473#comment-17134473 ] Duru Can Celasun edited comment on THRIFT-5164 at 6/12/20, 7:35 PM:

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134473#comment-17134473 ] Duru Can Celasun commented on THRIFT-5164: -- I think both approaches have their merits.

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134449#comment-17134449 ] Serhii Kanin commented on THRIFT-5164: -- [~dcelasun], hello, what do you think regarding our

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134447#comment-17134447 ] Serhii Kanin commented on THRIFT-5164: -- [~fishywang], thanks for your attention :) > Go middleware

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1713#comment-1713 ] Yuxuan Wang commented on THRIFT-5164: - As I [said

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134434#comment-17134434 ] Serhii Kanin commented on THRIFT-5164: -- [~fishywang] should work if I provide a mapping by name:

[jira] [Issue Comment Deleted] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Serhii Kanin updated THRIFT-5164: - Comment: was deleted (was: [~fishywang] should work if I provide a mapping by name:

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134433#comment-17134433 ] Serhii Kanin commented on THRIFT-5164: -- [~fishywang] should work if I provide a mapping by name:

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134427#comment-17134427 ] Serhii Kanin commented on THRIFT-5164: -- "You suggest to have a dedicated middleware for every

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134424#comment-17134424 ] Yuxuan Wang commented on THRIFT-5164: - {code}respGenerator map[string]func() thrift.TStruct{code}

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134422#comment-17134422 ] Serhii Kanin commented on THRIFT-5164: -- [~fishywang] thanks for the answer, so we are close to get

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134411#comment-17134411 ] Yuxuan Wang commented on THRIFT-5164: - This is an example of using middleware to do json response

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134372#comment-17134372 ] Serhii Kanin commented on THRIFT-5164: -- [~fishywang] it is not a problem to retrieve a data from

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134353#comment-17134353 ] Yuxuan Wang commented on THRIFT-5164: - [~USERHII] I think that is still doable with middleware, just

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134346#comment-17134346 ] Jens Geyer commented on THRIFT-5164: Just an idea: What about turning the "our fork" into an PR? >

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134321#comment-17134321 ] Serhii Kanin commented on THRIFT-5164: -- [~fishywang] with middleware we don't have an access to

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134304#comment-17134304 ] Yuxuan Wang commented on THRIFT-5164: - [~USERHII] is there anything interceptor can do that

[jira] [Commented] (THRIFT-5164) Go middleware support

[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134265#comment-17134265 ] Serhii Kanin commented on THRIFT-5164: -- [~fishywang] hi. You merged a middleware fork that does not