GitHub user ozymaxx opened a pull request:
https://github.com/apache/thrift/pull/1511
THRIFT-4476: Typecasting problem on double list items, emitting doubles
with high precision (for Java, C++, Python, JS and Erlang)
All commits have been squashed into one
see the related issue
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1510
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1510
@jeking3 I squashed all into one commit and opened another branch (I had
some problems while changing the history)
---
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
GitHub user ozymaxx opened a pull request:
https://github.com/apache/thrift/pull/1510
THRIFT-4476: Typecasting problem on floating-point list items, emitting
doubles with high precision in Python, JS, Java, C++ and Erlang
Squashed version
see the related issue: https
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
Thanks! I have just caught the meaning of squash since it's been the first
time i try to contribute an open source project. I will squash all into a
single one and let you know from here.
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
All green! :)
---
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r175284941
--- Diff: build/appveyor/MSVC-appveyor-build.bat ---
@@ -39,7 +39,7 @@ CD "%BUILDDIR%" || EXIT /B
-DW
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r175284886
--- Diff: compiler/cpp/src/thrift/generate/t_generator.h ---
@@ -268,6 +271,30 @@ class t_generator {
return out.str();
}
+ const
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
@jeking3 the build results have come out.
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
I have reverted the changes on passing the compiler flag to the testers,
and modified the double emitter.
---
GitHub user ozymaxx reopened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
@jeking3 or another alternative path to go: emitting double can depend on
the msvc compiler version. If the compiler version is 2013 or less, we can
ignore using fixed.
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
@jeking3 , I will now re-enable the tests. But please note that the problem
is at the C++ compiler level. The pre-2015 versions of the Visual Studio C++
compilers uses a different parsing
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
Okay, I will add a condition on the tests. The values to do the assertions
with will depend on the compiler.
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
Btw, what's the full name of the test which you want to succeed? I squashed
to another commit and will take a look if this test has passed or not (I hope
there is not something wrong related to my
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174687128
--- Diff: test/py/RunClientServer.py ---
@@ -298,7 +300,11 @@ def main():
print('')
for genpydir in generated_dirs
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174687088
--- Diff: test/py/CMakeLists.txt ---
@@ -27,7 +27,7 @@ add_test(NAME python_test_generate
)
add_test(NAME python_test
-COMMAND
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174686538
--- Diff: lib/java/gradle/unitTests.gradle ---
@@ -68,6 +68,20 @@ test {
include '**/Test*.class'
exclude '**/Test*\$*.class
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174686397
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
@jeking3 Forget about what I said on Travis. There is only 1 failure in
Apache arsenal of Travis (at `cross-test`) as follows
GitHub user ozymaxx reopened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
The build on the `CYGWIN x86` (see
https://ci.appveyor.com/project/ozymaxx/thrift/build/job/09xqx9b54efog55o for
more details) machine has broken. Here is the error that I got
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
I have just disabled my new tests on `MSVC2013` builders and kicked a
build. Let's see what happens.
If the tests also fail on the `CYGWIN` machine, I will also write out new
tests for the x86
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
The AppVeyor builder with the `MSVC2013` configuration generates large
double constants differently as the old `MSVC2010` configuration used to do. So
I will add a condition to not do
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
I merged the changes in the master branch into mine, and ran the builds.
There are still some errors:
On AppVeyor:
```
3125"C:\projects\build\MSVC2017\x64\INSTALL.vc
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
I finalized the changes, however there are a couple of errors in my builds
which I think are irrelevant to my changes.
Here are the links to my build results (please let me know if you
GitHub user ozymaxx reopened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
Okay, I will open it back once I am done.
---
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
Two errors at the initial steps of my builds:
* The one in Travis (happening in multiple builds):
```
Resolving master.dl.sourceforge.net (master.dl.sourceforge.net)...
216.105.38.12
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
The AppVeyor builds stay in the queue for a long time. Is there any
possibility to run the builds more quickly?
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1497
I also encounter the same error, but it does not show up every time I run
the tests on Travis CI.
---
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
It appears that there is another compilation problem in Erlang. In the file
`test/DoubleConstantsTest.thrift`, the double literal `100.1` is compiled
to `1e+06`. However, Erlang does not accept
GitHub user ozymaxx opened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python
37 matches
Mail list logo
