[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.

Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1312 You must use the generator compiled from the master branch. ---

[GitHub] thrift pull request #1312: Add context as first arg for client method.

GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1312 Add context as first arg for client method. Related: https://issues.apache.org/jira/browse/THRIFT-4260 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] thrift pull request #1312: Add context as first arg for client method.

Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request #1312: Add context as first arg for client method.

GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1312 Add context as first arg for client method. Related: https://issues.apache.org/jira/browse/THRIFT-4260 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] thrift pull request #1312: Add context as first arg for client method.

Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift issue #1309: Use build tags to support context.

Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1309 I will try to fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] thrift pull request #1312: Add context as first arg for client method.

GitHub user taozle opened a pull request: https://github.com/apache/thrift/pull/1312 Add context as first arg for client method. Related: https://issues.apache.org/jira/browse/THRIFT-4260 You can merge this pull request into a Git repository by running: $ git pull https

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097594#comment-16097594 ] taozle commented on THRIFT-4260: The commit is intended to add the context in only server side, and i

[GitHub] thrift issue #1309: Use build tags to support context.

Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1309 Seems that the failed tests has nothing with this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request #1309: Use build tags to support context.

GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1309 Use build tags to support context. As the comment in https://issues.apache.org/jira/browse/THRIFT-4236, this PR use build tags to support context in go1.7 above. You can merge this pull request

[GitHub] thrift pull request #1309: Use build tags to support context.

Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request #1309: Use build tags to support context.

Github user taozle commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r128160543 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, &qu

[GitHub] thrift pull request #1309: Use build tags to support context.

Github user taozle commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r128159321 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, &qu

[GitHub] thrift pull request #1309: Use build tags to support context.

Github user taozle commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r128158624 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, &qu

[GitHub] thrift pull request #1309: Use build tags to support context.

Github user taozle commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r128156419 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, &qu

[GitHub] thrift pull request #1309: Use build tags to support context.

Github user taozle commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r128145013 --- Diff: lib/go/thrift/multiplexed_processor.go --- @@ -1,3 +1,5 @@ +// +build go1.7 --- End diff -- Agreed, i will fix it. --- If your

[GitHub] thrift pull request #1309: Use build tags to support context.

Github user taozle commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r128144782 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, &qu

[GitHub] thrift pull request #1309: Use build tags to support context.

GitHub user taozle opened a pull request: https://github.com/apache/thrift/pull/1309 Use build tags to support context. As the comment in https://issues.apache.org/jira/browse/THRIFT-4236, this PR use build tags to support context in go1.7 above. You can merge this pull request

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084196#comment-16084196 ] taozle commented on THRIFT-4236: Maybe i can work on this this weekend or next week if it was not too

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071878#comment-16071878 ] taozle commented on THRIFT-4236: Awesome! I am considering making this the default behavior in 1.0, any

[GitHub] thrift pull request #1298: THRIFT-4236: Add context support for go server.

Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request #1298: THRIFT-4236: Add context support for go server.

GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1298 THRIFT-4236: Add context support for go server. This commit add the context support for thrift server side in go. for compatibility, added a use_context option in go's generator option

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069956#comment-16069956 ] taozle commented on THRIFT-4236: {quote}Could you adjust the build scripts version checks accordingly

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065827#comment-16065827 ] taozle commented on THRIFT-4236: Hi, [~jensg], I fired a pull request for adding context support

[GitHub] thrift pull request #1298: THRIFT-4236: Add context support for go server.

Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request #1298: THRIFT-4236: Add context support for go server.

GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1298 THRIFT-4236: Add context support for go server. This commit add the context support for thrift server side in go. for compatibility, added a use_context option in go's generator option

[GitHub] thrift pull request #1298: THRIFT-4236: Add context support for go server.

GitHub user taozle opened a pull request: https://github.com/apache/thrift/pull/1298 THRIFT-4236: Add context support for go server. This commit add the context support for thrift server side in go. for compatibility, added a use_context option in go's generator option

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062841#comment-16062841 ] taozle commented on THRIFT-4236: I don't think the {{THeaderTransport}} is what i want. The {{context

[jira] [Created] (THRIFT-4236) Support context in go generated code.

taozle created THRIFT-4236: -- Summary: Support context in go generated code. Key: THRIFT-4236 URL: https://issues.apache.org/jira/browse/THRIFT-4236 Project: Thrift Issue Type: Improvement