[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106959992 --- Diff: compiler/cpp/src/thrift/parse/t_field.h --- @@ -68,7 +68,7 @@ class t_field : public t_doc { int32_t get_key() const { return key_; }

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106796226 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c --- @@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v)

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106796208 --- Diff: compiler/cpp/src/thrift/parse/t_field.h --- @@ -68,7 +68,7 @@ class t_field : public t_doc { int32_t get_key() const {

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106796209 --- Diff: lib/cpp/src/thrift/protocol/TCompactProtocol.tcc --- @@ -387,7 +389,11 @@ uint32_t TCompactProtocolT::writeVarint64(uint64_t n) {

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106795259 --- Diff: lib/cpp/src/thrift/protocol/TCompactProtocol.tcc --- @@ -387,7 +389,11 @@ uint32_t TCompactProtocolT::writeVarint64(uint64_t n) { */

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106794729 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c --- @@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v)

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106794619 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c --- @@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v)

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106794199 --- Diff: compiler/cpp/src/thrift/parse/t_field.h --- @@ -68,7 +68,7 @@ class t_field : public t_doc { int32_t get_key() const {

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106794187 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c --- @@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v)

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106793777 --- Diff: compiler/cpp/src/thrift/parse/t_field.h --- @@ -68,7 +68,7 @@ class t_field : public t_doc { int32_t get_key() const { return key_; }

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106793785 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c --- @@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v)

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

GitHub user jbapple-cloudera opened a pull request: https://github.com/apache/thrift/pull/1214 THRIFT-2026: Eliminate some undefined behavior in C/C++ Clients: glib, C++ Patch: Jim Apple These examples of undefined behavior were found using