[GitHub] thrift pull request #1130: fix typo in package name.

GitHub user matyapiro31 opened a pull request: https://github.com/apache/thrift/pull/1130 fix typo in package name. fix: php-7.0 -> php7.0 php-7.0-dev -> php7.0-dev You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-3964) Unsupported mechanism type ????? due to dependency on default OS-dependent charset

[ https://issues.apache.org/jira/browse/THRIFT-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674796#comment-15674796 ] Gary Gregory commented on THRIFT-3964: -- Jens, Just now, I did a 'git clone

[jira] [Commented] (THRIFT-3964) Unsupported mechanism type ????? due to dependency on default OS-dependent charset

[ https://issues.apache.org/jira/browse/THRIFT-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674869#comment-15674869 ] Gary Gregory commented on THRIFT-3964: -- Done: https://github.com/apache/thrift/pull/1134 >

[jira] [Resolved] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3828. Resolution: Won't Fix Fix Version/s: 0.11.0 Based on the discussion I am

[jira] [Commented] (THRIFT-3348) PHP TCompactProtocol bool readvalue bug

[ https://issues.apache.org/jira/browse/THRIFT-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674718#comment-15674718 ] ASF GitHub Bot commented on THRIFT-3348: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-3348) PHP TCompactProtocol bool readvalue bug

[ https://issues.apache.org/jira/browse/THRIFT-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3348. Resolution: Fixed Assignee: Håkon Hitland Fix Version/s: 0.11.0 Committed, thanks!

[jira] [Issue Comment Deleted] (THRIFT-3977) PHP extension creates undefined values when deserializing sets

[ https://issues.apache.org/jira/browse/THRIFT-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3977: --- Comment: was deleted (was: How is that related to THRIFT-3977? Is it the same issue maybe?) > PHP

[jira] [Commented] (THRIFT-3964) Unsupported mechanism type ????? due to dependency on default OS-dependent charset

[ https://issues.apache.org/jira/browse/THRIFT-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674815#comment-15674815 ] Jens Geyer commented on THRIFT-3964: Sure, against master, of course. If you're on Github anyway,

[GitHub] thrift pull request #1134: [THRIFT-3964] Unsupported mechanism type ????? du...

GitHub user garydgregory opened a pull request: https://github.com/apache/thrift/pull/1134 [THRIFT-3964] Unsupported mechanism type ? due to dependency on default OS-dependent charset See https://issues.apache.org/jira/browse/THRIFT-3964 You can merge this pull request into a

[jira] [Resolved] (THRIFT-3977) PHP extension creates undefined values when deserializing sets

[ https://issues.apache.org/jira/browse/THRIFT-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3977. Resolution: Fixed Assignee: Håkon Hitland Fix Version/s: 0.11.0 Committed, thank

[jira] [Commented] (THRIFT-3977) PHP extension creates undefined values when deserializing sets

[ https://issues.apache.org/jira/browse/THRIFT-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674760#comment-15674760 ] ASF GitHub Bot commented on THRIFT-3977: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1133: THRIFT-3977 PHP extension creates undefined value...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1132: THRIFT-3348 PHP TCompactProtocol bool readv...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3964) Unsupported mechanism type ????? due to dependency on default OS-dependent charset

[ https://issues.apache.org/jira/browse/THRIFT-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674867#comment-15674867 ] ASF GitHub Bot commented on THRIFT-3964: GitHub user garydgregory opened a pull request:

[jira] [Commented] (THRIFT-3886) PHP cross test client returns 0 even when failing

[ https://issues.apache.org/jira/browse/THRIFT-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674697#comment-15674697 ] Jens Geyer commented on THRIFT-3886: We now have two patches for one issue. Could you two guys come

[jira] [Commented] (THRIFT-3977) PHP extension creates undefined values when deserializing sets

[ https://issues.apache.org/jira/browse/THRIFT-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674510#comment-15674510 ] ASF GitHub Bot commented on THRIFT-3977: GitHub user zhaakhi opened a pull request:

[jira] [Commented] (THRIFT-3977) PHP extension creates undefined values when deserializing sets

[ https://issues.apache.org/jira/browse/THRIFT-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674647#comment-15674647 ] Jens Geyer commented on THRIFT-3977: How is that related to THRIFT-3977 > PHP extension creates

[jira] [Created] (THRIFT-3977) PHP extension creates undefined values when deserializing sets

Håkon Hitland created THRIFT-3977: - Summary: PHP extension creates undefined values when deserializing sets Key: THRIFT-3977 URL: https://issues.apache.org/jira/browse/THRIFT-3977 Project: Thrift

[GitHub] thrift pull request #1132: THRIFT-3348 PHP TCompactProtocol bool readv...

GitHub user zhaakhi opened a pull request: https://github.com/apache/thrift/pull/1132 THRIFT-3348 PHP TCompactProtocol bool readvalue bug TCompactProtocol always serializes boolean struct values as false, due to a confusion between the internal compact type field representation

[jira] [Commented] (THRIFT-3886) PHP cross test client returns 0 even when failing

[ https://issues.apache.org/jira/browse/THRIFT-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674503#comment-15674503 ] ASF GitHub Bot commented on THRIFT-3886: GitHub user zhaakhi opened a pull request:

[jira] [Commented] (THRIFT-3348) PHP TCompactProtocol bool readvalue bug

[ https://issues.apache.org/jira/browse/THRIFT-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674508#comment-15674508 ] ASF GitHub Bot commented on THRIFT-3348: GitHub user zhaakhi opened a pull request:

[GitHub] thrift pull request #1133: THRIFT-3977 PHP extension creates undefined value...

GitHub user zhaakhi opened a pull request: https://github.com/apache/thrift/pull/1133 THRIFT-3977 PHP extension creates undefined values when deserializing… … sets Fix to set values to 'true' instead of undefined, matching the comment and old behaviour. You can

[jira] [Comment Edited] (THRIFT-3977) PHP extension creates undefined values when deserializing sets

[ https://issues.apache.org/jira/browse/THRIFT-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674647#comment-15674647 ] Jens Geyer edited comment on THRIFT-3977 at 11/17/16 7:55 PM: -- How is that

[GitHub] thrift pull request #1131: THRIFT-3886 PHP cross test client returns 0 even ...

GitHub user zhaakhi opened a pull request: https://github.com/apache/thrift/pull/1131 THRIFT-3886 PHP cross test client returns 0 even when failing PHP tests are mostly not asserting that the returned result is as expected, nor do they return an error for unknown protocols.

[jira] [Commented] (THRIFT-3964) Unsupported mechanism type ????? due to dependency on default OS-dependent charset

[ https://issues.apache.org/jira/browse/THRIFT-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674677#comment-15674677 ] Jens Geyer commented on THRIFT-3964: {code} import java.io.UnsupportedEncodingException;

[GitHub] thrift pull request #1128: THRIFT-3873: fix compiler warnings on windows wit...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1128#discussion_r88560045 --- Diff: compiler/cpp/CMakeLists.txt --- @@ -18,6 +18,16 @@ # configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/version.h.in

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674972#comment-15674972 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1128: THRIFT-3873: fix compiler warnings on windows wit...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1128#discussion_r88559811 --- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp --- @@ -60,7 +60,7 @@ #endif // _WIN32 #endif -#if defined(_WIN32) &&

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675137#comment-15675137 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-3978) Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds

[ https://issues.apache.org/jira/browse/THRIFT-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675133#comment-15675133 ] James E. King, III commented on THRIFT-3978: Discovered when addressing code review comments

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674976#comment-15674976 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 commented on a diff in the pull

[jira] [Created] (THRIFT-3978) Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds

James E. King, III created THRIFT-3978: -- Summary: Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds Key: THRIFT-3978 URL:

[jira] [Updated] (THRIFT-3978) Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds

[ https://issues.apache.org/jira/browse/THRIFT-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3978: --- Labels: security (was: ) > Thrift C++ runtime uses assert to prevent overflows,

[GitHub] thrift pull request #1128: THRIFT-3873: fix compiler warnings on windows wit...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1128#discussion_r88571093 --- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h --- @@ -135,8 +141,9 @@ class THeaderTransport : public TVirtualTransport

[jira] [Updated] (THRIFT-3979) offer TExtendedBinaryProtocol for customers

[ https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoshuang LU updated THRIFT-3979: -- Description: Sometimes, customers wanna put some options (username, password, id, etc.) in

[jira] [Updated] (THRIFT-3980) add TExtendedBinaryProtocol.java

[ https://issues.apache.org/jira/browse/THRIFT-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoshuang LU updated THRIFT-3980: -- Attachment: THRIFT-3980.patch > add TExtendedBinaryProtocol.java >

[jira] [Created] (THRIFT-3980) add TExtendedBinaryProtocol.java

Xiaoshuang LU created THRIFT-3980: - Summary: add TExtendedBinaryProtocol.java Key: THRIFT-3980 URL: https://issues.apache.org/jira/browse/THRIFT-3980 Project: Thrift Issue Type: Sub-task

[jira] [Created] (THRIFT-3979) offer TExtendedBinaryProtocol for customers

Xiaoshuang LU created THRIFT-3979: - Summary: offer TExtendedBinaryProtocol for customers Key: THRIFT-3979 URL: https://issues.apache.org/jira/browse/THRIFT-3979 Project: Thrift Issue Type: