[jira] [Commented] (THRIFT-2873) TPipe and TPipeServer don't compile on windows with UNICODE enabled

[ https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14233998#comment-14233998 ] Jens Geyer commented on THRIFT-2873: Hi, What Microsoft suggests may not be right

[jira] [Updated] (THRIFT-2873) TPipe and TPipeServer don't compile on windows with UNICODE enabled

[ https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Bach updated THRIFT-2873: Attachment: 0001v2-Make-TPipe-and-TPipeServer-working-with-unicode-on-w.patch Based on your

[jira] [Updated] (THRIFT-2873) TPipe and TPipeServer don't compile on Windows with UNICODE enabled

[ https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Bach updated THRIFT-2873: Summary: TPipe and TPipeServer don't compile on Windows with UNICODE enabled (was: TPipe and

[jira] [Commented] (THRIFT-2800) error in running make : error in thrifty.cc the method yyparse() reserch the method strdup() (not declared)

[ https://issues.apache.org/jira/browse/THRIFT-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234207#comment-14234207 ] saber hattay commented on THRIFT-2800: -- Hello, Jens Geyer suggest to try the

[jira] [Commented] (THRIFT-2873) TPipe and TPipeServer don't compile on Windows with UNICODE enabled

[ https://issues.apache.org/jira/browse/THRIFT-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234216#comment-14234216 ] Ben Craig commented on THRIFT-2873: --- +1 TPipe and TPipeServer don't compile on

[jira] [Updated] (THRIFT-2832) c_glib: Handle string lists correctly

[ https://issues.apache.org/jira/browse/THRIFT-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon South updated THRIFT-2832: Patch Info: Patch Available c_glib: Handle string lists correctly

[jira] [Updated] (THRIFT-2832) c_glib: Handle string lists correctly

[ https://issues.apache.org/jira/browse/THRIFT-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon South updated THRIFT-2832: Attachment: thrift-2832-c_glib-handle-string-lists-correctly.patch I've attached a patch that

[jira] [Commented] (THRIFT-2260) Thrift imposes unneeded dependency on commons-lang3

[ https://issues.apache.org/jira/browse/THRIFT-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234376#comment-14234376 ] Mike Rettig commented on THRIFT-2260: - The new implementation could be a lot faster

[jira] [Commented] (THRIFT-2800) error in running make : error in thrifty.cc the method yyparse() reserch the method strdup() (not declared)

[ https://issues.apache.org/jira/browse/THRIFT-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234588#comment-14234588 ] Jens Geyer commented on THRIFT-2800: {quote} Visual Studio Projet... build works

[jira] [Comment Edited] (THRIFT-2800) error in running make : error in thrifty.cc the method yyparse() reserch the method strdup() (not declared)

[ https://issues.apache.org/jira/browse/THRIFT-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234588#comment-14234588 ] Jens Geyer edited comment on THRIFT-2800 at 12/4/14 8:31 PM: -

[jira] [Comment Edited] (THRIFT-2800) error in running make : error in thrifty.cc the method yyparse() reserch the method strdup() (not declared)

[ https://issues.apache.org/jira/browse/THRIFT-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234588#comment-14234588 ] Jens Geyer edited comment on THRIFT-2800 at 12/4/14 8:31 PM: -

[jira] [Assigned] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2789: -- Assignee: Jens Geyer TNonblockingServer leaks socket FD's under load

[jira] [Updated] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2789: --- Attachment: THRIFT-2789-TNonblockingServer-leaks-socket-FD-s-und.patch TNonblockingServer leaks

[jira] [Commented] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234607#comment-14234607 ] Jens Geyer commented on THRIFT-2789: [Condsoldidated and rebased version of the

[jira] [Resolved] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2789. Resolution: Fixed Fix Version/s: 0.9.3 Committed, thank you both! TNonblockingServer

[jira] [Commented] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234633#comment-14234633 ] Hudson commented on THRIFT-2789: SUCCESS: Integrated in Thrift #1385 (See

[jira] [Comment Edited] (THRIFT-2859) JSON generator: output complete descriptors

[ https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234654#comment-14234654 ] Jens Geyer edited comment on THRIFT-2859 at 12/4/14 9:32 PM: -

[jira] [Commented] (THRIFT-2859) JSON generator: output complete descriptors

[ https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234654#comment-14234654 ] Jens Geyer commented on THRIFT-2859: [~stigsb], I still get a warning at a

[jira] [Resolved] (THRIFT-2465) TBinaryProtocolT breaks if copied/moved

[ https://issues.apache.org/jira/browse/THRIFT-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski resolved THRIFT-2465. --- Resolution: Duplicate Assignee: Konrad Grochowski THRIFT-2874 resolves this

[jira] [Assigned] (THRIFT-2874) TBinaryProtocol member variable string_buf_ is never used.

[ https://issues.apache.org/jira/browse/THRIFT-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski reassigned THRIFT-2874: - Assignee: Konrad Grochowski TBinaryProtocol member variable string_buf_ is

[GitHub] thrift pull request: THRIFT-2874

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-2874) TBinaryProtocol member variable string_buf_ is never used.

[ https://issues.apache.org/jira/browse/THRIFT-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski resolved THRIFT-2874. --- Resolution: Fixed Fix Version/s: 0.9.3 Assignee: (was: Konrad

[jira] [Commented] (THRIFT-2874) TBinaryProtocol member variable string_buf_ is never used.

[ https://issues.apache.org/jira/browse/THRIFT-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234682#comment-14234682 ] ASF GitHub Bot commented on THRIFT-2874: Github user asfgit closed the pull

[jira] [Updated] (THRIFT-2874) TBinaryProtocol member variable string_buf_ is never used.

[ https://issues.apache.org/jira/browse/THRIFT-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski updated THRIFT-2874: -- Assignee: Nobuaki Sukegawa TBinaryProtocol member variable string_buf_ is never

[jira] [Commented] (THRIFT-2870) C++ TJSONProtocol using locale dependent formatting

[ https://issues.apache.org/jira/browse/THRIFT-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234704#comment-14234704 ] Konrad Grochowski commented on THRIFT-2870: --- can you try adding {{#define

[jira] [Commented] (THRIFT-2874) TBinaryProtocol member variable string_buf_ is never used.

[ https://issues.apache.org/jira/browse/THRIFT-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234709#comment-14234709 ] Hudson commented on THRIFT-2874: SUCCESS: Integrated in Thrift #1386 (See

[jira] [Commented] (THRIFT-2859) JSON generator: output complete descriptors

[ https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234712#comment-14234712 ] Konrad Grochowski commented on THRIFT-2859: --- my suggestion: instead of

[GitHub] thrift pull request: THRIFT-2875 Fix typo

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/302 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2875) Typo in TDenseProtocol.h comment

[ https://issues.apache.org/jira/browse/THRIFT-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234718#comment-14234718 ] ASF GitHub Bot commented on THRIFT-2875: Github user asfgit closed the pull

[jira] [Commented] (THRIFT-2876) Add test for THRIFT-2526 Assignment operators and copy constructors in c++ don't copy the __isset struct

[ https://issues.apache.org/jira/browse/THRIFT-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234725#comment-14234725 ] Konrad Grochowski commented on THRIFT-2876: --- to get proper comments from Bot

[jira] [Commented] (THRIFT-2876) Add test for THRIFT-2526 Assignment operators and copy constructors in c++ don't copy the __isset struct

[ https://issues.apache.org/jira/browse/THRIFT-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234742#comment-14234742 ] ASF GitHub Bot commented on THRIFT-2876: Github user asfgit closed the pull

[GitHub] thrift pull request: THRIFT-2876 Add test for THRIFT-2526 Assignme...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-2876) Add test for THRIFT-2526 Assignment operators and copy constructors in c++ don't copy the __isset struct

[ https://issues.apache.org/jira/browse/THRIFT-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski resolved THRIFT-2876. --- Resolution: Fixed Fix Version/s: 0.9.3 Assignee: Nobuaki Sukegawa

[jira] [Commented] (THRIFT-2874) TBinaryProtocol member variable string_buf_ is never used.

[ https://issues.apache.org/jira/browse/THRIFT-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234745#comment-14234745 ] Hudson commented on THRIFT-2874: SUCCESS: Integrated in Thrift #1387 (See

[jira] [Commented] (THRIFT-2876) Add test for THRIFT-2526 Assignment operators and copy constructors in c++ don't copy the __isset struct

[ https://issues.apache.org/jira/browse/THRIFT-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234775#comment-14234775 ] Hudson commented on THRIFT-2876: SUCCESS: Integrated in Thrift #1388 (See

[jira] [Commented] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234919#comment-14234919 ] Sergey commented on THRIFT-2789: great to see it fixed! thank you! TNonblockingServer

Re: i32 vs int

As no one else commented I just wanted to point out that probably both 2a and 2b are acceptable as long the implementation is generic enough to avoid duplicated code on different generators. I believe 2a should use warnings to avoid restricting current working IDL's and 2b could give errors

[jira] [Commented] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234955#comment-14234955 ] Qiao Mu commented on THRIFT-2789: - Greate! Thank you! TNonblockingServer leaks socket

[jira] [Comment Edited] (THRIFT-2870) C++ TJSONProtocol using locale dependent formatting

[ https://issues.apache.org/jira/browse/THRIFT-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235208#comment-14235208 ] Simon Falsig edited comment on THRIFT-2870 at 12/5/14 7:23 AM:

[jira] [Commented] (THRIFT-2870) C++ TJSONProtocol using locale dependent formatting

[ https://issues.apache.org/jira/browse/THRIFT-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235208#comment-14235208 ] Simon Falsig commented on THRIFT-2870: -- Hmm - I remember looking at using that, but

[jira] [Commented] (THRIFT-2859) JSON generator: output complete descriptors

[ https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235216#comment-14235216 ] Stig Bakken commented on THRIFT-2859: - What about this patch (based on Konrad's, but