[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...

2015-07-06 Thread cmhe
GitHub user cmhe opened a pull request: https://github.com/apache/thrift/pull/542 THRIFT-1522: Fixes Memory leak by wrapping getaddrinfo into a class. Sponsored-by: Roger Meier r.me...@siemens.com Signed-off-by: Claudius Heine c...@denx.de You can merge this pull request into a

[jira] [Commented] (THRIFT-1522) TServerSocket potential memory leak with addrinfo *res0

2015-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614665#comment-14614665 ] ASF GitHub Bot commented on THRIFT-1522: GitHub user cmhe opened a pull request:

[GitHub] thrift pull request: THRIFT-2073: Fixed Thrift C++ THttpClient err...

2015-07-06 Thread cmhe
GitHub user cmhe opened a pull request: https://github.com/apache/thrift/pull/543 THRIFT-2073: Fixed Thrift C++ THttpClient error: cannot refill buffer Fixed-by: Qiang Li liqiang...@hotmail.com Sponsored-by: Roger Meier r.me...@siemens.com Signed-off-by: Claudius Heine

[jira] [Commented] (THRIFT-2073) Thrift C++ THttpClient error: cannot refill buffer

2015-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614867#comment-14614867 ] ASF GitHub Bot commented on THRIFT-2073: GitHub user cmhe opened a pull request:

[jira] [Commented] (THRIFT-1522) TServerSocket potential memory leak with addrinfo *res0

2015-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614672#comment-14614672 ] ASF GitHub Bot commented on THRIFT-1522: Github user cmhe commented on the pull

[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...

2015-07-06 Thread cmhe
Github user cmhe commented on the pull request: https://github.com/apache/thrift/pull/542#issuecomment-118762338 I have run make cross and make check without any unexpected errors. Feedback is welcome. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (THRIFT-1844) Password string not cleared

2015-07-06 Thread Claudius Heine (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614903#comment-14614903 ] Claudius Heine commented on THRIFT-1844: Why not use string::assign(size_t n,

[jira] [Commented] (THRIFT-1522) TServerSocket potential memory leak with addrinfo *res0

2015-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614940#comment-14614940 ] ASF GitHub Bot commented on THRIFT-1522: Github user cmhe commented on the pull

[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...

2015-07-06 Thread cmhe
Github user cmhe commented on the pull request: https://github.com/apache/thrift/pull/542#issuecomment-118833111 Maybe this can also be used in TNonblockingServer.cpp and TSocket.cpp. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (THRIFT-2858) Enable header field case insensitive match in THttpServer

2015-07-06 Thread Claudius Heine (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614891#comment-14614891 ] Claudius Heine commented on THRIFT-2858: Patch applies, compiles and make cross

[jira] [Commented] (THRIFT-1522) TServerSocket potential memory leak with addrinfo *res0

2015-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615000#comment-14615000 ] ASF GitHub Bot commented on THRIFT-1522: Github user cmhe commented on the pull

[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...

2015-07-06 Thread cmhe
Github user cmhe commented on the pull request: https://github.com/apache/thrift/pull/542#issuecomment-118848681 I moved TGetAddrInfoWrapper into its own C++ Module and integrated it into TNonblockingServer and TSocket: https://github.com/cmhe/thrift/commits/WrappedGetAddrInfo

[GitHub] thrift pull request: THRIFT-2850: Fix some Windows CMake issues

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615031#comment-14615031 ] ASF GitHub Bot commented on THRIFT-2850: Github user asfgit closed the pull

[jira] [Updated] (THRIFT-1844) Password string not cleared

2015-07-06 Thread Alexis Wilke (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Wilke updated THRIFT-1844: - Description: The function handling the SSL password receives a memory copy of the password

[jira] [Updated] (THRIFT-3223) TypeScript: Add initial support for Enum Maps

2015-07-06 Thread Felipe Barriga Richards (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felipe Barriga Richards updated THRIFT-3223: Attachment: 0001-TypeScript-Added-support-for-maps-of-enums.patch

[jira] [Created] (THRIFT-3223) TypeScript: Add initial support for Enum Maps

2015-07-06 Thread Felipe Barriga Richards (JIRA)
Felipe Barriga Richards created THRIFT-3223: --- Summary: TypeScript: Add initial support for Enum Maps Key: THRIFT-3223 URL: https://issues.apache.org/jira/browse/THRIFT-3223 Project: Thrift

[jira] [Commented] (THRIFT-1844) Password string not cleared

2015-07-06 Thread Alexis Wilke (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615529#comment-14615529 ] Alexis Wilke commented on THRIFT-1844: -- For sure my loop was wrong. We would need to

[jira] [Commented] (THRIFT-1844) Password string not cleared

2015-07-06 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615587#comment-14615587 ] James E. King, III commented on THRIFT-1844: [~cmhe] provided a very elegant

[jira] [Created] (THRIFT-3222) TypeScript: Generated Enums are quoted

2015-07-06 Thread Felipe Barriga Richards (JIRA)
Felipe Barriga Richards created THRIFT-3222: --- Summary: TypeScript: Generated Enums are quoted Key: THRIFT-3222 URL: https://issues.apache.org/jira/browse/THRIFT-3222 Project: Thrift

[jira] [Updated] (THRIFT-3222) TypeScript: Generated Enums are quoted

2015-07-06 Thread Felipe Barriga Richards (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felipe Barriga Richards updated THRIFT-3222: Description: Currently the generated enums looks like: {code} enum Foo {

[jira] [Updated] (THRIFT-3222) TypeScript: Generated Enums are quoted

2015-07-06 Thread Felipe Barriga Richards (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felipe Barriga Richards updated THRIFT-3222: Attachment: 0001-TypeScript-Fix-enum-generation-remove-quotes.patch

[jira] [Commented] (THRIFT-2889) stable release 0.9.2, erlang tutorial broken

2015-07-06 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616042#comment-14616042 ] Jake Farrell commented on THRIFT-2889: -- hi [~Skype], can you give some details on

[jira] [Commented] (THRIFT-3000) .NET implementation has trouble with mixed IP modes

2015-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616052#comment-14616052 ] ASF GitHub Bot commented on THRIFT-3000: Github user jfarrell commented on the

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-07-06 Thread jfarrell
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-119044633 we need to transition our jenkins build over to using the docker containers so we have more control over them and then can run whatever we like inside that. on my list

[jira] [Commented] (THRIFT-2734) Go coding standards

2015-07-06 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616060#comment-14616060 ] Jake Farrell commented on THRIFT-2734: -- fmt, vet and golint should probably be run

[jira] [Updated] (THRIFT-2734) Go coding standards

2015-07-06 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-2734: - Fix Version/s: 1.0 Go coding standards --- Key: THRIFT-2734

[jira] [Commented] (THRIFT-2580) better COM-ability for generated Delphi interfaces

2015-07-06 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616047#comment-14616047 ] Jake Farrell commented on THRIFT-2580: -- [~jensg] is there any progress on this or

[jira] [Updated] (THRIFT-2797) move java* build to maven

2015-07-06 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-2797: - Fix Version/s: (was: 0.9.3) 1.0 move java* build to maven

[jira] [Commented] (THRIFT-2981) IDL with no namespace produces unparsable PHP

2015-07-06 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616049#comment-14616049 ] Jake Farrell commented on THRIFT-2981: -- I thought there was a reason we required a

[jira] [Updated] (THRIFT-3200) JS and nodejs do not encode JSON protocol binary fields as base64

2015-07-06 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-3200: - Fix Version/s: (was: 0.9.3) 1.0 JS and nodejs do not encode JSON

[jira] [Commented] (THRIFT-3220) Option to suppress @Generated Annotation entirely

2015-07-06 Thread notona (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616186#comment-14616186 ] notona commented on THRIFT-3220: thanks! Option to suppress @Generated Annotation

[jira] [Commented] (THRIFT-1522) TServerSocket potential memory leak with addrinfo *res0

2015-07-06 Thread Claudius Heine (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614602#comment-14614602 ] Claudius Heine commented on THRIFT-1522: Ok, I will take a look. TServerSocket

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-07-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615181#comment-14615181 ] Hudson commented on THRIFT-2850: SUCCESS: Integrated in Thrift #1593 (See