[jira] [Commented] (THRIFT-3481) introduce TSimpleMemoryTransport which wraps a customer owned memory chunk to conduct both read and write operations

[ https://issues.apache.org/jira/browse/THRIFT-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055269#comment-15055269 ] Xiaoshuang LU commented on THRIFT-3481: --- Hi [~nsuke] , thanks for your comments. From my

[GitHub] thrift pull request: THRIFT-3482 Haskell JSON protocol does not en...

GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/742 THRIFT-3482 Haskell JSON protocol does not encode binary field as Base64 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3482

[jira] [Commented] (THRIFT-3482) Haskell JSON protocol does not encode binary field as Base64

[ https://issues.apache.org/jira/browse/THRIFT-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054941#comment-15054941 ] ASF GitHub Bot commented on THRIFT-3482: GitHub user nsuke opened a pull request:

[jira] [Commented] (THRIFT-3475) prefix tags with v as defined by semver

[ https://issues.apache.org/jira/browse/THRIFT-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054976#comment-15054976 ] Aki Sukegawa commented on THRIFT-3475: -- +1 I only looked around a handful of projects but it seems

[jira] [Commented] (THRIFT-3145) JSON protocol does not handle bool and empty containers correctly

[ https://issues.apache.org/jira/browse/THRIFT-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054949#comment-15054949 ] Hudson commented on THRIFT-3145: SUCCESS: Integrated in Thrift #1766 (See

[GitHub] thrift pull request: THRIFT-3145 JSON protocol does not handle boo...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-3145) JSON protocol does not handle bool and empty containers correctly

[ https://issues.apache.org/jira/browse/THRIFT-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3145. -- Resolution: Fixed Fix Version/s: 1.0 > JSON protocol does not handle bool and empty

[jira] [Commented] (THRIFT-3145) JSON protocol does not handle bool and empty containers correctly

[ https://issues.apache.org/jira/browse/THRIFT-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054933#comment-15054933 ] ASF GitHub Bot commented on THRIFT-3145: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3485) thrift NPM package includes whole thrift repository, is 30 megabytes

[ https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054961#comment-15054961 ] ASF GitHub Bot commented on THRIFT-3485: Github user nsuke commented on the pull request:

[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/741#issuecomment-164258574 It seems it's already fixed by f264884901d0e2a1197ae1511ee0fa0b8ca0d2aa. @azylman could you confirm ? --- If your project is set up for it, you can reply to this

[jira] [Resolved] (THRIFT-3359) Binary field incompatibilities

[ https://issues.apache.org/jira/browse/THRIFT-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3359. -- Resolution: Fixed > Binary field incompatibilities > -- > >

[jira] [Commented] (THRIFT-3482) Haskell JSON protocol does not encode binary field as Base64

[ https://issues.apache.org/jira/browse/THRIFT-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055051#comment-15055051 ] Hudson commented on THRIFT-3482: SUCCESS: Integrated in Thrift #1767 (See

[jira] [Commented] (THRIFT-3481) introduce TSimpleMemoryTransport which wraps a customer owned memory chunk to conduct both read and write operations

[ https://issues.apache.org/jira/browse/THRIFT-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054932#comment-15054932 ] Aki Sukegawa commented on THRIFT-3481: -- As you already noted, the functionality is very similar to

[jira] [Commented] (THRIFT-3482) Haskell JSON protocol does not encode binary field as Base64

[ https://issues.apache.org/jira/browse/THRIFT-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055028#comment-15055028 ] ASF GitHub Bot commented on THRIFT-3482: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-3482) Haskell JSON protocol does not encode binary field as Base64

[ https://issues.apache.org/jira/browse/THRIFT-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3482. -- Resolution: Fixed committed > Haskell JSON protocol does not encode binary field as Base64 >

[GitHub] thrift pull request: THRIFT-3482 Haskell JSON protocol does not en...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (THRIFT-3486) Java generated `getFieldValue` is incompatible with `setFieldValue` for binary values.

[ https://issues.apache.org/jira/browse/THRIFT-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gospo updated THRIFT-3486: -- Description: h4. Problem description In case of a binary field, _getFieldValue_ returns a _byte[]_ while

[jira] [Commented] (THRIFT-3485) thrift NPM package includes whole thrift repository, is 30 megabytes

[ https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055120#comment-15055120 ] ASF GitHub Bot commented on THRIFT-3485: Github user azylman commented on the pull request:

[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

Github user azylman closed the pull request at: https://github.com/apache/thrift/pull/741 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3485) thrift NPM package includes whole thrift repository, is 30 megabytes

[ https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055103#comment-15055103 ] ASF GitHub Bot commented on THRIFT-3485: Github user azylman commented on the pull request:

[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

Github user azylman commented on the pull request: https://github.com/apache/thrift/pull/741#issuecomment-164290342 @nsuke Is that commit published at all? I'm still seeing this behavior in the latest version published to npm (0.9.3) --- If your project is set up for it, you can

[jira] [Resolved] (THRIFT-747) C++ TSocket->close calls shutdown breaking forked parent process

[ https://issues.apache.org/jira/browse/THRIFT-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-747. Resolution: Won't Fix > C++ TSocket->close calls shutdown breaking forked parent process >

[jira] [Commented] (THRIFT-3485) thrift NPM package includes whole thrift repository, is 30 megabytes

[ https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055121#comment-15055121 ] ASF GitHub Bot commented on THRIFT-3485: Github user azylman closed the pull request at:

[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

Github user azylman commented on the pull request: https://github.com/apache/thrift/pull/741#issuecomment-164294334 @nsuke Looks like that's not published in 0.9.3. I just confirmed that master does _not_ have this problem, making this PR unnecessary. Hopefully that change can get

[GitHub] thrift pull request: Thrift 3486 - Java generated `getFieldValue` ...

GitHub user bgould opened a pull request: https://github.com/apache/thrift/pull/743 Thrift 3486 - Java generated `getFieldValue` is incompatible with `setFieldValue` for binary values. For binary fields, the compiler generates Java getter/setter methods for primitive byte arrays

Build failed in Jenkins: thrift #570

See Changes: [nsuke] THRIFT-3145 JSON protocol does not handle bool and empty containers [nsuke] THRIFT-3145 JSON protocol does not handle bool and empty containers [nsuke] THRIFT-3482 Haskell JSON protocol does not encode binary

[GitHub] thrift pull request: Update TNonblockingServer.cpp

Github user logicouter commented on the pull request: https://github.com/apache/thrift/pull/70#issuecomment-164346383 this pull request hasn't been merged into master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Assigned] (THRIFT-3362) make check fails for C++ at the SecurityTest

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3362: -- Assignee: James E. King, III > make check fails for C++ at the SecurityTest >

[jira] [Commented] (THRIFT-3362) make check fails for C++ at the SecurityTest

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055397#comment-15055397 ] Dean Chen commented on THRIFT-3362: --- I am new to thrift, run into the same issue with v0.9.3 > make

[GitHub] thrift pull request: THRIFT 3486 - Java generated `getFieldValue` ...

Github user Gospodzin commented on a diff in the pull request: https://github.com/apache/thrift/pull/743#discussion_r47467283 --- Diff: lib/java/test/org/apache/thrift/TestStruct.java --- @@ -309,11 +309,33 @@ public void testToString() throws Exception { }