Jenkins build is back to normal : Thrift-precommit #340

See

Build failed in Jenkins: Thrift-precommit #339

See -- GitHub pull request #961 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on ubuntu-6 (docker Ubuntu ubuntu yahoo-not-h2) in workspace

[jira] [Commented] (THRIFT-3757) Fix various build warnings on Windows with VS2015 compiler

[ https://issues.apache.org/jira/browse/THRIFT-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209399#comment-15209399 ] ASF GitHub Bot commented on THRIFT-3757: GitHub user tpcwang opened a pull request:

[GitHub] thrift pull request: THRIFT-3757 Fix various compile warnings with...

GitHub user tpcwang opened a pull request: https://github.com/apache/thrift/pull/962 THRIFT-3757 Fix various compile warnings with VS2015 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tpcwang/thrift THRIFT-3757 Alternatively

[jira] [Created] (THRIFT-3757) Fix various build warnings on Windows with VS2015 compiler

Ted Wang created THRIFT-3757: Summary: Fix various build warnings on Windows with VS2015 compiler Key: THRIFT-3757 URL: https://issues.apache.org/jira/browse/THRIFT-3757 Project: Thrift Issue

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209376#comment-15209376 ] John Sirois commented on THRIFT-3752: - OK - great. Thanks [~jensg]. After hitting this incompat in

[jira] [Comment Edited] (THRIFT-3751) Compiler allows field ids that are too large for generated code

[ https://issues.apache.org/jira/browse/THRIFT-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209345#comment-15209345 ] Jens Geyer edited comment on THRIFT-3751 at 3/23/16 10:45 PM: -- The several

[jira] [Comment Edited] (THRIFT-3751) Compiler allows field ids that are too large for generated code

[ https://issues.apache.org/jira/browse/THRIFT-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209345#comment-15209345 ] Jens Geyer edited comment on THRIFT-3751 at 3/23/16 10:46 PM: -- Several

[jira] [Updated] (THRIFT-3751) Compiler allows field ids that are too large for generated code

[ https://issues.apache.org/jira/browse/THRIFT-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3751: --- Component/s: Compiler (General) > Compiler allows field ids that are too large for generated code >

[jira] [Comment Edited] (THRIFT-3751) Compiler allows field ids that are too large for generated code

[ https://issues.apache.org/jira/browse/THRIFT-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209345#comment-15209345 ] Jens Geyer edited comment on THRIFT-3751 at 3/23/16 10:45 PM: -- The compact

[jira] [Commented] (THRIFT-3751) Compiler allows field ids that are too large for generated code

[ https://issues.apache.org/jira/browse/THRIFT-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209345#comment-15209345 ] Jens Geyer commented on THRIFT-3751: The compact protocol limits field ids to 16 bit, so this is a

[jira] [Updated] (THRIFT-3754) java: error: unmappable character for encoding ASCII

[ https://issues.apache.org/jira/browse/THRIFT-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3754: --- Summary: java: error: unmappable character for encoding ASCII (was: CLONE - java: error: unmappable

[jira] [Commented] (THRIFT-3756) Improve requiredness documentation

[ https://issues.apache.org/jira/browse/THRIFT-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209332#comment-15209332 ] Jens Geyer commented on THRIFT-3756: Hi [~codesf], you know that I count on your review, do you? ;-)

[GitHub] thrift pull request: THRIFT-3756 Improve requiredness documentatio...

GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/961 THRIFT-3756 Improve requiredness documentation Client: Website Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Wang updated THRIFT-3753: - Flags: Patch > TServerFramework::stop may fail to interrupt connected clients >

[jira] [Updated] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Wang updated THRIFT-3753: - Flags: (was: Patch) Patch Info: Patch Available > TServerFramework::stop may fail to

[jira] [Updated] (THRIFT-3755) TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT

[ https://issues.apache.org/jira/browse/THRIFT-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Wang updated THRIFT-3755: - Patch Info: Patch Available > TDebugProtocol::writeString hits assert in isprint on Windows with debug

[jira] [Commented] (THRIFT-3755) TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT

[ https://issues.apache.org/jira/browse/THRIFT-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209310#comment-15209310 ] ASF GitHub Bot commented on THRIFT-3755: GitHub user tpcwang opened a pull request:

[GitHub] thrift pull request: THRIFT-3755 TDebugProtocol::writeString hits ...

GitHub user tpcwang opened a pull request: https://github.com/apache/thrift/pull/960 THRIFT-3755 TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT Passing characters <0 to std::isprint causes asserts. You can merge this pull request into a Git repository

[jira] [Created] (THRIFT-3756) Improve requiredness documentation

Jens Geyer created THRIFT-3756: -- Summary: Improve requiredness documentation Key: THRIFT-3756 URL: https://issues.apache.org/jira/browse/THRIFT-3756 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-3755) TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT

Ted Wang created THRIFT-3755: Summary: TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT Key: THRIFT-3755 URL: https://issues.apache.org/jira/browse/THRIFT-3755 Project: Thrift

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209239#comment-15209239 ] Jens Geyer commented on THRIFT-3752: I don't know what you mean but the semantics of required,

[jira] [Commented] (THRIFT-3754) CLONE - java: error: unmappable character for encoding ASCII

[ https://issues.apache.org/jira/browse/THRIFT-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209233#comment-15209233 ] ASF GitHub Bot commented on THRIFT-3754: Github user mlpesant commented on the pull request:

[jira] [Updated] (THRIFT-3754) CLONE - java: error: unmappable character for encoding ASCII

[ https://issues.apache.org/jira/browse/THRIFT-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorena Pesantez updated THRIFT-3754: Description: I saw this closed issue with the exact same signature as the one I

[jira] [Updated] (THRIFT-3754) CLONE - java: error: unmappable character for encoding ASCII

[ https://issues.apache.org/jira/browse/THRIFT-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorena Pesantez updated THRIFT-3754: Environment: java version "1.7.0_95" OpenJDK Runtime Environment (IcedTea 2.6.4)

[jira] [Created] (THRIFT-3754) CLONE - java: error: unmappable character for encoding ASCII

Lorena Pesantez created THRIFT-3754: --- Summary: CLONE - java: error: unmappable character for encoding ASCII Key: THRIFT-3754 URL: https://issues.apache.org/jira/browse/THRIFT-3754 Project: Thrift

[jira] [Commented] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209049#comment-15209049 ] ASF GitHub Bot commented on THRIFT-3753: GitHub user tpcwang opened a pull request:

[GitHub] thrift pull request: THRIFT-3753 Fixed a race condition in TServer...

GitHub user tpcwang opened a pull request: https://github.com/apache/thrift/pull/959 THRIFT-3753 Fixed a race condition in TServerFramework::stop that prevents clean server shutdown This is a sequence that exposes the race condition: (1) Thread-1: in serve(), blocked on

[jira] [Created] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

Ted Wang created THRIFT-3753: Summary: TServerFramework::stop may fail to interrupt connected clients Key: THRIFT-3753 URL: https://issues.apache.org/jira/browse/THRIFT-3753 Project: Thrift

[jira] [Comment Edited] (THRIFT-3752) nil collections are serialized as empty collections

[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208762#comment-15208762 ] John Sirois edited comment on THRIFT-3752 at 3/23/16 4:55 PM: -- Hrm, so this

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208762#comment-15208762 ] John Sirois commented on THRIFT-3752: - Hrm, so this may not be a thrift compiler bug per-se. Marking

[jira] [Commented] (THRIFT-3750) NSCopying copyWithZone: implementation does not check isSet

[ https://issues.apache.org/jira/browse/THRIFT-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208564#comment-15208564 ] ASF GitHub Bot commented on THRIFT-3750: Github user chefnobody commented on the pull request:

[GitHub] thrift pull request: THRIFT-3750 Check isSet in copyWithZone

Github user chefnobody commented on the pull request: https://github.com/apache/thrift/pull/958#issuecomment-200389575 Yes please. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (THRIFT-3700) Go Map has wrong default value when optional

[ https://issues.apache.org/jira/browse/THRIFT-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208543#comment-15208543 ] John Sirois commented on THRIFT-3700: - [~connorgorman] - I filed THRIFT-3752 today which is very

[jira] [Assigned] (THRIFT-3752) nil collections are serialized as empty collections

[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reassigned THRIFT-3752: --- Assignee: John Sirois > nil collections are serialized as empty collections >

[jira] [Created] (THRIFT-3752) nil collections are serialized as empty collections

John Sirois created THRIFT-3752: --- Summary: nil collections are serialized as empty collections Key: THRIFT-3752 URL: https://issues.apache.org/jira/browse/THRIFT-3752 Project: Thrift Issue