[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492143#comment-15492143 ] ASF GitHub Bot commented on THRIFT-3929: GitHub user RobberPhex opened a pull request:

[GitHub] thrift pull request #1089: THRIFT-3929 php namespace remove tail "\\"

2016-09-14 Thread RobberPhex
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1089 THRIFT-3929 php namespace remove tail "\\" when namespace is empty, and global namespace is not empty, don't add tail "\\" You can merge this pull request into a Git repository by running:

[GitHub] thrift pull request #1088: Microsoft .Net Core library port and generator fo...

2016-09-14 Thread vgotra
GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1088 Microsoft .Net Core library port and generator for this library Here is port of csharp library to .Net core and also generator for it (t_netcore_generator.cc) All information in README.md

[jira] [Created] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-14 Thread Ben Meynell (JIRA)
Ben Meynell created THRIFT-3929: --- Summary: PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash) Key: THRIFT-3929 URL: https://issues.apache.org/jira/browse/THRIFT-3929

[jira] [Updated] (THRIFT-3927) Emit an error instead of throw an error in the async callback

2016-09-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3927: --- Component/s: Node.js - Library > Emit an error instead of throw an error in the async callback >

[jira] [Commented] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers

2016-09-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490437#comment-15490437 ] James E. King, III commented on THRIFT-3928: Are the compiler-supplied methods (when one is

[jira] [Updated] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers

2016-09-14 Thread Denis (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis updated THRIFT-3928: --- Description: cpp generator doesn`t generate implementations of constructors, operators for function and

[jira] [Commented] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions

2016-09-14 Thread Denis (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490396#comment-15490396 ] Denis commented on THRIFT-3928: In method generate_function_helpers doesn`t exists call for

[jira] [Updated] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions

2016-09-14 Thread Denis (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis updated THRIFT-3928: --- Attachment: thrift_cpp_generator.patch Patch for this bug > CPP generator doesn`t generate implementations

[jira] [Created] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions

2016-09-14 Thread Denis (JIRA)
Denis created THRIFT-3928: -- Summary: CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions Key: THRIFT-3928 URL:

[jira] [Commented] (THRIFT-3927) Emit an error instead of throw an error in the async callback

2016-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490078#comment-15490078 ] ASF GitHub Bot commented on THRIFT-3927: GitHub user lifei opened a pull request:

[GitHub] thrift pull request #1087: THRIFT-3927 Emitting an error instead of throwing...

2016-09-14 Thread lifei
GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1087 THRIFT-3927 Emitting an error instead of throwing in the async callback Because the data event of a connection is async handled, throw an exception can not tell the code the error. emit the error

[jira] [Updated] (THRIFT-3927) Emit an error instead of throw an error in the async callback

2016-09-14 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 李飛 updated THRIFT-3927: --- Summary: Emit an error instead of throw an error in the async callback (was: Emit an error instead of throw an

[jira] [Created] (THRIFT-3927) Emit an error instead of throw an error

2016-09-14 Thread JIRA
李飛 created THRIFT-3927: -- Summary: Emit an error instead of throw an error Key: THRIFT-3927 URL: https://issues.apache.org/jira/browse/THRIFT-3927 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-3926) There should be an error emitted when http status code is not 200

2016-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490024#comment-15490024 ] ASF GitHub Bot commented on THRIFT-3926: GitHub user lifei opened a pull request:

[GitHub] thrift pull request #1086: THRIFT-3926 Emit an error for bad http status cod...

2016-09-14 Thread lifei
GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1086 THRIFT-3926 Emit an error for bad http status code Sometimes the thrift servers is not ready to serve requests from the client. The status code of response from the services is 40x or 50x. But the

[jira] [Created] (THRIFT-3926) there should be an error emitted when http status code is not 200

2016-09-14 Thread JIRA
李飛 created THRIFT-3926: -- Summary: there should be an error emitted when http status code is not 200 Key: THRIFT-3926 URL: https://issues.apache.org/jira/browse/THRIFT-3926 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-3926) There should be an error emitted when http status code is not 200

2016-09-14 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 李飛 updated THRIFT-3926: --- Summary: There should be an error emitted when http status code is not 200 (was: there should be an error emitted