[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682784#comment-15682784
]
Xiaoshuang LU edited comment on THRIFT-3979 at 11/21/16 7:39 AM:
-
Hi
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682784#comment-15682784
]
Xiaoshuang LU commented on THRIFT-3979:
---
Hi [~jking], Jens has already told me that THeader can be
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682784#comment-15682784
]
Xiaoshuang LU edited comment on THRIFT-3979 at 11/21/16 7:33 AM:
-
Hi
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682698#comment-15682698
]
James E. King, III commented on THRIFT-3979:
I think what folks are saying is that THeader
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682294#comment-15682294
]
Xiaoshuang LU edited comment on THRIFT-3979 at 11/21/16 2:42 AM:
-
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682300#comment-15682300
]
Xiaoshuang LU commented on THRIFT-3979:
---
Understood. Thank you, [~nsuke].
> offer
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoshuang LU updated THRIFT-3979:
--
Description:
Sometimes, customers wanna put some options (whatever customers want) in each
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682294#comment-15682294
]
Xiaoshuang LU commented on THRIFT-3979:
---
[~jking] thanks for your detailed comments.
In fact,
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681420#comment-15681420
]
Jens Geyer edited comment on THRIFT-3979 at 11/20/16 4:42 PM:
--
You need
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681420#comment-15681420
]
Jens Geyer edited comment on THRIFT-3979 at 11/20/16 4:41 PM:
--
You need some
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681420#comment-15681420
]
Jens Geyer commented on THRIFT-3979:
You need some part of information. Whether one calls it state,
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681417#comment-15681417
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88805388
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -394,15 +411,19 @@ void THeaderTransport::setHeader(const string& key,
const string&
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804996
--- Diff: lib/cpp/test/JSONProtoTest.cpp ---
@@ -262,8 +262,9 @@ BOOST_AUTO_TEST_CASE(test_json_proto_8) {
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681390#comment-15681390
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681392#comment-15681392
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804989
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -375,7 +383,12 @@ void THeaderTransport::resetProtocol() {
}
uint32_t
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681388#comment-15681388
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681386#comment-15681386
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804934
--- Diff: compiler/cpp/src/thrift/thriftl.ll ---
@@ -39,11 +39,17 @@
#endif
#ifdef _MSC_VER
-//warning C4102: 'find_rule' : unreferenced
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804923
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp ---
@@ -394,15 +411,19 @@ void THeaderTransport::setHeader(const string& key,
const string&
[
https://issues.apache.org/jira/browse/THRIFT-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3978:
---
Description:
Currently there is widespread use of assert in the thrift C++ runtime
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681333#comment-15681333
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88804076
--- Diff: compiler/cpp/src/thrift/generate/t_erl_generator.cc ---
@@ -968,10 +969,13 @@ void t_erl_generator::export_string(string name, int
num) {
}
James E. King, III created THRIFT-3982:
--
Summary: Thrift compiler code throws std::string to indicate an
error, which is not safe
Key: THRIFT-3982
URL: https://issues.apache.org/jira/browse/THRIFT-3982
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681324#comment-15681324
]
James E. King, III commented on THRIFT-3979:
Based on my read of THeader documentation, it is
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681320#comment-15681320
]
James E. King, III commented on THRIFT-3979:
I would like to propose that:
# There is no
[
https://issues.apache.org/jira/browse/THRIFT-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681016#comment-15681016
]
Jens Geyer commented on THRIFT-3979:
{code}
How does one get access to the session ID
{code}
Part
Hi Allen,
there are three kinds of requiredness with Thrift:
a) required
The field must be written and the reader must be able to read it. If it is
not properly set on write or if the reader does not find it in the data,
some language implementations (not all) throw an exception.
b) optional
29 matches
Mail list logo
