[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

2017-02-20 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1156 Ok, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875530#comment-15875530 ] ASF GitHub Bot commented on THRIFT-4011: Github user Jens-G commented on the issu

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-20 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875528#comment-15875528 ] Jens Geyer commented on THRIFT-2945: Hi [~allengeorge] and [~prz], could you open a

[jira] [Created] (THRIFT-4097) Support for Fedora distribution - packaging and CI builds

2017-02-20 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4097: -- Summary: Support for Fedora distribution - packaging and CI builds Key: THRIFT-4097 URL: https://issues.apache.org/jira/browse/THRIFT-4097 Project: Thrift

[jira] [Closed] (THRIFT-4096) Remove unnecessary duplication of build/test effort in Travis CI

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4096. -- > Remove unnecessary duplication of build/test effort in Travis CI > --

[jira] [Resolved] (THRIFT-4096) Remove unnecessary duplication of build/test effort in Travis CI

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4096. Resolution: Duplicate Duping this to an issue I opened previously. > Remove unnece

[jira] [Reopened] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-3706: I am reopening this to finish the interop work with older clients. It should be possi

[jira] [Assigned] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3706: -- Assignee: James E. King, III (was: Gonzalo Aguilar) > There's no support for

[jira] [Issue Comment Deleted] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2504: --- Comment: was deleted (was: After working on THRIFT-3706 I found that the Multiplexed

[jira] [Updated] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2504: --- Description: The original intention of this story was to allow an older client to con

[jira] [Commented] (THRIFT-3250) Apache Thrift should use registered media types with HTTP

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874983#comment-15874983 ] James E. King, III commented on THRIFT-3250: I tried implemented the suggeste

[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874967#comment-15874967 ] ASF GitHub Bot commented on THRIFT-3891: Github user jeking3 commented on the iss

[GitHub] thrift issue #1196: THRIFT-3891 TNonblockingServer configured with more than...

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1196 Once someone has a chance to approve the changes I can merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874966#comment-15874966 ] ASF GitHub Bot commented on THRIFT-3706: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874965#comment-15874965 ] ASF GitHub Bot commented on THRIFT-3706: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3706. Resolution: Fixed Fix Version/s: 0.11.0 Committed - thanks! > There's no su

[GitHub] thrift pull request #1199: THRIFT-3706 - Implement multiplex protocol and cr...

2017-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] thrift pull request #1191: THRIFT-3706 - Implement multiplexor.

2017-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874955#comment-15874955 ] ASF GitHub Bot commented on THRIFT-3706: Github user jeking3 commented on the iss

[GitHub] thrift issue #1199: THRIFT-3706 - Implement multiplex protocol and crosstest...

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1199 The failure here is environmental (write error). I'll squash and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-20 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874943#comment-15874943 ] Tony Przygienda commented on THRIFT-2945: - OK, we're in agreement., I'll get to i

[jira] [Commented] (THRIFT-3250) Apache Thrift should use registered media types with HTTP

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874929#comment-15874929 ] James E. King, III commented on THRIFT-3250: Is there a way to do this that's

[jira] [Updated] (THRIFT-3250) Apache Thrift should use registered media types with HTTP

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3250: --- Component/s: Dart - Library .NETCore - Library > Apache Thrift shoul

[jira] [Resolved] (THRIFT-3042) Dockerfiles fail to build

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3042. Resolution: Fixed Assignee: James E. King, III (was: Jake Farrell)

[jira] [Commented] (THRIFT-2208) Thrift package for chocolatey

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874864#comment-15874864 ] James E. King, III commented on THRIFT-2208: Someone uploaded the 0.9.3 compi

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874862#comment-15874862 ] James E. King, III commented on THRIFT-3620: Hi [~jsirois], since all Thrift

[jira] [Commented] (THRIFT-1145) Implement Thrift runtime for C with ASF compatible dependencies

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874860#comment-15874860 ] James E. King, III commented on THRIFT-1145: I reduced this to Minor Priority

[jira] [Updated] (THRIFT-1145) Implement Thrift runtime for C with ASF compatible dependencies

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-1145: --- Component/s: (was: C glib - Compiler) Wish List > Implement Thri

[jira] [Updated] (THRIFT-1145) Implement Thrift runtime for C with ASF compatible dependencies

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-1145: --- Priority: Minor (was: Major) > Implement Thrift runtime for C with ASF compatible de

[jira] [Resolved] (THRIFT-1677) MinGW support broken

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-1677. Resolution: Duplicate Fix Version/s: 0.11.0 See https://github.com/apache/th

[jira] [Assigned] (THRIFT-1677) MinGW support broken

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-1677: -- Assignee: James E. King, III > MinGW support broken > > >

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874851#comment-15874851 ] ASF GitHub Bot commented on THRIFT-3706: Github user jeking3 commented on the iss

[GitHub] thrift issue #1191: THRIFT-3706 - Implement multiplexor.

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1191 Weird, I'm not exactly sure what happened here, but I submitted a new PR rebased against master incorporating your changes here and I added one more commit - see PR #1199. If that passes I'll squas

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874849#comment-15874849 ] ASF GitHub Bot commented on THRIFT-3706: GitHub user jeking3 opened a pull reques

[GitHub] thrift pull request #1199: THRIFT-3706 - Implement multiplex protocol and cr...

2017-02-20 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1199 THRIFT-3706 - Implement multiplex protocol and crosstest for c_glib client, java server I added one commit to https://github.com/apache/thrift/pull/1191 to make it work with crosstest, and rebased

[GitHub] thrift issue #1191: THRIFT-3706 - Implement multiplexor.

2017-02-20 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1191 I cannot do it since this commit is in thrift main outside master. So I cannot see it. You cannot merge because this branch is still not merged so it's still in my fork. You can merge and then appl

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874828#comment-15874828 ] ASF GitHub Bot commented on THRIFT-3706: Github user gadLinux commented on the is

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874806#comment-15874806 ] ASF GitHub Bot commented on THRIFT-3706: Github user jeking3 commented on the iss

[GitHub] thrift issue #1191: THRIFT-3706 - Implement multiplexor.

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1191 @gadLinux for some reason I cannot send you a PR for this one like I had before, possibly because I rebased on master. If you cherry-pick b2e4e1464b74733ccf78afd68abbe94b92aec96a from my repository

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874795#comment-15874795 ] ASF GitHub Bot commented on THRIFT-3706: Github user jeking3 commented on the iss

[GitHub] thrift issue #1191: THRIFT-3706 - Implement multiplexor.

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1191 Well I was hoping the multiplexed implementation was compatible with older clients using binary protocol but it is not. I'm going to send you a PR that changes the Java Server and the c_glib client

[jira] [Commented] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874773#comment-15874773 ] James E. King, III commented on THRIFT-2504: After working on THRIFT-3706 I f

[jira] [Reopened] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-2504: > TMultiplexedProcessor should allow registering default processor called if no > serv

[jira] [Updated] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2504: --- Description: The original intention of this story was to allow an older client to con

[jira] [Updated] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2504: --- Summary: TMultiplexedProcessor should allow registering default processor called if n

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874601#comment-15874601 ] ASF GitHub Bot commented on THRIFT-3706: Github user jeking3 commented on the iss

[GitHub] thrift issue #1191: THRIFT-3706 - Implement multiplexor.

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1191 Discussing with folks who created crosstest what we should do. My preference is to have a single "multiplexed" protocol test that uses the binary protocol. That will be the most widely used combo,

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-20 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r102025979 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1566,24 +1562,26 @@ void TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {

[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874588#comment-15874588 ] ASF GitHub Bot commented on THRIFT-3891: Github user jeking3 commented on a diff

[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874587#comment-15874587 ] ASF GitHub Bot commented on THRIFT-3891: Github user bgedik commented on a diff i

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-20 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r102025490 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1566,24 +1562,26 @@ void TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {

[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874586#comment-15874586 ] ASF GitHub Bot commented on THRIFT-3891: Github user jeking3 commented on a diff

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-20 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r102025071 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1566,24 +1562,26 @@ void TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {

[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874559#comment-15874559 ] ASF GitHub Bot commented on THRIFT-3891: Github user bgedik commented on a diff i

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-20 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r102023002 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1566,24 +1562,26 @@ void TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {

[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874554#comment-15874554 ] ASF GitHub Bot commented on THRIFT-3891: Github user jeking3 commented on the iss

[GitHub] thrift issue #1196: THRIFT-3891 TNonblockingServer configured with more than...

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1196 @nsuke this is ready for review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[jira] [Updated] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv3 protocol cannot be negotiated

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4084: --- Description: Following code review discussions in THRIFT-3369, and seeing THRIFT-3165

[jira] [Commented] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv3 protocol cannot be negotiated

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874552#comment-15874552 ] ASF GitHub Bot commented on THRIFT-4084: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv3 protocol cannot be negotiated

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4084. Resolution: Fixed Fix Version/s: 0.11.0 > Improve SSL security in thrift by

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv3 protocol cannot be negotiated

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874515#comment-15874515 ] ASF GitHub Bot commented on THRIFT-4084: Github user jeking3 commented on the iss

[GitHub] thrift issue #1197: THRIFT-4084: Add a SSL/TLS negotiation check to crossfea...

2017-02-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1197 @nsuke this is ready for another review as all the code comments were addressed and we have a clean CI build. --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (THRIFT-4077) AI_ADDRCONFIG redefined after recent change to PlatformSocket header

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874502#comment-15874502 ] ASF GitHub Bot commented on THRIFT-4077: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-4077) AI_ADDRCONFIG redefined after recent change to PlatformSocket header

2017-02-20 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4077. Resolution: Fixed Fix Version/s: 0.11.0 > AI_ADDRCONFIG redefined after rece

[jira] [Commented] (THRIFT-3973) Remove MSVC C++ projects to improve maintainability; document building Thrift on Windows using CMake to generate project files

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874503#comment-15874503 ] ASF GitHub Bot commented on THRIFT-3973: Github user asfgit closed the pull reque

[GitHub] thrift pull request #1162: THRIFT-3973: Provide some tools to make it easier...

2017-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] thrift pull request #1198: THRIFT-4077: fix Appveyor warnings (VS2015) in Pl...

2017-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874483#comment-15874483 ] ASF GitHub Bot commented on THRIFT-4011: Github user dcelasun commented on the is

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

2017-02-20 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1156 @Jens-G All tests green and rebased from master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library

2017-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874182#comment-15874182 ] ASF GitHub Bot commented on THRIFT-3706: Github user gadLinux commented on the is

[GitHub] thrift issue #1191: THRIFT-3706 - Implement multiplexor.

2017-02-20 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1191 Did you see that the test is working against Java? If you try a connection with and without multiplexed in one of the ends the connection doesn't work. The only way to see if the data is sent corre