Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128164607
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user taozle commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128160543
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128159593
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128159270
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user taozle commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128159321
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user taozle commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128158624
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128156875
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user taozle commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128156419
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128154458
--- Diff: lib/go/thrift/simple_server2.go ---
@@ -1,180 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more c
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128154321
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
[
https://issues.apache.org/jira/browse/THRIFT-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092566#comment-16092566
]
Aki Sukegawa commented on THRIFT-4256:
--
It is because of a change in show introduced
Github user taozle commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128145013
--- Diff: lib/go/thrift/multiplexed_processor.go ---
@@ -1,3 +1,5 @@
+// +build go1.7
--- End diff --
Agreed, i will fix it.
---
If your pr
Github user taozle commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128144976
--- Diff: lib/go/thrift/simple_server2.go ---
@@ -1,180 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more con
Github user taozle commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128144782
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
"
Tom Lippincott created THRIFT-4256:
--
Summary: Dependency on very old version of vector library
Key: THRIFT-4256
URL: https://issues.apache.org/jira/browse/THRIFT-4256
Project: Thrift
Issue T
[
https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091234#comment-16091234
]
Jens Geyer commented on THRIFT-4253:
The Go generator is
[this|https://git-wip-us.ap
16 matches
Mail list logo