[jira] [Commented] (THRIFT-4443) node.js json_protocol throws error in skip function

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314228#comment-16314228
 ] 

James E. King, III commented on THRIFT-4443:


Interesting - without skip() how does the protocol recover from unexpected 
input?

> node.js json_protocol throws error in skip function
> ---
>
> Key: THRIFT-4443
> URL: https://issues.apache.org/jira/browse/THRIFT-4443
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.11.0
>Reporter: Kerri Devine
>  Labels: easyfix, patch
> Fix For: 0.12.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The skip function is unsupported in the node.js implementation of the 
> json_protocol. Interestingly, the compact_protocol implements the skip 
> function, as does the JavaScript version.
> {code:javascript}
> TJSONProtocol.prototype.skip = function(type) {
>   throw new Error('skip not supported yet');
> };
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (THRIFT-4444) Make language bindings (ruby/python/rust) release part of project release process

[Anatol Pomozov (JIRA)]

Anatol Pomozov created THRIFT-:
--

 Summary: Make language bindings (ruby/python/rust) release part of 
project release process 
 Key: THRIFT-
 URL: https://issues.apache.org/jira/browse/THRIFT-
 Project: Thrift
  Issue Type: Bug
Reporter: Anatol Pomozov


Thrift 0.11.0 has been released a while ago, but there is no
 - python library at pipy
 - rubygem at https://rubygems.org/gems/thrift/
...

Please make these and all other binding libraries part of the whole project 
release. The bindings should be kept up-to-date with the Thrift core.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1459: Golang: do something with context.Context

[johnboiles]

GitHub user johnboiles opened a pull request:

https://github.com/apache/thrift/pull/1459

Golang: do something with context.Context

This patch wires through `context.Context` such that it can be used in in 
`http.Request`'s `WithContext` method. This allows Thrift HTTP requests to time 
out out based on `Context.Deadline`.

This patch breaks support for go<1.7 so it's not ready to ship, but I'm 
hoping to get some direction on this. When does Thrift expect to drop support 
of go1.7? It looks like the current solution is to duplicate files that need to 
use `golang.org/x/net/context` and add a `// +build !go1.7` but duplication 
seems unsustainable as the `context` package is imported more places.

Go 1.7 was released 15 August 2016. Given Golang has had significant 
performance improvements in most dot releases, I suspect most production 
services stay reasonably up to date. Here at Periscope/Twitter we're on 
go1.9.1, and we're a fairly large organization.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/johnboiles/thrift johnboiles/go-context-http

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1459


commit 757bd5301dbfe923df6b4e21d1054fec4abc833f
Author: John Boiles 
Date:   2018-01-05T22:37:05Z

Golang: do something with context.Context

(At least in http_client.go)




---

[jira] [Commented] (THRIFT-4443) node.js json_protocol throws error in skip function

[Kerri Devine (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314048#comment-16314048
 ] 

Kerri Devine commented on THRIFT-4443:
--

I will create a pull request with a fix.

> node.js json_protocol throws error in skip function
> ---
>
> Key: THRIFT-4443
> URL: https://issues.apache.org/jira/browse/THRIFT-4443
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.11.0
>Reporter: Kerri Devine
>  Labels: easyfix, patch
> Fix For: 0.12.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The skip function is unsupported in the node.js implementation of the 
> json_protocol. Interestingly, the compact_protocol implements the skip 
> function, as does the JavaScript version.
> {code:javascript}
> TJSONProtocol.prototype.skip = function(type) {
>   throw new Error('skip not supported yet');
> };
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-4443) node.js json_protocol throws error in skip function

[Kerri Devine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kerri Devine updated THRIFT-4443:
-
Description: 
The skip function is unsupported in the node.js implementation of the 
json_protocol. Interestingly, the compact_protocol implements the skip 
function, as does the JavaScript version.

{code:javascript}
TJSONProtocol.prototype.skip = function(type) {
  throw new Error('skip not supported yet');
};
{code}

  was:
The skip function is unsupported in the node.js implementation of the 
json_protocol. Interestingly, the compact_protocol implements the skip 
function, as does the JavaScript version.

{quote}
TJSONProtocol.prototype.skip = function(type) {
  throw new Error('skip not supported yet');
};
{quote}


> node.js json_protocol throws error in skip function
> ---
>
> Key: THRIFT-4443
> URL: https://issues.apache.org/jira/browse/THRIFT-4443
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.11.0
>Reporter: Kerri Devine
>  Labels: easyfix, patch
> Fix For: 0.12.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The skip function is unsupported in the node.js implementation of the 
> json_protocol. Interestingly, the compact_protocol implements the skip 
> function, as does the JavaScript version.
> {code:javascript}
> TJSONProtocol.prototype.skip = function(type) {
>   throw new Error('skip not supported yet');
> };
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (THRIFT-4443) node.js json_protocol throws error in skip function

[Kerri Devine (JIRA)]

Kerri Devine created THRIFT-4443:


 Summary: node.js json_protocol throws error in skip function
 Key: THRIFT-4443
 URL: https://issues.apache.org/jira/browse/THRIFT-4443
 Project: Thrift
  Issue Type: Bug
  Components: Node.js - Library
Affects Versions: 0.11.0
Reporter: Kerri Devine
 Fix For: 0.12.0


The skip function is unsupported in the node.js implementation of the 
json_protocol. Interestingly, the compact_protocol implements the skip 
function, as does the JavaScript version.

{quote}
TJSONProtocol.prototype.skip = function(type) {
  throw new Error('skip not supported yet');
};
{quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313428#comment-16313428
 ] 

ASF GitHub Bot commented on THRIFT-4390:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1458
  
There were related cross test errors:
```

===
*** Following 3 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
c_glib-rs   multi buffered-ip  
failure(timeout)
c_glib-rs   multicbuffered-ip  
failure(timeout)
perl-rs multi buffered-ip  
failure(timeout)
```


> Rust binary protocol and buffered transport cannot handle writes above 4096 
> bytes
> -
>
> Key: THRIFT-4390
> URL: https://issues.apache.org/jira/browse/THRIFT-4390
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Library
>Affects Versions: 0.10.0
> Environment: docker image ubuntu-artful
>Reporter: James E. King, III
>Assignee: Allen George
>Priority: Critical
>
> While working on improving test coverage and fixing busted cross tests I 
> reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16, 
> ..., 131072 and after 4096 the rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 
> 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError 
> { kind: Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}
> @gadLinux this may be the root cause of some of the issues you were seeing 
> with the interop against c_glib recently.  It is the root cause of some (if 
> not all of) the rs-csharp test failures.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1458
  
There were related cross test errors:
```

===
*** Following 3 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
c_glib-rs   multi buffered-ip  
failure(timeout)
c_glib-rs   multicbuffered-ip  
failure(timeout)
perl-rs multi buffered-ip  
failure(timeout)
```


---

[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313040#comment-16313040
 ] 

ASF GitHub Bot commented on THRIFT-4390:


Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1458
  
One of two fixes for problems noticed by others during cross-tests. I've a 
separate PR for framed transports.


> Rust binary protocol and buffered transport cannot handle writes above 4096 
> bytes
> -
>
> Key: THRIFT-4390
> URL: https://issues.apache.org/jira/browse/THRIFT-4390
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Library
>Affects Versions: 0.10.0
> Environment: docker image ubuntu-artful
>Reporter: James E. King, III
>Assignee: Allen George
>Priority: Critical
>
> While working on improving test coverage and fixing busted cross tests I 
> reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16, 
> ..., 131072 and after 4096 the rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 
> 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError 
> { kind: Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}
> @gadLinux this may be the root cause of some of the issues you were seeing 
> with the interop against c_glib recently.  It is the root cause of some (if 
> not all of) the rs-csharp test failures.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

[allengeorge]

Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1458
  
One of two fixes for problems noticed by others during cross-tests. I've a 
separate PR for framed transports.


---

[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313039#comment-16313039
 ] 

ASF GitHub Bot commented on THRIFT-4390:


GitHub user allengeorge opened a pull request:

https://github.com/apache/thrift/pull/1458

THRIFT-4390: Fix bug where binary/buffered messages > 4K could not be 
read/written

Client: rs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/allengeorge/thrift thrift-4390

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1458.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1458


commit b4a7fc785de82cd18ef6f56864d7e04ebeaea233
Author: Allen George 
Date:   2017-12-11T16:44:11Z

THRIFT-4390: Fix bug where binary/buffered messages > 4K could not be 
read/written
Client: rs




> Rust binary protocol and buffered transport cannot handle writes above 4096 
> bytes
> -
>
> Key: THRIFT-4390
> URL: https://issues.apache.org/jira/browse/THRIFT-4390
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Library
>Affects Versions: 0.10.0
> Environment: docker image ubuntu-artful
>Reporter: James E. King, III
>Assignee: Allen George
>Priority: Critical
>
> While working on improving test coverage and fixing busted cross tests I 
> reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16, 
> ..., 131072 and after 4096 the rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 
> 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError 
> { kind: Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}
> @gadLinux this may be the root cause of some of the issues you were seeing 
> with the interop against c_glib recently.  It is the root cause of some (if 
> not all of) the rs-csharp test failures.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4436) Deserialization of nested list discards content

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313012#comment-16313012
 ] 

ASF GitHub Bot commented on THRIFT-4436:


GitHub user bananer opened a pull request:

https://github.com/apache/thrift/pull/1457

THRIFT-4436: port nodejs changes from THRIFT-3748 to js lib (rebased)

test for serialization of nested list,
run all tests when building js lib

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bananer/thrift THRIFT-4436-pr2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1457


commit f398f57bf2caa052c4e451c1a4e5800317ba8cf4
Author: Philip Frank 
Date:   2018-01-02T08:00:36Z

THRIFT-4436: port nodejs changes from THRIFT-3748 to js lib,
test for serialization of nested list,
run all tests when building js lib




> Deserialization of nested list discards content
> ---
>
> Key: THRIFT-4436
> URL: https://issues.apache.org/jira/browse/THRIFT-4436
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library
>Affects Versions: 0.10.0, 0.11.0
>Reporter: Philip Frank
>
> I'm trying to transmit a list of lists, like this:
> {code}
> service HelloSvc {
>   list test()
> }
> {code}
> Using XHR Transport and JSON Protocol, with a service implementation in 
> Python like this:
> {code}
> class HelloSvcHandler:
> def __init__(self):
> pass
> def test(self,):
> return [
> ["s1", "s2"],
> ["s3", "s4"],
> ["s5"]
> ]
> {code}
> The serialized response looks good to me (seen in browser development tools):
> {code}
> [1,"test",2,0,{"0":{"lst":["lst",3,["str",2,"s1","s2"],["str",2,"s3","s4"],["str",1,"s5"]]}}]
> {code}
> However, when deserialized to JavaScript, the result looks like this:
> {code}
> [["s1","s2"],[],[]]
> {code}
> I would expect it to look like this:
> {code}
> [["s1","s2"],["s3","s4"],["s5"]]
> {code}
> It looks to me like during JSON deserialization, all but the first entry in 
> the list of lists lose their content.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4436) Deserialization of nested list discards content

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313014#comment-16313014
 ] 

ASF GitHub Bot commented on THRIFT-4436:


Github user bananer commented on the issue:

https://github.com/apache/thrift/pull/1454
  
rebased as https://github.com/apache/thrift/pull/1457


> Deserialization of nested list discards content
> ---
>
> Key: THRIFT-4436
> URL: https://issues.apache.org/jira/browse/THRIFT-4436
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library
>Affects Versions: 0.10.0, 0.11.0
>Reporter: Philip Frank
>
> I'm trying to transmit a list of lists, like this:
> {code}
> service HelloSvc {
>   list test()
> }
> {code}
> Using XHR Transport and JSON Protocol, with a service implementation in 
> Python like this:
> {code}
> class HelloSvcHandler:
> def __init__(self):
> pass
> def test(self,):
> return [
> ["s1", "s2"],
> ["s3", "s4"],
> ["s5"]
> ]
> {code}
> The serialized response looks good to me (seen in browser development tools):
> {code}
> [1,"test",2,0,{"0":{"lst":["lst",3,["str",2,"s1","s2"],["str",2,"s3","s4"],["str",1,"s5"]]}}]
> {code}
> However, when deserialized to JavaScript, the result looks like this:
> {code}
> [["s1","s2"],[],[]]
> {code}
> I would expect it to look like this:
> {code}
> [["s1","s2"],["s3","s4"],["s5"]]
> {code}
> It looks to me like during JSON deserialization, all but the first entry in 
> the list of lists lose their content.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1454: THRIFT-4436: port nodejs changes from THRIFT-3748...

[bananer]

Github user bananer closed the pull request at:

https://github.com/apache/thrift/pull/1454


---

[jira] [Commented] (THRIFT-4436) Deserialization of nested list discards content

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313015#comment-16313015
 ] 

ASF GitHub Bot commented on THRIFT-4436:


Github user bananer closed the pull request at:

https://github.com/apache/thrift/pull/1454


> Deserialization of nested list discards content
> ---
>
> Key: THRIFT-4436
> URL: https://issues.apache.org/jira/browse/THRIFT-4436
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library
>Affects Versions: 0.10.0, 0.11.0
>Reporter: Philip Frank
>
> I'm trying to transmit a list of lists, like this:
> {code}
> service HelloSvc {
>   list test()
> }
> {code}
> Using XHR Transport and JSON Protocol, with a service implementation in 
> Python like this:
> {code}
> class HelloSvcHandler:
> def __init__(self):
> pass
> def test(self,):
> return [
> ["s1", "s2"],
> ["s3", "s4"],
> ["s5"]
> ]
> {code}
> The serialized response looks good to me (seen in browser development tools):
> {code}
> [1,"test",2,0,{"0":{"lst":["lst",3,["str",2,"s1","s2"],["str",2,"s3","s4"],["str",1,"s5"]]}}]
> {code}
> However, when deserialized to JavaScript, the result looks like this:
> {code}
> [["s1","s2"],[],[]]
> {code}
> I would expect it to look like this:
> {code}
> [["s1","s2"],["s3","s4"],["s5"]]
> {code}
> It looks to me like during JSON deserialization, all but the first entry in 
> the list of lists lose their content.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1454: THRIFT-4436: port nodejs changes from THRIFT-3748 to js ...

[bananer]

Github user bananer commented on the issue:

https://github.com/apache/thrift/pull/1454
  
rebased as https://github.com/apache/thrift/pull/1457


---

[GitHub] thrift pull request #1457: THRIFT-4436: port nodejs changes from THRIFT-3748...

[bananer]

GitHub user bananer opened a pull request:

https://github.com/apache/thrift/pull/1457

THRIFT-4436: port nodejs changes from THRIFT-3748 to js lib (rebased)

test for serialization of nested list,
run all tests when building js lib

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bananer/thrift THRIFT-4436-pr2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1457


commit f398f57bf2caa052c4e451c1a4e5800317ba8cf4
Author: Philip Frank 
Date:   2018-01-02T08:00:36Z

THRIFT-4436: port nodejs changes from THRIFT-3748 to js lib,
test for serialization of nested list,
run all tests when building js lib




---