[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-02-19 Thread bgedik
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1497 @jeking3 The ``client_pool_tests`` failed in 2 of the bots within Travis-CI. I don't think it is related to my change. Are these known to fail every now and then? ```

[GitHub] thrift issue #1476: Remove premature call to workSocket() in TNonblockingSer...

2018-02-19 Thread bgedik
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1476 @jeking3 Here: https://github.com/apache/thrift/pull/1497 ---

[GitHub] thrift pull request #1497: Remove workSocket call that is too early

2018-02-19 Thread bgedik
GitHub user bgedik opened a pull request: https://github.com/apache/thrift/pull/1497 Remove workSocket call that is too early Make the work socket conditional Revert back the changes Only call workSocket() when there is pending data to read Minor update to a comment

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-02-19 Thread bgedik
GitHub user bgedik reopened a pull request: https://github.com/apache/thrift/pull/1476 Remove premature call to workSocket() in TNonblockingServer You can merge this pull request into a Git repository by running: $ git pull https://github.com/bgedik/thrift

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-02-19 Thread bgedik
Github user bgedik closed the pull request at: https://github.com/apache/thrift/pull/1476 ---

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-02-19 Thread bgedik
Github user bgedik closed the pull request at: https://github.com/apache/thrift/pull/1476 ---

Update the Rust Thrift Crate?

2018-02-19 Thread Allen George
I noticed that the rust thrift crate on crates.io has not been updated to 0.11.0 to align with the first thrift release with rust support. Could we go ahead and do that? If documentation is required to do this I’m happy to write whatever’s necessary to simplify this process in the future. Thank

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-02-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369219#comment-16369219 ] ASF GitHub Bot commented on THRIFT-4476: GitHub user ozymaxx opened a pull request:

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-02-19 Thread ozymaxx
GitHub user ozymaxx opened a pull request: https://github.com/apache/thrift/pull/1496 THRIFT-4476: Typecasting problem on list items (+ low precision double rendering, + mis-rendering non-fractional double literals in Python) - high precision double rendering in JS, Java, Python

[jira] [Commented] (THRIFT-3055) Apache Thrift Logo

2018-02-19 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369152#comment-16369152 ] James E. King, III commented on THRIFT-3055: Other possible ideas I found online

[jira] [Updated] (THRIFT-3055) Apache Thrift Logo

2018-02-19 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3055: --- Attachment: screenshot-2.png > Apache Thrift Logo > -- > >

[jira] [Updated] (THRIFT-3055) Apache Thrift Logo

2018-02-19 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3055: --- Attachment: screenshot-1.png > Apache Thrift Logo > -- > >

[jira] [Updated] (THRIFT-4489) Unix domain socket support for NodeJS client

2018-02-19 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4489: --- Fix Version/s: (was: 0.12.0) > Unix domain socket support for NodeJS client >

[GitHub] thrift issue #1448: Thrift-4441: Support compilation without Boost

2018-02-19 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1448 Would it be possible for you to squash this to make the merge easier? ---

[jira] [Assigned] (THRIFT-4489) Unix domain socket support for NodeJS client

2018-02-19 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4489: -- Assignee: James E. King, III > Unix domain socket support for NodeJS client >

[GitHub] thrift issue #1476: Remove premature call to workSocket() in TNonblockingSer...

2018-02-19 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1476 Squash to one commit, please. ---

[jira] [Commented] (THRIFT-4493) thrift-0.11.0.exe is recognized as trojan and the provided md5 is hard to check

2018-02-19 Thread Francisco Pageo (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369038#comment-16369038 ] Francisco Pageo commented on THRIFT-4493: - I'm having this issue. In my case I have Microsoft